From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D2DC25B75 for ; Thu, 23 May 2024 22:20:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70A386B0082; Thu, 23 May 2024 18:20:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 692F16B0085; Thu, 23 May 2024 18:20:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 533576B0089; Thu, 23 May 2024 18:20:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C3B06B0082 for ; Thu, 23 May 2024 18:20:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C4FE7A0304 for ; Thu, 23 May 2024 22:20:25 +0000 (UTC) X-FDA: 82151080410.25.96A52AF Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) by imf17.hostedemail.com (Postfix) with ESMTP id 103D640020 for ; Thu, 23 May 2024 22:20:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="eI0BbiK/"; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716502823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E0RUslfnDv278HYdX205N9mybSIZGSakTF6wsEC6Vvs=; b=f2ZFXeWwi0Eo7GrC21RKQtdg3Caf/KgAwBuuAqiWxKNEP0Lq/FDtinTz4VKYtlDSc7g1dC 3Ibn4iXdfQebhUBdp7EhfaIGzbjqCrFTksVKtTmPuJhOxV/LYp7YMcXjsf+AXrrXj4CFBG TT6QOAOP/LPv724gVQXc/4DR8gLC1H0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716502823; a=rsa-sha256; cv=none; b=jE5WgkQz/pY7QECLW3ovfWpVeJmvSsDjgR7lqllTJOFQOiWIFr97AcxLaOUqbR7yow9jSS /2SDNBYXQTH7mqv+7/u+LLENuhvB1uQuun1Pp0P2RzRT/l16s/lWdcZ0vX85OJzsZXiRQW jiPIqipBTnC0zOcW33ByGy89DYEihKc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="eI0BbiK/"; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-4e4efbc6fafso105770e0c.0 for ; Thu, 23 May 2024 15:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716502822; x=1717107622; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E0RUslfnDv278HYdX205N9mybSIZGSakTF6wsEC6Vvs=; b=eI0BbiK/pnc9LZjQzpubAZhPiVuDhrLIXuK0Cy5Bk0Vp1f+KkH8k+RaEM0ipO69OXy twd1G/bX2n7zMT39pYfhpl2Bb5b+ooFc4hSgeDIi3GN6ypd1rRt9DtuZ2S/STvoUqzZC 6fjEfzOsNs+BwX2Yukq3002hIz53H4gaX3iRzL7Da6T0/lKMECBnE+caOdf6PmM6C+Fx xoqcDWO7vn3Faq68CHPQHHacYWLL60v7mDskOZYrOle0kxt2Isft6asJM6jsBRfwMNKe l6ElbkRNj0bPTyR0akBpIeGL14toAnOLbf3ZGDQXcGFWnHFflT7rpdHCMlNPDjkcQPvJ lQ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716502822; x=1717107622; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E0RUslfnDv278HYdX205N9mybSIZGSakTF6wsEC6Vvs=; b=rQ23nA6hNgt77Dl0WblrCeTUAuC/2tUsaM+o2i1y7r4dyqXNNXgrPzHClUOYuxx1Py 2mq8hCYYUGo1ldRtyU3h0EmkqKwvMUQF6mgZgpGkEgV8Ka6obYGWAZRkM1Bf1IcV/rSq 2Hqi2uqZggzphLAxu+Cs7tb4KD0MKyjiWvc89A+h1vf69VNZ7lenXEmfOECiIEWhU2lm MKAbTjUWn3pSZldhn1S/KF2ipSM884KveLMH0tv2a6zc7/ziscebHT/Dmw8EDeD9G0o2 P1SMW2moZlnJgFHjFBZrWrHweLinrLEi/XACZ2dvS3pQytEFiJBjBZ/wPzogTgwBl/PE iEIg== X-Forwarded-Encrypted: i=1; AJvYcCWISoEVJTSZvXuwJrZkPJEdSS2yElCRhGClfKv+UNXhhvwEA8iEkv3pxCC35USh8HNF+gMscIPXGraR5COfm2f3TXA= X-Gm-Message-State: AOJu0YxoWOE4xGcdVl61q6RTsgr05HfItjaPIrcevUOoixf/UFiHl4fS cN6qrazsb0179gKNgvUMojijvrj1+axJI2JvZ4Z8bW7bYgZNBGKAgxtwZYXZpKfrti4kIJPV8wQ HhXGKWXQFOefS/27NHSWttac64o4= X-Google-Smtp-Source: AGHT+IEOWOv+nAoJtA7tINJy15y2Dwjm/2fjF6sxXyBECoq/cYteo0tvfFGTGswWHZC55W9APPZM5HC/smONocRLWo8= X-Received: by 2002:a05:6122:d03:b0:4e4:ea87:ec72 with SMTP id 71dfb90a1353d-4e4f02d0405mr674010e0c.11.1716502820398; Thu, 23 May 2024 15:20:20 -0700 (PDT) MIME-Version: 1.0 References: <20240418134435.6092-1-ioworker0@gmail.com> <20240418134435.6092-5-ioworker0@gmail.com> In-Reply-To: <20240418134435.6092-5-ioworker0@gmail.com> From: Barry Song <21cnbao@gmail.com> Date: Fri, 24 May 2024 10:20:09 +1200 Message-ID: Subject: Re: [PATCH v10 4/4] mm/madvise: optimize lazyfreeing with mTHP in madvise_free To: Lance Yang Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, david@redhat.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 103D640020 X-Rspam-User: X-Stat-Signature: cryyigqeto8f3p6jjheonaqgoouisz7f X-HE-Tag: 1716502822-450324 X-HE-Meta: U2FsdGVkX1+6dey2TOcgn3dw6HdaWDLRzRaha/s+Ud1gzmFBV5hRAGnyocJRTvqa9yao5RbB6GNvkOnxX6eguWgc12HNdoYXIzTQB76WBKEKsTbsa6lvTBlE7EGQ+JHTwnQAeMiro7g3zIeL8u6lxFt32zOeOznpazmdg0Vt99EEjoCkX2xUQsJFEfEH8NHtST6UiNDikeb6X7Wvjak2dnBb1q8OfugWEJ/UIE3PfM6wey/+xz/Sf+k01884PK1j3j7k91Lnt0JWu8Qa42UqBlWntYaN15AeMn5ffpgHFuJUFhjsfxRK3MwHPLQLjJ//O/gSVAzgWV49SATvvs1cbIYyYmuI6Pn57CHeetnIWcTqSRbe7UOoItLqFWqJ3EVmtaVfcaHzLxKti3GuUIDJ6t0pRfRhiEUblsXCLEYGk8mdc7mbvZp7CUA4ny9gbuHhk/OwCR7lhUsmuo+UIqXHI5aD6XQGMUm6UCri8Mr2ZPoL6kts3s+yc8TniE/BeFEjNAlCidUcaBj7mzMsKsD6sTCOQlAwrRywmANmlB21j8THYncik8/cb2byph8Zs7UOUXu4Z/J1MSo5G1iAKjht5Vb2G/POUFKqhq1gcN2u01hXh+dksrXqCwkAE1Tue4FEZeuqrDh6hukOKSWdsQppzcEVltJg+9l6rBmTYi+ZNXwavUBa9Js5ZjR53pUC0AOituQCwUnfV9DqTl5zSy70hHdsFEKRjvLb4k1P1pxOl0TPiws3WuOI5g/TMp8EYq+rVDd00E0xXdteV2zCZQqq+T4xKJYs37Wx7EBH5jwUXGXW2Lwtq07UQ62wC4j2fqLli1wmmIMguvV1ikuTfgx/MPWZpHsK6Ei5cFpdbbavrB/KCD6Htw1Ne7vNQNtSixyEtG/lQW+LGclevFaIliiwuZTWu1EdWqhvNd5QoLmC6uTxegrYTvtCrchJc0UUZtmIv4a7zhLEkFhvTx9BK75 OYAuoejn 9rTw5Vh1RUGKmw0iNZH6j/YFk4R2CfpAzMgoGxL0Pdawdgqt+pL5YuaFyUDHqiUlqiouQ2Y87+45tYRDGBgLlj4fQ3/Y9TmZAnMJ+rsmSWs4xfAMkNbWSNshDBgNZg4KyS3FKlsT3RuMPYjAjPLBWRMtIZNjrj9CU+ZclYV5Iawcmqmba90MdqAgvjhDMNua06xPwdLbfFDyBNV1AGYLzEjKD7c/BPAbeOqKKeXoAqH0ldVhHF2APT6KipObo4eyvfMuk+XH+tnQblZjFozw6BrQmsW1JMBB4rFGon19wWVii65dZlUl3Z7gfq6ZfngD3xERih5yAOn0NQepIv11rJYIR76e11w2rZTREUmbPC8uttBwd4tyupGuwaO30hlqnae14QQ3yxDzpZZWX3EUhmPlFK4msooLktXwqwDmrQcsT6zFdLkyiuckMJIU/HpljyHdKYp7/5MN6abICPdjvmoJvNdkjTN5J+3gMIg4Ak6zpG4rK3aer2JKF46M4K6fN+iSClD10hFAaWTRpC84xTHppez3s7tSkGPG0bsYC4Rdkaz42BE39EBa1JQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 19, 2024 at 1:44=E2=80=AFAM Lance Yang wr= ote: > > This patch optimizes lazyfreeing with PTE-mapped mTHP[1] > (Inspired by David Hildenbrand[2]). We aim to avoid unnecessary folio > splitting if the large folio is fully mapped within the target range. > > If a large folio is locked or shared, or if we fail to split it, we just > leave it in place and advance to the next PTE in the range. But note that > the behavior is changed; previously, any failure of this sort would cause > the entire operation to give up. As large folios become more common, > sticking to the old way could result in wasted opportunities. > > On an Intel I5 CPU, lazyfreeing a 1GiB VMA backed by PTE-mapped folios of > the same size results in the following runtimes for madvise(MADV_FREE) in > seconds (shorter is better): > > Folio Size | Old | New | Change > ------------------------------------------ > 4KiB | 0.590251 | 0.590259 | 0% > 16KiB | 2.990447 | 0.185655 | -94% > 32KiB | 2.547831 | 0.104870 | -95% > 64KiB | 2.457796 | 0.052812 | -97% > 128KiB | 2.281034 | 0.032777 | -99% > 256KiB | 2.230387 | 0.017496 | -99% > 512KiB | 2.189106 | 0.010781 | -99% > 1024KiB | 2.183949 | 0.007753 | -99% > 2048KiB | 0.002799 | 0.002804 | 0% > > [1] https://lkml.kernel.org/r/20231207161211.2374093-5-ryan.roberts@arm.c= om > [2] https://lore.kernel.org/linux-mm/20240214204435.167852-1-david@redhat= .com > > Reviewed-by: Ryan Roberts > Acked-by: David Hildenbrand > Signed-off-by: Lance Yang > --- Hi Lance, I am getting kernel panic with this patch, / # /home/barry/develop/linux/madvfree [ 78.345305] watchdog: BUG: soft lockup - CPU#3 stuck for 22s! [madvfree:= 101] [ 78.345992] Modules linked in: [ 78.346942] irq event stamp: 0 [ 78.347311] hardirqs last enabled at (0): [<0000000000000000>] 0x0 [ 78.348407] hardirqs last disabled at (0): [] copy_process+0x654/0x19a8 [ 78.349291] softirqs last enabled at (0): [] copy_process+0x654/0x19a8 [ 78.349851] softirqs last disabled at (0): [<0000000000000000>] 0x0 [ 78.350544] CPU: 3 PID: 101 Comm: madvfree Not tainted 6.9.0-ge51ae633c861 #253 [ 78.351200] Hardware name: linux,dummy-virt (DT) [ 78.351747] pstate: 01400005 (nzcv daif +PAN -UAO -TCO +DIT -SSBS BTYPE= =3D--) [ 78.352314] pc : queued_spin_lock_slowpath+0x5c/0x528 [ 78.352772] lr : do_raw_spin_lock+0xc8/0x120 [ 78.353245] sp : ffff8000863d3720 [ 78.353657] x29: ffff8000863d3720 x28: ffff0000c45a8ff8 x27: 0800000103b= 24003 [ 78.354632] x26: ffff0000c3b26080 x25: fffffdffc0000000 x24: ffff8000822= c2d10 [ 78.355446] x23: ffff80008403018f x22: ffff8000863d38e0 x21: 0000ffff7f0= 00000 [ 78.356259] x20: ffff800082fbe008 x19: ffff0000c3b26080 x18: 00000000000= 00000 [ 78.357120] x17: 0000000000000000 x16: 0000000000000000 x15: 00000000000= 00000 [ 78.357967] x14: 0000000000000000 x13: 0000000000000000 x12: 00000000000= 00000 [ 78.358878] x11: ff7ffffffffffbff x10: 0040000000000041 x9 : ffff8000801= 43750 [ 78.359818] x8 : ffff8000863d3708 x7 : 0000000000000000 x6 : ffff8000803= b34e8 [ 78.360688] x5 : 0000000000000000 x4 : 0000000000000001 x3 : ffff800082f= be008 [ 78.361602] x2 : ffff80012ac1f000 x1 : 0000000000000000 x0 : 00000000000= 00080 [ 78.362755] Call trace: [ 78.363132] queued_spin_lock_slowpath+0x5c/0x528 [ 78.363614] do_raw_spin_lock+0xc8/0x120 [ 78.364041] _raw_spin_lock+0x58/0x70 [ 78.364455] __pte_offset_map_lock+0x98/0x210 [ 78.364891] madvise_free_pte_range+0x88/0xa58 [ 78.365406] walk_pgd_range+0x390/0x808 [ 78.365829] __walk_page_range+0x1e0/0x1f0 [ 78.366256] walk_page_range+0x1f0/0x2c8 [ 78.366676] madvise_free_single_vma+0x16c/0x308 [ 78.367115] madvise_vma_behavior+0x504/0xa20 [ 78.367549] madvise_walk_vmas+0xc0/0x128 [ 78.367972] do_madvise.part.0+0x110/0x558 [ 78.368398] __arm64_sys_madvise+0x68/0x88 [ 78.368826] invoke_syscall+0x50/0x128 [ 78.369332] el0_svc_common.constprop.0+0x48/0xf8 [ 78.369778] do_el0_svc+0x28/0x40 [ 78.370184] el0_svc+0x50/0x150 [ 78.370583] el0t_64_sync_handler+0x13c/0x158 [ 78.371017] el0t_64_sync+0x1a4/0x1a8 [ 102.345217] watchdog: BUG: soft lockup - CPU#3 stuck for 45s! [madvfree:= 101] [ 102.345835] Modules linked in: [ 102.346290] irq event stamp: 0 [ 102.346715] hardirqs last enabled at (0): [<0000000000000000>] 0x0 [ 102.347252] hardirqs last disabled at (0): [] copy_process+0x654/0x19a8 [ 102.347796] softirqs last enabled at (0): [] copy_process+0x654/0x19a8 [ 102.348333] softirqs last disabled at (0): [<0000000000000000>] 0x0 [ 102.348925] CPU: 3 PID: 101 Comm: madvfree Tainted: G L 6.9.0-ge51ae633c861 #253 [ 102.349549] Hardware name: linux,dummy-virt (DT) [ 102.349988] pstate: 01400005 (nzcv daif +PAN -UAO -TCO +DIT -SSBS BTYPE= =3D--) [ 102.350535] pc : queued_spin_lock_slowpath+0x5c/0x528 [ 102.351010] lr : do_raw_spin_lock+0xc8/0x120 [ 102.351508] sp : ffff8000863d3720 [ 102.351939] x29: ffff8000863d3720 x28: ffff0000c45a8ff8 x27: 0800000103b= 24003 [ 102.352811] x26: ffff0000c3b26080 x25: fffffdffc0000000 x24: ffff8000822= c2d10 [ 102.353772] x23: ffff80008403018f x22: ffff8000863d38e0 x21: 0000ffff7f0= 00000 [ 102.354625] x20: ffff800082fbe008 x19: ffff0000c3b26080 x18: 00000000000= 00000 [ 102.355495] x17: 0000000000000000 x16: 0000000000000000 x15: 00000000000= 00000 [ 102.356370] x14: 0000000000000000 x13: 0000000000000000 x12: 00000000000= 00000 [ 102.357333] x11: ff7ffffffffffbff x10: 0040000000000041 x9 : ffff8000801= 43750 [ 102.358273] x8 : ffff8000863d3708 x7 : 0000000000000000 x6 : ffff8000803= b34e8 [ 102.359112] x5 : 0000000000000000 x4 : 0000000000000001 x3 : ffff800082f= be008 [ 102.360001] x2 : ffff80012ac1f000 x1 : 0000000000000000 x0 : 00000000000= 00080 [ 102.360887] Call trace: [ 102.361289] queued_spin_lock_slowpath+0x5c/0x528 [ 102.361768] do_raw_spin_lock+0xc8/0x120 [ 102.362294] _raw_spin_lock+0x58/0x70 [ 102.362825] __pte_offset_map_lock+0x98/0x210 [ 102.363299] madvise_free_pte_range+0x88/0xa58 [ 102.363771] walk_pgd_range+0x390/0x808 [ 102.364268] __walk_page_range+0x1e0/0x1f0 [ 102.364729] walk_page_range+0x1f0/0x2c8 [ 102.365263] madvise_free_single_vma+0x16c/0x308 [ 102.365786] madvise_vma_behavior+0x504/0xa20 [ 102.366315] madvise_walk_vmas+0xc0/0x128 [ 102.366779] do_madvise.part.0+0x110/0x558 [ 102.367269] __arm64_sys_madvise+0x68/0x88 [ 102.367714] invoke_syscall+0x50/0x128 [ 102.368110] el0_svc_common.constprop.0+0x48/0xf8 [ 102.368574] do_el0_svc+0x28/0x40 [ 102.369001] el0_svc+0x50/0x150 [ 102.369464] el0t_64_sync_handler+0x13c/0x158 [ 102.369916] el0t_64_sync+0x1a4/0x1a8 [ 126.345236] watchdog: BUG: soft lockup - CPU#3 stuck for 67s! [madvfree:= 101] the test code is as belows, #define MADV_PAGEOUT 21 /* reclaim these pages */ #define DATA_SIZE (128UL * 1024 * 1024) #define PAGE_SIZE (4UL * 1024) #define LARGE_FOLIO_SIZE (64UL * 1024) static void *read_data(void *addr) { unsigned long i; for (i =3D 0; i < DATA_SIZE * 2; i +=3D PAGE_SIZE) { if (*((char *)addr + i) !=3D (char)i) { } } } static void *lazyfree(void *addr) { unsigned long i; madvise(addr, DATA_SIZE * 2, MADV_FREE); } int main(int argc, char **argv) { void *addr =3D mmap(NULL, DATA_SIZE * 2, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0); memset(addr, 0x11, DATA_SIZE * 2); lazyfree(addr); while(1) { sleep(1); read_data(addr); } return 0; } > mm/madvise.c | 85 +++++++++++++++++++++++++++------------------------- > 1 file changed, 44 insertions(+), 41 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 4597a3568e7e..ed125ad8a21e 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -643,6 +643,7 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigne= d long addr, > unsigned long end, struct mm_walk *walk) > > { > + const cydp_t cydp_flags =3D CYDP_CLEAR_YOUNG | CYDP_CLEAR_DIRTY; > struct mmu_gather *tlb =3D walk->private; > struct mm_struct *mm =3D tlb->mm; > struct vm_area_struct *vma =3D walk->vma; > @@ -697,44 +698,57 @@ static int madvise_free_pte_range(pmd_t *pmd, unsig= ned long addr, > continue; > > /* > - * If pmd isn't transhuge but the folio is large and > - * is owned by only this process, split it and > - * deactivate all pages. > + * If we encounter a large folio, only split it if it is = not > + * fully mapped within the range we are operating on. Oth= erwise > + * leave it as is so that it can be marked as lazyfree. I= f we > + * fail to split a folio, leave it in place and advance t= o the > + * next pte in the range. > */ > if (folio_test_large(folio)) { > - int err; > + bool any_young, any_dirty; > > - if (folio_likely_mapped_shared(folio)) > - break; > - if (!folio_trylock(folio)) > - break; > - folio_get(folio); > - arch_leave_lazy_mmu_mode(); > - pte_unmap_unlock(start_pte, ptl); > - start_pte =3D NULL; > - err =3D split_folio(folio); > - folio_unlock(folio); > - folio_put(folio); > - if (err) > - break; > - start_pte =3D pte =3D > - pte_offset_map_lock(mm, pmd, addr, &ptl); > - if (!start_pte) > - break; > - arch_enter_lazy_mmu_mode(); > - pte--; > - addr -=3D PAGE_SIZE; > - continue; > + nr =3D madvise_folio_pte_batch(addr, end, folio, = pte, > + ptent, &any_young, &= any_dirty); > + > + if (nr < folio_nr_pages(folio)) { > + int err; > + > + if (folio_likely_mapped_shared(folio)) > + continue; > + if (!folio_trylock(folio)) > + continue; > + folio_get(folio); > + arch_leave_lazy_mmu_mode(); > + pte_unmap_unlock(start_pte, ptl); > + start_pte =3D NULL; > + err =3D split_folio(folio); > + folio_unlock(folio); > + folio_put(folio); > + pte =3D pte_offset_map_lock(mm, pmd, addr= , &ptl); > + start_pte =3D pte; > + if (!start_pte) > + break; > + arch_enter_lazy_mmu_mode(); > + if (!err) > + nr =3D 0; > + continue; > + } > + > + if (any_young) > + ptent =3D pte_mkyoung(ptent); > + if (any_dirty) > + ptent =3D pte_mkdirty(ptent); > } > > if (folio_test_swapcache(folio) || folio_test_dirty(folio= )) { > if (!folio_trylock(folio)) > continue; > /* > - * If folio is shared with others, we mustn't cle= ar > - * the folio's dirty flag. > + * If we have a large folio at this point, we kno= w it is > + * fully mapped so if its mapcount is the same as= its > + * number of pages, it must be exclusive. > */ > - if (folio_mapcount(folio) !=3D 1) { > + if (folio_mapcount(folio) !=3D folio_nr_pages(fol= io)) { > folio_unlock(folio); > continue; > } > @@ -750,19 +764,8 @@ static int madvise_free_pte_range(pmd_t *pmd, unsign= ed long addr, > } > > if (pte_young(ptent) || pte_dirty(ptent)) { > - /* > - * Some of architecture(ex, PPC) don't update TLB > - * with set_pte_at and tlb_remove_tlb_entry so fo= r > - * the portability, remap the pte with old|clean > - * after pte clearing. > - */ > - ptent =3D ptep_get_and_clear_full(mm, addr, pte, > - tlb->fullmm); > - > - ptent =3D pte_mkold(ptent); > - ptent =3D pte_mkclean(ptent); > - set_pte_at(mm, addr, pte, ptent); > - tlb_remove_tlb_entry(tlb, pte, addr); > + clear_young_dirty_ptes(vma, addr, pte, nr, cydp_f= lags); > + tlb_remove_tlb_entries(tlb, pte, nr, addr); > } > folio_mark_lazyfree(folio); > } > -- > 2.33.1 >