From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF5FC3DA61 for ; Wed, 24 Jul 2024 21:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83C776B008A; Wed, 24 Jul 2024 17:11:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC136B008C; Wed, 24 Jul 2024 17:11:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4876B0092; Wed, 24 Jul 2024 17:11:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4D8776B008A for ; Wed, 24 Jul 2024 17:11:52 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C18E4140B5A for ; Wed, 24 Jul 2024 21:11:51 +0000 (UTC) X-FDA: 82375893222.03.8116EA9 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 0CD81100015 for ; Wed, 24 Jul 2024 21:11:49 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721855471; a=rsa-sha256; cv=none; b=6/otcHfd/fMpPAQksVlUW6ZnrDD2I1N9lxsHiPyBO4DNlvSPDg4TeP2zBS1gk06RJ4oeqF awJdBbO4+h0HDS/s5oq8JpMvZGPUh0Wusb+6xWXVN2ZsTKoiZFfCUQEGp/uGGbb3qxNS1J /sq0tOR7GOG7Zif+j8nKonBhag1qLDg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721855471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wo9rBukdP/tuDMxJMB/GnqO9t6TTdQNeP2BoCKCEW1c=; b=QDS040fADuY8L6xcY01lCjQ3JUSZ8/lL5OUWCX+JyzonOTF+niUGh9hL+vt2GL2uvxEesl PMP7YxeTH+vO/7ay0fcdQz2s7Y8TlZ6FVhCIo8REoFlN9Y0Fw85U/axzT1fGp2FavbdHZ0 qvdxjG6g54bnZg3vjwJ+yUaTB8QObso= Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-4f51551695cso97844e0c.3 for ; Wed, 24 Jul 2024 14:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721855509; x=1722460309; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wo9rBukdP/tuDMxJMB/GnqO9t6TTdQNeP2BoCKCEW1c=; b=LIgc+SMzeb2YZoPxxIZ3lIOYbofl/nc/3+N3MqcRWDjJdXESar/k4g+jNM87bIit2J s6Xfh/Xd6CKCEO35tRLik4xl/RLQxTP7Mnj5ywkzGcnEa8J8s3GHgIim3rTXkNFwtHf4 sgdkzRF0eXy6z2CKyijfDGHgluAiwPmQPNDz+ucE+V0Wbj3tSGyVR2KiJsNNvjqCP+b7 WglC52ZFvrWuaWP0TuRr1i7VJs8ZiUXBZ5XRm4Iq2Gw+Pn7paAiPuPezTBHPfE4JDosS dGTn9G/WtuV8fm51kW6m5GhCVWfpYaeWLANQpRksXUHvzPnGTcis4aAxNO78jttmx7+1 RE9A== X-Forwarded-Encrypted: i=1; AJvYcCXHfpO6tCYHJAmyavuisYEbzCqQ9VPM8gjIXi+1GhpsKl120Kdl11RS3o2iv0BG/DOz1FH4V6Y/3J0UhHHRYeakn1o= X-Gm-Message-State: AOJu0YxWoZ//2Cso97XOz5n60VMrd7jozGy0oxS0AwAnzlU7/ydsb1OH /UK8Fh7hoCR/PjNbhXLQ2GlUiiH1W+y0MInY3lJmHJX0CPzNCxcCUvGMYbHzupHIPJyZwjpAN/U v269o52CchsTcw7Mai8bBd24KNaM= X-Google-Smtp-Source: AGHT+IE8c7oNYl/FchtBsRDZ6U8Utwg4wDCxMCwmVoVnrmcThNf9/d3IXeAEzQ93JwroZ73uxMNAhH/mMMbKgionSns= X-Received: by 2002:a05:6122:4129:b0:4f2:f1f1:a9f2 with SMTP id 71dfb90a1353d-4f6c5b6a2camr1642813e0c.4.1721855509106; Wed, 24 Jul 2024 14:11:49 -0700 (PDT) MIME-Version: 1.0 References: <20240710083641.546-1-justinjiang@vivo.com> <20240724125515.6cc3bd8479ea8bcdedaa7eff@linux-foundation.org> In-Reply-To: <20240724125515.6cc3bd8479ea8bcdedaa7eff@linux-foundation.org> From: Barry Song Date: Thu, 25 Jul 2024 09:11:37 +1200 Message-ID: Subject: Re: [PATCH v10] mm: shrink skip folio mapped by an exiting process To: Andrew Morton Cc: Zhiguo Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Matthew Wilcox , opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0CD81100015 X-Stat-Signature: ggj4q7m4cj8pi59jgpe19iecmtemqyha X-Rspam-User: X-HE-Tag: 1721855509-559721 X-HE-Meta: U2FsdGVkX19Yvc1jB/qP/MRWeEjhln5rYTmcP8gzJ2d140Exy5Gcb0gZfooV3E3q/f1aAYxKOypI+5yg3rx86zyvfwAwqGqRlVY0CbSCXvTl4EoZPXKAQllp5HBWFOPykJHl+cvM8Mmoe3tnDM8ONMgcqMOesjlAUBaR6xlHR91TlmGT5wsB2zr26tZQ1Op4cSk92fFxkUEnjZeerNGu8n0RkPY2/HO60dd+l8lEtnM6JLNt4Ze0Dk8A04SwgJZTwVV582CCCdIGNhQIabzjdVD+JKKCRjIszbf+4PIs+a3yE7HUdhhgqVfFQhXE6HzJEQdZoa8+Mi3LY/HrujD15CiKxz7QKclBLclUzY+xTXVAkJzL1/P/tLiKJqisI32zD0QnhEvQpWY48YOV+Ev6Jof5HngBjoLdlEuPVHQkuaLtylhDsvoUbtwu/PBkLnppUKbHBJnQWfYrZIBgxUFOpronFC8t9i5ygWTkSuTyjIavtDkm7eVqxfmGXip0p94RB1wB1PD6HBCfMbIdt3S96FP3YHjZ3xnCKnHEYAPEc3aos7TGisWr0NMZiuk5ZbakjusFAexLiK3f6ZKfBjsKfLPr0jEIeMn2FuIEgSwIk0bEU8pf54eAekgSKIxH3mGqLeK4zK29Axsl7sK5uyD2yTcre3oxPdcz/uVxZGcu64141BTl5nd/wYTJeLIvUr56nNloNZODCWErcTN+hNnoYxm5xixsUzMPfEy5YVtsImYbfQbkZmS5w3dbBsVZrg95u9fOLoDPu04t4SGSyppyUEQnL069ohJMkXoJkzRUuPbO+u7G4M0rScxgUNoq8UqP6NcClXfK/A7PLwguI+jtJnfOqDLFojlBJRzcFR4+NqpwU3sI0yWYFVYz15lWJaZIXm0T2h2Wu3hu8RtbbEcSNSXUwtNR6egJbixfnwCwZdfzudOcq2xAtPEQz/KTaa7pSEhoQ0EgCH9aMDoJsQG 7CXltiP7 WFdOBIB1C5W6py8pHRC0CSxAKWsW76+VBT2267oRnZXvceLv2cC6Chs9dbFn3/D72yc8RjwSfAFs6ORFRv6RyMbccS0nNiFdTMICe9oDz1AA9ZliYHdOmiDs6lJqh7zTlkqYh8NgV4LZWb0SrbKCRV8pba7LweSm1IM/zR5rHFqSf6pZz8H+pX27mDyFo0+FAP+reIXPPTEiH26x0Rd9aXf1TAMMMFl1dgDeOCNOV4t/KR6tZ2XTKY+jl9e3QN0F4faxKdphN/bUs1Gm88DqKb45if+qLsMAbELU9so2YDCLyrEVLzgzucQYxF1lNBIslOS+NLoYmxao6PBmgXgMj+XYvXaSfBvzQIMH6I8l5KorsBJP+g4krUR53CyazlW1exFwq+TkB83uMzK9Gqv5OLnDXTj+fTZ+Y6m6h0/lUcorOpE2qtim+vVBxBfRc9jTkNX1A3WrZEmuAi8RiyfwDHpEUcejLzQ+5Ngw/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 25, 2024 at 7:55=E2=80=AFAM Andrew Morton wrote: > > On Wed, 10 Jul 2024 16:36:41 +0800 Zhiguo Jiang wr= ote: > > > The releasing process of the non-shared anonymous folio mapped solely b= y > > an exiting process may go through two flows: 1) the anonymous folio is > > firstly is swaped-out into swapspace and transformed into a swp_entry > > in shrink_folio_list; 2) then the swp_entry is released in the process > > exiting flow. This will result in the high cpu load of releasing a > > non-shared anonymous folio mapped solely by an exiting process. > > > > When the low system memory and the exiting process exist at the same > > time, it will be likely to happen, because the non-shared anonymous > > folio mapped solely by an exiting process may be reclaimed by > > shrink_folio_list. > > > > This patch is that shrink skips the non-shared anonymous folio solely > > mapped by an exting process and this folio is only released directly in > > the process exiting flow, which will save swap-out time and alleviate > > the load of the process exiting. > > Has any testing been performed to demonstrate any benefit? If so, what > were the results? I think I shared my demonstration in version 7: https://lore.kernel.org/linux-mm/20240710033212.36497-1-21cnbao@gmail.com/ I noticed a significant improvement with my small test program. I observed that this patch effectively skipped 6114 folios (either 4KB or 6= 4KB mTHP), potentially reducing the swap-out by up to 92MB (97,300,480 bytes) d= uring the process exit. The working set size is 256MB. If Zhiguo can add more test data from different (real) workloads, it would be greatly appreciated. Thanks Barry