From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98525C52D6F for ; Wed, 21 Aug 2024 21:47:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BDB96B0205; Wed, 21 Aug 2024 17:47:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26E536B0206; Wed, 21 Aug 2024 17:47:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 136406B0207; Wed, 21 Aug 2024 17:47:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EA94F6B0205 for ; Wed, 21 Aug 2024 17:47:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8AA6E1610EE for ; Wed, 21 Aug 2024 21:47:49 +0000 (UTC) X-FDA: 82477590258.12.9FBFF73 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by imf10.hostedemail.com (Postfix) with ESMTP id B8B9DC001A for ; Wed, 21 Aug 2024 21:47:47 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hiuGXBWC; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724276828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=98sniykhgHyIjDFEFBrJSB+NsoobwZCkbD/WwKcnXqA=; b=J24vpC2uj8kSbVugFTkkSl0SPg65IgZxeXBPAi2sAxKy3NHUwa9si1dIn1uInbrSMCEycN 5vMC9blKC4YZMU8EvXt9nRpKMDw0tG4cQs4BHixW89HMDZFOe52DfPK9S4qhlcQpsb/blA h3wA8wC4nlGejgC6LkG9BvA268y7K3s= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hiuGXBWC; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724276828; a=rsa-sha256; cv=none; b=assDTojOZoXYoJOwfaiJJ9/reHo5Sx5V60okLAWDhqHGaLDED9+XYL4YaGEIwWWvEJxv1P BFT3lfFkQD+hDmNGYcYBnz5THMw2E1LPiz2A/50WnIb33zUvVFEdTS0V2w88G3ZogjHHZC Gg/0kRoTYrc4Sgs8ZvfSOP/0gOC+LdU= Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-4f6ba99286cso63317e0c.0 for ; Wed, 21 Aug 2024 14:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724276867; x=1724881667; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=98sniykhgHyIjDFEFBrJSB+NsoobwZCkbD/WwKcnXqA=; b=hiuGXBWC14T66XPMfKzhYJWmwWZ+Gs385kW2zdXflJ6UxUnbcSMkON0KVv1Uvqcxlq 8hn4wLeYVhY3ZaSk35PmkIF19RZRUkuZcZ4WI5ivGHTKQ+4r6ZePU2Um/7HstJBSKaoJ RqL+QGUgz+5c+WVUJqKZaVdJXiIsxfrPiVnjfOYpBSleUFWh9+6tomPnCzDfbSgAwN8L hawjGXWmq4aCvDbZlPXf9PKk9LAFR63knaKD8f9ZVsshR0ml0WaipHkfm+ko9XWzF844 TwNEyjwWjjLIf5wPMcwLIGnfkL3gSEW2hw4ptjwy4iOovR2s2MZZ+xIXal2GaeHxcsji tQCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724276867; x=1724881667; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=98sniykhgHyIjDFEFBrJSB+NsoobwZCkbD/WwKcnXqA=; b=rT0rSfK75UBXy2DJVQYrEbtKKhHnGDnwIIfE/QJtMz5XYi+uEuCktx867gOP7NK/yV bTG3u4sbpkSd0KTUJ6Fj3TR1RA6IvTHJKM4bYcno+6MUxQhduJMU+DJRkg7WsUAxmBLX YhBf4tAlTQE5JMFD7ZraZcY9vvo/ObGOcKpcTMWCdl8BXruUkfDtXbc1NHe7TzP8afdn 4THDHUGLL3UKoJD+pmXpqMwgRxpC4GfSTDoipv+c6Ni/8o2cPPZ+51orGwM0r7NeA/zO jhf5p5BHefU8/Gi2OHq9l/LoW8Qk8FyXt9ZTuRam9SwksdvvqdhGk2kFOAGL0EqS0XNM 6TKw== X-Forwarded-Encrypted: i=1; AJvYcCWXXIBfTJo5sfMi02yxo/ck9riavbSw0qLrM69/VhT55N1Sds+Mgb/EtjszzW73tFPtT88eKyXdLA==@kvack.org X-Gm-Message-State: AOJu0Yzno0I8dQfzwiw5m3xx1lsvzuMVBq4QqiduxSXnz1DF6HHLt0kn FjMK7iJUXG6g4vWT+0iA4mqbKI1eg4JiHizoQYbXBAah9N9ZvLe2Wq/RyTTHsZsNpX58yqZB3mD 7VpbncaSgBbJkvbWIu90l1EFE+Ks= X-Google-Smtp-Source: AGHT+IE4i6KUS8cNvu8h5bdx1rDgorR2H6gZqTPtMis5YSVU9JCyrkwyPbPBpidyC+Iut0PWkgr1fkIqlTo/oWqOR34= X-Received: by 2002:a05:6122:31a3:b0:4fc:f1e3:d238 with SMTP id 71dfb90a1353d-4fcf1e3d3c8mr4395884e0c.1.1724276866613; Wed, 21 Aug 2024 14:47:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Thu, 22 Aug 2024 05:47:34 +0800 Message-ID: Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail To: Michal Hocko Cc: gaoxu , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Suren Baghdasaryan , Shaohua Li , yipengxiang , fengbaopeng , Kalesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B8B9DC001A X-Stat-Signature: s311umwrppiefw7zocs47u8rer676se8 X-HE-Tag: 1724276867-20532 X-HE-Meta: U2FsdGVkX1/7KJwEm5aDBMdwp7sTTc0JPnE1KfbMbscv+iXTw2FNvBxOkUZxx8kyTs/v7K0l7SCIOqGfwj7VEODlilDuo3/QzqieRte4bhpZjnRgjYEfh6hLiL8ZRAdghy1tgZosUNWegde9twqYYKhdRsQNH3xnaZtcTLtWJQ2Jzf62o3hbHRAwMT9MckykEI1WMfn3azqFjHe6ifSQCxUscBiR6v6vQ6VPpftZWf5i2PR7gNPtGC9QlybvPrCmANh4ue1IirjPKFEuHomMzuAGWSIXLf2KeIjPEkUejAWsCXJljtyUsbm+/+uFrXesW2CsGl2Pfp/288P/iKB8MnfWpST5ESr+Qh1kxIX6Agjxgu2/iNpWSA/jN48zS+K8JvRboxxB8gT9cQQziLqaOW93cFUymMWx1x4pX+kuTnkpZL/DFZmMnu8q1TMYpz39l7tk8jHBTZN2Qj/QSE+4R4T7erBSs9PnnxUweuzcUEPPZxu/Lm6IXw0HNjdHzS7Dn+X8EFrkaKVHVE/84othWmAFzGRPG4P13b6KOI54PC4B1MDne3bH9uU0Bku9kCxUNDmkI86RL7IrEcqkuMYz1t+hTDJ/R4nXWgcNXqPx56J9z0BMz74NbtNZOBXjJUxPSOxLJUf/n9kYN9r4cEW+rFSBF4IyyQLsP91m/JlaILilksWul5fD9zu5TMmLC+magLP/ogks7q2U1ffPmuaY6f/fGCcAe8uzb4QxDrlZfADepDQelmnIGNfksSZJ75zr3lvee0wJydBW1YgdLU2vaM7wir+QOjQ/moXtG9InrkijYURgrIMxfFMjvzwM+9VC+2J8wrevfMIMWJ7riYXUMpeZ8mXCpUbbWau0NfMmS2vBNGm2CTHbjjJGw/BjmgE6IkmIYzB7MpHy83xLi8y57YMxDYAPQuH3NepPkL+9n9pzcQgPj/x5DVM3LROV3cSj8keLoHfiUKBzSGXOKAH 78q7cTUk QjJBIgIKDM9LwYEnf5bdt1xWWyH8D+Hx0ZACp3XvgmlJJrOBxy56fnSpJ5sAU3Yom4upcevh1xTAtx4oWC0R9rfPyQUtHnPSm+bR2XUI+T/HlFuXKtKqNPap0T8Om9gs2ItsAq/dmsMIHvMzTLYRXfTJvI5Cf0hnGY9IqrXKNidL8gET7wEEaf/Q5y+SG9zeI9bqbhVrCdxHPHtATNYaBqvebCTUjA2DrrlFBAFv5antkFO9Od2RB1P20rqZavdU5z2Cm3ZN/xe4k1ElRuNIo9T+bO6l27ReKdd/wq/dvf6sn7Wlr0vQqkWQwsfLQbn7ZdWHFJnWSv9jG/S13JEd9ahFMV4s1/AwPe3dOOzhLefXhrt+vnrnZ8w/bLuH4uNzk+6a2hu9CV5aZtNngpoCnTJoy3yqKAgdd8C0nX2NMTpMOMlO1PW7uYo4vf9bBkQqbSaW93U+svRYe6rQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003634, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 21, 2024 at 8:46=E2=80=AFPM Michal Hocko wrot= e: > > On Fri 16-08-24 07:48:01, gaoxu wrote: > > Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfree= _fn: > > 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it's > > moved to the LRU tail, it allows for faster release lazy-free folio = and > > reduces the impact on file refault. > > This has been discussed when MADV_FREE was introduced. The question was > whether this memory has a lower priority than other inactive memory that > has been marked that way longer ago. Also consider several MADV_FREE > users should they be LIFO from the reclaim POV? The priority of this memory compared to other inactive memory that has been marked for a longer time likely depends on the user's expectations - How so= on do users expect MADV_FREE to be reclaimed compared with old file folios. art guys moved to MADV_FREE from MADV_DONTNEED without any useful performance data and reason in the changelog: https://android-review.googlesource.com/c/platform/art/+/2633132 Since art is the Android Java heap, it can be quite large. This increases t= he likelihood of packing the file LRU and reduces the chances of reclaiming anonymous memory, which could result in more file re-faults while helping anonymous folio persist longer in memory. I am really curious why art guys have moved to MADV_FREE if we have an approach to reach them. > > -- > Michal Hocko > SUSE Labs > Thanks Barry