From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D4FC43334 for ; Thu, 7 Jul 2022 21:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 224996B0072; Thu, 7 Jul 2022 17:12:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D4B16B0073; Thu, 7 Jul 2022 17:12:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09CB16B0074; Thu, 7 Jul 2022 17:12:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EFAA66B0072 for ; Thu, 7 Jul 2022 17:12:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id C4B9C60532 for ; Thu, 7 Jul 2022 21:12:26 +0000 (UTC) X-FDA: 79661552292.25.8B79BAE Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf25.hostedemail.com (Postfix) with ESMTP id 5CC63A0031 for ; Thu, 7 Jul 2022 21:12:26 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id r18so24661985edb.9 for ; Thu, 07 Jul 2022 14:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E7lBX2NVyR4wLZQ7armge/PHuuUWSeFzw9RQb5K1xo8=; b=WtBL5NKziFNuFTThNyyKxNqq993+zYRIUkT4vjvf6Boey1TYr16Iy6Kg5WLl0accKf M3R3r0q5cjZhKBrhC9F9Pts9C/B1qSR9RpD87Et+zf1VDKnlCjjQtaOl+FxU5cHCdQFE qNvHSRvgbBlLaOzHhWtRzkJOzd6WJ3Pjb8lA48fKI1LdbRfNt4V2peiD0LbFdI/eU0BO Hikqrd9EUNEUs/L5yQnYPwFDZW7qx3ed2N1uIurkM9Ul1Wntrc5LOR9dQeXdpfT9Kjmg JtRAfK2OS+/rk+0JTFTLdpdFS88Nke5QOhX6rtFm/D/ylsf/SIIBskXzaByujWUh0b9c SnBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E7lBX2NVyR4wLZQ7armge/PHuuUWSeFzw9RQb5K1xo8=; b=73Nppn1fX1WazEzXSRKbIddNqbs/86dr08Z7+n9EQZn/MhM0KsL7uzN+ycvO0oTvj5 lcv3nVe2Uyrb/ptvdCpXD3NB/y3HRa8jxQ6KQF4El2GiAhjtFbOlNVKz7Max6SLyxfEK V3+G/p4hHiJjQ/RrN7LC1VtRK6YQX+KWGkI6fLkqJdgiQaVCqYdV05k/GAlrGIqKocil G4G/RSzxQzbDqYieoCU/ElGjOfIIMh0BV9HHBXk48eIHbeTLxj6YHPqmidBCopDbh2Hm hKC3wrtEGQVqpQ4gLMZdZ1DYX7PuI34PvOFKX8vYC9uUXAnvHzCLpa9YxsCHIePoZP6j yPYA== X-Gm-Message-State: AJIora+B4Ouats6zF+9zU0c7xKn3WQGY5WCPH8LHEPeOAHj7STduaXUh RYqJIH1Zw62yatkLRoVoK12l8ACvPRMGrK6Bd7s= X-Google-Smtp-Source: AGRyM1uu3GWZeriqyMwRw43BUsAdyD5/Ff+Q6S+6/8raxI7MhcRy13mOivlcRjUlnjBx7zoR3TsKjCB8RuKwpaY+71w= X-Received: by 2002:a05:6402:42cb:b0:43a:5df2:bb5d with SMTP id i11-20020a05640242cb00b0043a5df2bb5dmr138776edc.36.1657228345125; Thu, 07 Jul 2022 14:12:25 -0700 (PDT) MIME-Version: 1.0 References: <20220707125242.425242-1-21cnbao@gmail.com> <20220707125242.425242-4-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Fri, 8 Jul 2022 09:12:14 +1200 Message-ID: Subject: Re: [PATCH 3/4] mm: rmap: Extend tlbbatch APIs to fit new platforms To: Dave Hansen Cc: Andrew Morton , Linux-MM , LAK , x86 , Catalin Marinas , Will Deacon , Linux Doc Mailing List , Jonathan Corbet , Arnd Bergmann , LKML , Darren Hart , Yicong Yang , huzhanyuan@oppo.com, =?UTF-8?B?5p2O5Z+56ZSLKHdpbmsp?= , =?UTF-8?B?5byg6K+X5piOKFNpbW9uIFpoYW5nKQ==?= , =?UTF-8?B?6YOt5YGl?= , real mz , Barry Song , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Nadav Amit , Mel Gorman Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657228346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E7lBX2NVyR4wLZQ7armge/PHuuUWSeFzw9RQb5K1xo8=; b=IcYNageJtqONi68TmQvNziEfo01h3+y5pNHe5+v1q7AknGigcnWSH+zrmNaKHCMLhWatlk UpVBDFPFEoRyI7krTXkUnt9zf++Y+wZuk0sNx8++fqdOV3qxRPKtNBLvYKnxesnya9MGg+ roBdNwsXLW+rAVHwfpA3VkmDNPKixvU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657228346; a=rsa-sha256; cv=none; b=vS7EKjEwBneuS5mwMoLqfcOsJzd8RsHQ5Vp6CoNyzmOIZrP3Z9rzXouIBOto6q5VV7sYVU NKpZARzz7B8M7V+ns4qazph9+yuEd4Bf8fw+5zPvMNZ683T2WP24j8aUecXXn7yZ/m8JWv 3BPFOJfXLliwCnYPiLszT1vvBEbrE+M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WtBL5NKz; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: 5CC63A0031 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WtBL5NKz; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: a8kt5xr3gmxb5fy7e1ne1mbwypyqjebs X-HE-Tag: 1657228346-142302 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 8, 2022 at 4:43 AM Dave Hansen wrote: > > On 7/7/22 05:52, Barry Song wrote: > > static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch, > > - struct mm_struct *mm) > > + struct mm_struct *mm, > > + struct vm_area_struct *vma, > > + unsigned long uaddr) > > { > > It's not a huge deal, but could we pass 'vma' _instead_ of 'mm'? The > implementations could then just use vma->vm_mm instead of the passed-in mm. Yes, Dave. Peter made the same suggestion in 4/4. will get this fixed in v2. Thanks Barry