From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66266C7115B for ; Tue, 24 Jun 2025 01:05:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B35A06B00B8; Mon, 23 Jun 2025 21:05:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE5916B00B9; Mon, 23 Jun 2025 21:05:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D4926B00BA; Mon, 23 Jun 2025 21:05:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8D0EE6B00B8 for ; Mon, 23 Jun 2025 21:05:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 04143BEB66 for ; Tue, 24 Jun 2025 01:05:36 +0000 (UTC) X-FDA: 83588501514.15.C8A42DE Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 265DA2000F for ; Tue, 24 Jun 2025 01:05:34 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PpuiCilY; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750727135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wmkeh02O3FeRv42Ev8tu/Bl3qINyE2JFkylUQ/agpEw=; b=zI5/DgfJO4Ob98AKGMyoGZcxXbNmJLwdkHF4DHIeor8kAIW3/rgqmelRvVVZrLnDppwQ3p CutS+sMs0+v8G/80pg9JC8PFNX6R54ZaKOM73cYSIcosDs81trEcJChYXdGeSCMzhPBGmm gH1lhXoVQcDSMoz5Tm3aLNyYUzGjYbI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PpuiCilY; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750727135; a=rsa-sha256; cv=none; b=b/tBQx5n0hXqAWATqKRnm3IcBT1dyaJ/SJC3U1yoTxOU4oWkRcZS6w92GhnuvG2AlzJHz5 +Wlw1jeHV3DrWb+pTo610/KbRRyDZfS0ivTvoa806n+Abk7JKrlueCg8Tz920iv50LVeFl PvKOjviAPzZy8rcLiWzXc5C1MJ+dCM0= Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-5314b486207so1337065e0c.2 for ; Mon, 23 Jun 2025 18:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750727134; x=1751331934; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Wmkeh02O3FeRv42Ev8tu/Bl3qINyE2JFkylUQ/agpEw=; b=PpuiCilYuArzAvMonByQ0bq0nKER037cUcwn2Ud00Yzi4AVxzVsQaao9HY284U/kP2 itDWlCSxBFuwFuDsKm5A1/EtFALKdwcCrpwhyMNjcFyVHaywaIlTiONLRWFHoqef0wje qI3Rhldn8NLVcsxfF6RuuoMQyKzv4SmR3wAGKB1qs2O68gRZwo5edpZlLEsQFlwci96Q kQY9rB9tkBVA2M6sTT9GrWq5JYocvIvB9HU3p2AnrPQ/blfLJjTPk296sPD79OGeBtnv EHqSlCytdwRn0Poumn7O+bwPRTC7VUrtIQkAQBkOZg7RufF4h75Ou0AsjqvErvjUgHbM VQ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750727134; x=1751331934; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wmkeh02O3FeRv42Ev8tu/Bl3qINyE2JFkylUQ/agpEw=; b=HR02oo9bKXoYym5n3qkMCn+QVeLaT/uOZvEXjNmmqYCBAShP7876wplla4+K4sr9if 2AoNtUVVSdfTKtheqE87YG0noHzI4P1ZVYb01BDYvzt9NJTe1O0je8BCcK+dTSCqxJu0 /p+aW6A1+GC5deUlw+4NYtwHJfpvEinw0kmiOjbvnl3r42C4+H3QgPbe2RQ9flS9utFa tKo0RJ41NktMVnmvApBs9cPQ7Fs3sjY8rC9pV+Ubv6EAsg3r01NJJN+fK2RhxRbD5ZWP 5aOAl+bO0Ae8/iw4elFoSqlC0WIegHvFCk7y8ye1Hy8emaswB0Crm+ZG2BrdwS32PkY9 +fdw== X-Forwarded-Encrypted: i=1; AJvYcCVxnC6DMijxqbu/bqWa0qK35cSbfi8urjnRO/buRcoYAM7cvwe/6m964wb6PONLDj96QJJM51ao9g==@kvack.org X-Gm-Message-State: AOJu0YzVM572EvyruNRcOCnC9EkxQiF3FCIT+259rcQTZkgxC+FS2JJ0 5yOV3MuFSTgJyvMeqEIPd/nhes1uDdPAfvvnViwnU37HrlVShXUcWhRahSB5LQv80Z4EVHJJQzw I3ZqXxdCn2gnTeV3rS5e5OzlcbnYgsOs= X-Gm-Gg: ASbGnctvUivN4FMIOImn+feg99tLOTn5dvy4KEfXOKYv12LZCrKKJjIRwIzQiGt4S0W DIfLUTM4P37+C/WQZcRhM1BE24akd+PT3Zu5fJDbunfHRTvp2kIt4/S+m634XoUU5fsd7aDuKFo CwB697kx/5abcl3lY6PIKooL8wNbLkq3wzTlOUj7EBQgkVrdiG4aXMNw== X-Google-Smtp-Source: AGHT+IEO+e+3lV8g5Vl93wLo7V5HtixLSBUG9hh5kJ0GIJdwxP/WV2y2BnIaTCHIaVZYIloASjI1u/mbF9djBJ+6BVo= X-Received: by 2002:a05:6122:78d:b0:530:5996:63a2 with SMTP id 71dfb90a1353d-531ad86d9femr9596660e0c.7.1750727134097; Mon, 23 Jun 2025 18:05:34 -0700 (PDT) MIME-Version: 1.0 References: <518480ceb48553d3c280bc2b0b5e77bbad840147.1750433500.git.lorenzo.stoakes@oracle.com> In-Reply-To: <518480ceb48553d3c280bc2b0b5e77bbad840147.1750433500.git.lorenzo.stoakes@oracle.com> From: Barry Song <21cnbao@gmail.com> Date: Tue, 24 Jun 2025 13:05:23 +1200 X-Gm-Features: Ac12FXxHr7lCHVAg0CKYT9Vu5jW2rD5YG_mrzrV7mswUqpt7MSvGBlJuyRVYRdo Message-ID: Subject: Re: [PATCH v2 3/5] mm/madvise: thread VMA range state through madvise_behavior To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang , SeongJae Park , Suren Baghdasaryan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 265DA2000F X-Stat-Signature: en96qbhtqqxt1kct4yymbcono853mqc6 X-Rspam-User: X-HE-Tag: 1750727134-439674 X-HE-Meta: U2FsdGVkX1/chvmbCMCwzcrJddV2TgHr6LuRqzEv8DpMd0igxz7Kiiv1M5s00YsukQfppBmRn0/yKENQ4lTtTXCT+CdI1WFn1txN4wgKuLpjN7pVsIXnNn7siqXDOZM+ELiMweeSHhxOigwRV0k+jHfuC4qLxSGCLAyGYFHy1f+4RH1RO4yX07BRbUEY+I8p56CiLr7Zp+d/TrQIv5Yr7XTQ+icCePA7zLufbgrs682dkbKTZsHDw2J4rV0nnP5hjMiZm8Z/ej/OUgj9EXgeoCDJ/LKur1GRjtOiHQq2M8TVTKXaI3vVuXSIqPgKvc3wX0l4RXyXqvgKHXy2u832HCfyZtq0RaBIX4Yov5fhpwqbDK3ETiMnH5QQH08ebywZ2aPVXAc2HaZrHxzXYsXkLfpqyFQRlMTEOc1ohbxv0DLqvfcJNxrW2Gz2FoEjqJ17bTKOyqrpM+03873Th0Wa3BfLUVwGxf81qTA9jGg6lS6tizqZsH8Pz/CpTLoEIr+WI7vRtSyFu7R8g6t6ejpUzAVvpK8YfA7/h6NiuPpY2sF6kbX8Geg1j8poWsMTtf5Sg07w2DQ4zFzka1SJR0Xz7LGvTD9hqB3rykCOc46oqBZiPZPlXuOY6fLZKH5lPsaQ2hoO9zcGrVFw+DZ8sQcqSRkOMmLEnqp+OWg/+j95S9hgSAhffa0bk/CHf4tWtwbXCXlEy5PYgkxm7K3BDuQZyZkgJ9ccCk9wo0tLOSmub398GHQImGfc+XQwe7nBpaTIi2ltSusPFh4QiTOI98Yr5fd72XNfQSQbFQmGHDpLo8rk9g91nGa9hzNtbXrQwJRy1zSbNE4wfGZ6/E+yMn9tUA7nEPGz5QXY/AXTv3leZ71LXxwgTOowtGemQEhwERNgjZI4rIaEZnuZRbUi3W/amKka3klKP1S10DSGqnkvRMEuLXXrow8L8nfoowN4clVGhc3rM1/suL+eoFKaqCL WaIdI5Hv Ic21GaJ1NJOYoZwI/EwmRvXSc1cAOAhmkaXc7oyVQ0zOQqun1ZHY0k/IYYMa5ZAh5OMYj0tbbpeY0hTZDEYA75FbEcv97gl8gCTOB4DFDzG0Q8A/9sSr/xgDIpMWcKrI1fFP3yMHgerync0pRGp5cnYCOv4yiYR3tzRhdG41Tty+CAYN0Fd6U0ThJvp8F3zYiq6zpqnb67+bd1jkbPQq1CelpuO69W/B636o6PTXC7W8+XSdUNAsp4fwXro2ePNj9dEwFaM+6+0aQshHTS8RUJrqv7FqOeMZx7GvWG5u/l7Un8/o48b5V5IzdE85BFYc+JHftPVXklcDDJC5MrEhBDPQ4Fi6Oe9U5Gxntf+Csm+A1wuOvD6HrJm0RbVkwdID+zfNvcGCo8l2dbEqo37fkZFj5AbCHq+a10Rzr0uYj8TZ0BeVIEQ5gJ5BdhMhO+lxjP9XT5EEnf3BuFiQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 21, 2025 at 3:33=E2=80=AFAM Lorenzo Stoakes wrote: > > Rather than updating start and a confusing local parameter 'tmp' in > madvise_walk_vmas(), instead store the current range being operated upon = in > the struct madvise_behavior helper object in a range pair and use this > consistently in all operations. > > This makes it clearer what is going on and opens the door to further > cleanup now we store state regarding what is currently being operated upo= n > here. > > Reviewed-by: Vlastimil Babka > Signed-off-by: Lorenzo Stoakes > --- > mm/madvise.c | 103 ++++++++++++++++++++++++++++----------------------- > 1 file changed, 57 insertions(+), 46 deletions(-) > Reviewed-by: Barry Song Best Regards Barry