From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE82C25B77 for ; Wed, 22 May 2024 10:40:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8891E6B0088; Wed, 22 May 2024 06:40:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8391F6B0089; Wed, 22 May 2024 06:40:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701976B0092; Wed, 22 May 2024 06:40:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 515BE6B0088 for ; Wed, 22 May 2024 06:40:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EC273C024F for ; Wed, 22 May 2024 10:40:34 +0000 (UTC) X-FDA: 82145687988.27.7806996 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) by imf24.hostedemail.com (Postfix) with ESMTP id 306AD180014 for ; Wed, 22 May 2024 10:40:33 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lkHDUfjG; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716374433; a=rsa-sha256; cv=none; b=TI3o3UzI1/cWuhNH2GTDNKWgSutk0QEQPgMPD1yuq52OKNuGbQoBfKKjGy/Eh0Degq0Y11 RUl8YTEEw6TLIUEOdJ8+GDK8wGJYVqaXHMUXK1uqhbCbIhxB9R3+cu3oD1JXrqFOXBFEzv uXh+TLbqOlogVOrLNmrKbeFKLl/28ao= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lkHDUfjG; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716374433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JGBrCiYdmQ4B6wnJrGx67czT3yLNOBqFphtPVjs664s=; b=3eCAMoh5dr0LNRttYPdcnm8EKtUPYLO9TJrDZZrhLspDHvuwgneF7Q0iG2/fc+KO8pKSG1 MlrcKY1SvgmuR4eLtMKMPUQ+F1HGzqNENhzlEv2ziOhE8+kApuMApK/DiQN+RSka8GESHw P6X66+JFGLoGtLCp//hQpUqua1eIBzs= Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-4df456bbf86so1594680e0c.1 for ; Wed, 22 May 2024 03:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716374432; x=1716979232; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JGBrCiYdmQ4B6wnJrGx67czT3yLNOBqFphtPVjs664s=; b=lkHDUfjGu6rHu4A3J4hEwmfqW0MxqrfWpf7jC24b/NJckBoljwCw+m+0v9blFBu8mh uAsJifPbJAgNy8MlyiiUARGWixChTr/2BVzqRRRHee7YjOGSOm7v8U1HEHe3+ncRN9Y1 AOG1cNLPN+U7p5hn8oAyk64MhgG9LhdVDza05sLN1bVmvcV+5q7eu3SbF8enLsdjlHv4 r4er/NMBDR68iW9Y8WMwB02U5Bs5WaoY0mwHtLrB+n7WiH4xFaSt5U92O+oPIjp4BnLI 6O7Tjpxu83IoTz+YNEm1F9OgMdYG+hgWN6rGIAmHO9xwgV23xjKo06z2vuSVmGQuQtnv 8eew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716374432; x=1716979232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGBrCiYdmQ4B6wnJrGx67czT3yLNOBqFphtPVjs664s=; b=HYrGsquyUmnNXtY34fdChprUblc4ynHxRr5kAS+sChM4vixdqM+wR05Z17gTyvdHJC eh3MQ6FnF87tmjlxbemw+0AcCO6K4kHHhe4AISDEcfacL1kLLvDT+8U2KCrN8E3FLenJ H4+0uRYqd2N9JROShsjg671IXzSj+2vs4LEhxK9HbTgLNXIW5+FuZ1GcI1Kn04uAZkkz P6Ny7MQAsD/tNz+RdL3m54rfvdGQsxC4Twt5zT3m0/5oAiBzCnl+f8Ti6HWEYYJsUGNw ldYS9SMQORmICEylDPd9gxSo+GS8vezGaqjrg6LfoNOjhw5kuRuN+RtxM3oI4uhrngFv af2w== X-Forwarded-Encrypted: i=1; AJvYcCUKlFLMreC2Xfr/8sAjlJfNrOZqTwn8V6pFTbWxEenAkWsUL/wSiwhqGm0AVqLyaE7J9KoumIiBWcurxq/IzK4QJvo= X-Gm-Message-State: AOJu0YwvR4Su6o8cdoB6gDda9PNKc+7NCkQndEOlM6w/FYfz7S0JXHNG szDNzwHKwX0UU0lz8MuggrE0h6bOHmvqC8nVNVD5lhmJUKSUNyK5l8YjiPZ0NV6kMEhf1q/Vd/5 Q5RCWNWHbZzgy+nx7wbBKv4rd4Rw= X-Google-Smtp-Source: AGHT+IFz/+FulVn/L4GngDGNYyGatHQM4h9w9g4/jURT3l7FTQh1zUzhDggmL2PIlEtdWuaZYnIBue2iy9mAn20e0uE= X-Received: by 2002:a05:6122:168b:b0:4cb:fc25:7caa with SMTP id 71dfb90a1353d-4e2185dfe36mr1512317e0c.14.1716374432152; Wed, 22 May 2024 03:40:32 -0700 (PDT) MIME-Version: 1.0 References: <0e2a6f232e7579a2e4407ecf075531980d97f286.1716367360.git.baolin.wang@linux.alibaba.com> <22ac01a3-ddbb-4114-88cd-ad1a31982dad@redhat.com> <51ba1fc1-fd77-4601-8d27-459162fd008c@linux.alibaba.com> In-Reply-To: <51ba1fc1-fd77-4601-8d27-459162fd008c@linux.alibaba.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 22 May 2024 22:40:20 +1200 Message-ID: Subject: Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters To: Baolin Wang Cc: David Hildenbrand , akpm@linux-foundation.org, willy@infradead.org, ying.huang@intel.com, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 306AD180014 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: jnwzuosn1aj8xrgz3t3ij33d815c5uae X-HE-Tag: 1716374433-465940 X-HE-Meta: U2FsdGVkX1+wpAy7fvCUB9e8M9ZBxKrJUHai79fzDZcMw5cPlrVkFD18PXXq9fvqw6syUNHsjjren1Qu1MW748dfOngwqyVnOZxMEy8KCBbiy3vKPnVXrCZQBgLNkLDlMcx+VIGLUfiv2EoOcZaG3j7qU9eqmhZAGV4WU+q44uzYtd0cBxxfiwwaQcdP6c/MBFRuFVqA9AJtN/1Ennxi7rHnd5nKBjFyPgN+mibYW29EwpoMaBLTOL5xMaK2iOmTkyytlP6keMXfaxN0mej2813NvdavzmGLm+Qd1fjyj7QxqSdk7qOEow2Na+PLALLIBhkHHs+z6jfvKX/JUJ7E3BI3QW+BSbG3JpzOTfACrLXpkPb6VPDbwC7PfEBaJshkS19xs26trMYApYaVk/GSeONzPtHSIKLszZVnpy7xKF241BqNG0gJ7WblM9DkwnyHjejTR0Ejt1hBdjHUn72dqGOMOhQG/lhmQE5OXfVJu2Lk1In9/o7LnrL36r9R6REolVCjQalm0I8UpYoPThWamk2tQoGSiFCd07+/7zP/fCv00aHwVeMkZ/8Q000DWi8l3m8mOxBdjq6w59jreazlh15Y3atqshzfsv8uprsZoNq0TBrjNEZX81RTOqPEcHXIJph8YiRYo4bZGin7vu/x195q0cO6NnRjSbD7CqIZODzYFA+Di70wNgVFKWU2nCg6uVzNBNevwJhcVEVm6PqCIyJUxRluEJ9zeelMOk/TI/M+rn85D4fBsMrtsZ/W340sd6/SCIlHky+IAiDzqbAXsvPwDKkdefguFd0xzAwqbiL/lOxftWEwjkt/AwI1XgNd8+yuC3rYD+e8WqXaIkFrvIp94zfuxj6EJKwJWKqzNU1eNDW8F+tOFpw70bRINskJ4FxrV0diMzlts8QJh1+cqMidKbNJzmhBQaly9aKwAGGbpRGSpwPrDO/Jx2RWCKwSjGmT2IlF4rFDApAx0+D EdNa1d4B 5tp2tGwPRiejkOo+DKIEwXVpJxeyHk1bZwjOqT9Xsev48rAAprv0QoZ0zDEYZe1A6FG0ZYl3SHlipaicljzFkcfvZ8/xKXtczMMi4bU5slPekTDXFgnaNRayUCb020CsYXLLYY34tQtyptO21Y730+RGKwOdeCxhlyS3QXchAODeIB0PWSDQ3WGwWlwc+vMMbllNGWT9n5Lk6ITkkWf+M3G9J8M4JNg/rcr6nB5wMkQAbmIL2xUYKoOyR1mbtQqe++LfLeh4yTZyHsCrh21fp2Sm18tCuEbYvS+sIskKfrCuhjDD7MvZD7/ytlIAhDJnIfNZXqUYZc11aA8dnScmtDXBsincqOedkNpEHl3QirGfNzDDEF5aGkJVlLz1qWUXeMsC0j708pV3Lo+7r1nNUwbRCMb/hwMl1jA+JwY6W/e/8uEtORH237Q8ywRaz9ZIbiH4s8kt9sXsz+Tyitc4vtEVI+XjCyM88eRTW+Zx/MTZqLPnN4yMuGWaMhVkgqf89xfDsCvK60chYxBeeUoQza7AayO+oJKlrCJdy/Bcvt7Sm3kU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 9:38=E2=80=AFPM Baolin Wang wrote: > > > > On 2024/5/22 16:58, David Hildenbrand wrote: > > On 22.05.24 10:51, Baolin Wang wrote: > >> The mTHP swap related counters: 'anon_swpout' and > >> 'anon_swpout_fallback' are > >> confusing with an 'anon_' prefix, since the shmem can swap out > >> non-anonymous > >> pages. So drop the 'anon_' prefix to keep consistent with the old swap > >> counter > >> names. > >> > >> Suggested-by: "Huang, Ying" > >> Signed-off-by: Baolin Wang > >> --- > > > > Am I daydreaming or did we add the anon_ for a reason and discussed the > > interaction with shmem? At least I remember some discussion around that= . > > Do you mean the shmem mTHP allocation counters in previous > discussion[1]? But for 'anon_swpout' and 'anon_swpout_fallback', I can > not find previous discussions that provided a reason for adding the > =E2=80=98anon_=E2=80=99 prefix. Barry, any comments? Thanks. HI Baolin, We had tons of emails discussing about namin and I found this email, https://lore.kernel.org/all/bca6d142-15fd-4af5-9f71-821f891e8305@redhat.com= / David had this comment, "I'm wondering if these should be ANON specific for now. We might want to add others (shmem, file) in the future." This is likely how the 'anon_' prefix started being added, although it wasn't specifically targeting swapout. I sense your patch slightly alters the behavior of thp_swpout_fallback in /proc/vmstat. Previously, we didn't classify them as THP_SWPOUT_FALLBACK, even though we always split them. if (folio_test_anon(folio) && folio_test_swapbacked(folio))= { ... if (!add_to_swap(folio)) { int __maybe_unused order =3D folio_order(folio); if (!folio_test_large(folio)) goto activate_locked_split; /* Fallback to swap normal pages */ if (split_folio_to_list(folio, folio_list)) goto activate_locked; #ifdef CONFIG_TRANSPARENT_HUGEPAGE if (nr_pages >=3D HPAGE_PMD_NR) { count_memcg_folio_events(fo= lio, THP_SWPOUT_FALLBACK= , 1); count_vm_event(THP_SWPOUT_FALLBACK); } count_mthp_stat(order, MTHP_STAT_ANON_SWPOUT_FALLBACK); #endif if (!add_to_swap(folio)) goto activate_locked_split; } } } else if (folio_test_swapbacked(folio) && folio_test_large(folio)) { /* Split shmem folio */ if (split_folio_to_list(folio, folio_list)) goto keep_locked; } If the goal is to incorporate pmd-mapped shmem under thp_swpout* in /proc/vmstat, and if there is consistency between /proc/vmstat and sys regarding their definitions, then I have no objection to this patch. However, shmem_swpout and shmem_swp= out_* appear more intuitive, given that thp_swpout_* in /proc/vmstat has never shown any increments for shmem until now - we have been always splitting shmem in vms= can. By the way, if this patch is accepted, it must be included in version 6.10 to maintain ABI compatibility. Additionally, documentation must be updated accordingly. > > [1] > https://lore.kernel.org/all/05d0096e4ec3e572d1d52d33a31a661321ac1551.1713= 755580.git.baolin.wang@linux.alibaba.com/ Thanks Barry