From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15EEC54798 for ; Sat, 9 Mar 2024 05:08:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BCFF6B0078; Sat, 9 Mar 2024 00:08:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36BC16B007E; Sat, 9 Mar 2024 00:08:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2339E6B0080; Sat, 9 Mar 2024 00:08:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 139636B0078 for ; Sat, 9 Mar 2024 00:08:29 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BD1CC815FB for ; Sat, 9 Mar 2024 05:08:28 +0000 (UTC) X-FDA: 81876319896.29.6A0B3F9 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf29.hostedemail.com (Postfix) with ESMTP id 29FCF120005 for ; Sat, 9 Mar 2024 05:08:26 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L6K44Rxe; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709960907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C3Ne36dcKUp5dKO89MEhMA2kgBQTra2ujtbNnpNKHJ4=; b=lmhQGAJKI0DwT6OTw0GP1ZkVpY5wGMyu0kc0DElPRQpiZOk6JhAA0Xd3DI4fBvtxTJR/Tz dnHyTp+aR0BYfLXKC9jQE9eM6kjvDMwxekKKiMqkChWvhPNghkcFLD2moWB2UWeG+Unfrw f8klnBP+j47a8Q/Y74TBpWf+Qlfh8kw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709960907; a=rsa-sha256; cv=none; b=t2TBroNaQlM5OloLitdVsTpHBR44euB+2Mzz8Pl4H8jK5CxAF6/q7McbGiYtd0SvCbSPRb 0AWtrz0Qs+0hqitat5hIpFZiE6EuPRdRyPPPXWBEKl5KERkVupmHOm1jFBElywG/ZeJhBL mRIL7y846snibIX9/038qpJNg4XC+dc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L6K44Rxe; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-7db4484672bso968507241.3 for ; Fri, 08 Mar 2024 21:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709960906; x=1710565706; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=C3Ne36dcKUp5dKO89MEhMA2kgBQTra2ujtbNnpNKHJ4=; b=L6K44RxeNgLpwqpXCAK6XaOrdETrtUSfaNePWmVNFb1N9SKzFhlrzK9cxSiqvdhoFo TM9CZdtdPpqxXTg+FX1y0Rv+21ZZReLgW9DfjGtHU/G712/J27tFWu/pMV6uHcvzp9g7 6ZjCTN5vjMCh1A54AgQpgkBJe6PhUAVsk+fZG19RQzB7g1iACbaGyuhTUOW7fFtKmDE1 YLHh7BLBLeQNc+fQ/5rsrW3+D15KZxbX9RpfMuQIvwpGH141w61w5nss6W3heuk2zf16 zQEWyplNa26mABMXWVPvppbK5HUEOqMYxZKb+uBHdfNKOIcWVgSlK3Y+lvq/vxP11JBI HeXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709960906; x=1710565706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C3Ne36dcKUp5dKO89MEhMA2kgBQTra2ujtbNnpNKHJ4=; b=QpuR7ieHs8O7vdqXjyarqqLSqGl9Jvtfh9ZwbbRuLTEneM/7Y/Hkb6a1x5QdX1B/S/ BL0/SeXSB0A1ysHpTdf+OZaK6uE/rUVqfWetX7vhaBv1r7PtLV7/eVcQFFbwSIMrTeUD dxlMryGYDd0pETshVRUyWpHinuMKxAO9fVIgc/VeoX5XsYf3QagF8i2iyg5slV2dz8Xo zSJ1bQfKYGLUvEhGC6F0XFXDRGS2fhmFXDXV5QecTtf8XdvtoxPbH2U94BNwd7Z+xhHz 4TT8qtgek5sVnsFu94uuLMZsuefuBNh2t5brH2CuwksvS9Uv5YcWaNdBY8oVeXy/YDpl vsQw== X-Forwarded-Encrypted: i=1; AJvYcCVeJeoeGXpQtKFMGspxOwMM50QxeOiyT0L2zKTxTFW7FUNWQxmDLuuejLrrahdb1+AWxos5TiI/2qC6bSDWv/RK22w= X-Gm-Message-State: AOJu0YxKAFx1SnTvxrdwMNUDcR2E7AKZXXkic64Ee2NzbZ7gTvATKllR AcoFwG0cS4xlJTnkh1LfABORuziygmsu7FhDaY0431k9o2h8ZWTQ1lofiN7sLwdVlLH1cH5NPUp Yj3HUwcT1m4UoYFN78uPVtZyZtxM= X-Google-Smtp-Source: AGHT+IG7/pySYCmBlupSm8NrazejiIUUebLfJGUmtfsFXcoXvUFaBM12ciZAsVZJVELPx7TmORBqRHwUVLzXxhjowbY= X-Received: by 2002:a05:6122:421c:b0:4d3:9a8d:c736 with SMTP id cm28-20020a056122421c00b004d39a8dc736mr1045077vkb.8.1709960906120; Fri, 08 Mar 2024 21:08:26 -0800 (PST) MIME-Version: 1.0 References: <20240222081135.173040-1-21cnbao@gmail.com> <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org> <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org> <20240308204251.43d7e518ba95fb4ce22f8d4d@linux-foundation.org> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Sat, 9 Mar 2024 13:08:14 +0800 Message-ID: Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable To: Andrew Morton Cc: herbert@gondor.apana.org.au, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song , davem@davemloft.net, hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, zhouchengming@bytedance.com, nphamcs@gmail.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 29FCF120005 X-Rspam-User: X-Stat-Signature: zfdogxpdtti7jdyr1xkhnej9zzak3qsj X-Rspamd-Server: rspam03 X-HE-Tag: 1709960906-927563 X-HE-Meta: U2FsdGVkX1+Sgx78L1gCF+IN+oxSVJw3YbF3+Ya6ykgUD6gU7ISDMS3qd2xNKIdVMRU76lkppCr2/qaf6qVSs7xIb/JDxkx35qYmHeqzUU0er4UkCOnmhVwKic3/YtdgRy5cjs+/vFoY1A66ddrlMBgZXcfyw5vYHCegSFM5ny/n6FC7QayLwjlCldwSphiqQztOM8jMzhW5CKbsphfac+o3WZxKGmQ22H6KncC0UgpVSE7vfQgwbArUHRrzaWVDjaN63dHKCJPjQHsaIHcRARSKCc3X9HCyRRvRfGNTogIzYIrS1WBTt/sBjaXJScr6kqC16NskKpqvVwSoRHpx3MR3El2fYdUl3jDpsR4OjuxPoc53emlTOHHxQYSFkTMpGjdRWpeeGkR0iy06fvmf4fH/IRK0KQtQmFzo2BHRnj19wA0iPQFd61xJ8mCInR4IirGLsXJhJWcFIWhTp/ndSRk44wcmQPW2tKT3m1zSyVRzIKNCsXg9MeweQ9jcIe8MFj6HPdbiSQ9lW5zLPUOwbNiVpso1Ye1R7/GwDrGVpoTStTHsXi6Sy6pziwZTnYype8nZAoCfU9sj6meM1QxbRVPzovjbaD9xTVR8KolDdg7Ae+Opzk9+V4t/QxsslkNvqjjblZgIdLEZbgukxI49uhAnjNHjRz/9Ttkq470tX4vXLc7xw+tAIOUrBurpiQKgY9Qmjtzd6WFF2PL4RFpcUdSyPoagGSRwV9dN7iDO6mtFT04Bd4qHi+hFKC5amEQcqC87soEbeeruSDs93qbxlkncyxnyO2lPo9rGZWJvBkV9xQ6prtiYGBWO5rfMWCCjFN3DTKIQZhj1oR2cbnXAWE6hdDOqHHb/jUQi9xrITMIUCR7f9DWCbT6PVwKKz16erbHX9mhkw6o6h0J5L3oHICbsNE3wPXZB+RYnebG1opS7gzMRF5WRyeMZgkPlli7VYsary2NgbsYbOpidyFb v8juj6xK lJg55ZvSCof1g06nZc82GV6uG9XtryeqBiitQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 9, 2024 at 12:56=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot= e: > > On Sat, Mar 9, 2024 at 12:42=E2=80=AFPM Andrew Morton wrote: > > > > On Fri, 8 Mar 2024 20:36:41 -0800 Andrew Morton wrote: > > > > > > Okay, I understand. Since this patch improves zswap's performance, = I wanted > > > > it to be integrated sooner to contribute. However, I'm perfectly wi= lling to > > > > respect your concerns and adhere to the community's best practices. > > > > > > > > > > OK. I very much doubt if anyone is running those drivers on mm.git, = so > > > adding it now isn't likely to hurt. > > > > > > So I'll merge it now and shall aim to get it upstream very late in th= e > > > next merge window. > > > > Nope. mm.git won't build without acomp_is_async(). > > > > We can merge the zswap patch via the crypto tree. Acked-by: me. > > Herbert Acked the acomp_is_async() patch in v5 instead of picking it up > into crypto: > https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/ More details: Herbert acked the acomp_is_async in v5 [1], while he requeste= d that patch 3/3 of v5 be split from the series and applied by crypto [2]. Patch 3/3 of v5 can function independently of 1/3 and 2/3, and it has already been included in the crypto tree. That is why v6 has only two left. [1] https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/ [2] https://lore.kernel.org/linux-mm/ZdWLim6zYSl%2Fx1Bk@gondor.apana.org.au= / > > > > > Or please just resend the zswap change after 6.9-rc1 is released. Thanks Barry