From: Barry Song <21cnbao@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Breno Leitao <leitao@debian.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Lance Yang <lance.yang@linux.dev>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mike Rapoport <rppt@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com,
"Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Subject: Re: [PATCH v5 2/4] mm: huge_memory: refactor anon_enabled_store() with change_anon_orders()
Date: Wed, 11 Mar 2026 04:22:50 +0800 [thread overview]
Message-ID: <CAGsJ_4zQf-6t5uSqNobA22q8wtchsE217ohC+2yG9-Rgum+dvA@mail.gmail.com> (raw)
In-Reply-To: <20260310131726.a9173c7cfa333b6522f9c8f2@linux-foundation.org>
On Wed, Mar 11, 2026 at 4:17 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 11 Mar 2026 04:11:36 +0800 Barry Song <21cnbao@gmail.com> wrote:
>
> > > +static bool set_anon_enabled_mode(int order, enum anon_enabled_mode mode)
> > > +{
> > > + static unsigned long *enabled_orders[] = {
> > > + &huge_anon_orders_always,
> > > + &huge_anon_orders_madvise,
> > > + &huge_anon_orders_inherit,
> > > + };
> >
> > Is there a reason enabled_orders needs to be static?
> > Could it instead be allocated on the stack?
>
> Could, but then the array would be rebuilt each time the function is called.
> The idea here is to save a bit of runtime cost.
I see. My understanding is that this function is very cold,
so we don't really care about its performance. But I'm fine
with keeping it static if you prefer.
Thanks
Barry
next prev parent reply other threads:[~2026-03-10 20:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 17:57 [PATCH v5 0/4] mm: thp: reduce unnecessary start_stop_khugepaged() calls Breno Leitao
2026-03-10 17:57 ` [PATCH v5 1/4] mm: khugepaged: export set_recommended_min_free_kbytes() Breno Leitao
2026-03-10 18:32 ` Zi Yan
2026-03-10 17:57 ` [PATCH v5 2/4] mm: huge_memory: refactor anon_enabled_store() with change_anon_orders() Breno Leitao
2026-03-10 18:38 ` Zi Yan
2026-03-10 20:11 ` Barry Song
2026-03-10 20:17 ` Andrew Morton
2026-03-10 20:22 ` Barry Song [this message]
2026-03-11 1:37 ` Baolin Wang
2026-03-11 3:12 ` Wei Yang
2026-03-11 4:52 ` Lance Yang
2026-03-11 9:26 ` Breno Leitao
2026-03-10 17:57 ` [PATCH v5 3/4] mm: huge_memory: refactor enabled_store() with change_enabled() Breno Leitao
2026-03-10 18:40 ` Zi Yan
2026-03-11 1:39 ` Baolin Wang
2026-03-11 3:13 ` Wei Yang
2026-03-10 17:57 ` [PATCH v5 4/4] mm: ratelimit min_free_kbytes adjustment messages Breno Leitao
2026-03-10 18:41 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsJ_4zQf-6t5uSqNobA22q8wtchsE217ohC+2yG9-Rgum+dvA@mail.gmail.com \
--to=21cnbao@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=usamaarif642@gmail.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox