From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 352B9D59F75 for ; Wed, 6 Nov 2024 21:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB6A06B00A2; Wed, 6 Nov 2024 16:53:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B66976B00A4; Wed, 6 Nov 2024 16:53:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E0596B00A5; Wed, 6 Nov 2024 16:53:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7FE7B6B00A2 for ; Wed, 6 Nov 2024 16:53:25 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 45D5B140144 for ; Wed, 6 Nov 2024 21:53:25 +0000 (UTC) X-FDA: 82757020206.07.7C61560 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf22.hostedemail.com (Postfix) with ESMTP id 3BFC0C000D for ; Wed, 6 Nov 2024 21:52:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C8W2murL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730929919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AF/zxMWhYdd3F+5qWwSaKGM6vouZPDy8y9g97i1mZbo=; b=y3xicJgxAGYF6kAHioZVQLcVEMBr/fpXn9bhfBhNNhhmL2JEHHErRA0nFhGUq0y4U6FeOk CUZcSl+8sPrrNUXYVXTh2OHIVFsFG3o8oDa9nLJKuT083UB9n81bmk8MWLvOh3sHV8IYjQ y8JRgt4DnIB6t9ava6NEyP0E+N6DXj4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C8W2murL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730929919; a=rsa-sha256; cv=none; b=7te4akf4ICrO/gTSNPfw8XNjjmJ8/g0EWM8kBr0hnr5jhBWfsyOnc/yheZPR0h+buVEk3s 5nbeLvuXCj92Vr9H9PrL8oTW+Qharwcr5nlgidS9r3It+QzY2wcvMVA+G2bLXOS6N/BN86 DsQS6J3nnE1KjjnHjFAABrcRPw+nw/4= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-84fcb49691fso92422241.3 for ; Wed, 06 Nov 2024 13:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730930002; x=1731534802; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AF/zxMWhYdd3F+5qWwSaKGM6vouZPDy8y9g97i1mZbo=; b=C8W2murLfqksV2uhlL1FuwC/sYul7nADOCWWd6N9rIRRNiWIZmsLh8UrEv2psSrH27 dS1gMsZMQEAa0baaAR5kdptSfgd/GBLYsO+lQb/Ng2p3GOv6m25sbRvJpmXN1Qmm1eQ0 NzOpO6ig8vZYk13AN46e8dNdCWRDAibXKe1t7HqdLl3iPEJBMhRT7DYXzWGsyR/7qElV tFURvFVf8OlxrV1ATkKZkgR5sXlH85B4cACAu7hoKFtmbYe5fAr8WcPQyyojnLj7++Ik yaMo0/HTWkb73g+V6oTQgoDIZeZZJZrDZJqTMvoGy3znCarSq8fXvR4r2R+gxYwmOXey uypw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730930002; x=1731534802; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AF/zxMWhYdd3F+5qWwSaKGM6vouZPDy8y9g97i1mZbo=; b=I70WUsG5oqj23PexBmpZTfxZwcWtG8xu2FxWerWKfOowWR6tVh8hlqnsBLUoDZctRM D2MLrODMIf0V1x1y5EcGEwZNsN2JDcspeJ60XQctMRAzROPgPcUtRFtgwmNCmCzvZ3x+ SYSn+d2Pd68DwkvkP8hZWQZlM6Ziwe+Fu/2c8SEBgMRVPz82xmo7v5IrRC+oqbdSYYe2 yKIP2mOltyrxD4gsG70DfolvQjVGFvsTYtfeuCCHTqy9v5aEOUhvaY0jfm5SxvCBwDv7 SNEhYOJj49tfbL+2XStIJRgJkl3sZtjmycRwBu6QJ4kNl8Cn9FTSwg3R+x+WHIIsYK5+ uhHA== X-Forwarded-Encrypted: i=1; AJvYcCVDT1z8Vz5QL/71/PIFKIHG8NZIjGHsXLompmQa9oEwkaHhsXk1dsBIcImZNqBfjfidxze01lkTlQ==@kvack.org X-Gm-Message-State: AOJu0Yx4woEI+6alYxrIhFdziZBLKWQD4fqoqPj28GE7atxTdaAjfDDB IMS5nIyFXNbvrjRFrLKpQ/hvPulyz/6iUjeqqHcxRNRT6qSOnh6QNGiLiskGmF0PC3AzncEejXv XYub+rovE5QulIlm6IHYEvUZ6/uQ= X-Google-Smtp-Source: AGHT+IHzVx0GzHxGxE7gncrXRX7YZTwBsFmcbvBR/mGsOtf6FSBN5/kujypl1V+CAG8IQXObE0r1Bca490Jx6n6jjhg= X-Received: by 2002:a05:6102:2ac7:b0:4a4:8ef0:25ae with SMTP id ada2fe7eead31-4a901045900mr28978994137.25.1730930002472; Wed, 06 Nov 2024 13:53:22 -0800 (PST) MIME-Version: 1.0 References: <20241105211934.5083-1-21cnbao@gmail.com> <20241106150631.GA1172372@cmpxchg.org> <20241106124225.632b42c3680cae0b940d2871@linux-foundation.org> <20241106134446.aaadc57a2a88c9efe899c838@linux-foundation.org> In-Reply-To: <20241106134446.aaadc57a2a88c9efe899c838@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Thu, 7 Nov 2024 10:53:11 +1300 Message-ID: Subject: Re: [PATCH v3] mm: count zeromap read and set for swapout and swapin To: Andrew Morton , Kanchana P Sridhar Cc: Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Nhat Pham , Usama Arif , Chengming Zhou , Yosry Ahmed , Hailong Liu , David Hildenbrand , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3BFC0C000D X-Stat-Signature: xicxz3rqhksxokgrwjoiasahgprr8bhn X-HE-Tag: 1730929960-974302 X-HE-Meta: U2FsdGVkX18Uq/uQLmYCFHsXRQLManN3kcJkZqwh6HLiHG87x7e5/fi3YItIdbxRmbZzfU9typzMoGtFuxMNnaPnEO03xODIoDvnZB/k3w/9oFWg0P11T9mpg7/mcN9+ApJ4Lvd2578JJ00D5qnZqbqG+ai8dpLfHGrGES6oCZIxVQnOtdM4tP1GMrnGh9O+CZZ33IftvQtPxO741t71kPJpak4/sm+FstwqaNfyQDVQhHUU3hnhKV09/Su7f0+R5DcyUZenJTG5ZHZETFkk8bx2tSJGrXdqb2gFG2ZJxazs85PRNs5soeJkH3SNwOKmeKAiSJD34mY4fVwR31v6818vKL3WL8eC65X9+qRUkrunpg0GoEUFpE5Ut1KLnUKYY7NfogUm75MafRkIMOJvFEz8MZSxRU2AK6kP9eKbH0V0vU9/vcalVT3/+AK1ugl5m0rvpfG/gGPsbF3eCCqenpd2fGF/hTfocy2FrMP3f7ltIDIMPlQmD5zvkk8nPYMJrOlm9foPALx1bQ9YcPddYfw1yWB/+tlG43gctj3Jdwlg7mp/4j6b+hyxoYhYChuQllroWtOP3LTFWE3P3n/c+SwaW50bw6GK+/H044XzwjXYSKWqbWUVh78TY8CU+ZWTYep/5hLsaYoZbBl73UUZ6AwMcYDXAwWHUjM1U6ElX8/yQ1kg8d7sC1QAbGbVc4C1Bw0hDN2nVHBXE1JqeArSsGJL9yRXreYgtPcCmzrPIYrEhA4wk1nkXDqvVjjeWVY/AzD65SyjnBProE3XeYgxi4twD/xKjYzkEi9pKhhCdRjAnj/mVPrL5Cs08zDB9esXm7qz94rWYmNRg+STpY1iNVrYw6UNWw9a2fPtnITBHiIqhqKEfD3XngVzfGetFMYorTT6cWC8ITmpJaydyUpTWi7qv3mLdDiHk/rd69dzPIZrWJSGOHISTrns9uNUm+y9ctMGzO+b4txWmYUG/n+ xjg9pK9n z2l480VpGC80JlCCedt/BK69+sEYbpBcIAK/Es96m7vFPimq2r/vxWV+GvSaCnvcI2/AHOwE8FhhTFo9+mD+i8zIZl5CRFgZi4bn9m98wg8UDor9Yl79hDbH0rmjLiFSBQatIfT7waQq1o0FehLfFz9+7TnGlx+jLw0waCkTJ7IY6I1j36PMdmmOXhQHZs97Oq1f7lFGkSzN2tneUbrbWrQ5iIZ/JoHjd5m4FD+z7GmsEuKL7MgNn8pscjBJpRHE0A63+tLFpQ+Cq0YMDlidHYDQTGH5JUws1y/vfbDYQQAz6bbzeCJIYylpM5WGqvd9TBcNOt3lLTxlGhkRRrMlaHaOVZXH3u3hV86XhEU7Ky1sEn77kTPK70m//d9YzwQxyXUSugfT0iix/565POMbwWoY3ELg7TpxJZYokmzBqHA19OGs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 7, 2024 at 10:44=E2=80=AFAM Andrew Morton wrote: > > On Thu, 7 Nov 2024 10:00:47 +1300 Barry Song <21cnbao@gmail.com> wrote: > > > On Thu, Nov 7, 2024 at 9:42=E2=80=AFAM Andrew Morton wrote: > > > > > > On Thu, 7 Nov 2024 09:01:14 +1300 Barry Song <21cnbao@gmail.com> wrot= e: > > > > > > > Oops, it seems that it depends on Kanchana's 'mm: change count_objc= g_event() to > > > > count_objcg_events() for batch event updates,' which also isn't pre= sent in 6.12. > > > > > > > > Otherwise, it won't build, as reported here: > > > > https://lore.kernel.org/linux-mm/CAGsJ_4whD31+Lk0m2uq-o=3DygvkRsw1u= XcPeqxBONV-RUXkeEzg@mail.gmail.com/ > > > > > > argh. > > > > > > > Apologies for the inconvenience. > > > > > > Hi Andrew, > > > > What=E2=80=99s the best approach here? Should we include Kanchana's= patch that extends > > > > the nr argument for count_objcg_events() in 6.12-rc as well? > > > > > > Let's do the right thing here. I'll drop this patch from mm-hotfixes= . > > > Please send a v4 against Linus mainline fairly soon then I'll redo > > > Kanchana's series around that. > > > > Alright. The question is whether we should integrate Kanchana's 'mm: > > change count_objcg_event() to count_objcg_events() for batch event > > updates' into 'mm: count zeromap read and set for swapout and swapin,' > > or keep it as a separate patch as patch 1/2? > > > > I guess integration would be better, as hotfixes may not be ideal for a= patch > > series? > > I don't fully understand what you're asking here. > > I'm suggesting that you prepare a minimal patch that fixes the bug in > Linus's kernel. Then we figure out what to do with Kanchana's 6.13-rc1 > material after the bugfix is sorted out. Kanchana's commit 'mm: change count_objcg_event() to count_objcg_events()' changes count_objcg_event() to count_objcg_events() and supports nr_pages more than 1. This is what we need for the minimal patch of fixing zeromap as zeromap could be nr_pages > 1 for large folios. So my question is that, do I combine Kanchana's change into my patch and send a single patch, or do I send a patch series with 2 patches: 1: Kanchana's mm: change count_objcg_event() to count_objcg_events() 2: mm: count zeromap read and set for swapout and swapin If we combine them into a single patch, I'll need to incorporate the change= s from 1 into 2. I'm also unsure how to acknowledge Kanchana's contribution =E2=80=94perhaps mark it as co-developed? Cc'd Kanchana as well. Thanks barry