From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B18C021B2 for ; Sat, 22 Feb 2025 07:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED5E3280001; Sat, 22 Feb 2025 02:13:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E86336B009C; Sat, 22 Feb 2025 02:13:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D26F3280001; Sat, 22 Feb 2025 02:13:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B24F36B009B for ; Sat, 22 Feb 2025 02:13:27 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 74EC1A143C for ; Sat, 22 Feb 2025 07:13:27 +0000 (UTC) X-FDA: 83146714854.18.2EE46E0 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf24.hostedemail.com (Postfix) with ESMTP id 98D1D18000D for ; Sat, 22 Feb 2025 07:13:25 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XDv9qBE+; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740208405; a=rsa-sha256; cv=none; b=Z6b6Ik9j3qb481mnmDxCTAhB+UYQ80grXudoRJZeDPFLkXkzK1yhmHUtPXaWAr99YElDAH iIdkT0Zrsm++fPDI9m5iUgzvJpszVq0YXKkcgqdnFDS+jX1zZMJQjkZ7fxYWCDcvK1zdqN Jos5ikKJdlLNFMCtr3u78/X/DkSuqmg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XDv9qBE+; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740208405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w9DEPfIUaeTXMgfFcGEhuQIhfSpChWt0G71yif5xy60=; b=WRmtBcCmjrypdqT+RUBexjHYeenRsBDXe6oo/kUqATOWc8MfiZ36YNLDE05OAChC3te28S jsQE+SUuPnQPfDSXht7r+s2olID6H+VImycTCVuNfJnEc2Yrcaho6jw2qcfZ9nhYlEXty7 uADo+2bGXSMJGzxaWF/Ul3VlGhlYaNg= Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-8692998b124so1640792241.0 for ; Fri, 21 Feb 2025 23:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740208405; x=1740813205; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w9DEPfIUaeTXMgfFcGEhuQIhfSpChWt0G71yif5xy60=; b=XDv9qBE+hZilEFlzUOs/l2uP3b13WtOzGHw49nMwsd771XEC/C9ktntcYUX4y8RtaW Sl+vHSnGdG5ccZkraF7vL+Qt09hGG4jODX1+9uEGfAAjiU82dupzgfWoKv8x/cSxt+PQ sgmDm2GNZvADAchFLbbgCq/+XEHVSfTVmhpj9g3TiID27Ky0vl7sqJ95KVEYqN6qoOv4 SBBdHwb6IPJe+EiDvRNEPJQ267U+15ZB8oCJKfTXVlmx3xsUFwYrDw9eiP5GjwQg8zJt 0iGj6EQqfgUqcsRNduzRrID3ffVjrhfgxHmBxHaz3p2zFdE3d7bQY15eUMWJPw32Y8N8 o0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740208405; x=1740813205; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w9DEPfIUaeTXMgfFcGEhuQIhfSpChWt0G71yif5xy60=; b=nSkKLR9znV+vJu3Rj4KytD6SCiDvBEH5DDHrX5rBDUjuL3orIXcPZ1cY+2SPfevCIH WVB5br9dcY4dc/KglQHOP9B3IqGL05xrAyFEbjrWaLU655VGjnALkkxIWaTiWh5BbJlr wcJ29dzoySQIDUYnQ7dfqT1LAbFx2dadezsjSGEtpAhD8SRFViLvqXQEHPgtAWjJ4tq7 6kc9ObvK2T8nkjPf8x6b49DzLzZx5bJfM/JPzgtAC/nddJaPTeFB/Gj2TXKvzw8BsMpF ArDD/bo0JVz5xpuuZN68YTgwo4s+ZeFv3RFh+ioUlYVeHqIk6qCWtmm3UuG4HtlwhXuB GZ6w== X-Forwarded-Encrypted: i=1; AJvYcCX+cMDCA2KfO3eE9ZYV3OORmpRXWbUJPtJtRVdBGP1ncQrypTOdu7g1CqZAx8NVqw357sHB4SWhuw==@kvack.org X-Gm-Message-State: AOJu0YxI4HX0Re0mEhk3/3CdqnIM06rof9HcYsRWySCQjQwUt7ew2+a9 y4lr95x8eULA82Th/wx9TzvO5Z+qByI8PGW1ADjNbsHs430aR52auYMJRY/mx+bA1r+mI8HM0wc TeayVXJWxz/RVGtR3B5Z4TGQTGto= X-Gm-Gg: ASbGnctuGGCb6r02cwHOWXGfe8+kHiPJB2OTq/W0TheoDva/tq/nHHGD6FoD2ne3RMj J0ylgFek+D2qFUUhhI7b/bLrXI+sQt7cVD4Zgpvd4XfDEHAdrhNWnxqG+0rnjKDWmBPrmUypJqT 4W5JAE1UI= X-Google-Smtp-Source: AGHT+IEjCNuNtx0HqgQzp0hQ1PJkoUz6gjyrbF7QTZN2cGChVV7Ye8nzJ0mfsDS0KbBqSYD5fzGU3lyxkVdS/G6inkI= X-Received: by 2002:a05:6102:3590:b0:4bb:cbbc:38 with SMTP id ada2fe7eead31-4bfc27af44cmr3135788137.5.1740208404697; Fri, 21 Feb 2025 23:13:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Sat, 22 Feb 2025 20:13:13 +1300 X-Gm-Features: AWEUYZm4ocljS3cZC8vMkzKYwy5pQFoaMBXQCfkIV2ImUhm2yWeLVnECTF6-ZyA Message-ID: Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. To: Herbert Xu Cc: Yosry Ahmed , Minchan Kim , Sergey Senozhatsky , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: rm9f6rzrk8ny4mxsgnqse8irp39ytxm8 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 98D1D18000D X-Rspam-User: X-HE-Tag: 1740208405-765659 X-HE-Meta: U2FsdGVkX18fz4RP6Wml7wCur82PMmB52mAc1YL7bOXSirgdnsPuPXdJCFtXrfetwQ3Xedm9Awu3+Dr8ZYcfZDgLL1acEuZ8oPMUrL4QS/EvX0AYpHJJ+sysMyGM96p1Urq+lzT5978Ir3j1eS7YR4WL26YLEhykLEea2gqqVBr9iOuSX7qxUwJDRJqzO+CalksQojt4KdY4PvjeRT85Mik5KqY7K2ayg7v7TGELEXseaq3SkK4IJLGPc4Ah8BvuLHHLYF9VvwHZ8CjFVkyZJDnqEYU3xlZopzDeXKWx8Hf47vIcW6eZ8/roL1sgpoOEMhd/ZO65IGtWMph92+h3aTMUQKRKDg+KnKsIQkV1c0khd3JmWNVwlr54JD0c5WvC/CFttjbgeC/oFKKpNC9pYPf+yHONPe6QWfWpgHLlmhsXDf1/0V8nsSSSZXBEL7M9dxcwMz+zfATPUlOUvgIcifimtpb016q0c3L/JzidXoefM0/YgWZAM0+KoqHFIE1ql8aXbS2aQOue+p+0GniWUmD/aNhzw5/9a5Yz1Glp3dIlHcpAqmbiqpnkurbk/vxuGI4Z/IznMGVUTnsSlnelHxvvr4XSKE6H3AKyg5dkdR+ksBJTu4TsBiE+xUCj0l0snHT3oXyZ4La4UTraXNOf7VMRQobKni2NTXWfsCDZnJgGBSyYuXLuUohjRmxzEQ9yaAB32LAwcCx2WwiB9YLl0lLrAAcVq5frziwhKn+ZvrMTi3BS+qY+n+8djBHlAWnqkSy3fCXnA1kQL7Pe8PVvThI1bwhqB0iXEdDiRCIBDNndyJck2fn4Th1nGtlE0ELuLsnV1nQ8XRTRN36uVzbwBEj6k6YtWqGCh0MOf0jOYESbFj7hwGMgzwZ6p4Bbq5BZVvf4pfMPCR7eMJ6m4nMJW8bxeENClqHu/71ufRXokOd+WF05EG8BlMKUYcjSl8/no+0mKlYROIbRbkEDnfX kQi/mpsF 9jfvTZk0+uPUI1djDphW9nrwsz+xXEj1Fc4Kt6btcz1Rr8H/L5MUnKgBcHmdwt6AUjdi+uDHr2hgZR3GqfngoDzYBDKBG5o6uc9hBiFaVX2we96GfQOJpACKzZGkkOIkVUrRpO2Icl0dUj3Cfjl8938ysvj+KRiU7sn0zwjTWtrr6038WFRLfwnrHqxF1489QZj5zlb2Se7CGKnRwNTWneLh5ny2g8MxhN/0TFRYpBilpMupQswQe2aJaxiTNFpFQsZR9NASVqEfNZaYCF2l8dSUTZPMofsTan8JPlV319yFsUBpAkAofmIfd0pDKQpjVZsHRq901ZVt6qJT+NPa04i60c0fFFIM8QpiRNQUq2YZjP3iVHihTvJ3yAMY+3/CPCiDFPwQd+yBWzabL0bduQWMEVdGN3jXopilfeB5d3BO9u8g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.007283, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 7:52=E2=80=AFPM Herbert Xu wrote: > > On Sat, Feb 22, 2025 at 07:41:54PM +1300, Barry Song wrote: > > > > probably no, as an incompressible page might become compressible > > after changing an algorithm. This is possible, users may swith an > > algorithm to compress an incompressible page in the background. > > I don't understand the difference. If something is wrong with > the system causing the compression algorithm to fail, shouldn't > zswap just hobble along as if the page was incompressible? > > In fact it would be quite reasonble to try to recompress it if > the admin did change the algorithm later because the error may > have been specific to the previous algorithm implementation. > Somehow, I find your comment reasonable. Another point I want to mention is the semantic difference. For example, in a system with only one algorithm, a dst_buf overflow still means a successful swap-out. However, other errors actually indicate an I/O failure. In such cases, vmscan.c will log the relevant error in pageout() to notify the user. Anyway, I'm not an authority on this, so I=E2=80=99d like to see comments from Minchan, Sergey, and Yosry. > Of course I totally agree that there should be a reporting > mechanism to catch errors that admins/developers should know > about. But apart from reporting that error there should be > no difference between an inherently incompressible page vs. > buggy algorithm/broken hardware failing to compress the page. > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > Thanks Barry