From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817C7C27C75 for ; Thu, 13 Jun 2024 09:06:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17C4F6B0098; Thu, 13 Jun 2024 05:06:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12AFA6B00B1; Thu, 13 Jun 2024 05:06:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0D686B00B2; Thu, 13 Jun 2024 05:06:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D2EAB6B0098 for ; Thu, 13 Jun 2024 05:06:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7F1ADA0818 for ; Thu, 13 Jun 2024 09:06:37 +0000 (UTC) X-FDA: 82225284834.17.172F210 Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by imf10.hostedemail.com (Postfix) with ESMTP id AF860C0004 for ; Thu, 13 Jun 2024 09:06:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UfWpOM+J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.52 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718269594; a=rsa-sha256; cv=none; b=0fCfTF7M19WDHNMeHSQn23mRrYci7FUcXd9THkJH2ciNSwfMHvNojw0gkWUxjPINOGnH2K kQF7AeEjp9MK0xhLdrav2Y+O1Jg20MlloRMH/QaxLgYArN4d8wLoeXKudDLR18qCxjIT9E yK7hEspYXmFnmASigSx5zV/qCKZYR+c= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UfWpOM+J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.52 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718269594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DNG7ptLAal/TClLlySTQH8fkHg8QY6bThTZHAf7rB8U=; b=cjcDUk52IQMBvgeRGX5SLAyBQgH1K+1auGRCcB6ZMGBdHHJ1fBsXzmz3qsX5tnCaLBjZ/R Osghb1laJTB3zpetjns4fmuE7Fzm3jcZXcc53/Dwt6p+zuAqQ9SunelgWq/8NCrYlbHkSr MV6Iei+UU1FM57QNoznWf50F8sBlqEM= Received: by mail-vs1-f52.google.com with SMTP id ada2fe7eead31-48c4a3d7930so307136137.0 for ; Thu, 13 Jun 2024 02:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718269595; x=1718874395; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DNG7ptLAal/TClLlySTQH8fkHg8QY6bThTZHAf7rB8U=; b=UfWpOM+Jk81vwufSzgzKt8v1zM9IYqBqvJLySBmU+eUUqURsbu/hkyfy2BVXrXCykN KsbT2LlOibSxK890OVoPQN6J0YX033Y0+vR1TyapsQxs6V1sOTwMuXC1DBEyB2cn1k+q fyoN6j9/zJpCv1id3xv31L6PMW8rCik1uK0R0YHzFIE/ruhgY4pFY84795B9//cxMyY+ 5l+6bH61oW35MWdhQ/4D6otQaPSDBT1/BuFXCVvf0UyujkvP8G6/UPIvLMkj08GuSILP AnS6d4xLIrsffQUaI5OiAkLZs9uuQpfmoL1aj861jdfQaS+87Yew+o6EY/Vb4gvqDzhq kiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718269595; x=1718874395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DNG7ptLAal/TClLlySTQH8fkHg8QY6bThTZHAf7rB8U=; b=oOpbwdE1QuOSD3UGSKkHDL4CHmwO0LejlX3uvKa+exRT4CsK1ek5/7dx5Iqz6BzXRG peMpNzGjLlH6RkTlxGbow1DFaoBuM7v6F6W5Q6+hvo21wl/gClDnYYQKeA+IcYlYT8BW qP8zMr4zzc1CnYk06hyul2yKiulumBY/aUbCgHlD0RVwHjEpmoQRhil1oJjhgqGvw78f 4Oy6ESa85ZzP2hezh445mNHh2xbB4m59s0zvFjGE6avPXxp6ooyHyCTSCBBVbMhBK9fp dJf/0KLkZqRulQ62G+3+TbNEXTbB8VBGh182ixDXcSyXxuMBBrpLTrwveTJujxyJ8nNW +EiA== X-Forwarded-Encrypted: i=1; AJvYcCUtb6YJ8YQzTIamZP3ZpfaxLMC1MMB5HvHF1EMvOyX3yVu0P9cyXJ1CA3ghk5yn2J6/M/S13GHBpLcHefxvnN0ochg= X-Gm-Message-State: AOJu0Yzdy3F78S7ykb6nLiRK5c2OR8orBb0kU0jFsJolY7Tu4sgJoN4d laIuXDnNgJw0MdUbsh1J1zlgm1Ux/bPXWE4IulIKLGXmnVlx5//J5QzhtaboNXte85wjtifhSJp HlOBCZ/uXHHO/9+3V6nubZZ/Sz0/CBLop X-Google-Smtp-Source: AGHT+IGUkb1yA0vr++rTLVJk2R+RG8H/J4P4Mh0tUIOr96GMGzduxXI49p0hQoIUjy03jE2EQwFR834uE+sWgiL/060= X-Received: by 2002:a67:f2d5:0:b0:48c:3d45:553f with SMTP id ada2fe7eead31-48d91e8313fmr4780629137.25.1718269594704; Thu, 13 Jun 2024 02:06:34 -0700 (PDT) MIME-Version: 1.0 References: <20240613000721.23093-1-21cnbao@gmail.com> <20240613000721.23093-4-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Thu, 13 Jun 2024 21:06:23 +1200 Message-ID: Subject: Re: [PATCH RFC 3/3] mm: remove folio_test_anon(folio)==false path in __folio_add_anon_rmap() To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, chrisl@kernel.org, linux-kernel@vger.kernel.org, mhocko@suse.com, ryan.roberts@arm.com, baolin.wang@linux.alibaba.com, yosryahmed@google.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AF860C0004 X-Stat-Signature: kecpxhra7q7c5ci1ijpn3uhy7qfe4qc8 X-Rspam-User: X-HE-Tag: 1718269595-835741 X-HE-Meta: U2FsdGVkX1/looZoQcSr4q09ll3m04HT8U7ut9bBy/zGDBHbOA4f9AYMJVnOwOIjNcj8Gta96ooUTtjn0psIbUFvC3mHjrcGztWMyNK25gGH+4NsoGiWd3fQgVYIWiK4FbGNf6MlyQo/fxMeizx+gsbSNPJvZGK/svA37t4nypTbRNDzwURNAvk1YZpsabPWjMml7rL25SZWDFKnGQ5t3Aza5qHZpTvt3p6WTZXMA3vd6LgXlBX/eh0ANvenG3r2mL8Vc895uUdYnygfsobth28h1mfKCzAKJhsN9p8vMVhUosrSb+gCmBJ7rqSP/kIFYCv/AFYNeZOvyrzzy/1dEMpyrz853u4r5X0RLiORIdhn/d5NPmfm32sFHxj6wMMrMTN1kf8Gz+UOwZOAFnLe3uwlyf3nvbA5LWIoLSeDl76PvI2OfZ7ued34fSl5341jSBg1TEBpUtYayRaw4gkfJnb61P6s4yDZBbEPhhfhqgsIDTuhRqS8l+6riz+VQGt/1hkjVac8eQrJWyOXIMwHTtqaO/4lEuQt9GkDleopFcziNrb89dGGCdxA/fARhP2jvuGpetuP8tSBCvirkvPLDaWvf+QEUeOm4CsJ3qrAVBk6vT1W0zFhUeX4KC2azCpQY143qkZ/dTaU1QTtYufs8kdJ8NYdLWnBccJ0Zi3cl/iWLjSdtfT1VM8p03vhkWFAznya88xVgvsMDyjzrtXPYN8svLKNKAI1hoVtr+b836CzwerXdIgy6p0Ks2L4dlRkiiPeJa5m58389gX/9pAWRuTtZhDXGqKOpLURAljdpyvLUwmy9siI70rlVx0M+QCf2H+DcgkiaJP5kEPkqUot42OdsWiSxNjaXm8JkkTJCKtU/X/t36rfbSOXwlpllLVYXwqGErPIPthqQJL5cNFXf06QzwV2y3Ejpxh5/vjLxHqXmgcZhX1sQk4M3rmJ1vi1q7x/e3XoBZP5O67LHyG +LOc0t3j bCiWI7zZXUClXgXHKg3D0kJqVQ6s4wjws6/ozBOodij54gCj4380YdCIMuTWzDVUymCFc5XCJ50vE5Ia5Mgtk6fg2KWM3sABTx8xMUXNmsAffC6LCbAdWJnVMW9sNtwzVBdugMV558qxV+gkcd28+A2CFfYfqTTLPNfLHpQGiSbuM/zfkXRvrYH2ZM9AF99LXUGvK+hqN6LEjC1kdEokcx7VO0lEwjW4Y6MP9ZsGncyi7DwrxzxA0boIC4Va7OCxyjUKjqDK+8HNAo0wxI1gtw+AXI6MvZZ0kBd7i8oWSr1nLwUFD65EbfQarG6YhG8WHSwZz+MpGXk/bv4ug2WO1/vN5Nc/w3CQgaX6YzO+jXLHTDJqZsUiBB6rN4LMgsol/k6yMkdq2Zbff2wBjvVuj/0XFOnOKdlAlPMjGvhwm3DeG5dO+I6y3C533Nax6RjvQvtsM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 8:49=E2=80=AFPM David Hildenbrand wrote: > > On 13.06.24 10:46, Barry Song wrote: > > On Thu, Jun 13, 2024 at 12:08=E2=80=AFPM Barry Song <21cnbao@gmail.com>= wrote: > >> > >> From: Barry Song > >> > >> The folio_test_anon(folio)=3D=3Dfalse case within do_swap_page() has b= een > >> relocated to folio_add_new_anon_rmap(). Additionally, two other caller= s > >> consistently pass anonymous folios. > >> > >> stack 1: > >> remove_migration_pmd > >> -> folio_add_anon_rmap_pmd > >> -> __folio_add_anon_rmap > >> > >> stack 2: > >> __split_huge_pmd_locked > >> -> folio_add_anon_rmap_ptes > >> -> __folio_add_anon_rmap > >> > >> __folio_add_anon_rmap() only needs to handle the cases > >> folio_test_anon(folio)=3D=3Dtrue now. > > > > My team reported a case where swapoff() is calling > > folio_add_anon_rmap_pte *not* folio_add_anon_rmap_ptes > > with one new anon (!folio_test_anon(folio)). > > > > I will double check all folio_add_anon_rmap_pte() cases. > > Right, swapoff() path is a bit special (e.g., we don't do any kind of > batching on the swapoff() path). > > But we should never get a new large anon folio there, or could that now > happen? My team encountered the following issue while testing this RFC series on real hardware. Let me take a look to identify the problem. [ 261.214195][T11285] page:000000004cdd779e refcount:4 mapcount:1 mapping:00000000ba142c22 index:0x1 pfn:0x1b30a6 [ 261.214213][T11285] memcg:ffffff8003678000 [ 261.214217][T11285] aops:swap_aops [ 261.214233][T11285] flags: 0x2000000000081009(locked|uptodate|owner_priv_1|swapbacked|zone=3D1|kasanta= g=3D0x0) [ 261.214241][T11285] page_type: 0x0() [ 261.214246][T11285] raw: 2000000000081009 0000000000000000 dead000000000122 0000000000000000 [ 261.214251][T11285] raw: 0000000000000001 00000000000d84b3 0000000400000000 ffffff8003678000 [ 261.214254][T11285] page dumped because: VM_WARN_ON_FOLIO(!folio_test_anon(folio)) [ 261.214257][T11285] page_owner tracks the page as allocated [ 261.214260][T11285] page last allocated via order 0, migratetype Movable, gfp_mask 0x2140cca(GFP_HIGHUSER_MOVABLE|__GFP_COMP), pid 11285, tgid 11285 (swapoff), ts 261214177545, free_ts 261151875699 [ 261.214268][T11285] post_alloc_hook+0x1b8/0x1c0 [ 261.214284][T11285] prep_new_page+0x28/0x13c [ 261.214291][T11285] get_page_from_freelist+0x198c/0x1aa4 [ 261.214298][T11285] __alloc_pages+0x15c/0x330 [ 261.214304][T11285] __folio_alloc+0x1c/0x4c [ 261.214310][T11285] __read_swap_cache_async+0xd8/0x48c [ 261.214320][T11285] swap_cluster_readahead+0x158/0x324 [ 261.214326][T11285] swapin_readahead+0x64/0x448 [ 261.214331][T11285] __arm64_sys_swapoff+0x6ec/0x14b0 [ 261.214337][T11285] invoke_syscall+0x58/0x114 [ 261.214353][T11285] el0_svc_common+0xac/0xe0 [ 261.214360][T11285] do_el0_svc+0x1c/0x28 [ 261.214366][T11285] el0_svc+0x38/0x68 [ 261.214372][T11285] el0t_64_sync_handler+0x68/0xbc [ 261.214376][T11285] el0t_64_sync+0x1a8/0x1ac [ 261.214381][T11285] page last free pid 90 tgid 90 stack trace: [ 261.214386][T11285] free_unref_page_prepare+0x338/0x374 [ 261.214395][T11285] free_unref_page_list+0x84/0x378 [ 261.214400][T11285] shrink_folio_list+0x1234/0x13e4 [ 261.214409][T11285] evict_folios+0x1458/0x19b4 [ 261.214417][T11285] try_to_shrink_lruvec+0x1c8/0x264 [ 261.214422][T11285] shrink_one+0xa8/0x234 [ 261.214427][T11285] shrink_node+0xb38/0xde0 [ 261.214432][T11285] balance_pgdat+0x7a4/0xdb4 [ 261.214437][T11285] kswapd+0x290/0x4e4 [ 261.214442][T11285] kthread+0x114/0x1bc [ 261.214459][T11285] ret_from_fork+0x10/0x20 [ 261.214477][T11285] ------------[ cut here ]------------ [ 261.214480][T11285] WARNING: CPU: 3 PID: 11285 at mm/rmap.c:1305 folio_add_anon_rmap_ptes+0x2b4/0x330 [ 261.215403][T11285] pstate: 63400005 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=3D--) [ 261.215423][T11285] pc : folio_add_anon_rmap_ptes+0x2b4/0x330 [ 261.215428][T11285] lr : folio_add_anon_rmap_ptes+0x2b4/0x330 [ 261.215433][T11285] sp : ffffffc0a7dbbbf0 [ 261.215437][T11285] x29: ffffffc0a7dbbbf0 x28: ffffff8040860a08 x27: ffffff80db480000 [ 261.215445][T11285] x26: fffffffe04cc2980 x25: ffffff808f77f120 x24: 0000007b44941000 [ 261.215452][T11285] x23: 0000000000000001 x22: 0000000000000001 x21: fffffffe04cc2980 [ 261.215459][T11285] x20: ffffff80db480000 x19: fffffffe04cc2980 x18: ffffffed011dae80 [ 261.215465][T11285] x17: 0000000000000001 x16: ffffffffffffffff x15: 0000000000000004 [ 261.215471][T11285] x14: ffffff82fb73fac0 x13: 0000000000000003 x12: 0000000000000003 [ 261.215476][T11285] x11: 00000000fffeffff x10: c0000000fffeffff x9 : 0d46c0889b468e00 [ 261.215483][T11285] x8 : 0d46c0889b468e00 x7 : 545b5d3935343431 x6 : 322e31363220205b [ 261.215489][T11285] x5 : ffffffed013de407 x4 : ffffffed00698967 x3 : 0000000000000000 [ 261.215495][T11285] x2 : 0000000000000000 x1 : ffffffc0a7dbb8c0 x0 : ffffff8068c15c80 [ 261.215501][T11285] Call trace: [ 261.215504][T11285] folio_add_anon_rmap_ptes+0x2b4/0x330 [ 261.215509][T11285] __arm64_sys_swapoff+0x8cc/0x14b0 [ 261.215516][T11285] invoke_syscall+0x58/0x114 [ 261.215526][T11285] el0_svc_common+0xac/0xe0 [ 261.215532][T11285] do_el0_svc+0x1c/0x28 [ 261.215539][T11285] el0_svc+0x38/0x68 [ 261.215544][T11285] el0t_64_sync_handler+0x68/0xbc [ 261.215548][T11285] el0t_64_sync+0x1a8/0x1ac [ 261.215552][T11285] ---[ end trace 0000000000000000 ]--- > > -- > Cheers, > > David / dhildenb > Thanks Barry