From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B81C4345F for ; Thu, 18 Apr 2024 03:55:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16A026B007B; Wed, 17 Apr 2024 23:55:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11AED6B0082; Wed, 17 Apr 2024 23:55:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F24956B0083; Wed, 17 Apr 2024 23:55:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D399E6B007B for ; Wed, 17 Apr 2024 23:55:31 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7C9B51605A2 for ; Thu, 18 Apr 2024 03:55:31 +0000 (UTC) X-FDA: 82021288062.02.5FB2ED8 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf15.hostedemail.com (Postfix) with ESMTP id B79DCA001C for ; Thu, 18 Apr 2024 03:55:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JcPdghtk; spf=pass (imf15.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713412529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HSFVsf7yg9xeJZAC97zFjVf1GebGLbTu3LyPHnS2CXE=; b=ev5mMzrh1aRfFaArghWrvq7EltDVGlcUC6gbav105xi9ncTKHVJMJifk7TB2wUOakWHaYt Y6hRa88J9h2MOBPKySjTKbBoerqEX21Ld9Mt7t/NUjlxqS1du9Ec9C6UBm4NNaIsoDlfJx yp02XQNpkWqOVxNNXvzC7z51N6hsAC8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713412529; a=rsa-sha256; cv=none; b=L5Mrt1FwmAfP9lQ795OoTkE/CbSqxrNSCtDV1BUJvQ9v0U5crnXAawGAzj3X6gqTBEtbZ8 Ib4KdxqFrWtAh8YThVI6h3TqycZVXWq4pyVwEe7QUm13EbJoODCnCl2dkH9uktNH/AJdW6 mLT9F+nixSHIKcBfR9gyvOJED8q65H8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JcPdghtk; spf=pass (imf15.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4daa5d0afb5so114356e0c.0 for ; Wed, 17 Apr 2024 20:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713412529; x=1714017329; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HSFVsf7yg9xeJZAC97zFjVf1GebGLbTu3LyPHnS2CXE=; b=JcPdghtkZctLBRCUltXuLtazPOC1d4Db8Cb5D6WDE44JFKAfqf9kJ95MU8k9LES5Gt lGcdZao6w524MZBNy7ybBirjb+KkXToQ0C8ItofwcJW1zQkOI+YTsN/nXMIRO4HKtIxg WoRiM/W67rdTF9Ko3hAezNUaRqTJb6ewAzX3FVc4zgFRVlci+mu+8eYh3JmGWF06dOfk cYeP6ZXHm9tPCVldreKpkI2OD/nF4bJpCBdXQLkc/YhgYD9b1CxRmauyPRpUmMK5DUCg pZ4naQluS4XEkV0RWv9JwbFasG3WPMorzVzeUXGeeGc7tcL2MlqCCmM0wjV5LOdQ24Sz SAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713412529; x=1714017329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HSFVsf7yg9xeJZAC97zFjVf1GebGLbTu3LyPHnS2CXE=; b=MIxtStJTY2ianRN8VPWxzB85ZzEPbN2+cFxoV7xD1seEFJW03uTDfuGYgoUBghU3lw UmIP70X6qz6yK5wdiceDmbXpadf3iJsSA2vAjsn5tTXEdUKms61hiQa4AwiWIvRcz05I JXzd7O94F6KUPrIMoohaig76PvfRzysr171pVsI+yI+yo5TXFzfWLehUa6iyAX6rkyPC xi64WCPiKu8gSEo7Z5kmI41CAkzPdoFcWcvjZiw0uqp18dWmhv40AEf2Vyht2hmdxqxf VHkulFlNwsFf8ag6bpwQqjbTcXoODWXL7PUFY1pFYn7oN4fcrnIqSPIOLHWXclnwts2b 1zFg== X-Forwarded-Encrypted: i=1; AJvYcCVxMEmniwYIPIDOHklEhS20EeEC1qAr3dpANWBW9xBYF3J0WbV2vNDILKLbuiCryCJNp6Sl6FcNeFQxBdPwaiOBGCQ= X-Gm-Message-State: AOJu0YzjP9GJmeiJdCfT8b6OZSLXEEOniy1vJospAFlzHX8mAbCU4qxr HGngbpLeWJX13qvLtwgv1CnKeQrt6+qAoStyI82QS+zCR0WLCfV+k2pjbFVnpJU0cglbD0G4YmJ PIyrE4xMFPiQux1gpy3z/tEK/Ujs= X-Google-Smtp-Source: AGHT+IEy4zpzc+qCzIoclfV+YTK+u+KL4zMM2pjKTTvV0W79cUczjD9ffc8LsG38t8IzneZ8jhaIkLK3cc5hcpOIQf0= X-Received: by 2002:a05:6122:a0a:b0:4c9:b8a8:78d4 with SMTP id 10-20020a0561220a0a00b004c9b8a878d4mr1803881vkn.3.1713412528761; Wed, 17 Apr 2024 20:55:28 -0700 (PDT) MIME-Version: 1.0 References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-8-ryncsn@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Thu, 18 Apr 2024 15:55:17 +1200 Message-ID: Subject: Re: [PATCH 7/8] mm: drop page_index/page_file_offset and convert swap helpers to use folio To: Matthew Wilcox Cc: Kairui Song , linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B79DCA001C X-Stat-Signature: akyrojpzqk6gpf8i4gpca7pacuosybdz X-Rspam-User: X-HE-Tag: 1713412529-275122 X-HE-Meta: U2FsdGVkX19DxLIEeUeqQLcJxV7xjMbFGj1oDR7aWiTS71zerWZPyMgai6uQ2A2jmmlKu2uj2PbFY9nXr2kwxAZk4gpAG49sl5ITqCCFnPj/VtxHo6BePJa/qC037AMc8unNgy/uiol1keIQTyi3eGk3dB+WorIfEVk1NG79NLvWuv+koonKq+pjRza8LVkJCWTpp46P536WdOQOCwPpZNI7uBTAgsomSN0vHsusuZXbvo8Lcwhsgj+rTuyMfjdcZ9mB7les66fl7daNAT+YLIWy3sNizcLPx4SmtSBMDYaDGcnp13zkNpP6lL8QvJHkBY5MBGkDYbbtl+mwdkklQYxAvwisY5ZsVgtlr8mK6zfcI3czqXAxhmCKCPwJ98V8kC357EPVNvSB6Kq4Kq5joshCvUEF8YWFT/A68FShkepGtkL26/lZ8usUyZZvuiZ4wYKR2vwccJtnRBzQLbEwHUqhOAlLLMxqGhUAeaqKIPGDlc/APD8A1LVtH37FaxNY/+IAxR0Jbb2XX8Lld9UgzAZHWqUZ9DSmMMcMMCRHeRxA/BSF/Ao6HDR500x/6rj5ADNVhE/Ffbo7zEAWNxpljB0PGWaJ2/rUfda/U4dwgNauiDxBphJaNlNwK5ZIplH534Tg5sb+8NiqwuZMZxk0frUzsCh3B/7L6PsR3LupArDquhpYNPYAl99J9WmtTSzwLcKckoqMscAS9LDrjusQYxqxT+vXkKYO1/8CJGibvdQ8FRx50deKxFvmLgM1Pef0RtYQMtEIx9W/8EPJSPURHMIS9K2mTv8VwILSw7hhII+n1SRPuNa1psRBgVoaVMF8YoyGVE8ZPd04yJI09wLYO/3T1L9HEvXqD2bSQreKlVCPC+ZBKI+SmhM+MN7JTTVMm47NtKrsd/srugJ/cHkbSpBvGackYeYisQHyiMIOzRZYjy+TCEuTmQgvcUuJBdXXt6Mtma6VA2eb0KNr16G lxIdPvuk 7UFES2pUcjydlxr0HXtcWuwb5I/Nk6mx0hnGF8VfBaBOsFLTlgIU7GuFtuOusb7N7si4DIGaBQhiIojt0GrX5zfS6w7bLiH2IXdyZRC6gJnk1ZZodThpSXYdDv+VXhB3WLjdG+voET3RJCXHXMcWVq+GHmTxB6qt1YvTe3pPh9brHFZmNERzW6JBUiUH+wYLSGDv177RH+IxFlD3pHlYQXHNkYbjZMN229Idi6jqJI3+BPhCxC/rVRYmGnTfmcHzNYOff6oh9kD4PYZpuV/1gjI0+jruqMhISsg1pYqfKBEEO636PqEaY5aPBKG4m5UQR2r44imes7V7GQCVKlgBRViL2GJ2IZygdUhMB87FpuyMYPWyFMhLPyK/AfVN0Pt5K3I9fULSYgLp6orcya4u3j7f9nuDwD63eNTiNWDKpJTPsTDBCqAxQg06svM0bxLD38/18qfNHtUaEUt7Mv99qfUjHQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.013967, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 3:31=E2=80=AFPM Matthew Wilcox wrote: > > On Thu, Apr 18, 2024 at 01:55:28PM +1200, Barry Song wrote: > > I also find it rather odd that folio_file_page() is utilized for both > > swp and file. > > > > mm/memory.c <> > > page =3D folio_file_page(folio, swp_offset(entry)); > > mm/swap_state.c <> > > return folio_file_page(folio, swp_offset(entry)); > > mm/swapfile.c <> > > page =3D folio_file_page(folio, swp_offset(entry)); > > > > Do you believe it's worthwhile to tidy up? > > Why do you find it odd? What would you propose instead? i'd prefer something like folio_swap_page(folio, entry);