From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B0F9C3ABC3 for ; Thu, 8 May 2025 01:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 579D46B000A; Wed, 7 May 2025 21:05:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527886B0082; Wed, 7 May 2025 21:05:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EF666B0083; Wed, 7 May 2025 21:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 21F7D6B000A for ; Wed, 7 May 2025 21:05:43 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 81D351CC840 for ; Thu, 8 May 2025 01:05:43 +0000 (UTC) X-FDA: 83417948166.29.324BD35 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf20.hostedemail.com (Postfix) with ESMTP id 9DB751C0003 for ; Thu, 8 May 2025 01:05:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MK2DRozS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746666341; a=rsa-sha256; cv=none; b=0dhntIFAwDl4nIM24sZtlGu60z5VIGY5Yt3cZurycnq60Jg5YJCRSbdXgutDYUPcOD2Kos DZcbY3iX9ELbX1DPeqK2AQOtygGI8wnfB7//zzFqOpe3/xqf3sC/I3BbM+FkoemklaOCvV X7LN+xx9FLrv/rxjsxvv/4uWkCsOMMg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MK2DRozS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746666341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V20XewBqSgIlIIe+WN0AIsJRzTuePTfDjWltPUvkBBw=; b=l0gKtxRSUFnnaNMZ1icCOhKSMMd3NApK8tB7i6+JxAR1ExBn8N7cm2KxXt0VKAzBoHMJpD dUsjNOmfteooir3bglvoFRp4AuLbonTZDYp4wVhaOm6g4cberU3hk/m2wEzCdlavhq1790 RLgN0buquDo0nF27bAKFFao71wR47Ys= Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-4c301b1df82so370999137.0 for ; Wed, 07 May 2025 18:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746666341; x=1747271141; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V20XewBqSgIlIIe+WN0AIsJRzTuePTfDjWltPUvkBBw=; b=MK2DRozSo6Ex1Kpy47nK3r8qyPjVZHt1aKuRqUK8RPQyM4tGSuPghu/YpVydc0Vk5b f2Bi4ppxLDIg49xvveDzUm3hIMzqtGh2/dkLhym0/ztoIDeStB0Iq8skssbDTHa244Gw AsNDCmsXI2PNCGWSxTe+UJvXG+ek360PVpntVtCAn+tsR0Sw7O10H93VdlGqYtn6jw+f 2hWHzArH0qzAx40yRRrPt3dy2sK98pn8f+hycSdrWUkMJ+1HlaGMUIpWbQ4kqZYSpji4 XFy7c+IGs1S0dOKEdFfDIwdykNvMuMCrIP37bYAswvWNPd5TFByBuHT3LWgG7JpE7mYk yHAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746666341; x=1747271141; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V20XewBqSgIlIIe+WN0AIsJRzTuePTfDjWltPUvkBBw=; b=qcZ5UrvAenm91O2C2FIaPs8xdxBCeY9LsFygDc8gdfvmk7x9YQguFHVaYpm/jVvA9f zAoZztb+NcUE/5iugF55KOIb/5vfCufjUz7ZCj4HQB7oLl9/gRqlHTeCGnGhneLmkweJ ZCJ1e1vjRRKLr/DAxDmfGuuMimOxoC83/nZzVKlfatRqYsxT9kynunuXY9QL64MP4OtN yB4fFnqKg2IlDmWXEvauylGrO4/svkuZAWombiOXaJ7SmZ9mzlDLoEKTxAN1i7qDNzbB TrirFKBnwjQ1qKSXP5PCcwxaBBjhGI6JFqNCJTgKf+yoRb1NUNmXmfysAXf3R1tabsZL fDxw== X-Forwarded-Encrypted: i=1; AJvYcCX06kU+ZetdGhirnifaehsmiRfMAdtZOkTqFJ70CB1Nt739CuHghmseW27RNPdTd5dFTF+z3iItlg==@kvack.org X-Gm-Message-State: AOJu0YxzR1DjdoBdiFFIYHwbQ6/Mi0VkIIZTG3uhSw3ubV+tUG0KFkYc q6nFOLdgWJYS0CYzaiKI1PNeWbXafbJiG8yWwXp5+DOyxNduPPuoKJOSt3yYHMjGrLhZd0IMU+b WwTVbhFXrJ1fCO6SQm147t/CL2cE= X-Gm-Gg: ASbGncu8nn9ij2R0t44NueX0ugp9wcCnv8EEIzOVByRlLyYOQ8JNaqrBp7Lhhi0+f8g 4MawEYCgzeAdm5VptANL6YAFcoOzmvFC2cSK4VPLVWpnA2LXPpqiPSY0KbKgg1fFIZrWF/Nd1bO yiyXwVksGchhxBqRF5uOKR0A== X-Google-Smtp-Source: AGHT+IE7km9lmSTnSvKTjYLMV92hOJPH1egp7siyKPqBzv3WI9OzYiCidDJet77XUG0vq8DWl2IRaTBKlHCZOCCEGpo= X-Received: by 2002:a05:6102:1276:b0:4dd:b3cf:880 with SMTP id ada2fe7eead31-4ddb3cf1498mr106286137.16.1746666340565; Wed, 07 May 2025 18:05:40 -0700 (PDT) MIME-Version: 1.0 References: <20250507060256.78278-1-dev.jain@arm.com> <20250507060256.78278-2-dev.jain@arm.com> In-Reply-To: <20250507060256.78278-2-dev.jain@arm.com> From: Barry Song <21cnbao@gmail.com> Date: Thu, 8 May 2025 13:05:29 +1200 X-Gm-Features: ATxdqUE6npRZCUjSAVz0xnncNeF_TmidG1_jkgEPYgB9rZsFVjbgVIogY_crfUQ Message-ID: Subject: Re: [PATCH v2 1/2] mm: Call pointers to ptes as ptep To: Dev Jain Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, anshuman.khandual@arm.com, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hughd@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9DB751C0003 X-Stat-Signature: 7kerfqqdgnfss536cxdmu31z53qp4wre X-Rspam-User: X-HE-Tag: 1746666341-781631 X-HE-Meta: U2FsdGVkX19T/vM44831rxpyh6oM+0IvNUZzX1HbsNMGaier8KSrWI5eU3y/zwyqMCQA4N6rfqq55f0a1bv+pluNRW8HarQXzYCKqUp2nTHRpVv1Rck8nhOFpQQEZtAGTMpKuo8Zhmvc+F2IySJS4P7quE0cyCoBCEDfk8aU4iAUFjvUtf2nRJuzBMcZ3QPaWSj8/DLlUSA8YsS4y4KvUCkHZX3PAYWxwhuLJiteQhoiYg/+VakYI+ru8A1b+cYuJWbMKW8lR2iQnWtB++35C0a4hT7Kbzo1hZmwsR16QaFXzC6r9WhqMp3MjLX78eYNZb+PDQy3cRVrViglTYQuYe6eH9bugBcgKfyY8EOSSpx7tsThiF6zyXSpWyeb6rU61RJbF4GBEBPUV7Wm3eqJedLNRWrjgfbikLvVnMBtGhby2RIhPbol17osPi7t+Zr/YWfAhhI7ixt7GCnzgw2qjVzbogn1m3X0RWJjhSFG2yoshF6s2t9Xbm0REA9dhlBHzTvH91RBWqa8Ejo5YH0874hY0DER7MBMSFZoQ12dgAZYubc4MqPoy0rlnsaLrF1dp/W51rT/amCZDQerGOrojwLllbo1jNdLhfixKj/NzGkhdZNnmOoM5Mx575Qiwq2cn5kDYzuKpcLplklBa24+WPSmrvhpOgz/O0CR+Yw69XtbljYy6RNYzpyspCsDFHelJbv8pW2TOCpSDO27MPG2vR8wzpH80WqilBVj1In5o4ukW7/1QYp951DpDLqNGzavJfoRvmX4F6OxiuBqfuN4mTg9bc70bTDCGnW0u5kM3r2NvHaVbUmgDprOLRIIOloWk85yUWKSdmwuhzmx8yQHUMej2FipZbCQBzBoCRJzO/ddf8TsVVrjQxSfeEjAbCEDmyVAXsBLgG9JBaCMLR8SUfT/FyZ0lKiKezZ/nTgGLo1cWdYc5Rv8+g/YgaxMUec3lihETw2mP6YL5YhxanY I4TI9tl4 wDVBFAPKvEQgTtNX7dQQp1jVV8Yb/pPa/sogvdGnzcVtphgrPorlYnekazYaQ09ofsiR8QiUVexIL2eyy/jtvtfhRdakl/W5SYVvvcR6wxgsCdtVfi5Zpg7Ag+NLYwBZQcw2O1m5U9UiY+QHeAX0pgRM594Gw7gRFupci9AwKT+XImN7MqCcmLxDt9+I4pmhTipR/Hm9IhyYCCOurQK/1bd6prq9GQzb/T44WFmhqLXYTRzbsPPPe4QVXwUJIYi0b2l8qpKvx6w5BBa0d15pQ//GQ+XIYgIAr6MJef35/2DvLpUPwiZfknewxYmPS0CrhMOoQuM6lAQIfsr54E7MMXalCZ24SbR8IEd74YD8zxzXovnBL+2xcb+rXgqS2hylnsrSQ2oFC99O2rrGEnDe6LgQKzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 7, 2025 at 6:03=E2=80=AFPM Dev Jain wrote: > > Avoid confusion between pte_t* and pte_t data types by suffixing pointer > type variables with p. No functional change. > > Signed-off-by: Dev Jain Reviewed-by: Barry Song > --- > mm/mremap.c | 29 +++++++++++++++-------------- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/mm/mremap.c b/mm/mremap.c > index 7db9da609c84..0163e02e5aa8 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -176,7 +176,8 @@ static int move_ptes(struct pagetable_move_control *p= mc, > struct vm_area_struct *vma =3D pmc->old; > bool need_clear_uffd_wp =3D vma_has_uffd_without_event_remap(vma)= ; > struct mm_struct *mm =3D vma->vm_mm; > - pte_t *old_pte, *new_pte, pte; > + pte_t *old_ptep, *new_ptep; > + pte_t pte; > pmd_t dummy_pmdval; > spinlock_t *old_ptl, *new_ptl; > bool force_flush =3D false; > @@ -211,8 +212,8 @@ static int move_ptes(struct pagetable_move_control *p= mc, > * We don't have to worry about the ordering of src and dst > * pte locks because exclusive mmap_lock prevents deadlock. > */ > - old_pte =3D pte_offset_map_lock(mm, old_pmd, old_addr, &old_ptl); > - if (!old_pte) { > + old_ptep =3D pte_offset_map_lock(mm, old_pmd, old_addr, &old_ptl)= ; > + if (!old_ptep) { > err =3D -EAGAIN; > goto out; > } > @@ -223,10 +224,10 @@ static int move_ptes(struct pagetable_move_control = *pmc, > * mmap_lock, so this new_pte page is stable, so there is no need= to get > * pmdval and do pmd_same() check. > */ > - new_pte =3D pte_offset_map_rw_nolock(mm, new_pmd, new_addr, &dumm= y_pmdval, > + new_ptep =3D pte_offset_map_rw_nolock(mm, new_pmd, new_addr, &dum= my_pmdval, > &new_ptl); > - if (!new_pte) { > - pte_unmap_unlock(old_pte, old_ptl); > + if (!new_ptep) { > + pte_unmap_unlock(old_ptep, old_ptl); > err =3D -EAGAIN; > goto out; > } > @@ -235,12 +236,12 @@ static int move_ptes(struct pagetable_move_control = *pmc, > flush_tlb_batched_pending(vma->vm_mm); > arch_enter_lazy_mmu_mode(); > > - for (; old_addr < old_end; old_pte++, old_addr +=3D PAGE_SIZE, > - new_pte++, new_addr +=3D PAGE_SIZE) { > - if (pte_none(ptep_get(old_pte))) > + for (; old_addr < old_end; old_ptep++, old_addr +=3D PAGE_SIZE, > + new_ptep++, new_addr +=3D PAGE_SIZE) { > + if (pte_none(ptep_get(old_ptep))) > continue; > > - pte =3D ptep_get_and_clear(mm, old_addr, old_pte); > + pte =3D ptep_get_and_clear(mm, old_addr, old_ptep); > /* > * If we are remapping a valid PTE, make sure > * to flush TLB before we drop the PTL for the > @@ -258,7 +259,7 @@ static int move_ptes(struct pagetable_move_control *p= mc, > pte =3D move_soft_dirty_pte(pte); > > if (need_clear_uffd_wp && pte_marker_uffd_wp(pte)) > - pte_clear(mm, new_addr, new_pte); > + pte_clear(mm, new_addr, new_ptep); > else { > if (need_clear_uffd_wp) { > if (pte_present(pte)) > @@ -266,7 +267,7 @@ static int move_ptes(struct pagetable_move_control *p= mc, > else if (is_swap_pte(pte)) > pte =3D pte_swp_clear_uffd_wp(pte= ); > } > - set_pte_at(mm, new_addr, new_pte, pte); > + set_pte_at(mm, new_addr, new_ptep, pte); > } > } > > @@ -275,8 +276,8 @@ static int move_ptes(struct pagetable_move_control *p= mc, > flush_tlb_range(vma, old_end - len, old_end); > if (new_ptl !=3D old_ptl) > spin_unlock(new_ptl); > - pte_unmap(new_pte - 1); > - pte_unmap_unlock(old_pte - 1, old_ptl); > + pte_unmap(new_ptep - 1); > + pte_unmap_unlock(old_ptep - 1, old_ptl); > out: > if (pmc->need_rmap_locks) > drop_rmap_locks(vma); > -- > 2.30.2 >