From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835DEC27C53 for ; Sun, 16 Jun 2024 10:23:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C4D36B011F; Sun, 16 Jun 2024 06:23:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 675646B0120; Sun, 16 Jun 2024 06:23:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53C356B0123; Sun, 16 Jun 2024 06:23:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 35AC36B011F for ; Sun, 16 Jun 2024 06:23:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 88F5FC102F for ; Sun, 16 Jun 2024 10:23:32 +0000 (UTC) X-FDA: 82236365064.09.BB23368 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by imf20.hostedemail.com (Postfix) with ESMTP id CB82B1C0006 for ; Sun, 16 Jun 2024 10:23:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nrIJ/YrA"; spf=pass (imf20.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718533407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MSBxsPczZ+4pot3zvMVUtuvia7JJEO/t9QU4pSIhmLc=; b=dKi/uGYb1NyWGLkASEc4EaAOIPPwpkVt3E64BYPSux8XjCSjZdyoWdOQztKmSh8yleaXzr IqRpaU4hgV5nY65kr7937z5V8EPGMyyipmAcokVI3JoxoucEpwR2P+ayjigvOoaoY4XfST OFBK2E9l4scdTCU8G8lVGVeKx/lw8+c= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nrIJ/YrA"; spf=pass (imf20.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718533407; a=rsa-sha256; cv=none; b=mewrofhRv/9qh1slJ9+P8K9qFdJMGSrlcWTTKxiN6lH4ANjwj/tFd/TWP2tUdywXBW4auo 5utfyJUIqegBdZy3NwCuZnVkEv3VEJMTwlx2V67jhEVL6L22Oy3qC8KM255+SDG965wuua fpBBxPRxAOJ8M5kBCEod2Bv8jRI0FCQ= Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-4ed0b3c6a76so1011833e0c.1 for ; Sun, 16 Jun 2024 03:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718533410; x=1719138210; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MSBxsPczZ+4pot3zvMVUtuvia7JJEO/t9QU4pSIhmLc=; b=nrIJ/YrAccppM9OrdxJycqYDcQRbbH1LXSOoN3dTTybBR7dK0I+WMSGKdrInzXcv7U OmfTRu1Em9K9VdeC7JpnESEgR46I03pP1aqdrG/3y5wos1eZKMGn2oHJxIvgYkzMn7A/ t79cSmSjeBSbO/k9eMni1sLaVoaJSbBaiw18S8QMFKp8M/4/jIriNLZqFMMk7YVthtLO Eehh4qOEL8cpHH+82ffkiDdckWTeTJnvOha4jK8iPw8e6s6I+D5D7msFJSpC/+7rPjGS QegrIS6g4LfBeUHMUqvC0nMaKXrwtmQmXtYtEhaCKiG6du+/t42ZmYUFUFMsy+hi5ohZ v0aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718533410; x=1719138210; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MSBxsPczZ+4pot3zvMVUtuvia7JJEO/t9QU4pSIhmLc=; b=wUtHHXE2qm8dvP/rhV5R3XFLiHN05DJgsalPoKZcPXcAS10FkcVm6S6vB3GAdV3Ejd YKEirzv+4OTcku0JrW8eXoCpb0/ri+zKuNA6Vt6npWET3/jp3wMSrtr3xSUECQyTGZAS AO3v6dMBvIltFYPwj4NzGlfFkEYa7O9e/fKrCF3ilNsq0EBxCnWJEYHrtxNgDN85TqfF e9TN4NpKA50qj+q/PxBpC0L38lpLFtrCIxwEN42k3mAnt8J4BgRA1wlhYS9tPz42UAWT kUf8VpZT+CEgrkN+/+wiS//nDIviXU2GoiuHboggw6zoChM0IWC3lCB7RWKYU68oePq9 tkZA== X-Forwarded-Encrypted: i=1; AJvYcCWq/fRqfPRn+wOe5AaLQc1A6eDYV24Nrx4INvD908VvR07T9UxpPEX9N8a/yrZRp92eDK7/PAUlesuiL6KrFqfhDX8= X-Gm-Message-State: AOJu0Yw1QIkuwSllqaB/mbV6WddzqlDLE8KCJzI33vab8OvJvcgrvTVH jRObO3g5jbyjg6X58fAv4PE34Pg0UVa4XcC1bokO7HRsbhwUmu1QYo1LbeasYWgbHxHvVvvdomw plRP1SX0juiT/ghE5geV8+skB3O4= X-Google-Smtp-Source: AGHT+IEEl4jPkQqUM+tuvbj8jM0PJmlDwSYA0hEp4W8mWisa+3eruCF0wyklnGyyisWLVfbaOiXpgiyXYE5YuXsglc0= X-Received: by 2002:a05:6122:20a5:b0:4eb:5d5b:a894 with SMTP id 71dfb90a1353d-4ee3e291ec4mr6496762e0c.6.1718533409829; Sun, 16 Jun 2024 03:23:29 -0700 (PDT) MIME-Version: 1.0 References: <20240614100329.1203579-1-hch@lst.de> <20240614100329.1203579-2-hch@lst.de> <20240614112148.cd1961e84b736060c54bdf26@linux-foundation.org> <20240616085436.GA28058@lst.de> In-Reply-To: <20240616085436.GA28058@lst.de> From: Barry Song <21cnbao@gmail.com> Date: Sun, 16 Jun 2024 18:23:16 +0800 Message-ID: Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap To: Christoph Hellwig Cc: Andrew Morton , Trond Myklebust , Anna Schumaker , Steve French , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, Barry Song , Ryan Roberts Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: jx8f4eqjz58pp9fbrbxp3psm1gm6r9qz X-Rspam-User: X-Rspamd-Queue-Id: CB82B1C0006 X-Rspamd-Server: rspam02 X-HE-Tag: 1718533410-90860 X-HE-Meta: U2FsdGVkX18vZgO8gXj04vsEhhrpykc43pSJanBtn5+IkgrdhLoMBatbDnFZX7/e8o3lsOCG+xWbPp5hBJvsWk3eA8B7E2v0zUQlj92VhA2tzrq/tq5LvJRWIf3cXdNJ2QQvHdba/Kd5WRA0r6GJz24bzpitKSBjjxwW5ZrZXG3QoBgfAGrixCBmZdrtmqD8svzeVTn0kquxY1I6F5l0CCE8nOOCEDVWXskpY2VfzjppKY8+YNY+AN2d4y9K+BBJm2/XD42nbFAMvLDDEBWXNjIfDtduWcYgFrJ09QiQktSi2X0KWxnKu04gMEZ7332zj6CC5r0ygJBy8ydcnnuFpY6dypsyjeL3YtAZD5L2o8EMeUlLSbZJKHaWr7/4RQkThUvbVQPCOUzyTenhQxL5FFKNSWZuT2ECoumjfBJ7VEEdLYcvPHTGwTo4mH9cI0T/JXE6+OBXpLG2zbaDLbrdXMQnPZJstqIvUE4stxD2cfsddy+3lbPiTr/NQZ1Ryxc5fBL543SnTForqNvubkVfsPnGi/xW6fUNTmisW7dmEZdI51CMMsl1GkKwKcq2kz1PawG1rfExj6xfv8no1chiuOeGI+rXs9vtqTzERW1CGLj9f3CzmXgdheDSqCU9lENfIqV6WLCrMd+UQX/t/xPqvewRt3XvZgLdad9Qzqup1CRB19I6kfUlzx2apfMGa+7duBVJg0jFwZeGefwRYM69nIdYYWNLPavV3VMIvwEi+36Fc8/uWfHYTpC3u3eZdX9lkcD8j/HAcPytpvVDQv4xxI11aqO1rdtd1domCZhCgAHFYIt3289q107HodYGkidv+3uUG+LdKGX8jwc8mxywd99NPQ7K/tDqmc6peN+BtzTF86iQL86AP/am59KCpLjvPTIV4lMhpx270ju/6aQL5PPnliRCURuZpJ47PsGBS5ZGI8nDS157/BiIT5vy8cr9zbKvE3HeBxKgBrOYBka J7Ff17ss KqZni7+lSqEWz7GKygTO9Y/bjgTQbhgppLTRqKUuaxYke05E/TtI7wQFZ69RaANbLRaRRI3EMqw61nR2yTYgNfcz+GC1LvraiUV9/TQMoEWFysFHwdHopTOaOKw4KIin4gxWTNSn/4vP8vgV4LdaHNMFmVfca5Zr94wbIO+ObrmRaVzafaeOkuym5ZCUxEUmC7srTnxuS6hdSoOHkEWrOkzTx69F3jmw2GBjAfp1HWWhL9qeaDnozncumLih9AlH7NSKes4VvJ+WNKFojoVkRKb17XWOMd3oE4yQMzpDdLbW6FPtRp2F0sd6IZ1w/hkuZu1/y72DEyX5WNZxzlH6ETMEatX2J2uSQZf527ivqjxpyuZ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 16, 2024 at 4:54=E2=80=AFPM Christoph Hellwig wrot= e: > > On Sun, Jun 16, 2024 at 12:16:10PM +1200, Barry Song wrote: > > As I understand it, this isn't happening because we don't support > > mTHP swapping out to a swapfile, whether it's on NFS or any > > other filesystem. > > It does happen. The reason why I sent this patch is becaue I observed > the BUG_ON trigger on a trivial swap generation workload (usemem.c from > xfstests). This is quite unusual. Could you share your setup and backtrace? I'd like to reproduce the issue, as the mm code only supports mTHP swapout on block devices. What is your swap device or swap file? Additionally, on what kind of filesystem is the executable file built from usemem.c located? >