From: Barry Song <21cnbao@gmail.com>
To: Zhang Peng <zippermonkey@icloud.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Kairui Song <kasong@tencent.com>,
Zhang Peng <bruzzhang@tencent.com>
Subject: Re: [PATCH v3 1/5] mm/vmscan: track reclaimed pages in reclaim_stat
Date: Sat, 11 Apr 2026 07:58:52 +0800 [thread overview]
Message-ID: <CAGsJ_4ytrMg6mBKXNky=jcuKF4KFpwZbCFnFin-7S2XoP93yfQ@mail.gmail.com> (raw)
In-Reply-To: <20260410-batch-tlb-flush-v3-1-ff0b9d3a351a@icloud.com>
On Fri, Apr 10, 2026 at 9:04 PM Zhang Peng <zippermonkey@icloud.com> wrote:
>
> From: Zhang Peng <bruzzhang@tencent.com>
>
> shrink_folio_list() returns nr_reclaimed while all other statistics are
> reported via reclaim_stat. Add nr_reclaimed to reclaim_stat and change
> the function to void for a consistent interface.
My gut feeling is that the existing code is better.
There’s no need to enforce consistency across all cases,
since the function can only return a single value rather
than a structured set of statistics. It is also clear that
it returns the number of reclaimed pages.
Best Regards
Barry
next prev parent reply other threads:[~2026-04-10 23:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 12:43 [PATCH v3 0/5] mm: batch TLB flushing for dirty folios in vmscan Zhang Peng
2026-04-10 12:43 ` [PATCH v3 1/5] mm/vmscan: track reclaimed pages in reclaim_stat Zhang Peng
2026-04-10 23:58 ` Barry Song [this message]
2026-04-10 12:44 ` [PATCH v3 2/5] mm/vmscan: extract folio activation into folio_active_bounce() Zhang Peng
2026-04-11 0:02 ` Barry Song
2026-04-10 12:44 ` [PATCH v3 3/5] mm/vmscan: extract folio_free() and pageout_one() Zhang Peng
2026-04-11 0:24 ` Barry Song
2026-04-10 12:44 ` [PATCH v3 4/5] mm/vmscan: extract folio unmap logic into folio_try_unmap() Zhang Peng
2026-04-11 0:31 ` Barry Song
2026-04-10 12:44 ` [PATCH v3 5/5] mm/vmscan: flush TLB for every 31 folios evictions Zhang Peng
2026-04-11 0:34 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGsJ_4ytrMg6mBKXNky=jcuKF4KFpwZbCFnFin-7S2XoP93yfQ@mail.gmail.com' \
--to=21cnbao@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=bruzzhang@tencent.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
--cc=zippermonkey@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox