From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5B8C27C53 for ; Wed, 19 Jun 2024 05:34:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9ED56B03E2; Wed, 19 Jun 2024 01:34:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D01316B03E3; Wed, 19 Jun 2024 01:34:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B54186B03E4; Wed, 19 Jun 2024 01:34:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 836856B03E2 for ; Wed, 19 Jun 2024 01:34:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ED09F80813 for ; Wed, 19 Jun 2024 05:34:41 +0000 (UTC) X-FDA: 82246523562.02.DE01E79 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf14.hostedemail.com (Postfix) with ESMTP id 41DE2100002 for ; Wed, 19 Jun 2024 05:34:40 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nAh3Ativ; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718775276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+x8K8+jvDeyavKrJ3TJNFrLayuAVvxFB/ZRzxaqejPk=; b=I0IrKYRjOZCcLroVZ1putHl8WAIV2FycyUdeN0OYP3ZyKwbFPY2G5rR9qeEbeMHNgISQdw 90Q6zcM8LnRSWGvgb03zG7KiecRwrJ/hGvHsdRxNvzveg7rACNZHuzyPDsAjQWhbEMssNL SiaPjQcCqcfjB228Lry96KW9j7IZAw4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nAh3Ativ; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718775276; a=rsa-sha256; cv=none; b=SfM+eUEMZPXsyL6IAotzp4QEydxjN71ttun5csqEO98aYijdtPTzs7vRJny2SvRST8bNPX LN10DQ+y1V9Bn6R9bQBIykOVVrQMMkz53GjsBbqN6Nkqr0wUggCFCp+6Dv0ki20DQX8iMG j4xVc7SNjl+p5gMlncuYoazeyKzr4/Y= Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-4ecf4100d9dso285332e0c.1 for ; Tue, 18 Jun 2024 22:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718775279; x=1719380079; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+x8K8+jvDeyavKrJ3TJNFrLayuAVvxFB/ZRzxaqejPk=; b=nAh3AtivbwETk+XiMV3xGUOR7y4baXBGekO64AXbZY/Q8nbPRKIVNRTeJuadWejAs4 8RUgCROSJIS2Vu27O9mZwhYpS+egq0kdoH9W1uZsDKSbcsz6IeNwjiI+tMfrjTKgq5BK n0DTwAxMfxLo+/KX9SsENMx+4YktN3Jb3DvuHYzA2ukBTif2CsZvrOz2FeTQOo0Hwluv 4kaBYXK0hIWG1yuUtUnw/qaTIiP38iIoEKkKAEeVcj7fZfEWDiXP2jSbBl/9TIHFTtBU /aALngqaXgox1282xl4d0enFx+wfAqFSATNk2j554lbGj0C3Cqv34q3UyNyxiB2dVduT BthA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718775279; x=1719380079; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+x8K8+jvDeyavKrJ3TJNFrLayuAVvxFB/ZRzxaqejPk=; b=a9e2XmoGM1WH31veGNGtTKWonsKL76EpK0JtwIn769f8QEGgn/0ERBM0jHrAflPBmG 6GwW3XKgWTBFGDNDudttZ4Ba61cW7iNpYSXbIaM6om4eR2HLksyKgHi9X6N7XMFadrnI V13Fx4rM/h7p8AmHsq+8HolkRpfDKaZsipW7oT2RUJqmk/hHXT57xsOZpivrCbfPQofp nJHOvROu5SGNO/wMNygJmPB1i3uSDWYrA95T9kQ4vF/9IG/CU5aPEjCAoToah68NerBR +LZpILR2HtyaYj4m3XHAAeP5XIY4Xj3f7xd1o5lyaERFWUAyI5+KRYPCXyGgfPAOUIYw SLkg== X-Gm-Message-State: AOJu0Yya9n9tvipkFvUOpx4m33OljmQqgFytu8S1cfzMdRsnZ/s/sUUE Ut1Vm/Sk2x5uY+Yoe6HcrYs10IEL8/i8k+WE0iKajEHmxckOHxkQ4p/A+/zWb8DRKLGRfcTtPmT +zhl/qmKPe5z8NdWEhbZhMbyWwbM= X-Google-Smtp-Source: AGHT+IEqTCVFaF3Qw5cbwz5Gug/v23/DYwJI/kOp2bT/pFC7Ukb+UHmO01zJBypiA4srCgLBjMcc1vytH+VF64qDXrU= X-Received: by 2002:a05:6122:3124:b0:4ec:f3b4:6283 with SMTP id 71dfb90a1353d-4ef277bedbdmr1929947e0c.6.1718775279172; Tue, 18 Jun 2024 22:34:39 -0700 (PDT) MIME-Version: 1.0 References: <20240618065647.21791-1-21cnbao@gmail.com> <20240619052740.GA29159@lst.de> In-Reply-To: <20240619052740.GA29159@lst.de> From: Barry Song <21cnbao@gmail.com> Date: Wed, 19 Jun 2024 17:34:27 +1200 Message-ID: Subject: Re: [PATCH v2] nfs: drop the incorrect assertion in nfs_swap_rw() To: Christoph Hellwig , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-nfs@vger.kernel.org, anna@kernel.org, chrisl@kernel.org, hanchuanhua@oppo.com, jlayton@kernel.org, linux-cifs@vger.kernel.org, neilb@suse.de, ryan.roberts@arm.com, sfrench@samba.org, stable@vger.kernel.org, trondmy@kernel.org, v-songbaohua@oppo.com, ying.huang@intel.com, Matthew Wilcox , Martin Wege Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 41DE2100002 X-Stat-Signature: zukgkb7gfpn4msam4ahio44rcimymefh X-HE-Tag: 1718775280-963079 X-HE-Meta: U2FsdGVkX18HmrYeIhWss/VR05YLqtJDbYFKoQJBjCadG5obHl0PpIHhQF7mOkK7hEutMfwlaiSNyxX8Duw5Jjgom/8eeUE3HlBKA5SRhrmuBpP/oc++pV2j9dqEvWT/hS6WXYodTnjU6O7i4uEGTxelo8MSM4wI1SW2g3Y91PFFZbfW/5sbaOVYLdszXG+F3Bg6hEcPAd9j4V0igw6jqx7YjZ1C/1N6dX+6u7FVroBYZiPyDEtyxB7fjut+qCBd3QfPUq87pKCV7p7y4+20TFW4jPPCnHpYv01PAseYPx6UcYlDs6m75hcHSeleS1grptXAoK5Kgb4LM7wabFo0lUHgbcWgKy05coqe6j/mFW0pY7CwlQvUNcOGI5ZJNVlowmY9PULQU5nZapKBi09G2O+l0FeyDi8ymceIxoMxGV4cVJwC/iqMn+RPvKm0BD41iMdvmkihoRHR9e/yajTpoiiPt58q5XRuruFZxrwp8dL564JdFdH/VMoEnuj83cWT55mBlgcPq6qcRiDrBveD6WLYIa0nsetJ7J0+Ji0ez6gEp98ECIa3Corn9sHJFfG4MeUGWmMscxx5G2QMGpX4S1CNxfvAASnloBxO3v6/KUq0sWx6c2dguTFn16RYzfH/K6bGMdiwCfysQJ4QMR8dcY8Epgh/rKrYRO+tMipiS2gOI+/ft4M5JMhamm9arXQfD3LOe67wlpdDScpL2bBLrwi+UomBfS8dgOwo6lcs65Itu2ljNpN5nOFjQlE+ZIA2gsajwxuCGz6kycADEEMLjsYvEIEX4D7Dg7FuZmQTeAhQ+EBY/mk3tsFpKbZZp4EC5wKejW6TNCz4W2WOj6WjIjX/VHdLd3MyRjpiEp3iFKO5sYrhdDiegdiYZpcEElMuOT0cPaHcWmtNr/2PPsVnWL3oA0s/syb0rmdCcwzcEsGMjXhDsnUuaLTB/K+JWjTsnkPSyFftEzzbLair8Qe FDTLX26h IIFfy0NX2qMdcjFk5CpPUdJu2zYkbP4sB4K0eFQL94YKMcm9QbGP702MHbcsGuKNh1BBePSDkVWXTe7rBVf1ewFMHv15Ax55xpcGHThhrr9wL5paI+Adx9iRzvbAhu8wRMEE9SHuNBSuMTsPm9gBAQI5S3AXMJyLXosACgDRlCDNDgbmTxwJm8iruoRD9izntwZQe9XZXUmZY3siOlTDNCZtAM/vZHUQoCpGnLI7FOAafXkZGG26uH3/5QL5w3tSGrJQPvI3KcRLEzSyZCN4eSTTZ8OwfSeFMj8qVxFRDVpygqfEwq2qxmCF6um89UgcljDuHzQzHrCCytIHK/9k/G+RhxGqbldeyKznn38YhqbqYpwtV1jhW9tbOlJZF3q5/TkKlz3LeUoS/9IYRNZPKVMWEQNpEaYqIuSMm X-Bogosity: Ham, tests=bogofilter, spamicity=0.001630, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 5:27=E2=80=AFPM Christoph Hellwig wrot= e: > > On Tue, Jun 18, 2024 at 06:56:47PM +1200, Barry Song wrote: > > Fixes: 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS swap-sp= ace") > > Reported-by: Christoph Hellwig > > > Signed-off-by: Christoph Hellwig > > A reported-by for the credited patch author doesn't make sense. Andrew, could you help remove the "reported-by" in the commit log? Alternatively, would you prefer that I send a v3 to drop the "reported-by"? >