From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D0AE68944 for ; Thu, 31 Oct 2024 08:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E57216B00A6; Thu, 31 Oct 2024 04:21:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E09006B00A7; Thu, 31 Oct 2024 04:21:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF6E96B00A8; Thu, 31 Oct 2024 04:21:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AE9046B00A6 for ; Thu, 31 Oct 2024 04:21:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5E3501213CF for ; Thu, 31 Oct 2024 08:21:38 +0000 (UTC) X-FDA: 82733202720.12.D0E3289 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by imf07.hostedemail.com (Postfix) with ESMTP id 4B27340008 for ; Thu, 31 Oct 2024 08:20:59 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PumLHvh/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730362840; a=rsa-sha256; cv=none; b=JfMVEARIhh3LSoqzNY+9Wwj+6fgh1P1wIkRvr/UK2Z1YVzu9MY+fxLuzFVPSca6Y3NiwxI D/9PHEurcj5KQABJoZVcMoyqUPoJAZ+eqd1e9KWZ85729PDsoCp7IGzD+fiYzp+62YKuwB MSuSR58bhnrFwj/g91WdTxMK78d9z6I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PumLHvh/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730362840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wDCd5xrXH973PgUiiNflQUyEcb5wHDWnzkZRvUd+oi8=; b=MvW9RLNg5bCnoEdkAqgTIYBiB1C+IJWU4lDEwe1mjspVTCEg47OjVccSAg6/wiPUe+Dcfb ylRXn7AXlvcjOeOgTtrDtt8IadDqlVJ36se++ijcTPSb0f1JXwOAuuj0OyHGI49EIHDWBL U7+4LfCluSTiH/l9tgDTOqN8DeBu9VI= Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-50d58e5bfd2so215884e0c.2 for ; Thu, 31 Oct 2024 01:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730362895; x=1730967695; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wDCd5xrXH973PgUiiNflQUyEcb5wHDWnzkZRvUd+oi8=; b=PumLHvh/2y9eSE3f7zN+4ucRbZHzi5J63TIg2cQprCbz4y5aF2V8qWP0BSc1uwhFn8 NFLYarzxUrFo2UKjqkSPXXruBQ7jaRVw+nXYPPtFZNo4x7T0iTmDAq02w5AKJyKXN3/n QVBDEIMGTmhOGiDzZ1rEGg2/c9wSnFK6BZBO+b9+GS9fpwMcWQ2p6kSSJa2aeB184m95 m+h+M3QayLz5Z8E3if7uOZ1dLwIoOICqIVWAcR64kbGmfWP3mITvXSismZAHIvAFNkON a+U8t2DR9yUN/KFGVrLluLpx0xMZaNbqsU7I6tzhCzv+U97BzAdWEo9NQDk9y+ihhTRs HsZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730362895; x=1730967695; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wDCd5xrXH973PgUiiNflQUyEcb5wHDWnzkZRvUd+oi8=; b=PNeW4Z0kVuUA7MERUKkV3pV0fTmqfBabDjK1BtT+7+Tf+UYht8zn6+AM8534ulmoeq yr65e7d2I8CfZHvUrTgPbB5XqrzC1qNh3r7FsGNzedcYZNqC8rie02wxvaEs5yfEUkGl Ue+wGEhp8ZIAKnCpcmRshNDjP4wBcll9xoIiNC3rmuEcdWFJq7vEP6i429OojHUmckFv eQQkoVi6X3/1UMjouTjtmWI/lIufYj7Ft8ErPZeZBws4pIBcsHNUxRqDwtIp+xN6noeQ fiFvrxxwyJoEbGuVLkFkoXmve3P0WxYC6Qk1x4GXFunBTdNWIRXrZ65So4SqYd/ND3be VI7g== X-Forwarded-Encrypted: i=1; AJvYcCWYCQBg/pyvTfLnEVXYO4kdNeuyDTXPwmy1HuBnaov14nc356O/u4H1WS/XjbazX3Y6abqU1DvdYg==@kvack.org X-Gm-Message-State: AOJu0Ywj7CmBs+/Nprg0p9yIj8XLgeDJf5DpAHvKtbbf7SNDHtZgfTE/ DOURNDd9JohmVpWfdp3IMnhp0whnibCxO4/iNLpiTaThnU7vWK2ZTHzuWjOGBeZ05E6hUQQAiDj +JFzBLsYrygd1cgUS3PXvkzwbxeQ= X-Google-Smtp-Source: AGHT+IEn7Nd7ktAUrffEigFShW9caWs2hR3+bx+Dz4T79PlwM4rCw499HvHwxgNBR3sCJohjZn8lLZsE2VH4HLp8zOE= X-Received: by 2002:a05:6122:8003:b0:4fc:e3c2:2c71 with SMTP id 71dfb90a1353d-51014ff7a65mr14179081e0c.2.1730362895459; Thu, 31 Oct 2024 01:21:35 -0700 (PDT) MIME-Version: 1.0 References: <20241031075325.1037-1-21cnbao@gmail.com> <874j4sae8y.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <874j4sae8y.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Barry Song <21cnbao@gmail.com> Date: Thu, 31 Oct 2024 21:21:24 +1300 Message-ID: Subject: Re: [PATCH v3] mm: add per-order mTHP swpin counters To: "Huang, Ying" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Baolin Wang , David Hildenbrand , Chris Li , Yosry Ahmed , Kairui Song , Ryan Roberts , Kanchana P Sridhar , Usama Arif Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 4B27340008 X-Rspamd-Server: rspam11 X-Stat-Signature: i4x6u818bkoaob3rikw51wgnb71yoht8 X-HE-Tag: 1730362859-810736 X-HE-Meta: U2FsdGVkX187kRGA64ux/sgiZwXpWTgSvO3zoTdbXyQe+dfC3Hi+NYLI1zycw91MPekcjp8IvW5L1PWx6toL0zUZMyAOIPRaC6+xu1wY2U/7QfEMkcDl9EVsAofak4VYu729KM7d5DQw2Se6wfnuDaVbHHfBckWKxdtmyaJrExYll3x7OeA/VSZsCHcOI6OUe3dbQF5UxvcN4sR0EmEWzPVhDeh0owWNOxQVJgDy8ZnoVZ5V2ubmAMc3ElTABGGaRkdP7XsDUCqYXfJH2i1qqPh5KiIXh7Gd2AYm2vAbR9scYBjwIiFeM+Wr7HmuNPxnb6FgcQkm+BynWL3tNX1XB6tCgmVz78SGemkki6quDSJ4ucYBBXJC0g7EKh6m+apj65AuMDJYSUTGYcze1ZFeMufR0bvcW2RN9cq77PqCPfjzwVeIpkaJleOaOYOqa36Msixs1DJaS+C0Ju/9uIzXhYRjuDbz8SOM4N0sXc8A5JDhj7HQOLI6MxxfrUHP+VjApsqYtEgFUdcMjQ0Vy+LfzruilGOY+B9s9dRlWQ7oQpz9JkZde40PB3e5cb12Qukhg1gsv01Cb9vLEQGyYHJVUxCUd1GtmxSm2MBF+f2t2JHMroo9cmwp3u+tN7hYfVsMiaMNZyjSW7sXKeb2FDIAGAs6MxiVsa44UNxjCoc8V2xKg2Ao+f4JehnCBEejnJ9stt6aJDKi0i/5CBPuhqdhNut/5vN7452yp/4px/1k65sD4+ENMyqyCE16NQWgOmSyEtipqI7w83N8guXEnL7qPr/Cj6bLnFehYa43jz1Y3FGnPYdpWwFfhq+awOr3KfuJI220G1FOQ1tkPab4nTOxFILjdL/LLZOvuHYxGoOl9CeQkmXYsQsJQa3Hk34RH72KVF0r7FS2o4iC5uWDcBVI6k8roS9lTH4qwsAz8kL7cE817eNL4LyOJHH7Bx0/Tf6ALPRK5vPu8kcuNDut4SJ CqoWE6EQ LotOgz0od41dmk60r3qqXoLF3s4eSKQ3m7Dn0f+h0kc4dVAjPrV6t7wVZ86dO0d9/HIa5nDyuXb5KWOEyszyFXWxwOTzYftpSI7upHvgoUL+AtV+wP0KpCJ1xz0Yywe1Na/HmXblb1s5iP/9ULwlop3bQFek/NQy0HB6BaafBnse+euv14HUoQiRw8DJGMoRUkd92NzYhoJoVb9CGqvQirXbumP7uGVpd6hBJ6R2gapjkwrBr3wdv/TOuS9NYLRinW9runSV++1RTWeqRi1E0Fm4bqfUoTP6xjtM66/x/84XkcfW8II7DD/TBLK1Llu9i/SXlkjIulpjDUtX9YTwWCSbabo6zS8J4O7ZHsV9q3v8167iGUxLCdRtgSL8keTI8xLatHhpJll67V22Gk/faleUJK8A71fO82PLTjBESuCodnz4moOLAOyh7k2DQyP1CEc1jvhAEHSTIJ2TT5DbVuSSifzwhX7klGyBYv9e8xZ2+C7S12mW7BGghT0OO45m42iDi5bUi7lo2erBupYShJ5XO2z4FIDaph3EWUrLR3ss+u2aCmJVI+m1CnsFFarZ12a3oZJSxWcxSdzdP1MQNnsWkw9xqAvCn7M5V0oCfUBfZEtBgnPwV+2VQeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 9:09=E2=80=AFPM Huang, Ying = wrote: > > Barry Song <21cnbao@gmail.com> writes: > > > From: Barry Song > > > > This helps profile the sizes of folios being swapped in. Currently, > > only mTHP swap-out is being counted. > > The new interface can be found at: > > /sys/kernel/mm/transparent_hugepage/hugepages-/stats/swpin > > For example, > > $ cat /sys/kernel/mm/transparent_hugepage/hugepages-64kB/stats/swpin > > 12809 > > $ cat /sys/kernel/mm/transparent_hugepage/hugepages-32kB/stats/swpin > > 4763 > > > > Signed-off-by: Barry Song > > Reviewed-by: Baolin Wang > > Acked-by: David Hildenbrand > > Cc: Chris Li > > Cc: Yosry Ahmed > > Cc: "Huang, Ying" > > Cc: Kairui Song > > Cc: Ryan Roberts > > Cc: Kanchana P Sridhar > > Cc: Usama Arif > > --- > > -v3: minor refine changelog per Huang, Ying. thanks! > > > > Documentation/admin-guide/mm/transhuge.rst | 4 ++++ > > include/linux/huge_mm.h | 1 + > > mm/huge_memory.c | 3 +++ > > mm/page_io.c | 3 +++ > > 4 files changed, 11 insertions(+) > > > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation= /admin-guide/mm/transhuge.rst > > index 2a171ed5206e..5caa3fb2feb1 100644 > > --- a/Documentation/admin-guide/mm/transhuge.rst > > +++ b/Documentation/admin-guide/mm/transhuge.rst > > @@ -534,6 +534,10 @@ zswpout > > is incremented every time a huge page is swapped out to zswap in = one > > piece without splitting. > > > > +swpin > > + is incremented every time a huge page is swapped in from a non-zs= wap > > + swap device in one piece. > > + > > swpout > > is incremented every time a huge page is swapped out to a non-zsw= ap > > swap device in one piece without splitting. > > In Documentation/ABI/testing/sysfs-kernel-mm-transparent-hugepage, I > found > > " > What: /sys/kernel/mm/transparent_hugepage/ > Date: April 2024 > Contact: Linux memory management mailing list > Description: > /sys/kernel/mm/transparent_hugepage/ contains a number of= files and > subdirectories, > > - defrag > - enabled > - hpage_pmd_size > - khugepaged > - shmem_enabled > - use_zero_page > - subdirectories of the form hugepages-kB, = where > is the page size of the hugepages supported by = the kernel/CPU > combination. > > See Documentation/admin-guide/mm/transhuge.rst for detail= s. > " > > So, Documentation/admin-guide/mm/transhuge.rst will be used as ABI > document? Yes. this follows: sysfs-kernel-mm-hugepages: See Documentation/admin-guide/mm/hugetlbpage.rst for details. sysfs-kernel-mm-ksm: See Documentation/mm/ksm.rst for more information. sysfs-kernel-mm-transparent-hugepage: See Documentation/admin-guide/mm/transhuge.rst for details. > > [snip] > > -- > Best Regards, > Huang, Ying Thanks barry