From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23C1C433F5 for ; Fri, 15 Apr 2022 10:16:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 521246B0073; Fri, 15 Apr 2022 06:16:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AA2B6B0074; Fri, 15 Apr 2022 06:16:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 322F66B0075; Fri, 15 Apr 2022 06:16:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 1E53D6B0073 for ; Fri, 15 Apr 2022 06:16:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id E1C69625D2 for ; Fri, 15 Apr 2022 10:16:03 +0000 (UTC) X-FDA: 79358707806.03.93AB387 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 7739B1C0005 for ; Fri, 15 Apr 2022 10:16:03 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id s18so14746578ejr.0 for ; Fri, 15 Apr 2022 03:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=isTdaKobIfw71vhVrWliledBvPWOo0t2AS4RMsJHhgw=; b=VojlBmOs7qhrPLjvBT58iz2RSikqaqngUp0thmoO0BrOKKvxGEcdaET1fQ4+qoAcgn wjJCU0JQ2q6uTuwg8ry+hQHp+25Gm+CW39abzWign/R5aY5PEckMm5LH2u7XepLGPknN WZinzb1UPdKxzdHiPemWbLb4RaZhe65B/6ZGLbPin/vigUjKbhUajeWXSwNrY/b7rf2V dI/+EJhDOQ+wn1JfdAQIlNjLkqBdqg0Iv/GK24ZpTgDjmw5zdhXnOUYE38UleN/WhHaA e5irtprXsvMP1VMv1U7incWvDTFHbd4avKLigZC9Iw1eYCZh7u4K+UIHoXORE8OG/M26 1nLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=isTdaKobIfw71vhVrWliledBvPWOo0t2AS4RMsJHhgw=; b=XW8jmBcSYAHMYUrPDBAOmVOnG6znPh6PgftrSDAULTIWb2Yxk+pcs3XS67Yfjb1zJC V3wm/ECwGg9WAd8o25mAxNO/VYqE+X9F4RHmFS7mgtnSYq7dqv4aFqFit/b4o4dNpYkq K/wAHvGoBx+4DJfhW8ZJlRKCfj2lX7IaL0/9iPvZnuelBeCOTcV0jB0yGNqKQ18tGI5a J39POSCP/KQetcdCm2PHXW3OtThEu9vEULGzKhmgF0tH0UCg7Twj8M67JNy7AG0seak/ GrLSriq6sQ2YBGGDpTGRv6RCxXhKGJzgJssv8ojfcbI5OdsVNGxrDVOne+lvwbzGKc9j GK0g== X-Gm-Message-State: AOAM533Hhjv0smYG7OfELTJytBm8rLR7o3mkimCnKexHZWi2VWf57AEX 4lRUqpIq2VgftivuLASQeIMvxullmXOl4tu0NxY= X-Google-Smtp-Source: ABdhPJyLCZsI7fVraonfF0F+ehCoQyH2DCXZkx6+1XCDfSBeo4O7J2luzopYDAGCrcw8pNEf+1NRHyyIfn3f38d8GQo= X-Received: by 2002:a17:907:2d23:b0:6e8:807c:cd94 with SMTP id gs35-20020a1709072d2300b006e8807ccd94mr5588243ejc.502.1650017761992; Fri, 15 Apr 2022 03:16:01 -0700 (PDT) MIME-Version: 1.0 References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-7-yuzhao@google.com> <20220414143959.0daf4534613f2511b9b27f11@linux-foundation.org> In-Reply-To: <20220414143959.0daf4534613f2511b9b27f11@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Fri, 15 Apr 2022 22:15:50 +1200 Message-ID: Subject: Re: [PATCH v10 06/14] mm: multi-gen LRU: minimal implementation To: Andrew Morton Cc: Yu Zhao , Stephen Rothwell , Linux-MM , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , LAK , Linux Doc Mailing List , LKML , Kernel Page Reclaim v2 , x86 , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7739B1C0005 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VojlBmOs; spf=pass (imf18.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: n9ukqpxsectag85o8ida85d75fygith9 X-HE-Tag: 1650017763-613608 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 15, 2022 at 9:40 AM Andrew Morton wrote: > > On Thu, 14 Apr 2022 14:36:03 -0600 Yu Zhao wrote: > > > > or it is only something > > > meaningful for the internal code? > > > > This is how swappiness is interpreted. > > > > > if so, can we rename it to > > > something else? otherwise, it is quite confusing. > > > > Feel free to suggest something. > > It is confusing, swap_preference? seems to be much better. might also be worth using MACRO to replace those 1, 200, 0 magic numbers to tell readers the exact meaning? > > Thanks Barry