From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50298C52D7C for ; Sun, 18 Aug 2024 07:46:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C52358D00DE; Sun, 18 Aug 2024 03:46:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C03608D00CF; Sun, 18 Aug 2024 03:46:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF1708D00DE; Sun, 18 Aug 2024 03:46:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8F4CA8D00CF for ; Sun, 18 Aug 2024 03:46:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0BAD8C0AC6 for ; Sun, 18 Aug 2024 07:46:14 +0000 (UTC) X-FDA: 82464583068.02.8D45D03 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf17.hostedemail.com (Postfix) with ESMTP id 466A640004 for ; Sun, 18 Aug 2024 07:46:12 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LI1p7MMw; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723967096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AAvjJXjZn/M1UFHTVDjEXTa7UKeEb5l9wox/vLEuT9k=; b=GrWlT1veo+itb5wlutB5qC4ccZsvjLOyB6s9Bfurzi7lvFkyAk78ZVhSBq8kYID0bAtDI9 eNzycSrBI2gkenZlhueez+Kj7+ehlXSVSMicVBZubexWgqsEShBWokjemHGf4Xzo2CXNMp oEdMITogI3YFgl33fBeTltnVEwd1yO0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723967096; a=rsa-sha256; cv=none; b=QgC+WphAOeP87YRhtxQvFcHyFAcEoGhQ5tqPKcMz4bP0gk638kKVVu76LeM+79+X4Dd1Ou A3d8sdWnOIrNP+Y+uZBg7LXttM/o+/Zva3fetTmY/Ux5spHx38UBJBOYRRTGXo0xNIhjj8 7Rp23zTqtQa3zSidiSmUsa3epSeNhdU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LI1p7MMw; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-4929f9a28c7so1099592137.1 for ; Sun, 18 Aug 2024 00:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723967171; x=1724571971; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AAvjJXjZn/M1UFHTVDjEXTa7UKeEb5l9wox/vLEuT9k=; b=LI1p7MMwKR8VmyDfxS73O+BCkyGE7NUkc55nHl3HB5xmJNxBRexGHRZT/A85J6G4Xo z/3SDA/UEnqAuH5jEFJqvKWXq1C7GQMjoy1oZUZ/T0+scD7PI4VNTDGDUS8SJE+5Y9/6 H4YrMx/aseXA7BLPtzgHRZPOJif7qgM3RChG/VTZ9qKdAYp1e4nk2aFCF4rb0cmI+P9J fmIVdO3tiQinSva3cY1mtd1a37MNdaGVruPE1Oaer/efBGqMyNKX6Lp+LUTtxrCFUyqe hEebYBmBFcO050BfeFp/l0HaijPGRBrRAw3ZKtvQsGVMSAYGU1ABrM4BQSMaYCFA24Cv 1VLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723967171; x=1724571971; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AAvjJXjZn/M1UFHTVDjEXTa7UKeEb5l9wox/vLEuT9k=; b=D/LLSB+QnqPmhxUxP6lEI6NrAZTg5//OxROLDgMiV4Oyy/z1EOrU32h9kG/6qI/WWi otLVrrreuTt6WKD/a/DJxlHS/TYZiht8D3NxNHNqnRRfcxsZdRRHd3nC5g+nfqT84fFn VxWBxaITymIGc2/m/rmRQVxyjN76hf6dCkM3QdEUr1/q/tgaqjmr8yQi6iXIK8CK/e0n f3VwMzfCZoe2Q06O2W71ZxpCIsXd72fggMsfhIVrdVstQK/VqTFOWe3a00lRRHCa9Xgm UDWyCMKask6MGc6qKOMFLRXPmYf8hIf2ACfzhnX1wCdFHntzoksQU/ts4UYjDcmUvIQQ waEA== X-Forwarded-Encrypted: i=1; AJvYcCXevIXGAOtkf5DlCB0poYXWj+7oS08EG7CDfHi8AVzgRvSRjSJuGs9o+rUy+2dSxmiXEvuMZ11bKr1ZOevUnj+vlr0= X-Gm-Message-State: AOJu0YxIiEaxB2cLfJ3go6SqBAYir81e+Lhptk8gbDvfM4mEdK/Be2Bb rXu8VpT9YiRUPwmZbyeFxCTIDzqwrVLKPu1dteRY8DrWGmJgDYI+UuMd6T31Ao9/KfwSfoiM6tf Nrmsa9vKZDQhO17RsCGeUk+C6xEg= X-Google-Smtp-Source: AGHT+IEKL4gMV3p0eKY4nYvTpM8TFYfkrNVFvtZvOsrm4kDB/YSfYSjZJMAPikLTM43m8TmeDSsf7cL+f5RZDwa2ZCc= X-Received: by 2002:a05:6102:370d:b0:494:560b:6c07 with SMTP id ada2fe7eead31-497798fa046mr9382717137.16.1723967171177; Sun, 18 Aug 2024 00:46:11 -0700 (PDT) MIME-Version: 1.0 References: <20240817050921.18462-5-kanchana.p.sridhar@intel.com> <202408180729.M6uZh634-lkp@intel.com> In-Reply-To: <202408180729.M6uZh634-lkp@intel.com> From: Barry Song <21cnbao@gmail.com> Date: Sun, 18 Aug 2024 19:46:00 +1200 Message-ID: Subject: Re: [PATCH v3 4/4] mm: swap: Count successful mTHP ZSWAP stores in sysfs mTHP stats. To: kernel test robot Cc: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, akpm@linux-foundation.org, oe-kbuild-all@lists.linux.dev, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 466A640004 X-Stat-Signature: m3ns6u1p5oetswumcojsiireyburdeb7 X-HE-Tag: 1723967172-68308 X-HE-Meta: U2FsdGVkX1+A4/uabSDXQk/jqFG9J3B5KIgzZ/t0pgkDvltdHofZYva/ItVM63dMv+5FakhH11z7qoMnZeYuW4+fhd3GxurLdCuF2jyMud9+NRUWEXwLbIunS/uEzR+GtqxQfNQ0zVpNVYT9rQCsXYUm1oeDfA/R6gI4BXcmngechM6YZtmbkmS8MnljAqQtc1uLKvugOoYhbSaBURpUJaZeOm9RWyIgR7g7V4ElyN4n/LCLGXhHCBpGkbWt2GqI+Ox66JKPRz9TfevSTONzsJUidpDN/5zwPW11DnC+8x0R1nm74CMS1WW93ZWG59czvw9H2ScvSMAvZJAPeP05Ry3MdxwWhrv5b1IJRi4eDh5YKPdEQ2KsxAHaOaHi8rOX/gUSIOhK2OLGH+CiXrwSCKdLQsrvPhA5GKqIYHbk4rbwnCAXATdRDli5tfmKWise0XXXbYzUDcjjh43Yv1HPja+tBWHWg+AkWnQV49hK33m6tzGChZU6HrloveuJjhGmo/4Pxo4r5IN1mkQgbkVl0W9E3lwSxi9G9w/CeKIIdy5cTYGGt9Q+cxtrFwHTLjy93Gp4j16S6icuNEt8yLjJ/HUaEKtEbZTa4cnkILBIyOdwpsEDYirK+dg48myNLcF10SS7h85I+ko62x9BdSpW5YAIYcXK3t3X6ryEC5rfvJLjedC3UHXEB3AX3SAduTQA52+W1bT8i9I5sl135cjTKKrq86RibUqZYSk5cxuhPsF41nG5QnNjFvLRQNIfL41iRMyHP3ltfyHXaOmYDi99BFXmgyOiwPCpYe/2n0GDrGnKfm5UmbAVtKnNnXBnkydsAl8yCGY3sjKBxWPHHqobmP57A54MAt04igRnQ+FRZUgbHkfoqOS+vEgU2yJWFYE2ASGu3D7PfcCk6QLfRq1UbLvcsmspgCGYBD4L7wA6H+C8Kup9Ql/T5BGep3OYgmgaCIqSrD/AP9cHJRFfcVe 3lGbXiIF cJxIBaiUarRDV2Bd3AHVnvqg0/mrhNPyrvbGt8jSGMIH4ILTfTMIM32nBq41dA/GWL+4LxUBOP9FOJE+J5P7a8e+cBALSZ/1o2GyNolhhTFHQCRCqJiwl665HLRm2h6sJq+b7cJ20Nu6+JyVSEdfH1VRKUzolRFgM0kmrSSNm56jfZouC6NNocAegAbrqxPts7XJhGbsn14L8LxmZAr9qpkaOKW8l7mDFT414OnTesKEX2/PofomuVdWd1uS9ANm/xj4LIU3NXI4NZETEwaONnoOPxNsoLD3l/+N6HjkaR92m0TObwpvVjarnNi3qRsk6gx0IaaHhq85/jEq9mZGjSATSzJ+JJIpBV25fx/VVYLSwkZ2Rr1GK+cExED2lHgrvs4vAzVfV8waP5mq+f78yXBcc0K0duAac4sNC0TaTHAPUIJKh46IALbTONdvvb2BxGTzHcKG5P+8kDfMIgVcM0J6KfVfsKPcwE4tp65JTyT6eSeXI27m3kYdu6eyazrPABq/kLmIixSDyOXA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 18, 2024 at 12:04=E2=80=AFPM kernel test robot = wrote: > > Hi Kanchana, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on 7c626ce4bae1ac14f60076d00eafe71af30450ba] > > url: https://github.com/intel-lab-lkp/linux/commits/Kanchana-P-Sridhar= /mm-zswap-zswap_is_folio_same_filled-takes-an-index-in-the-folio/20240817-1= 31053 > base: 7c626ce4bae1ac14f60076d00eafe71af30450ba > patch link: https://lore.kernel.org/r/20240817050921.18462-5-kanchana.= p.sridhar%40intel.com > patch subject: [PATCH v3 4/4] mm: swap: Count successful mTHP ZSWAP store= s in sysfs mTHP stats. > config: x86_64-defconfig (https://download.01.org/0day-ci/archive/2024081= 8/202408180729.M6uZh634-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20240818/202408180729.M6uZh634-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202408180729.M6uZh634-lkp= @intel.com/ > > All errors (new ones prefixed by >>): > > mm/page_io.c: In function 'count_mthp_zswpout_vm_event': > >> mm/page_io.c:178:17: error: implicit declaration of function 'count_mt= hp_stat' [-Werror=3Dimplicit-function-declaration] > 178 | count_mthp_stat(folio_order(folio), MTHP_STAT_= ZSWPOUT); > | ^~~~~~~~~~~~~~~ > >> mm/page_io.c:178:53: error: 'MTHP_STAT_ZSWPOUT' undeclared (first use = in this function) > 178 | count_mthp_stat(folio_order(folio), MTHP_STAT_= ZSWPOUT); > | ^~~~~~~~~~= ~~~~~~~ > mm/page_io.c:178:53: note: each undeclared identifier is reported only= once for each function it appears in > cc1: some warnings being treated as errors i believe this has been fixed by Ryan's latest cleanup https://lore.kernel.org/all/20240808111849.651867-2-ryan.roberts@arm.com/ Kanchana, is your code on top of mm-unstable? > > > vim +/count_mthp_stat +178 mm/page_io.c > > 174 > 175 static inline void count_mthp_zswpout_vm_event(struct folio *foli= o) > 176 { > 177 if (IS_ENABLED(CONFIG_THP_SWAP)) > > 178 count_mthp_stat(folio_order(folio), MTHP_STAT_ZSW= POUT); > 179 } > 180 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki