From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4F8C021AA for ; Wed, 19 Feb 2025 20:45:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FD69440180; Wed, 19 Feb 2025 15:45:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80B4C440179; Wed, 19 Feb 2025 15:45:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 684D6440180; Wed, 19 Feb 2025 15:45:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3F89E440179 for ; Wed, 19 Feb 2025 15:45:46 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D87A316049E for ; Wed, 19 Feb 2025 20:45:45 +0000 (UTC) X-FDA: 83137875450.28.71BDDAE Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf13.hostedemail.com (Postfix) with ESMTP id 0694220003 for ; Wed, 19 Feb 2025 20:45:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dHS9p+Dd; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739997944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2kdz4SCba9xdhN8nuXdn7O8wnIsJaLIGPRVuUKnzGCw=; b=tce/Id3UGDZ1qV0xumqG7Vva/RYBPFe1ZcpbcU2Kr8+1kqg7bX9gi1Rii5N38aw4IwVKsE BBinYH2dYMymHHk5UHFVIhWX2QH/ztgyfkm26p1snTu8ChtGCqS9MtURiwBjne3toFBEvB h4kZ81Rm10VkBxgFDhGgj9g1RlyB11A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dHS9p+Dd; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739997944; a=rsa-sha256; cv=none; b=JlygVY+x1QeJfdeyiOkFHK4jns2mK4VYHn1dCs2x5fuzDVaYoiC+h0+DE2v1PmPDm9ALNM GQy+yuEbDr5nyvm5QxjZmmEUOHTs9WiYEOZBoVVQTunjxhJX+M/jJaWNfXIDY/zPEdWgbv jlCFKiVF/k+gFb7Lo8iWkRSgd9GjQLo= Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-4bd3679279bso80206137.3 for ; Wed, 19 Feb 2025 12:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739997943; x=1740602743; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2kdz4SCba9xdhN8nuXdn7O8wnIsJaLIGPRVuUKnzGCw=; b=dHS9p+Dd1u6LzPaAga6sooxgDYSsGzxl/rcAZwZPx3sz273bHbYjqrI9M4Ta7ceRji sG1cvZDy2Yl7PBM17oX97j8qXA9i1luch6HPG/5w+CarO913E9GG9/wHpeK7yKf2CW0C 0Od6+hg4aLNGfE62gvQqZvtTKN8yGykwVpArpeUcWk6GPqyajKK4maLjaHCtS/10cNTG k5zpVLgDbVBSR+SeDH098sTIrNBLGStA1uRL+kenB+my9yOlvBPLcfLBSty1FCk6/K0n 3POFzvtNYrXm6aIjCbqFUHbmVjsCZAUWdKM2ePGVoFwNfFQrQTMEDTcLh6Cm6l66fYCQ /AMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739997943; x=1740602743; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2kdz4SCba9xdhN8nuXdn7O8wnIsJaLIGPRVuUKnzGCw=; b=R1na6sVIPkpwufwF7Yz7Ox4RmYvw07UUsBB4fy2iIilwD5uBRe/4Z9YF8/fnM8sPIm wIezYPQaoUEV24Fx6iI4LahKsCh17S/ZxRvMklFOQaKs3EOo1mGMzQ49kOHmUJ0sZBv7 GFQT2MIZSgWfhGMjz/pHV+YzA3yFA3G5McKydkBicdy29huHAaZ4ujE8E0e8eb+v6zpa 9kUgd9zD7lFWK1XkxhQQCmNiUjumSxR0WxDOilvvjCQ15eMMO6moyy0Ln1G/3usCm0qj FSDMHNcuOd7ldDZ3RwCzOc4YCo0o7pxsktbU/1+0jRzqEuAoaSvKpec5zA5dGQvhyFx9 sOxQ== X-Gm-Message-State: AOJu0YwaLmu6re1n0POCTzBa6bNlb4ewZoD2dPmMgmL1w44wfZvkG9Lc /qjlr6bOSjt1XD3GVFiGWpn7V6Ilr1rmg3Wv0aHkioAuAoGxNFpvv/5as00wSop/y8D+4cPMURC GGfk8JJ7QRjWAJJyt16RjgDhrlzg= X-Gm-Gg: ASbGncvsiaPWPuNqs9Pue/2FH4l9A3e0VwxcStfOSjA0FFjMMtWPs/jiTbT1obctsTJ ORKWjsfynFa6cXxBH2hoy1cC/DD5ick3w6HgCCJ/mWSmUg1y6mETceHxpSmY0jSh9w3zD5g+H X-Google-Smtp-Source: AGHT+IFRyFHSbPg3/hU95ww3EgpIsFXMJqe9Iqd9gJrZQxjPUkB7mpRhnebwjC3Ub46zGGpSlp3kFmM+cTMGDycR79Q= X-Received: by 2002:a05:6102:38d0:b0:4b2:af77:b53a with SMTP id ada2fe7eead31-4bd3fca53b5mr12554016137.11.1739997942703; Wed, 19 Feb 2025 12:45:42 -0800 (PST) MIME-Version: 1.0 References: <20250219112519.92853-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Thu, 20 Feb 2025 09:45:31 +1300 X-Gm-Features: AWEUYZnRLDo1Bbx1Y126RSQSoIOiOt_dGqBvxIzKKQC-3id9cE10C0cXBZJnITY Message-ID: Subject: Re: [PATCH RFC] mm: Fix kernel BUG when userfaultfd_move encounters swapcache To: Lokesh Gidra Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, zhengtangquan@oppo.com, Barry Song , Andrea Arcangeli , Suren Baghdasaryan , Al Viro , Axel Rasmussen , Brian Geffon , Christian Brauner , David Hildenbrand , Hugh Dickins , Jann Horn , Kalesh Singh , "Liam R . Howlett" , Matthew Wilcox , Michal Hocko , Mike Rapoport , Nicolas Geoffray , Peter Xu , Ryan Roberts , Shuah Khan , ZhangPeng Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 1wdq41urqmwuony6emtys7yunqftr6ak X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0694220003 X-HE-Tag: 1739997943-259371 X-HE-Meta: U2FsdGVkX1/pScnaJfh7hrAlt/n20/mM6++G+g4FMcBX1iwnJg2PAABCYm3ub6tTJdENuZ5lxikArAOJ33uwM2kcdDw1Vk2y+nWZuvbRK+76s+7WOOM/+CTnFXM4rBeLawX0ugAATyDBApYzKYJVpoO/QiEU6RRa9kkTze6ZtDguQN/sILipxmppKIf3+7LFZCNMstU8l7QQx6njL1/AODsvPZ1lGHsH/smHXooUMb0GMMS8hdxS9wfQYYi03T32ut8D7rcJgAiy6Y7WexoHyLElYxuLPmKQ03sJobgloPHAuPWVVQihWD++k8ejabvUgZtiW5sLARgwGr0o8C1HzCdGm66i8/obaByNP9J/ygCS3QGSl3z+buP+IOTVUu862WBQhybe+hX4Z1AMcewNzPbq9/r2MnnRdhbqw7uo6gkjrmS036iGV8x/E9yTf8KXOs8DDGSjVlQCHsX6GRg96pEU/wUTsrxnfOCgE8iWg1Av6gv2icZLZS1u9F2esNOKhBJ+LAZL/2ohD8tb23zphDhY1fwQCsmSw+lPfAfIZx6h+aK18+fx+40r2mBglXCaDUrf8SqdD72rTpJPF7CxZg/1VL9Hwik8rCtMVZsL1Gdyu3aD9X2r8c2n9pJoAHRS4vFz7pRdVtyJUKHs+mfFCfaoJ7y+lL+NlvAVNiI0m0W4i4XCuo+Sry/XS4GNdb0FJD+JzMGSetH4GAJvV2nrGiNpSTg+Hw8DJmEjUoCHi0alFNi3BNflaCblckt5CvsnFDJ4sdWxmXK1Dpng4fC47+w2VysAObQgcM/4brATLuyFKLwYNq528A7jparpyJNvPqm05H9KHHIuoxUE2uCcxgiGuhbWpsQi++xfwSxR9eo1m/KvcWWU1R8NhS1NGaxxwXk2j9AxoOgMgAmZ0ELT2wC3CH3fvvml0dyz712q1XFn4kcA8Zq7lOope5hpy3Z4b+YtVLjr7M6K5RFpQsU utP7c986 jQxrExUorxJxey+JwAooamzUyOXr8eKuadUZp4BXQLIuOZMR2ZnwaGN/sbN9WIUiWmWJ/aTsSduoZ/C5i91fTYhrF112LwE28Po1nAEEXoODfc19QiHBFXG+/Fp/YZtT69tEAlDBkJJN1fV8YXQlOPMzPqOWDrO5frwBb0cQSxxEUcZv4ggIpjJjAIlUKwV0X+RHGr9qrs/nIOl82Zp8khdaV9Ks3WcHdkj/SvjHtisWgD0Xah1XtUe6+wZVlfVZ2PIJeoLQMBX56VoewD41GPOwPcEpxLAxEere3vDTu+C56rkynu7UbBX4vM6vwKckg4g8Dy/2LgxgIN1BkwCy3GZvBukfjDhZ9//YIE2ZTTcOTSU6k3hp7Z5aCDHFpWlPZJUjams5mh48UMPgdCm8zQJoWG2CHhUcw1nSHBYcNK2ipgAl3yWSTdt0o8lXJonyeGHUu56K/Q7kcmz+YE+RiEROp5RIf3wHlR6gVM9+CrdNIvEFNKhN3uMS7YXzyRiJbK3teRgbDZE5vJtt+qGP6npZcDckEF8et7221/HBvoBoDfTsHdeIcc4InuOaRbFMxtkPENMfoISD+HNXuewuuUTVoIzuMGj9/7LMMVPjudVlDb+7IS4anNKGG9jHbRqzE6wKkQzGn1uAV7pQ0rk1CUralQgmwO6T02V/ZvFm/5pHmJR1y8uSBzURs9FGSnehGgcjdS0NJdAE8lOw8gsPeZ4SuWiPrgmU1p5ZtYrWGfcw9mnkAQQaK3e1qGUePKhrStRtANWxEL0IxEXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 7:40=E2=80=AFAM Lokesh Gidra wrote: > > On Wed, Feb 19, 2025 at 3:25=E2=80=AFAM Barry Song <21cnbao@gmail.com> wr= ote: > > > > From: Barry Song > > > > userfaultfd_move() checks whether the PTE entry is present or a > > swap entry. > > > > - If the PTE entry is present, move_present_pte() handles folio > > migration by setting: > > > > src_folio->index =3D linear_page_index(dst_vma, dst_addr); > > > > - If the PTE entry is a swap entry, move_swap_pte() simply copies > > the PTE to the new dst_addr. > > > > This approach is incorrect because even if the PTE is a swap > > entry, it can still reference a folio that remains in the swap > > cache. > > > > If do_swap_page() is triggered, it may locate the folio in the > > swap cache. However, during add_rmap operations, a kernel panic > > can occur due to: > > page_pgoff(folio, page) !=3D linear_page_index(vma, address) > > > > $./a.out > /dev/null > > [ 13.336953] page: refcount:6 mapcount:1 mapping:00000000f43db19c ind= ex:0xffffaf150 pfn:0x4667c > > [ 13.337520] head: order:2 mapcount:1 entire_mapcount:0 nr_pages_mapp= ed:1 pincount:0 > > [ 13.337716] memcg:ffff00000405f000 > > [ 13.337849] anon flags: 0x3fffc0000020459(locked|uptodate|dirty|owne= r_priv_1|head|swapbacked|node=3D0|zone=3D0|lastcpupid=3D0xffff) > > [ 13.338630] raw: 03fffc0000020459 ffff80008507b538 ffff80008507b538 = ffff000006260361 > > [ 13.338831] raw: 0000000ffffaf150 0000000000004000 0000000600000000 = ffff00000405f000 > > [ 13.339031] head: 03fffc0000020459 ffff80008507b538 ffff80008507b538= ffff000006260361 > > [ 13.339204] head: 0000000ffffaf150 0000000000004000 0000000600000000= ffff00000405f000 > > [ 13.339375] head: 03fffc0000000202 fffffdffc0199f01 ffffffff00000000= 0000000000000001 > > [ 13.339546] head: 0000000000000004 0000000000000000 00000000ffffffff= 0000000000000000 > > [ 13.339736] page dumped because: VM_BUG_ON_PAGE(page_pgoff(folio, pa= ge) !=3D linear_page_index(vma, address)) > > [ 13.340190] ------------[ cut here ]------------ > > [ 13.340316] kernel BUG at mm/rmap.c:1380! > > [ 13.340683] Internal error: Oops - BUG: 00000000f2000800 [#1] PREEMP= T SMP > > [ 13.340969] Modules linked in: > > [ 13.341257] CPU: 1 UID: 0 PID: 107 Comm: a.out Not tainted 6.14.0-rc= 3-gcf42737e247a-dirty #299 > > [ 13.341470] Hardware name: linux,dummy-virt (DT) > > [ 13.341671] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BT= YPE=3D--) > > [ 13.341815] pc : __page_check_anon_rmap+0xa0/0xb0 > > [ 13.341920] lr : __page_check_anon_rmap+0xa0/0xb0 > > [ 13.342018] sp : ffff80008752bb20 > > [ 13.342093] x29: ffff80008752bb20 x28: fffffdffc0199f00 x27: 0000000= 000000001 > > [ 13.342404] x26: 0000000000000000 x25: 0000000000000001 x24: 0000000= 000000001 > > [ 13.342575] x23: 0000ffffaf0d0000 x22: 0000ffffaf0d0000 x21: fffffdf= fc0199f00 > > [ 13.342731] x20: fffffdffc0199f00 x19: ffff000006210700 x18: 0000000= 0ffffffff > > [ 13.342881] x17: 6c203d2120296567 x16: 6170202c6f696c6f x15: 6628666= 66f67705f > > [ 13.343033] x14: 6567617028454741 x13: 2929737365726464 x12: ffff800= 083728ab0 > > [ 13.343183] x11: ffff800082996bf8 x10: 0000000000000fd7 x9 : ffff800= 08011bc40 > > [ 13.343351] x8 : 0000000000017fe8 x7 : 00000000fffff000 x6 : ffff800= 0829eebf8 > > [ 13.343498] x5 : c0000000fffff000 x4 : 0000000000000000 x3 : 0000000= 000000000 > > [ 13.343645] x2 : 0000000000000000 x1 : ffff0000062db980 x0 : 0000000= 00000005f > > [ 13.343876] Call trace: > > [ 13.344045] __page_check_anon_rmap+0xa0/0xb0 (P) > > [ 13.344234] folio_add_anon_rmap_ptes+0x22c/0x320 > > [ 13.344333] do_swap_page+0x1060/0x1400 > > [ 13.344417] __handle_mm_fault+0x61c/0xbc8 > > [ 13.344504] handle_mm_fault+0xd8/0x2e8 > > [ 13.344586] do_page_fault+0x20c/0x770 > > [ 13.344673] do_translation_fault+0xb4/0xf0 > > [ 13.344759] do_mem_abort+0x48/0xa0 > > [ 13.344842] el0_da+0x58/0x130 > > [ 13.344914] el0t_64_sync_handler+0xc4/0x138 > > [ 13.345002] el0t_64_sync+0x1ac/0x1b0 > > [ 13.345208] Code: aa1503e0 f000f801 910f6021 97ff5779 (d4210000) > > [ 13.345504] ---[ end trace 0000000000000000 ]--- > > [ 13.345715] note: a.out[107] exited with irqs disabled > > [ 13.345954] note: a.out[107] exited with preempt_count 2 > > > > Fully fixing it would be quite complex, requiring similar handling > > of folios as done in move_present_pte. For now, a quick solution > > is to return -EBUSY. > > I'd like to see others' opinions on whether a full fix is worth > > pursuing. > > > > Thanks a lot for finding this. > > As a user of MOVE ioctl (in Android GC) I strongly urge you to fix > this properly. Because this is not going to be a rare occurrence in > the case of Android. And when -EBUSY is returned, all that userspace > can do is touch the page, which also does not guarantee that a > subsequent retry of the ioctl will succeed. Not trying to push this idea, but I=E2=80=99m curious if it's feasible: If UFFDIO_MOVE fails, could userspace fall back to UFFDIO_COPY? I=E2=80=99m still trying to wrap my head around a few things, particularly what exactly UFFDIO_MOVE is doing with mTHP, as I mentioned in my reply to Suren and you in another email: https://lore.kernel.org/linux-mm/CAGsJ_4yx1=3DjaQmDG_9rMqHFFkoXqMJw941eYvtb= y28OqDq+S7g@mail.gmail.com/ > > > For anyone interested in reproducing it, the a.out test program is > > as below, > > > > #define _GNU_SOURCE > > #include > > #include > > #include > > #include > > #include > > #include > > #include > > #include > > #include > > #include > > #include > > #include > > > > #define PAGE_SIZE 4096 > > #define REGION_SIZE (512 * 1024) > > > > #ifndef UFFDIO_MOVE > > struct uffdio_move { > > __u64 dst; > > __u64 src; > > __u64 len; > > #define UFFDIO_MOVE_MODE_DONTWAKE ((__u64)1<<0) > > #define UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES ((__u64)1<<1) > > __u64 mode; > > __s64 move; > > }; > > #define _UFFDIO_MOVE (0x05) > > #define UFFDIO_MOVE _IOWR(UFFDIO, _UFFDIO_MOVE, struct uffdio_move) > > #endif > > > > void *src, *dst; > > int uffd; > > > > void *madvise_thread(void *arg) { > > if (madvise(src, REGION_SIZE, MADV_PAGEOUT) =3D=3D -1) { > > perror("madvise MADV_PAGEOUT"); > > } > > return NULL; > > } > > > > void *fault_handler_thread(void *arg) { > > struct uffd_msg msg; > > struct uffdio_move move; > > struct pollfd pollfd =3D { .fd =3D uffd, .events =3D POLLIN }; > > > > pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL); > > pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL); > > > > while (1) { > > if (poll(&pollfd, 1, -1) =3D=3D -1) { > > perror("poll"); > > exit(EXIT_FAILURE); > > } > > > > if (read(uffd, &msg, sizeof(msg)) <=3D 0) { > > perror("read"); > > exit(EXIT_FAILURE); > > } > > > > if (msg.event !=3D UFFD_EVENT_PAGEFAULT) { > > fprintf(stderr, "Unexpected event\n"); > > exit(EXIT_FAILURE); > > } > > > > move.src =3D (unsigned long)src + (msg.arg.pagefault.address -= (unsigned long)dst); > > move.dst =3D msg.arg.pagefault.address & ~(PAGE_SIZE - 1); > > move.len =3D PAGE_SIZE; > > move.mode =3D 0; > > > > if (ioctl(uffd, UFFDIO_MOVE, &move) =3D=3D -1) { > > perror("UFFDIO_MOVE"); > > exit(EXIT_FAILURE); > > } > > } > > return NULL; > > } > > > > int main() { > > again: > > pthread_t thr, madv_thr; > > struct uffdio_api uffdio_api =3D { .api =3D UFFD_API, .features = =3D 0 }; > > struct uffdio_register uffdio_register; > > > > src =3D mmap(NULL, REGION_SIZE, PROT_READ | PROT_WRITE, MAP_PRIVAT= E | MAP_ANONYMOUS, -1, 0); > > if (src =3D=3D MAP_FAILED) { > > perror("mmap src"); > > exit(EXIT_FAILURE); > > } > > memset(src, 1, REGION_SIZE); > > > > dst =3D mmap(NULL, REGION_SIZE, PROT_READ | PROT_WRITE, MAP_PRIVAT= E | MAP_ANONYMOUS, -1, 0); > > if (dst =3D=3D MAP_FAILED) { > > perror("mmap dst"); > > exit(EXIT_FAILURE); > > } > > > > uffd =3D syscall(SYS_userfaultfd, O_CLOEXEC | O_NONBLOCK); > > if (uffd =3D=3D -1) { > > perror("userfaultfd"); > > exit(EXIT_FAILURE); > > } > > > > if (ioctl(uffd, UFFDIO_API, &uffdio_api) =3D=3D -1) { > > perror("UFFDIO_API"); > > exit(EXIT_FAILURE); > > } > > > > uffdio_register.range.start =3D (unsigned long)dst; > > uffdio_register.range.len =3D REGION_SIZE; > > uffdio_register.mode =3D UFFDIO_REGISTER_MODE_MISSING; > > > > if (ioctl(uffd, UFFDIO_REGISTER, &uffdio_register) =3D=3D -1) { > > perror("UFFDIO_REGISTER"); > > exit(EXIT_FAILURE); > > } > > > > if (pthread_create(&madv_thr, NULL, madvise_thread, NULL) !=3D 0) = { > > perror("pthread_create madvise_thread"); > > exit(EXIT_FAILURE); > > } > > > > if (pthread_create(&thr, NULL, fault_handler_thread, NULL) !=3D 0)= { > > perror("pthread_create fault_handler_thread"); > > exit(EXIT_FAILURE); > > } > > > > for (size_t i =3D 0; i < REGION_SIZE; i +=3D PAGE_SIZE) { > > char val =3D ((char *)dst)[i]; > > printf("Accessing dst at offset %zu, value: %d\n", i, val); > > } > > > > pthread_join(madv_thr, NULL); > > pthread_cancel(thr); > > pthread_join(thr, NULL); > > > > munmap(src, REGION_SIZE); > > munmap(dst, REGION_SIZE); > > close(uffd); > > goto again; > > return 0; > > } > > > > As long as you enable mTHP (which likely increases the residency > > time of swapcache), you can reproduce the issue within a few > > seconds. But I guess the same race condition also exists with > > small folios. > > > > Fixes: adef440691bab ("userfaultfd: UFFDIO_MOVE uABI") > > Cc: Andrea Arcangeli > > Cc: Suren Baghdasaryan > > Cc: Al Viro > > Cc: Axel Rasmussen > > Cc: Brian Geffon > > Cc: Christian Brauner > > Cc: David Hildenbrand > > Cc: Hugh Dickins > > Cc: Jann Horn > > Cc: Kalesh Singh > > Cc: Liam R. Howlett > > Cc: Lokesh Gidra > > Cc: Matthew Wilcox (Oracle) > > Cc: Michal Hocko > > Cc: Mike Rapoport (IBM) > > Cc: Nicolas Geoffray > > Cc: Peter Xu > > Cc: Ryan Roberts > > Cc: Shuah Khan > > Cc: ZhangPeng > > Signed-off-by: Barry Song > > --- > > mm/userfaultfd.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > > index 867898c4e30b..34cf1c8c725d 100644 > > --- a/mm/userfaultfd.c > > +++ b/mm/userfaultfd.c > > @@ -18,6 +18,7 @@ > > #include > > #include > > #include "internal.h" > > +#include "swap.h" > > > > static __always_inline > > bool validate_dst_vma(struct vm_area_struct *dst_vma, unsigned long ds= t_end) > > @@ -1079,9 +1080,19 @@ static int move_swap_pte(struct mm_struct *mm, > > pmd_t *dst_pmd, pmd_t dst_pmdval, > > spinlock_t *dst_ptl, spinlock_t *src_ptl) > > { > > + struct folio *folio; > > + swp_entry_t entry; > > + > > if (!pte_swp_exclusive(orig_src_pte)) > > return -EBUSY; > > > > + entry =3D pte_to_swp_entry(orig_src_pte); > > + folio =3D filemap_get_folio(swap_address_space(entry), swap_cac= he_index(entry)); > > + if (!IS_ERR(folio)) { > > + folio_put(folio); > > + return -EBUSY; > > + } > > + > > double_pt_lock(dst_ptl, src_ptl); > > > > if (!is_pte_pages_stable(dst_pte, src_pte, orig_dst_pte, orig_s= rc_pte, > > -- > > 2.39.3 (Apple Git-146) > > > Thanks Barry