From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 533EBC369B1 for ; Wed, 16 Apr 2025 09:24:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA7DA2800DC; Wed, 16 Apr 2025 05:24:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C31AF2800D9; Wed, 16 Apr 2025 05:24:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF7CE2800DC; Wed, 16 Apr 2025 05:24:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E6462800D9 for ; Wed, 16 Apr 2025 05:24:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F157E1403D4 for ; Wed, 16 Apr 2025 09:24:41 +0000 (UTC) X-FDA: 83339371962.26.BC4C965 Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by imf07.hostedemail.com (Postfix) with ESMTP id 264B640003 for ; Wed, 16 Apr 2025 09:24:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VsSqFlws; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744795480; a=rsa-sha256; cv=none; b=YPw9joDIuif1P9XgGWZzoJHEdwUTVdw0pi2VEoLb+m2HF3IKSb97PV6SYx3ulyQ7zhV31z 3Htxbm/D5hC9AYWlBjBW10Eyh9ofDgGua8sZGsARi9NcPiOx7rhjqTClfn7MU11ijOGm4I nNCeHFdH4bWLZkYeOhg7AoHFIK2WFbk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VsSqFlws; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744795480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hHnar/R1bLTQG5T8505mOWlUcoq1efFUMRUpBQOrn8M=; b=DL0GpZoCcqNSbef/DChr1HHjinJp5cAwD6xSa01cOZPdq04iJqnO/vNkNMaHFuIOMZPYUl VNpbRIuJqHmiQZvCUHGaGKh+nCH0btmLM9sXfDoJggtxCL8vXGfFDOdT6jDVdHXfgSpM5B rHb/l4NYqudHWgaznZIzeigN3uk9sSk= Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-86d42f08135so2340771241.0 for ; Wed, 16 Apr 2025 02:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744795479; x=1745400279; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hHnar/R1bLTQG5T8505mOWlUcoq1efFUMRUpBQOrn8M=; b=VsSqFlwsuROWhMcy3pjk0esJoFZ1l3yHuIITN7UvI1S53VB+Ai1ECTQRdPr9E4n28o o7f5cFWKZ7BIYpZ4CsGZ2JoMRwWSy1ohkaGDfGaHEqjDSXo4GK2bQATGoGiBp2cGKpfg svbSyPgFdxCmXd3Oov4Bl53RgBndf/b9aj897PHcwVe1oxbDODUvP8sCLDkpshIKWSMq Y2L2iwvwDJOEbs4vZOdGzvCNI1+8bj/OMT4+hgSCZ10rf6MqdqUyu0EoH8ao4N6OLm8B cfbxSny8j1DTx7pWOI0NshE4OJMlb+kKSZLPoDjqJR+D14jKm2HDhxRerDfiF5MQy7i3 6I2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744795479; x=1745400279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hHnar/R1bLTQG5T8505mOWlUcoq1efFUMRUpBQOrn8M=; b=G+ZNSteC+BlrizJXTaa3f3/t4KmQKSp2FvdB8HIOyAtl910XfozsalD3/8917H+30j AjNY9GSXlL/M7nOSsPBb+Y2G4+2cdDv+BzL/1cJVWhQS5uqinzXq+8K+e2wj+fGfY7o4 z5Hj7liv3mff+wyAi9yC7rNdxqs1Ip+4+7wszl5afE8eCLiPl0qf4nUKre+4C2yws/0j cxXL/FLvxem9CUWmur9RSqAxuTjw6/NjF95IVCu9PEFpLzoTYB+bHf6MhNACCxlzcANW TchhM2ZhkijdMt1e8Qab1eCgtBv/AApx000DwaC2ymsn+2q1+CMYGhiyeM9HTODYOzrT UB0Q== X-Forwarded-Encrypted: i=1; AJvYcCWBeBFW2/nU0ABupOyoBjRYaj9ZFH1hSSQRp6JFdXcl+InbByE93GbOuo2I8E1cf2FXIfkT9PhLhA==@kvack.org X-Gm-Message-State: AOJu0YzmjzgGTKKY4jaa/NkKZBCSZzkmBb+1nMev4mLnVvlkh8iZ1qiP OFuXPN6OpeD8ajMmXgLE9ad87jgfHH2srORSJolSdVEq2lh0OOnQY2EP64p5ZNdQjDsyCZLZxcX Osnw+UPWidBT7TUWTdB75AOAHmd8= X-Gm-Gg: ASbGncsecAhwPQ3AJQ57lx06layL4WE2IgMSCrsUoaP3uucnuyIUTcXyGWIc3W+nIN2 a8ciitpscgHosWwwdt7JUB2f+BPqCzsnctRanAc7kTfTYnh5vbH8qwpYJocq5eDcI3r6D9pF5K6 WBp1YiLFPepT/U0P7HtTntlXq3N1+3U89z X-Google-Smtp-Source: AGHT+IFc6hLhG1BRBDAs3AcWYprpi1NvCFZHy+Fzt2jeq3AQ5eYFlyQTAvoJlabM+Ckb6agoT9lQ6MyxKq8NIJ0oiAQ= X-Received: by 2002:a05:6102:3115:b0:4c5:78ae:1e3a with SMTP id ada2fe7eead31-4cb5930cef1mr272529137.23.1744795479179; Wed, 16 Apr 2025 02:24:39 -0700 (PDT) MIME-Version: 1.0 References: <20250412085852.48524-1-21cnbao@gmail.com> <34c54df6-9a7c-475d-9b91-0f8acb118231@redhat.com> In-Reply-To: <34c54df6-9a7c-475d-9b91-0f8acb118231@redhat.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 16 Apr 2025 17:24:28 +0800 X-Gm-Features: ATxdqUHPpVHDcE4njgv8l7WvP6FJzZ4Hqu_QY8qPLeoJbLDDIVYAzTmNulKWw4Y Message-ID: Subject: Re: [RFC PATCH] mm: don't promote exclusive file folios of dying processes To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Baolin Wang , Johannes Weiner , Matthew Wilcox , Oscar Salvador , Ryan Roberts , Zi Yan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 264B640003 X-Stat-Signature: bk4tf5d383tefmkzoif4ezjaich14fyw X-Rspam-User: X-HE-Tag: 1744795480-650646 X-HE-Meta: U2FsdGVkX1/glcJGQz+hOtiNBuFkb6bka/B30QLvnyuPYvVAIYPG3RYfxdgeGoCoyVkgu3Uodty6O1bMW4nn2OGsWpoz5SS4AKfHdnykJGe8Ss1hlXRePP5kdeFw4wEoFrVJlXiMOXIwVxZ+a/8iqf0KRerpqGY1vrn7ZhKubz4c+WeGEnvS+8r1fsX/gimVpMwAmuPThKjhwcURtoAGMayz6cVt67gcqliRCU+AxIzvUr/FMUPld8INKBr9V7m1jdJf8kf9GgtL/1YY4faKIsSU/wQrYDILI9ZVoqhQJwaDNV1GIp8AzHStvsCv4Mp1qpVDfJFw98tsyN8e8Natj3W9h6LDhn2psGn09+9Zc/dG2mCTsaf/DzO/XTXj8JtSVcCN/tWgxts8Qs4iP5mjO73fUANGFUHuEi8Kgh/HZdWM0eDTATYZ7z6OdCvW0EeVURwpWoYUSSUZUeaTX7nVcB9IK3cpPNWgocw7KEtGLsYHEEYfotJBtpfqR5s39kXWg/nMiS/KtsO8pOPD5mpAes39bPx55mh6G+cPjNK0ZKpHrO7hDjLF8dxgLVfPpDSU0SdYdwR0VfytFb/3gMOh4AveYXVgNmPTePrizzqPCCo1AjU+rOd9psty16lV/R06YBgGEPlo4AdPBVyFT+3mQL36yZoKb9h6I5YIRQU5ugNvxgK2BYCqN9bodt7lDuzbGGOe38Sj7j1H4N/GK7o0pYqMoSfDULeflFyu6Ww4L4TWQXZoiBRX2PGUh5kiW266homiAJhS377nanupNGG5nmHI1rVXAz3puJL8SUAx7IlIh5WjCAQYCIu5ZqiCA4VAhxpazBjAOdzyizmBZtjYCKKYBWSU3bIHDU55UuJWyKMfrYh2UOhdsKWaPeGQi/+Lau5objNoXvv/ZrXc1+ase/fZKrbCnMMAKnxgKR99HpDtWasOd6339Rv49Gzc3gFP6qKj/oSK3zJhqWhzQbz DUptwPad FfmJv0IRWQDdKt4qHV1b2SbcQtmrofZWx4XT0KPTiOoC5SFOXbQM+mcL3H8MdEjxsxcuhEkqGkHHCKRzj+U9ZsPPp3QU8TZxgoUl72F+0kfuls4ZifG4UTvoZySyOZYi7j0ZsB7LSZ3hgAZXGJb9Z5O5ZxxO/owLPPJMJyCDdmUMc22pLqQWP1NyQrZtuqKuAMmz88yfVf+alVltgq128VnCgMlaKt8nAiOM1yikKqVfyvpzYsnsAFb/fe7WVjjayIGk/df/NqsaLWvfWJT7SMSEjTH/3fZBtA3a5BTglIniJyc1tmIg5dDCB5hKb+ug17Mqk0I6/Jq8uUV+MkO4tPIwjQTgWEhPFt9hMS12ypmib8cezOtaw6hLPMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003113, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 16, 2025 at 4:32=E2=80=AFPM David Hildenbrand wrote: > > On 12.04.25 10:58, Barry Song wrote: > > From: Barry Song > > > > Promoting exclusive file folios of a dying process is unnecessary and > > harmful. For example, while Firefox is killed and LibreOffice is > > launched, activating Firefox's young file-backed folios makes it > > harder to reclaim memory that LibreOffice doesn't use at all. > > Do we know when it is reasonable to promote any folios of a dying process= ? > I don't know. It seems not reasonable at all. if one service crashes due to SW bug, systemd will restart it immediately. this might be the case promoti= ng folios might be good. but it is really a bug of the service, not a normal c= ase. > Assume you restart Firefox, would it really matter to promote them when > unmapping? New Firefox would fault-in / touch the ones it really needs > immediately afterwards? Usually users kill firefox to start other applications (users intend to free memory for new applications). For Android, an app might be killed because it has b= een staying in the background inactively for a while. On the other hand, even if users restart firefox immediately, their folios = are probably still in LRU to hit. > > -- > Cheers, > > David / dhildenb > Thanks Barry