From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A800C02183 for ; Mon, 13 Jan 2025 21:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 099856B0089; Mon, 13 Jan 2025 16:56:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 049B06B008A; Mon, 13 Jan 2025 16:56:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E53066B008C; Mon, 13 Jan 2025 16:56:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C1E876B0089 for ; Mon, 13 Jan 2025 16:56:33 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 209AD42E90 for ; Mon, 13 Jan 2025 21:56:33 +0000 (UTC) X-FDA: 83003788266.05.BAA6AE5 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by imf01.hostedemail.com (Postfix) with ESMTP id 4418E40002 for ; Mon, 13 Jan 2025 21:56:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j7pjrsUB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736805391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NItoc+EQdtom9/DPCya8gK3neybR0v9zV0/uNtgIaE8=; b=mr4Dwu1ALlkf5taNpg1J8QBFRIfUQnPkcuAoZNsMXyKUFmWmAuaeZd92OzTp+pEDceYwlk 0jTl0dFqlXvn7yTqcL8is6L0Xt/Brqh3lA1pNm81Rzw70HiM4tviy9Kgg41Bt061dp+Ss1 1LpbayHu7P8DY+9SpjLQwPHi02egG/w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736805391; a=rsa-sha256; cv=none; b=XTF2dla5aBgMap77lbShuEykojLNf00zC9F9ez8o45yXBVGUwAB1MVITueekwvf1u9r4g1 ec9vCpqpzjmj1WQqAbHq9H6O65eu6thhYDRt/GG3TPQ8YbNe9DoRgx9TfizicIWyZOmj3C QuPUpT4YbZfdoKUybauAjZ7g1J3t3d4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j7pjrsUB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-4b24bc0cc65so3049333137.2 for ; Mon, 13 Jan 2025 13:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736805390; x=1737410190; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NItoc+EQdtom9/DPCya8gK3neybR0v9zV0/uNtgIaE8=; b=j7pjrsUBXcQbPk64m+rF1bAECMR0FPTbdwMPQyEWotRlLU1xlTNOh2hR0r6MzLCZ3t 8QY4IIjJNvWzovYOkHXoDKpmgN09B94szvnHUCCX9lU2mTMCWP021CfTA/10AQDB6ebI +JJR/2CuHjMIoC2MGcNRWYklFCIvrDP/WuShMs6HQrIMJr9mfVaIXEbZKZ9x8pqaKkl2 Z3Zxi0xJWYnrs9geffTL+L0dZizgME0FVAxRU1DNZ/iNwV3HyXcP6oXzGFc1STLv8DiS tVF0p6aqMPIW6fpk+zohPOv91Ek9Izen0QFLPFyAevfDHG/BlTAeTuIug+MpU/37Oa9E bW+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736805390; x=1737410190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NItoc+EQdtom9/DPCya8gK3neybR0v9zV0/uNtgIaE8=; b=cUR6j34LnwY7SCvrwQd46N/RFp5GMvevsMespKN59SYJMfSqBKZyImzeT6ZvVykE5s OMOLzmrQjl+TsLe8l+otlvTBNR1UKUeJwK7niY55Sx2yGN66ezgqYRxLgnccjn8+vZgY JxJf3TWFQ3GyKfbUy5jujqPdwiINUbeY7XWJm9+igtwlZLqRM9JinyK1kADe30t2WSVQ HnGCmpm2CUxGs10OUX+M1Giob/Tz5zUTC3x3votFV5QGlyt7HHQiEKJ+q70dppq4PNxo 6R5JhCDGsY+RIUm23KvRiNd/JYIbKG6A4iONOJXqHN7EKyn5ovzu/OZkoluCevyM/e3w d4vQ== X-Forwarded-Encrypted: i=1; AJvYcCWojtDFPRcLvNQ5aXfXolG+WriY1zgothxm7XFaNdcvoTyLJ5oRMLMzhOyuEmIqOK90bB6kyVhFSQ==@kvack.org X-Gm-Message-State: AOJu0YwnxgN7djwzCwOw/4ceg3NyPFot8HmGQkaoUz5V4TGJgcTYWEpE vDwvz4XUhL4d74/TGdmOrgYLQjN/4rLFvhtoZof8WdiAyzBUVXPrWoGVR+JTUZuTN0jpYdu+D1Q QAKBnwgACJracmJ1soniRMSpLnFE= X-Gm-Gg: ASbGncsNCSnKpmD+n4CWe5aQpjSIDTeEgoWE8zOMJUN7nLsaLOMt8emYB3tup8sa8qF xNm1Z1s9m1bMqNOACMSnEKkLdV6EkjTq+Gg4IzS2TbG1xz1/Ubd+hqVzroWTV+ekTrLaKR6JA X-Google-Smtp-Source: AGHT+IFmdfZVLHFm0DOdvRjOe5yeGt4ONJkezdk7eWCtSqnsJVeDh8+x0oC6m6z5E96lL9tvfWmOeuAn2d9TrcwzTFM= X-Received: by 2002:a05:6102:5716:b0:4b6:15fa:565e with SMTP id ada2fe7eead31-4b615fa5b5emr17893878137.11.1736805390315; Mon, 13 Jan 2025 13:56:30 -0800 (PST) MIME-Version: 1.0 References: <20250113033901.68951-1-21cnbao@gmail.com> <20250113033901.68951-2-21cnbao@gmail.com> <296b04db-9524-48f1-9fa1-0b028bc939a6@redhat.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 14 Jan 2025 10:56:19 +1300 X-Gm-Features: AbW1kvYSn8pVt_GuaD4XsZAWlpumqtc0Gw1qVob3xu_doT5JcAUKe0qvWh_LHms Message-ID: Subject: Re: [PATCH v2 1/4] mm: Set folio swapbacked iff folios are dirty in try_to_unmap_one To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, ioworker0@gmail.com, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, linux-riscv@lists.infradead.org, ying.huang@intel.com, zhengtangquan@oppo.com, lorenzo.stoakes@oracle.com, mfo@canonical.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: yxm6hid4zog9hfuicptgti3gjkk5h1f1 X-Rspamd-Queue-Id: 4418E40002 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736805391-106415 X-HE-Meta: U2FsdGVkX1/rfV87M4XcPLqIJXLNK0LXNq7HRO22FLTbIuOh2FFQIkLq3/uaXx9ba9tSo2oHqpUtc54fQXjvtcToj/+7tMIs6j+7wDA0BR1G2YEjaB+x4OuV4kGCNtuWvXkKjKqD6aNvAbH8dxgth50q9NokzVcVhfkpaxYrpfyBU/gbzhEyhCQ1/6hQ1Vsj1rmCDXsRyhjLf3HcXYyqV6G5U5HqQZZKJhfuNgFwhCdKIXx1EOujCWWivz23FN0X7A/NPgcMDZdnWt8bIJyARxKXhA7lBDMvhgQfVmmZ41duuSYT0jQ49D8p4vtxswQADpDZ96vYgNLRm2y9AOOX7XRqChroiFbQFxRMzw7qRVwztUije16pD4bKOzk0HkOzy1FNE1i0QmSiJhMBZw2GTSw+lLB8R44UOQUYU20bZUvGvDdlUUc03PZz8WUNIwZoDMzxTXvMLw5Krbq4fFSxUEEPE8V0A+mRuhNZNBga1dX2DorVQvNiH5c6y+GyvNRLP/OnhYBSnHlVl/ac681ZjTRl/TEVhv7mCNOnEtb4dVJjLKiWob/Uw3G4pjuTHqaDLJKcw8iTdZyt7KKjOEAZUir+FYwYe5Weh414Ha+dayatJvsrO2UuPbG65zHxO3b3FOYJEoJRdDSwZ1WZhLkj+W+pqvndp0ESI+zXQaL5EohYsT22o05vJq0ms6veYvujE6o1WeFAGBdwvQHzeMZib9TrWjfwv8uFfjW8SNe/EAvkRA9g0stDac/8rGQqfjLhRJVQ/TyjSNVoQveDj1F27jYyp+oQdHJod91frPi1nsgW2ifYWWBgCH6yMoynQnj8sr+jzTehPGMG+50cRd/3eFIDkOQpu7QvScursMR5fjy1fKDavDjkrYIhi1axw9nZrCFI/BO6L5/FLS75osTrkb9Lp1EZeasF89mnxaM33hN8eal+oXznQD5XYUlXPwXan32ePyK7IZTpVxbNMLf 7Q1HDiez au8YvOGpyybUUys4eZsEfRpLhI1mB+jnOuNTkUkftakdBI5yN87pRQo5SLFxRPn0WaJGKUKp9A081lIGturukdkq26StWi93T+4EMJTdFopBY0PWkvGAw6VYfxC3CvumEqYY4IQQtd0N1rVEq+BMLWppgUmOg40pbKHao/CWYlnaNC5BSDqTD/R7mbTDfAnyhokhxOTdYeWYxRr6TVH1hS8xE0iPXzQnWmkdkVAP27XXJN2rY1JBOb63YQTxUoESssokgUPPGrvF9o0yoJB9IB5SPPMVC8A3dvTYuBJn3zlcDnebPTL8+fcNltFJswMT5xljXwrpfmzia5/mH42A4tz4De7qnTT+G7w59GkVqAWg0RtQs1rFA4gVCHYWiSJigugK4U4p8lHSbthhEZLMz0OrIEmM01pyyHwvH X-Bogosity: Ham, tests=bogofilter, spamicity=0.116493, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 2:21=E2=80=AFAM David Hildenbrand wrote: > > On 13.01.25 14:19, David Hildenbrand wrote: > > On 13.01.25 04:38, Barry Song wrote: > >> From: Barry Song > >> > >> The refcount may be temporarily or long-term increased, but this does > >> not change the fundamental nature of the folio already being lazy- > >> freed. Therefore, we only reset 'swapbacked' when we are certain the > >> folio is dirty and not droppable. > >> > >> Suggested-by: David Hildenbrand > >> Signed-off-by: Barry Song > >> --- > > > > Acked-by: David Hildenbrand > > Thanks! > > Ah, should this have a Fixes: ? That makes sense to me. > > Because of a speculative reference, we might not reclaim MADV_FREE > folios as we silently mark them as swapbacked again, which sounds fairly > wrong. > I assume the tag should be applied to Mauricio's commit 6c8e2a256915a2 ("mm= : fix race between MADV_FREE reclaim and blkdev direct IO read") and also Mauricio is CC'ed. > -- > Cheers, > > David / dhildenb > Thanks Barry