From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5B4BC27C4F for ; Mon, 1 Jul 2024 00:02:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B38966B0082; Sun, 30 Jun 2024 20:02:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE86A6B0083; Sun, 30 Jun 2024 20:02:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B0ED6B0088; Sun, 30 Jun 2024 20:02:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7C0596B0082 for ; Sun, 30 Jun 2024 20:02:28 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 023A31C3008 for ; Mon, 1 Jul 2024 00:02:27 +0000 (UTC) X-FDA: 82289231976.28.976B3B8 Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by imf09.hostedemail.com (Postfix) with ESMTP id 3DA9214000E for ; Mon, 1 Jul 2024 00:02:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KGW9dYgT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.48 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719792129; a=rsa-sha256; cv=none; b=TgpjmZZKI8RFDLWWf+mhDcRaPwkTDrGUCHTGo2wlKIq/2gkZuK5cQV9DR3ix267vlgv0Iz Hv0MpoANSjPEgNTaQvzvM54VEcmU82aCVqMjRelJX+Y7PxPrKCoWKhZx/Nb9JLHZfRM9y8 wCluUHSn2OaNqt3CJMP6re6QV0ywFi8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KGW9dYgT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.48 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719792129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bhN9AvD496DDfdjwo2Jpu2JMzYfWFg3K+lNbZSu8nz0=; b=WMfqK4JvbGLRGSvLsKrs9xjLf+Avddv1Hw7/S7LTKWB0hD10wL7hjFIu9V9q72EiF9xYYP U6enHYu/aMyfEx57JaDTKLgb/CPz6mm7PQBgSUCXYnESUiE3teRiQUNLnk4ku+ntexhWva 0lCSriD14BWp2J21q5GjqJP/w0MI6Ig= Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-80f65707b31so634258241.3 for ; Sun, 30 Jun 2024 17:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719792145; x=1720396945; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bhN9AvD496DDfdjwo2Jpu2JMzYfWFg3K+lNbZSu8nz0=; b=KGW9dYgTnR7sy0l3Cm9Qfnk5mbCBxjv/FFAGkKC0kyfneoF54rsf7w6OaW6OiiBs8n fcExwq9rpuyvDge3yfodtSo9evWyxD4b90m1yMLOWaoiHCz7FiHe/wTSiNZXcb+dvf4t MrV21hy0fJDCxkQgnbSiYQwTAtB66nH1UUBbDqVh88SwAIogfGS8xIynDASx34rlnlAQ yMHqd737oYos20vmOkfgP9hWr+2yGKbCXW3S+2z8wPomh9E2AX4nrkGl4UWU9Wqgh7fr vxIzifZciwcQBBEjrBfZy7PjSa/Svxbg0r7ld4yL4EQp3XhuuOMKxDEbPsXth7BpbWWK 2WAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719792145; x=1720396945; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bhN9AvD496DDfdjwo2Jpu2JMzYfWFg3K+lNbZSu8nz0=; b=nvgKkU/JTwPS3pNnx/bOgd7m9vgOR8EHAKctOjt6KecsaMFvoS1UyKoX7EohGk+rtV y1tK/bxuPktkGwwMHdUI3QeWokRgUUbCTvetiUqJlsL4mKW6Ixq39e+Eyi8pZffMIYZF 1MKkv+WFI4h0iEvg124iFsIE+eYxoaNfBELUsGsFr0TSYmh6YAeR7LjIlfDM+1b3NcoK 3Vyrr+9GmiYM7Gq0F8i+ap6ZbJyAO1QhPxjg8crh/y9KKUdhche3UPZpH4hwpBvKXxnT DkiOKO/ReamdiW/38oedyALfXXMPMnXXDOTAtINQiZesHa9cTb93Ut9Hrs/Ed2JtRDhf 4Ofg== X-Forwarded-Encrypted: i=1; AJvYcCWOqXCb1oPQi3kyLAsgXaWoyIsZdT5ABos3UqF3WiRZivLiHPHS5iXpBHB7zKFRSu9hHOz1gYoxeOBhU7vbMmj0T0I= X-Gm-Message-State: AOJu0Ywevk7RUS68BOPWCcMCUWkL9POY3q0/0KpFtmOQtNbMU+OZFzaX PLm8DrYTcNNj02946FfZfGDXs0hm9h2oFhw9uR+u9AxU2CfxVC4ycmc4pRDJmVp8x7M7+FxId+Y +5vQNqqExlmZSg41y7CSciMsVnOM= X-Google-Smtp-Source: AGHT+IFkYOZAIccehM4mD5dWvZy3ssCMdsjnZYfbVnoRIM94K1dOA5MX7p4didYbA0msMSHMQoipe2OMdh8UBaXpttc= X-Received: by 2002:a05:6122:1b85:b0:4ef:6b47:3570 with SMTP id 71dfb90a1353d-4f2a56addcbmr5108954e0c.8.1719792145192; Sun, 30 Jun 2024 17:02:25 -0700 (PDT) MIME-Version: 1.0 References: <20240628130750.73097-1-ioworker0@gmail.com> <20240628130750.73097-2-ioworker0@gmail.com> In-Reply-To: <20240628130750.73097-2-ioworker0@gmail.com> From: Barry Song <21cnbao@gmail.com> Date: Mon, 1 Jul 2024 12:02:14 +1200 Message-ID: Subject: Re: [PATCH v2 1/2] mm: add per-order mTHP split counters To: Lance Yang Cc: akpm@linux-foundation.org, dj456119@gmail.com, ryan.roberts@arm.com, david@redhat.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mingzhe Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3DA9214000E X-Stat-Signature: ufqweshdjnsrj51z1ggkgxgj57qjf45g X-Rspam-User: X-HE-Tag: 1719792146-511549 X-HE-Meta: U2FsdGVkX19bIy5Kai8S6YZIxcd0yX2CZdkoK6Ajk8mPolCMdVi9sICK2Y+oALRuYEc+FHRNgHI+qxBjsOuXID5qDPPqERp+AvzoDNUhRZem9e+62Ya6fDTJRw3InIoD8Qnwhr5/WAuAaij9NlR0jhasK0vp4ssolW0MMA/mNVDZ+4BHEMK8TvSxwnAfc19vGw+s2ZwXcVzapMbjyr168FX4gC/sbdOflvaI9O+kOY0TANzF8JkldIFY8731jJDVzr+ztA/yS7zORcbA4kaDpkCivHQ2WkG0WkJwWGxmvd4OyD4pd22DwV1inr7Ge7zFgCUTuCu7dOIdStv1E/gwM1Kc1BfBoj1YD0lsOkn/Kr0bnnE0i2JJ8OCiqtn8njHgdF5uHB30fIGX05pkvo5KXXxlQcXkYkuzlmFVCmpyQKabS/bn8YdQvQp8JtPw4i81g11QQQuuhFMa83PsiubXkEtOE6aYPxXfi70UWgw4vVsHK3LcZtsNECgyDyZLRnbnDoSnKfx3gNMp+0a/jISw7JjqAyhE+/1nijy61g+LuF9uPOup2CalyzuCpn2i3SvWVEabZ/OT1HzRHembRtElTJrD908eZyDyweUedoudixGwBVe+Rm//98sBlvYGH3An/tAJfIQUj//GQQ54axYsy9LHKKXJG8BefW7OXqP1rBW2PpNjjJDL4J4J+lG679SJsmxQqlBLSYs6gEGH983iU10mBWPKAVRSN0IvsnXWi5Q5fvq3DG+vjwImqDRftunpc7m4EksntvaykhxFgwV7YP/9cyE5m/rY0Mr23rt7l3v3nWb6KJmHhCDWQZ+q1/ofz1cHdmnbR/Z5+FA+ce13VD/vBhMeTMigQWNWIESLcXac9ACFksGO8Lq00tUHOykIODAdQ81EwJw7SlFCLoUt/2vzyhIlMHDNpxXHhOLUps0j6TalvNiVlt3fNE9NOJF7IuzIJsmzk97pqVpm8Gk C6UY7jj/ U3PDHZyNGhUYdMq0wTydc5CW2FGu2IRO1LO+Xm0anEYqnC1ZQW0nr+MGDX8o7tMKc0IH0XFM4W/Va/VLrqlnlRWwqGPfya3iZOBd/xhmt3h8qfr732FerCieH2RbakiB9upKxu3w1Ub5dMkGlxln594ZDgWRMIadnE3JTrxQVPfuup1TV7gPJMiKVksdVRweA7Wt0xvblsDvDR7SlEIZq6GUKnyr8x+GdNxw2i7hJU9mwZ4Jfr9T9Yx5mpyUtxBLAip7RG9i4NSzg/oOmDSpV9hX4xB6p02Gr0dFmL0Ofrnv4Gvz885kaukSGCltmQLnCnYNcMMAkIMBvMa1EhLjgXWqxPYCBYiLUQAhj0iPciN6METBqromqAGTRdrOMBgBUxh+kWKE5NvYGAnQZeg6fFPsd/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 1:09=E2=80=AFAM Lance Yang wr= ote: > > Currently, the split counters in THP statistics no longer include > PTE-mapped mTHP. Therefore, we propose introducing per-order mTHP split > counters to monitor the frequency of mTHP splits. This will help develope= rs > better analyze and optimize system performance. > > /sys/kernel/mm/transparent_hugepage/hugepages-/stats > split > split_failed > split_deferred > > Signed-off-by: Mingzhe Yang > Signed-off-by: Lance Yang Personally, I'm not convinced that using a temporary variable order makes the code more readable. Functions like folio_test_pmd_mappable() seem more readable = to me. In any case, it's a minor issue. Acked-by: Barry Song > --- > include/linux/huge_mm.h | 3 +++ > mm/huge_memory.c | 19 ++++++++++++++----- > 2 files changed, 17 insertions(+), 5 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 212cca384d7e..cee3c5da8f0e 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -284,6 +284,9 @@ enum mthp_stat_item { > MTHP_STAT_FILE_ALLOC, > MTHP_STAT_FILE_FALLBACK, > MTHP_STAT_FILE_FALLBACK_CHARGE, > + MTHP_STAT_SPLIT, > + MTHP_STAT_SPLIT_FAILED, > + MTHP_STAT_SPLIT_DEFERRED, > __MTHP_STAT_COUNT > }; > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index c7ce28f6b7f3..a633206375af 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -559,6 +559,9 @@ DEFINE_MTHP_STAT_ATTR(swpout_fallback, MTHP_STAT_SWPO= UT_FALLBACK); > DEFINE_MTHP_STAT_ATTR(file_alloc, MTHP_STAT_FILE_ALLOC); > DEFINE_MTHP_STAT_ATTR(file_fallback, MTHP_STAT_FILE_FALLBACK); > DEFINE_MTHP_STAT_ATTR(file_fallback_charge, MTHP_STAT_FILE_FALLBACK_CHAR= GE); > +DEFINE_MTHP_STAT_ATTR(split, MTHP_STAT_SPLIT); > +DEFINE_MTHP_STAT_ATTR(split_failed, MTHP_STAT_SPLIT_FAILED); > +DEFINE_MTHP_STAT_ATTR(split_deferred, MTHP_STAT_SPLIT_DEFERRED); > > static struct attribute *stats_attrs[] =3D { > &anon_fault_alloc_attr.attr, > @@ -569,6 +572,9 @@ static struct attribute *stats_attrs[] =3D { > &file_alloc_attr.attr, > &file_fallback_attr.attr, > &file_fallback_charge_attr.attr, > + &split_attr.attr, > + &split_failed_attr.attr, > + &split_deferred_attr.attr, > NULL, > }; > > @@ -3068,7 +3074,7 @@ int split_huge_page_to_list_to_order(struct page *p= age, struct list_head *list, > XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, new_o= rder); > struct anon_vma *anon_vma =3D NULL; > struct address_space *mapping =3D NULL; > - bool is_thp =3D folio_test_pmd_mappable(folio); > + int order =3D folio_order(folio); > int extra_pins, ret; > pgoff_t end; > bool is_hzp; > @@ -3076,7 +3082,7 @@ int split_huge_page_to_list_to_order(struct page *p= age, struct list_head *list, > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > > - if (new_order >=3D folio_order(folio)) > + if (new_order >=3D order) > return -EINVAL; > > if (folio_test_anon(folio)) { > @@ -3253,8 +3259,9 @@ int split_huge_page_to_list_to_order(struct page *p= age, struct list_head *list, > i_mmap_unlock_read(mapping); > out: > xas_destroy(&xas); > - if (is_thp) > + if (order >=3D HPAGE_PMD_ORDER) > count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAI= LED); > + count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_F= AILED); > return ret; > } > > @@ -3278,13 +3285,14 @@ void deferred_split_folio(struct folio *folio) > #ifdef CONFIG_MEMCG > struct mem_cgroup *memcg =3D folio_memcg(folio); > #endif > + int order =3D folio_order(folio); > unsigned long flags; > > /* > * Order 1 folios have no space for a deferred list, but we also > * won't waste much memory by not adding them to the deferred lis= t. > */ > - if (folio_order(folio) <=3D 1) > + if (order <=3D 1) > return; > > /* > @@ -3305,8 +3313,9 @@ void deferred_split_folio(struct folio *folio) > > spin_lock_irqsave(&ds_queue->split_queue_lock, flags); > if (list_empty(&folio->_deferred_list)) { > - if (folio_test_pmd_mappable(folio)) > + if (order >=3D HPAGE_PMD_ORDER) > count_vm_event(THP_DEFERRED_SPLIT_PAGE); > + count_mthp_stat(order, MTHP_STAT_SPLIT_DEFERRED); > list_add_tail(&folio->_deferred_list, &ds_queue->split_qu= eue); > ds_queue->split_queue_len++; > #ifdef CONFIG_MEMCG > -- > 2.45.2 >