From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCAE9C48BF6 for ; Tue, 27 Feb 2024 02:12:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24AA64401D8; Mon, 26 Feb 2024 21:12:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FAB444017F; Mon, 26 Feb 2024 21:12:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04E064401D8; Mon, 26 Feb 2024 21:12:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EA0A444017F for ; Mon, 26 Feb 2024 21:12:55 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9668214091C for ; Tue, 27 Feb 2024 02:12:55 +0000 (UTC) X-FDA: 81835960710.24.19A75F0 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf14.hostedemail.com (Postfix) with ESMTP id EA474100005 for ; Tue, 27 Feb 2024 02:12:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hGK1zsrQ; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708999974; a=rsa-sha256; cv=none; b=lIGDwRrZbhx5JG6qZcBGepA/0kRsmZgd0Msw+uVvCeXHuC8tHP7tu9hF/RacsoPS+orUx5 jb6IX63ieuOJzvGiS6znHsL/IWlJ1YzrdNCGjZjfwf8ZTDLTff3ftFyu+r8i2EAQ8xw/HN djCklUq4f2Bu7EWGczfS13jkOUZFZsg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hGK1zsrQ; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708999974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p4AL21Kby9XJrGNwCYh+T8ly2jOpVTK59tg/4cTmKhs=; b=qgD/H5wZ9FfgRmeUgQ1P/AgcE/ODh8BWmI39YuV1xIVEGL2jyaIABs0T5UDj1Z5SAlW4Nx jsQ07y5ldIO6gL3lNn2Vdbcyr5cVluy1UR2q48FCZvGBI7PBWP4BSmDUmWUpKncjLokOi+ i7muZ4oZ3bj5zYX9MNkujEREfOlCdRk= Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-4706de5227aso537734137.3 for ; Mon, 26 Feb 2024 18:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708999973; x=1709604773; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p4AL21Kby9XJrGNwCYh+T8ly2jOpVTK59tg/4cTmKhs=; b=hGK1zsrQMs6okrBkbAZnr3dx6CYUXiXBA5FM3nRP3gB6mvNOn2YHAyWxdYOkiT4AAo 8eVaqKCaArsVNHkM+Bta5zZzYW4uhzhz67nyvEmofR7k4fXLlv8GQORMOceB/d5Ad0B4 gJlPNyfOKk2PW3MSjXB3c3RFPjB9uXQd/Ss2OdsFpvhYCd9vBF0mGdZf/x7wv+Am6X3e JNhPQU0V/3PvElTkT8cZUN4ZJSQREQc8JsUu0DNg6qdUtiDSbHRSFCEK/XMvNNoTOhl1 qdSWhI5l9J9a/uTne7z4V0wPQzwHP5U6T9jS6InFoKhrmwynwQglaRFWgkqdFluzJVT+ 0J7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708999973; x=1709604773; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p4AL21Kby9XJrGNwCYh+T8ly2jOpVTK59tg/4cTmKhs=; b=k3emxATWV3jQvGcsSMrlzRgTC3L8jcT542TaiRLh3SyKK1+RTUeohfRSAIN2uUOyx8 +ValEL124odJjGhq/r1xYSUYh/9++4jLzi/Q/4f25tvMBFCIzVsHhZoHFUXHSJvn/taG ozwB++MA7h8F+rnnLAsKMeqtLItvrvLx8Rs74CiJC3DAoRW/rjV8zxXhfPe+LJoZXjmX Zv/mVv1ME0VNX4j/BGvr/JDfeQ7S6wZ2N2sqKDcOzGZAjOHAl6eWLAFGkwlzoImbzI/A lzPiqKhCl31cyeyBEXoR9RtcLO+WZOtPdEutMnupyJyhRov8m2esV0MNTENIiW0qR2dv lFPg== X-Forwarded-Encrypted: i=1; AJvYcCWhUVbDKJW2JNxlqeO1i0zYjMQS7WX9qxdlKMMaxN+78y6FnZRPZjdXWcA7GKEGD/xQOgtJJ9L4/Ep2lIGVX0rs4u8= X-Gm-Message-State: AOJu0Yy/miSiFgor9TP6MYUtf4NSmXSSstK9ZdkiP4lDZ4RGHybznKjv i9US7UpgzZ9TQEq3IWYXLumUxKbA122ZuFqCVYh4Qc8Fo0MQ71YjCJRRDtJa0pabPgJVyBO6mYd eXwi5sGWTDfdJf/exJH6RggALiN0= X-Google-Smtp-Source: AGHT+IEn9Q4OROYSWs3z77bMr2noi6omg7s7GADR2IZlrTVeK6Mo0tUALc2VX5D7GtWTnunpuNiVz/TfwXUSzS2nl54= X-Received: by 2002:a67:fc84:0:b0:470:3afd:81dd with SMTP id x4-20020a67fc84000000b004703afd81ddmr6274013vsp.4.1708999972959; Mon, 26 Feb 2024 18:12:52 -0800 (PST) MIME-Version: 1.0 References: <20240227012127.174048-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 27 Feb 2024 15:12:42 +1300 Message-ID: Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free To: Lance Yang Cc: akpm@linux-foundation.org, david@redhat.com, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, zokeefe@google.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EA474100005 X-Stat-Signature: kpejujttm5c3oyquttye9jdag7mmfxsm X-Rspam-User: X-HE-Tag: 1708999973-161663 X-HE-Meta: U2FsdGVkX19KLP5t87WHDdPmQxyJz8IyV1S6Ph6GfHnaLbFCEYel34+qdbUdEPt6HO3s49VY3a+LmNjkmK5EyKDONjlMz1fjxpeSnq5ehOZuqDhnGMZK2V6q2yagUJNAuaPINW+dCBMKVFZYZhgszfzwo5dYW6eTLOvu3oUmkSzW6Zx01FJZUhA2S7kwUzCmVIrJiHUzZQBvcyNB3CKuvBHSYp6/9aHTls/Ezf2SeyDcxnZSvIBrTSXecP1+K2IFfpzrQZGVnfEw3L/v2nIRDZgk+s7ud7uLqSMJeJOhUbVJ5B2frxSa/dKE5by/3hHAqMKYHx3+4fE49ZPoFpsRJxIyRjUoiYt41HCUnEyX26Um2bM/RCZkN3oRns3asmQ1DMetzYCAFRHONtT0QjCku+BukIH3XQpAq7uK/Pt+gtv8qUoaRUDwVTUTuocMZRsEshMBiga1NwnvEEKTA88LD8erpMm0aJNEW29hA4Oeliw6sPPY3TTnHCnmbfBfN1FJjCA23MxC/WDELz0cCSfiWD7gXlF/Xlf+TvORUGnqnzYF6c5pM3qi+dOHE1QzokGOiXOeTQ3HPZw++dZwudRSP33zb2Nnwj9ge2DD2tXDIRaixL6TSuEvizO47WdjBPAfo8VkFjs+niAwtanJ5teOVVNk2lLxYeuJa0ECWCKt5peh/takUfwjVc83vq6WmuOU4NKPwUj4S0HPyDDN070mouQpO2dsiqfjPWSicr8WL7e7wNnPm0VRrPkZd4ZBJmh8YPULuf5wKDd6UfV/MFcn5O339xdVfgjk22Fj5wwP11qFNoa28pD2ZAxFS6yNoFgF7x9KCm07lCliNcVWZ6QKW/0+vjaSlqpBAyIrFIVkoWSocniT4G0P3+J7SoqaEYzQV74fvfMx0Lhzd40XB2V3i4Mj48ob7sppOl1aEeduZwm4FaGtOsJ1Hsz/RhZmXsyvIR7vZXwdKm7SMWaEE1V clOBu+/D 7aCnqHQbSvpm8hCmj6dyCh7s+MyWvxqAVW08B6cPImHoze//98xGlLTNcM94X7riUL+nQYtTShVI2pxp6lu4JjeJh0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 27, 2024 at 2:48=E2=80=AFPM Lance Yang wr= ote: > > On Tue, Feb 27, 2024 at 9:21=E2=80=AFAM Barry Song <21cnbao@gmail.com> wr= ote: > > > > > Thanks for your suggestion. I'll use folio_pte_batch() in v2. > > > > Hi Lance, > > Obviously, we both need this. While making large folio swap-in > > v2, I am exporting folio_pte_batch() as below, > > Thanks, Barry. > > Could you separate the export of folio_pte_batch() from the large folio > swap-in v2? Prioritizing the push for this specific change would aid in > the development of the v2 based on it. I agree we should make this one pulled in by Andrew early to avoid potentia= l dependencies and conflicts in two jobs. > > Best, > Lance > > > > > From: Barry Song > > Date: Tue, 27 Feb 2024 14:05:43 +1300 > > Subject: [PATCH] mm: export folio_pte_batch as a couple of modules need= it > > > > MADV_FREE, MADV_PAGEOUT and some other modules might need folio_pte_bat= ch > > to check if a range of PTEs are completely mapped to a large folio with > > contiguous physcial offset. > > > > Cc: Lance Yang > > Cc: Ryan Roberts > > Cc: David Hildenbrand > > Signed-off-by: Barry Song > > --- > > mm/internal.h | 13 +++++++++++++ > > mm/memory.c | 2 +- > > 2 files changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index 36c11ea41f47..7e11aea3eda9 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -83,6 +83,19 @@ static inline void *folio_raw_mapping(struct folio *= folio) > > return (void *)(mapping & ~PAGE_MAPPING_FLAGS); > > } > > > > +/* Flags for folio_pte_batch(). */ > > +typedef int __bitwise fpb_t; > > + > > +/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ > > +#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) > > + > > +/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty = bit. */ > > +#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) > > + > > +extern int folio_pte_batch(struct folio *folio, unsigned long addr, > > + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > > + bool *any_writable); > > + > > void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *folio, > > int nr_throttled); > > static inline void acct_reclaim_writeback(struct folio *folio) > > diff --git a/mm/memory.c b/mm/memory.c > > index 6378f6bc22c5..dd9bd67f037a 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -989,7 +989,7 @@ static inline pte_t __pte_batch_clear_ignored(pte_t= pte, fpb_t flags) > > * If "any_writable" is set, it will indicate if any other PTE besides= the > > * first (given) PTE is writable. > > */ > > -static inline int folio_pte_batch(struct folio *folio, unsigned long a= ddr, > > +int folio_pte_batch(struct folio *folio, unsigned long addr, > > pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > > bool *any_writable) > > { > > -- > > 2.34.1 > > > > > Best, > > > Lance > > Thanks Barry > >