From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4353C021B2 for ; Sat, 22 Feb 2025 06:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 344986B007B; Sat, 22 Feb 2025 01:42:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CE1D6B0083; Sat, 22 Feb 2025 01:42:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 148A16B0085; Sat, 22 Feb 2025 01:42:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E22866B007B for ; Sat, 22 Feb 2025 01:42:08 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 54CDE1A078E for ; Sat, 22 Feb 2025 06:42:08 +0000 (UTC) X-FDA: 83146635936.02.A298F59 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 6EAB680004 for ; Sat, 22 Feb 2025 06:42:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mlIfjWmm; spf=pass (imf02.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740206526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oSaxQxuNaNvr7jWVenpv73vu1UWmnwa+JPv741TO9K8=; b=y4/mXslLFr1yfHRIsmhqBbjkqQNcWHHMn0GyadpDlgR7fTNqPk2ETSfATwgpr8hXcKmWN2 YwnFNrszwlQ9wpw3mEJQXbdt2R5JPQ3JaRy0c5RV5jP28ScmZOkwmzZkxfcni5eRysNq5I YVWJsE5YnZBPrEDBS9447hgxI2+ks1I= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mlIfjWmm; spf=pass (imf02.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740206526; a=rsa-sha256; cv=none; b=H2kG6podNjdftPMEcCVGhZuT7XQI7mZVNKIptBep3Ewhhw7/DnwTuDOaAmKlY2QFCJTWuR ZpY5Y+JFTUHle9HuAyVJrViMfbRxF8E/cTzVy+zr6w4J2y4ao8JBDAeOvj/eSvBvcglAiG /0Ihm++HbEpE66moEgwUp8GcrcqphAk= Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-868fa40bb9aso827333241.1 for ; Fri, 21 Feb 2025 22:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740206525; x=1740811325; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oSaxQxuNaNvr7jWVenpv73vu1UWmnwa+JPv741TO9K8=; b=mlIfjWmmTKPnLtyyHbzQ1my3ipgJuHTIVy9PXz9q7qgle6RtbVMbSPYZVl5/ZR5Ss4 nD577n/mOWYq5pjy8E+EfuWQJJt+osC6J0T7zcmEV3a3199oMgTLeMKh3j/G/uQkmKRm QKNLYz5Kxj3xnsa/mij0GVGSLEWPwq/7yQlhR6iOmEN6wCMYHMIqpJcHD65aqvFv+ECZ C+2SD8E5dwyxgdC7PUB8RFf7jbehu8dGLByDlRmSCQdRQz3ACJsgqqL3FpyPngXlcJZn NMxkLsJtBVCX/f2cfEtpiQfqcb86I4C0y2/RJh8i5GA4ruYtdv7BPHm3vNJQjlj//smq d0nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740206525; x=1740811325; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oSaxQxuNaNvr7jWVenpv73vu1UWmnwa+JPv741TO9K8=; b=n+MtMkQRiLGqeorwvaDN12CZHwpvmowCgn4XEp/pTPAooArQoIKcK8Wwdok4Efi/Md ONJeHyvfZ6M6NFUPD6NcN6uql/LoAHNv0EnnSF8XrgzYWVbFIbNYx3zWaNEhYRrOy8Ao oV3Te7Qln1wdYO3EXtQiRBGZBtzHlP3kC796E/HJ9uDQx7ncUFxk57+qUsp2hg1KBGX2 f+TyfL/Z/Cu38sQw5wuIR+jTDf5moiso35omuXB/S4rEIXKt2w7oiDui1hsl8fB0hT0g gnQnesl8D14ieKcMpaX1Iv0fklnZinHkxppxEL/VNRucvsxN9QpIiHliSPvAWEGQz8SM ykgg== X-Forwarded-Encrypted: i=1; AJvYcCV5i9h2K4ALF+ETNLT0BFkdZw0jEovpEvthlkraA7+/ijtwCCDs5cGCOa098UxTnnOuBXBF5WH7RQ==@kvack.org X-Gm-Message-State: AOJu0YwLjs6qpE4Wp8U8RfraPI4eythVUXTTPmglH6keipeU2wOV5hhu xygL7L/zOoyZJGw44O6CIoxgJKh/YOh7DGTSIcB/KvV8HNWakIouBqPUa/Xg+c7ZLezMqZGXvFP SzGBxcFL2AlObOKZlulimkwFi1DEtJrArV60= X-Gm-Gg: ASbGnctRk8dlF/KFj3B5xdYkL7evusWs5zX0WVUyWw/VwCeLKzmnmlUJtrLMqcOsMuS 9x9mHsG18xjafCiRbPSYEWvbJo6RyqnkTLZjt2TFbJAid/NHaiedazq+naawd2S3okwoTgSFDS7 5l8mtrk8Q= X-Google-Smtp-Source: AGHT+IEUveAywgoWbMJcZ+6O4ktIym5ZwsXDVoeqsKfYbVBdGQ5yMATuk52cuIBEm+9iE2WyJ3mwLcLO0F2UQof7bng= X-Received: by 2002:a05:6122:2027:b0:516:240b:58ff with SMTP id 71dfb90a1353d-521ee290f48mr3236184e0c.5.1740206525299; Fri, 21 Feb 2025 22:42:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Sat, 22 Feb 2025 19:41:54 +1300 X-Gm-Features: AWEUYZlmcDguna01sojniDrQEtisK2vBnZybWqL2k4nT4V6CyMWa08LH70YV7m4 Message-ID: Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. To: Herbert Xu Cc: Yosry Ahmed , Minchan Kim , Sergey Senozhatsky , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6EAB680004 X-Stat-Signature: 4uqw369dkuzrfa6rpfwaih8aifmyans4 X-Rspam-User: X-HE-Tag: 1740206526-97635 X-HE-Meta: U2FsdGVkX19xPk22RQN7Y8PkmGDNFYfuqa1acnrx/nQ8DFo24mVzid7hcR80cE0wjWNZehxNRi253ZUAGDTqkTnyTpZJNErgk5WA9CepMV66JXs9ZIACNXTL8us73vE5cUXns5dYBFaHvHFKheVhkRR3d3y4F8MUhTcmlkNM7Bd79yvAKHZMXYfwiODDGbzB7Au4Xw97wUjpNzY2ZFeXQIcRWO14K52G/em+/gYtJ9+YLD22kngkbHs9iIAwbNn32pOeAKk1n8cYewFcmntSxPXfbUMqs6raWfc1yGcVyh2mz5/Km2pV+LHMI22kyjv2hKTIcX9rx7vxuZa6NcfMdiMzXXJPs83vvHwpihj8Q6Lm6N2XPjo/f99rRkrF4GSZHYUXmLsvb/52vj9VdMOISSKp6xcCJHdLIWsy8IjzbJ3KFacW17HKp/GcZn83w4lpb1MhvFrZhl02XR+1uz+ra0FH5SUIRoyduQjGSq6iP6sa03OhNmzHuDHICLfP9z8vjE0hHjPPkPScoLKXOhNGTLAk5BKnWLnZ3/wTK4RAzJhrVOQOhuyjXNIUELTkLKnLEx71czhHT7LwzwEwT7oYA6i7xblaGAKeEse+N8uBhcZc0myV9Gk3PYW9XUWkJ0gBgbe9kRvrZKrdTFpgjGK41kEbayJLuiG02bXXINwe7uzUHqfMU6y8rTjZNGCqwwVcq8ds8cJsoQhREwYNv+vrdTfmuiTx/pWbQmxDdnr5zaL9yDwYKLglVcMqxweqcq66In2m41YSM92im5RI9Cxk8Ht2YonJK2OS6UN2sYcKU4Tu7s7PKUdVHD5xEB9nTRnXcFbpxbzMPdhB0gHzxnNOr6aOe3Ho97KxEcqzvjO4xeNR+Iq7vN8JDcLPlJQyz/fpRmAsfzEkoizAFzHTNH5m8uLqhCtFUVLjNnYMpOiCDKS6CdqHfTrHa2iebbk2MNEPFsmbUoC51xssT22gsbL r2d2fSkF G3ztDYM0Dyk5IvkCnCIKv+yUWOqaFYgkZSbARFNSUOAfibRhZFL07ugxw+nOxix8Bl3MJPcv2FDg7VuBY00pgmWcXGsqpkFY9KTH12zurcm+kl7grDDwx6rNe25vw7lfJYyz6chS/qQy6ay5Db4ThwTT9Yc79zf/6DqAb8oVeVmz0fMD+gH7C7L9RgKdvOq5EgRCebKZY/n/9ffDrihwJ3kmGuoG6CAksMGKKjHu5+Bfys51sQH9eoszb02bybZ/kh5hFOWSxYeYhsqPZ4N+N74r7DcGqvd3UY4Ynv4+/kD7ud/ODBfuPeSFLErSEfOCUauwsRvFgO/qLQ6szKByClzYug6+Sk2J3zwyitQB/o+qGXJbiNb2n+Qor4kGLiRUzd8wL/DK+ay8MRWjTa1UdiZw655JZnp6gzq6molLxDXLSGlE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.029984, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 7:34=E2=80=AFPM Herbert Xu wrote: > > On Sat, Feb 22, 2025 at 07:26:43PM +1300, Barry Song wrote: > > > > After reviewing the zRAM code, I don't see why zram_write_page() needs > > to rely on > > comp_len to call write_incompressible_page(). > > > > zram_write_page() > > { > > ret =3D zcomp_compress(zram->comps[ZRAM_PRIMARY_COMP], zstrm, > > mem, &comp_len); > > kunmap_local(mem); > > > > if (unlikely(ret)) { > > zcomp_stream_put(zstrm); > > pr_err("Compression failed! err=3D%d\n", ret); > > return ret; > > } > > > > if (comp_len >=3D huge_class_size) { > > zcomp_stream_put(zstrm); > > return write_incompressible_page(zram, page, index); > > } > > } > > Surely any compression error should just be treated as an > incompressible page? probably no, as an incompressible page might become compressible after changing an algorithm. This is possible, users may swith an algorithm to compress an incompressible page in the background. Errors other than dst_buf overflow are a completely different matter though :-) > > I mean we might wish to report unusual errors in case the > admin or developer can do something about it, but for the > system as a whole it should still continue as if the page > was simply incompressible. > > > As long as crypto drivers consistently return -ENOSP or a specific erro= r > > code for dst_buf overflow, we should be able to eliminate the > > 2*PAGE_SIZE buffer. > > Yes we could certainly do that. > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > Thanks barry