From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E720C54E58 for ; Mon, 18 Mar 2024 20:25:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CACC28D0001; Mon, 18 Mar 2024 16:25:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5C9D6B00A2; Mon, 18 Mar 2024 16:25:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFD2B8D0001; Mon, 18 Mar 2024 16:25:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9CA086B00A1 for ; Mon, 18 Mar 2024 16:25:25 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F7B5C0A5B for ; Mon, 18 Mar 2024 20:25:25 +0000 (UTC) X-FDA: 81911289810.20.9AA95E3 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf13.hostedemail.com (Postfix) with ESMTP id A271F20014 for ; Mon, 18 Mar 2024 20:25:23 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z62IY7z8; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710793523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yh13/+xplAtGooEGPkIeg18n7lJuselZGYLiwqNgbTg=; b=lL3gqHd5bq4p39KgdLwxHDvBAl6j0mZAR+VO6RR5rlbaOh9WgZghLXxTEFAM5xQZC39wt6 cvBlVLXgPooRwtVHkZtnwGdH8W4S0dW0iT/0lBTjmx8OEwb9Sy12AYr1adsbIip4wrAdMI 06d+vMX9SkwHYT0FdmT1o9Q/SmHP628= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z62IY7z8; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710793523; a=rsa-sha256; cv=none; b=j/7do+RqsqZ5SkGKTFwkpo6Q1/BairhJs4hgQ0pH/HsugCH0NgWgiwpmhCW617Pg8868xs oaf2LTWvWWe5TNe8NMh9xhUcuDRZW1AhKvL5c6tXkv6x1j5K1DwTP41Y+rnDa4VEsxaSnI dD+fNgeqh43dmwPFSoFoHP/y9S5N1aY= Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-47651248841so1614088137.2 for ; Mon, 18 Mar 2024 13:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710793522; x=1711398322; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yh13/+xplAtGooEGPkIeg18n7lJuselZGYLiwqNgbTg=; b=Z62IY7z882TxYt16qmNehOO9VCpuFRJyX08cbJJH0YTT3+GofFa6r78yOzzgUgGXBh FTGyhA1QEE1O08MtrplF5PDWAh5Mtza34lgw1XgH1K4tVV0AyvdYvgZmN9TYpxt9z+QN dVSCj2rZMD3QufcIxuCyo+LdhzvQP4H9T6voTQ0nZSEQVUkD+OvNz4wXn+9DI6uf54uE xyWqUrKD2at+pAob6v4JqIXDMXFikqWgILfzmK20YbzmJ+Xz4sYtkFvK6WfKY5IwVZo1 ida1v9aPVKObazA7wzpP0MeHh9XDzzvDK01mfi2hQqfP7dvof7k/et09ekOV8RatBQST Mqxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710793522; x=1711398322; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yh13/+xplAtGooEGPkIeg18n7lJuselZGYLiwqNgbTg=; b=etQEjx8dj3H2hLuwwl5a1LWwikxc40pk3WdaQPy9d3YfnpiFGODhCEKWyBIy1NShUT D/z8E1rIrk57D3VdrKyovb80A0sJ8ZHWoIGAdNtrgqwFVJuae+G4Nn+IZswVyvQvwKgA tKVdBIU953jVyv0NqCFw1vj2TOxC/DkqOobY9YdsuYJ8AYFb2va2XXhZPwKFup0xv2FC U2t3oOCI9vrMYic5tr6mbXujlCOhnETWbMsPYtJPECR3ZgfZ0lirhgQqLa1Uhr4db07Q nxPzzJ8aS89VVYd24e6Dk+Xpb4ZHUMe5WXj06vrawJZUDpWNqOkQzNZ7/DlelX3H//ba b0TQ== X-Forwarded-Encrypted: i=1; AJvYcCVRaX48ubaQUZC4kEyN3VDJgAq7CNGI6kU2hTVgm3h8y7TP6ls698+LvIKFDmfDHXvyZm1RKMFum3eM+w27opCA/wo= X-Gm-Message-State: AOJu0YzBGSuJfBB7HkSurDmfgNPn5f71hmJ/JPcMhGc3dDxZDpt0TZQE bVBBDjK3k0msXMg5yBWg581zza2Xh/NHPYfyRc5NovqE9jht6wc8fWog+zYaIB0WUOeS3DR3zWn 2Ag7yrTvZ+rmjohcaZLvxloWPFDU= X-Google-Smtp-Source: AGHT+IHD+hGP/ZN8Jo+jvJKOM89hWwYxhbzHH5KX8yOZkQv9N4xi/9XSZZLwCnxJaXCwqOIP+t2YDTUGZUKmUo9UWvc= X-Received: by 2002:a05:6102:216d:b0:476:9727:b810 with SMTP id i13-20020a056102216d00b004769727b810mr1611089vsg.35.1710793521127; Mon, 18 Mar 2024 13:25:21 -0700 (PDT) MIME-Version: 1.0 References: <000000000000bbb3d80613f243a6@google.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 19 Mar 2024 09:25:09 +1300 Message-ID: Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one To: Nhat Pham Cc: syzbot , akpm@linux-foundation.org, chengming.zhou@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, yosryahmed@google.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A271F20014 X-Rspam-User: X-Stat-Signature: 6ktwaadgw8wjwb8hh88tw1xsn18f4adc X-Rspamd-Server: rspam01 X-HE-Tag: 1710793523-773581 X-HE-Meta: U2FsdGVkX1+ph9LyvRi5B/vRnhcfK5TUxJUW/bwP9C3wp+4LpAcsI66loukbWoSGNMKwp0zr1/QYLxiIE+nSX8l7HzD0isIi9qggGSfBfUS3Gf7OZopQQCyzfZ10poriKEg1mXvfOBLNToCcT3GYL1tkLBOaAzNBn20mX3gqcEmNfLWwwcG4PGoK+vWGpOTjc40VyOkUXCXk2qYgZHNa4kslk4pCvP2te1Ah3Yzk49zV+rJwuSMNqXVbQYYCRnJSYJF68y3qOO9p+trYGnpsEtJQ2vNhzQBru3BLctNAdY3S6wVVL7TXMMPgXE/j++3VAMvY2dbe7/RVmBzXHBFMhnWbdrWFEXOzvkdXBo8dN9McoOuS5KzoGDP1RegRFcuqulqN5brty5QmMWUgrpQeU8LY6BlISJ9Mb7twejOHRnK8xcJ4F3r5o/Aw3OKNEw0+Q8l51GsNh1vqkfl6tLWDbKhy+yBQdYLvzgTDAAfZxGwcyj+xgVQjIdO92pC5OGQV2aNAs1mk9GreV8zZutea+P9m+C2DVcLtXW9vwMJlhg2wqtVa58mn5ETePrjr9O4e9PPkFs9p2tSdHtbL060VzlU3dWhOT2BR2yLa0xQn9iVDAoW8syRZlxOpUA1jcgeuoMy+syN08Lzx3enbWtPLxqIUKS3tiA2aRc8njKe24clYuCUkEzwXy+SdIiUH13Cbg4B8qotcFKHk9pXZgh9Ehj7qHN6uNB18V5+oMGW7n68qbwl1rEq6/EwsRUrcd/pIWQrcj0qMyWFBAcfNeUFE7srNoe8vo8VcmncxsAqHe1v6Jphw9rLbNB3chQIZtGkpTmA9Da3hHpfRufQ3eUvtdLmHWBYNQdOrg/eZBaPuVv8GQ1CeUSHqlh1KBq9InJfCTipDhVzFhKzB17z+BQxcPtKu2xE50/dqcW1LXvauaHoH6f0xm9FTGrkzWDkTH7YJinVCaOGOLQO3GotdwmH MOuFaR9d YtI9lY6NmwG1ir33haE8VyqKZzWx4TcfpHVcnp8to0MxxMHQILuoZHQ1lOTfS5AqMK0gw4VIYvDJSYDsn4dR5PPXM+0A30mzYFO54XLbAzU1w0DJUSz/Mc2n3kyituTZdOvj3PZECITCqqsSMg/Ug1rmjPsQJphGwvjoEFri4xXFHLT8o53WPgUorFvRHQWQknpclcRSiymf19+8DNQo395EDjImjvR2XMIxxkaSATSdtya3QqfYJMK8jk66T9L8fJcaFPvfAteol2gEa2Xupxaq/LxX64fmeYR2GXjSJESUBkRz80zgnlDupsI88Mjai7GJZKV20IvRxkKFpAIaaExW2Q4XP/aXsjqtyJeixNF8LtzwCgX72lbu2Em3pGs0d4lWXUEk28tprQ5sc5EH3xf9GM5pLv9Sc3Kk0L2OVV8LNLeEEjvhJoVhCsACbNMM/UKAPXh9FlMInzuCqehJmqiT450RDQRxqOW1upruVE0T1n5yNNkjldDqGC6jBVQnLuK2DjQv6CM8oB/O5lSZhDC1exnAIkLjbckEfDTuoX7ztsHk0yMc+eq2sQCv/ykoCUpgTFSwjDbP95JARi10L6jcAdjk/ovfbFDVrH7du7Az5akTwrfuZ4HHLuMEGXaicPRE9JKipjB4BnQ2veTzDLd2ooyMpiXdYsr4bp2zBVLDLqW1FY+RbcgS8opWCChZ6DbNv9+9I6EFJMODdUC4Cp0CXOZjBeF2F0sOTrl8xwfbkZ3ivfMLcN171HIiyWqckaBMGJOCCRxI1yCX0maGQQi8a8GAaP7VMrVJ0ohJKB4/d1xkZLLNs0O1BnfFNA+E0HIYvJsx03NMFc823QQ9juTB30D1yjC1eptB5cMuuhQdGiH/DiAwIexCYZ4S884Ll35J48v47uHXkLd1taemjZm//9FTMx1TYyTySb5tvzlnKGApKR72zArFTEZlC8p/B0qMCPMcSLRUiRNdlDDrHk/+XNvNr ol+3WUUs Jd72p0V9VxI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 19, 2024 at 7:00=E2=80=AFAM Nhat Pham wrote= : > > On Mon, Mar 18, 2024 at 9:58=E2=80=AFAM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: e5eb28f6d1af Merge tag 'mm-nonmm-stable-2024-03-14-09-3= 6' .. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D13043abe180= 000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=3D19bb57c23df= fc38e > > dashboard link: https://syzkaller.appspot.com/bug?extid=3Dadbc983a1588b= 7805de3 > > compiler: arm-linux-gnueabi-gcc (Debian 12.2.0-14) 12.2.0, GNU ld= (GNU Binutils for Debian) 2.40 > > userspace arch: arm > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D1706d2311= 80000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D13ba7959180= 000 > > > > Downloadable assets: > > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets= /8ead8862021c/non_bootable_disk-e5eb28f6.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/0a7371c63ff2/vmli= nux-e5eb28f6.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/7539441b4add= /zImage-e5eb28f6.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the co= mmit: > > Reported-by: syzbot+adbc983a1588b7805de3@syzkaller.appspotmail.com > > > > ------------[ cut here ]------------ > > kernel BUG at include/linux/scatterlist.h:187! > > Looks like the provided buffer is invalid: > > #ifdef CONFIG_DEBUG_SG > BUG_ON(!virt_addr_valid(buf)); > #endif > > which is "src" from: > > sg_init_one(&input, src, entry->length); > > Looking at the surrounding code and recent history, there's this > commit that stands out: > > mm/zswap: remove the memcpy if acomp is not sleepable > (sha: 270700dd06ca41a4779c19eb46608f076bb7d40e) > > which has the effect of, IIUC, using the zpool mapped memory directly > as src, instead of acomp_ctx->buffer (which was previously the case, > as zsmalloc was not sleepable). > > This might not necessarily be a bug with that commit itself, but might > have revealed another bug elsewhere. > > Anyway, cc-ing the author, Barry Song, to fact check me :) Will take a > closer look later. I guess that is because on arm32 , we have highmem but sg_init_one supports lowmem only. the below should be able to fix? diff --git a/mm/zswap.c b/mm/zswap.c index 9dec853647c8..47c0386caba2 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1086,7 +1086,8 @@ static void zswap_decompress(struct zswap_entry *entry, struct page *page) zpool_unmap_handle(zpool, entry->handle); } - sg_init_one(&input, src, entry->length); + sg_init_table(&input, 1); + sg_set_page(&input, kmap_to_page(src), entry->length, offset_in_page(src)); sg_init_table(&output, 1); sg_set_page(&output, page, PAGE_SIZE, 0); acomp_request_set_params(acomp_ctx->req, &input, &output, entry->length, PAGE_SIZE); >