From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4810BC83F22 for ; Sun, 20 Jul 2025 23:44:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD81C6B007B; Sun, 20 Jul 2025 19:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB0A46B009E; Sun, 20 Jul 2025 19:44:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC70E6B00A3; Sun, 20 Jul 2025 19:44:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B95B06B007B for ; Sun, 20 Jul 2025 19:44:53 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 809C51DAB15 for ; Sun, 20 Jul 2025 23:44:53 +0000 (UTC) X-FDA: 83686275666.27.C85F162 Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by imf29.hostedemail.com (Postfix) with ESMTP id A4DC4120009 for ; Sun, 20 Jul 2025 23:44:51 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Kb57ZVys; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753055091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+LBnzd3v/hpHhCUNhojeHVoFejEzEwc/Hd5UG60oSVY=; b=6V2QyPDn66jL60XmczsysY4sN/y+icidkvS0iZihCqoAgBGeBdAeNkMs2fHlfWqscrN2eO T279gh35aP2EN1A2hQM0/Pue1dCoXP9JElG1EiGNtir4VWyWBowtwwdGzEnlfe2b7io5y3 90HaqIkRgE27k/LdpjICvQfEhJsgk7A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753055091; a=rsa-sha256; cv=none; b=q+vbkBzYGbOFmYVXGR1IUUpr0a26JPDqxL1piZhjL9cjjbMkNwSBteQG4IjUl8uX7Hx97g nVP7ZexaBqXIN72CoDUwn98DcImXBpltf/AxGORtjoyCLG2u9RIafMsAOXFPERp/qJN1Zx +Bn5gC2EVLLlU/qopq5Rk1Y5hLbWMp4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Kb57ZVys; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-87ed3b792a2so1882623241.3 for ; Sun, 20 Jul 2025 16:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753055090; x=1753659890; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+LBnzd3v/hpHhCUNhojeHVoFejEzEwc/Hd5UG60oSVY=; b=Kb57ZVyshQIN/HXTQF+ZHHksuipGKLkumQtD+fB1pw/aP9Up5znBWqLQPI47W23YCY 3ij0yq8L3SxkBKVkcdfpn6r1nNjdqNbhmZtA9hv8ukrlBm8hRMWn/nJ4nA0FCaaVF10s ewmE1C7k2/kNRucxHXSntH2u7ArtFxOQHno1ImEHWcjqCkanORgTVw4aiQpwEraa9M18 RH8aP0rG/IzLQGvCDuHb+2jChEf97NFk6I+uSyrWq6ksGXa+ozYtNVmaup7HbB3kiiMo cI5x4/NyMLL/9G711o8TMCYPpIbrq4O1FmEoKUquIOZmOh81v85YJ0ClYIWjBknJO5tf WJlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753055090; x=1753659890; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+LBnzd3v/hpHhCUNhojeHVoFejEzEwc/Hd5UG60oSVY=; b=YH4Slb3RlMGhkRCuTxC7G6/mDeew9RI+ZXSg+I494RN2ELScn9YIEKyBtfTFFaC2et bTESSIDp2gWuiM4ZTB3/l+umYPOsD/gi3Xnr/5GDUMoHtuK2YQrZcs4GxpOdoxT5F8tf yBemlA00tt+2vsi97nVXVY5j23NS7B7SzIKMRTLhv/j0gsD7JjGBUpfuPwMBZjsm5pDn CB0QTmaGj4TCPzU00dH7UBowabWDuTWyQN0M91NPp/+/KNz810QblHOdozbIqU7R8aHm UEuXYO0N+sXR/9mY3+bguKiUZcJiGYlmSh3ntgniww0/gpSNyEu0M45QyvkpKWFgfv2N 7YiA== X-Forwarded-Encrypted: i=1; AJvYcCUZXaum4uQlFnS2ZXXroLzkVVwjIB4Sv4jx8dCIL8d0U9qrHuz+yaB/tgfu5hl/kdqRO5Cnc0HLhA==@kvack.org X-Gm-Message-State: AOJu0Yz1qzwc9FFkSEYTjJTjwDycNNJyVUIGVtEb2wPSSECD2L0QUKBS Y1MpjKeyhtFkN7GCAKqTAaoU02s9elwBkmT359z6VVpe2KgzSab4YkVXs5HOSud2LxJ0viruVwT tH2676PLTQGcljCdtiN6iBH6M6WhOZs4= X-Gm-Gg: ASbGnctUet29YEhip+G8N3jYaDWy9TcEAMF8UEoBQ3CfpE9wLJAzIWc2wyNdJvDDJhM J0/EyxrojMKTCsCvkuab1jEscLISuCvSdfj+UsZmPnVMtb1PlztbN/sOxdKdU0JFnCebxSpHRXx SfL5iqp7LYWfeCDoMbfUjgY/FNvQN8hodUe3OOnshbgZrHVUu66J6nMNSHrx/nloR7AKZPqIuC2 4eL2xA= X-Google-Smtp-Source: AGHT+IE5Iww1i00Pt12bS4PeAauPkTugTt4uJE2TsnwTnY38yNwpFQjV6A6pNGslKMdLzsjoyJUdyCljvCrlxmmznjI= X-Received: by 2002:a05:6102:3f0c:b0:4cb:5d6c:9946 with SMTP id ada2fe7eead31-4f95f30463emr10103615137.10.1753055090526; Sun, 20 Jul 2025 16:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20250718090244.21092-1-dev.jain@arm.com> <20250718090244.21092-2-dev.jain@arm.com> In-Reply-To: <20250718090244.21092-2-dev.jain@arm.com> From: Barry Song <21cnbao@gmail.com> Date: Mon, 21 Jul 2025 07:44:39 +0800 X-Gm-Features: Ac12FXzBjmVqmon0-2uZp6WT1U6OMbiYJHYosmIwhhkMAqnhdJDT2LExr2m1S2w Message-ID: Subject: Re: [PATCH v5 1/7] mm: Refactor MM_CP_PROT_NUMA skipping case into new function To: Dev Jain Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A4DC4120009 X-Stat-Signature: erez3uembzwppd36hpj8udq9nm198sr4 X-Rspam-User: X-HE-Tag: 1753055091-995271 X-HE-Meta: U2FsdGVkX1/2vBAjOv08o/9QyvuZuj1PLvOE/uwHF9HO4EKHBtPVwgbslF+If/MrcoGUwVpOfAq5JBg5eQxN4y3XhU0HPmiD3njLtOF5XFveQ7xorkSnCf+6GsctAIqO4EV+N7l2gisR0IY21or7tj/meRftQ9JLGAWPk7QUmD+p5l6/O71LaPqCXTdJDnFU3N9MXbm/RBvSJ6ARePx/DKYESTPRPliGl29gJ25KUMsuE/Fyf1cAtd3ZzwZ5fFmJzWv3J15cni1iusovvLpkg1u77h65ZrAH8gFYSRM5abPydDrKd3qDzy8MnmrqddmmCZ8kSav1I3cCuZvtKLsXJ3X6O/71xrNSMu6+WuGC/GYg9LIZ1aFTuDO9obnGr2M/iYVAhYxiUbFJyrgJ10WNR9cTRWIYlMBZ1xED3B7lTmuREtkgg76RwbalebEyHKn5OkMbyCZg8jYXp0or+5wmXPu4AAiWp6QH8A2EBYi+D68YHGpBj3RX9Qck2LZ/aXs8x7UJkEu6mT2czk2/spCYGU9U9FPGYEVWZ/6z8KSlzxOXW6yojhYIIIEaYvbe/ie3mh2rfYOLeayoMASNyD39Eu5wwlQMtYh/tv5lROSUp1MRsfOd8YK9dGnJij5/4wQsExIqb+tRP2GqYtMZ1qZYCXHWVWkZfTd30viIdp4rgZ0g1mbm9ZaX8bfFMJQhc1odtCyWNlBDD0evKf9cwSh2BHB40sK5tARI/VrVJa18cJp06ctK+8T/t9x9D+KoCNLNeeixfYnBqyl/mWs0BCu5Fchqjn/jgAVPrzu1mfufkRihAAoXnUsEpihsW/qQx1vey3GaO4UaimXeuV8DZbI3ZQz8aQJQdTUHoncwJhH8PNZbxK0J8bk0jaighPs0LrhjWy1KoL4sAVpbxf/sXtPl9ltNOfHouF0QS3jrKwqaxRZsoAF6fvq2jnVRMi9cV0BPlXqYmAZNUBEDsU/T/T6 ge7CYuvD UtzUdhUY51OnBw84j+fXvXNx5S37Wc1alhNJ/n1Ww9WFGMThY8c+V3JlIDS4CoT6N6hkN+P3lWRy6ncGmJY7eVNJeQyE3wcgnEbcGB1+qC/4Ed3Gbi1QLgIYwlmTFap8um2e0YoLxffhBoVAywGbZJwalZgrrx7PLUMCZtnLmpWZtSdnu90ppk+gv2w1GUlbWvuEhuPYWSTNyGlgZa+QXWbJXLxSJGWPj1v8wWjT91PzPbV7okG8GZYGkpMpNro6f3vUPyevdMmwWZ+IxThWLrUSMkLX8UdiZNChM0XJVLXoOHU/lVgh8+ExODO93UEbxfbJZpfo+2YSUlGauUvF60SAcxIcgAjFmr4NDlxg7/mJfjcYcN4KFMe3ociINotwa/b4t7LXupKz2gMhtgBi9TzO2rGlBUtNpSgSih/noHUy236Q7eZQGHOJJCVz1x2lhcHqCZFP2grbQ6hx5hp54v1GHrHYlhMFlhlgPqC+Hs7zJbkH5ahE3ez/pk7FQ4L5F2WkuTBDkZxuSnUM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 5:03=E2=80=AFPM Dev Jain wrote: > > Reduce indentation by refactoring the prot_numa case into a new function. > No functional change intended. > > Signed-off-by: Dev Jain Reviewed-by: Barry Song > --- > mm/mprotect.c | 101 +++++++++++++++++++++++++++----------------------- > 1 file changed, 55 insertions(+), 46 deletions(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 88709c01177b..2a9c73bd0778 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -83,6 +83,59 @@ bool can_change_pte_writable(struct vm_area_struct *vm= a, unsigned long addr, > return pte_dirty(pte); > } > > +static bool prot_numa_skip(struct vm_area_struct *vma, unsigned long add= r, > + pte_t oldpte, pte_t *pte, int target_node) > +{ [...] > + /* > + * Skip scanning top tier node if normal numa > + * balancing is disabled > + */ > + if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_NORMAL) && topt= ier) > + return true; > + > + if (folio_use_access_time(folio)) > + folio_xchg_access_time(folio, jiffies_to_msecs(jiffies)); Nit: I wonder if this should be moved elsewhere, since this isn't actually about 'skipping', even though the function is named `prot_numa_skip()`. > + return false; > +} > + Thanks Barry