From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68EB3CD1297 for ; Thu, 11 Apr 2024 01:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D895C6B00A4; Wed, 10 Apr 2024 21:27:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D12E36B00A5; Wed, 10 Apr 2024 21:27:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8BB26B00A6; Wed, 10 Apr 2024 21:27:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9756A6B00A4 for ; Wed, 10 Apr 2024 21:27:38 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5E7301A08EB for ; Thu, 11 Apr 2024 01:27:38 +0000 (UTC) X-FDA: 81995513796.01.B0DE344 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf25.hostedemail.com (Postfix) with ESMTP id A5532A000A for ; Thu, 11 Apr 2024 01:27:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=T+I0YtKp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712798856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GfGZWRXSUIyqNHCgW8rswLstTfY/iXLOVHVR00RmzH4=; b=z46RjmsUtN3Fr3Ax+O6KGkIXyzWLNC7MOvTD9gSwxM5wswPdQCkomkd4DX2n5K9TJGIzYS hKsyEUfrlxLOWeog76yGWVkm+ABEsi7PWKm7CPlrJ23YAoK7R34Q0HtRI3a6aQ3jROl8V/ 4z3kIgC9Zw4/YGR6TQI2mnbqlWucJ18= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=T+I0YtKp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712798856; a=rsa-sha256; cv=none; b=QYM+ANdXwCvIpZFUMyRMto6x25nGLSp+5PaHEAc6iMNk4LM//rQ6Ka2qOieyTKPu9fZ5zV OKo1VyLQrA8uLdem2sGKUV7XbdsAOEJffHSIsh73rLbpsSUzp350a/SQ8JVTdMdH7s1L++ FA4IWoDHx5sOUXaSLNXN0To0zbXvn7o= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7e043f577c5so220544241.1 for ; Wed, 10 Apr 2024 18:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712798856; x=1713403656; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GfGZWRXSUIyqNHCgW8rswLstTfY/iXLOVHVR00RmzH4=; b=T+I0YtKplPX8hRCD3fZPakxm2NwpKiLe/rt/8Ig7fEuuwhblVPHqJ2ZLIT1lZH7K43 Ztdd+3xHIoRfe/YCI6wmUp5hqCFpklKZk/PWODWHp3QmGxGvxEd9wpFGYtpAn9L/FLNC bCeDWFDUP49iuRlKDd+Ov8GCWEo1ittMEdH3kQrAq0Fgu61CV5++Bm5zPpkCOQwqgmkN JGxq7Cj7n5nPmeGkOLMXyqEcmOOc+RiRy9FhmDiAO4Co8xko9rR1jb7IaB38aZbCgfUw 8mDWW6VkiLNmLa5oC9yJDBNkCi5Cn6Mz5b7EsjiIpohDoK05yZMEYF6DQOhUhvfY0m+W v2Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712798856; x=1713403656; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfGZWRXSUIyqNHCgW8rswLstTfY/iXLOVHVR00RmzH4=; b=wk7fQgbID1J0BGst6gc2LdRGDowdHeose8zSaCBHmKd2rhSoDpmJSAK2f+9EvcmuyF 3C9Rcdu49vm65uQYxNrEzvwJLQjt1L1VLy3opa4kKmbjU9eezrrUmd3QrQm/xCLSjkfG eGT91ntHLyhhBdgC0wbf6/mwJAi9DwjVhSDZ59ThbNYU2Xr4EnDKGiGLlXg15qRkIgt+ FR8vPvzdsZw2GYuSBpWoxKYxIhDIAIv8g1sPvfHatO22hdkyrfsclkEFaGchWJEovKaZ 0M+Uo62KSqghS/ka6GfZwSDQZgXNUcyVosgWjfvDt6/O79ftolWwnqtUwYBLxMvgNiTV A5KA== X-Forwarded-Encrypted: i=1; AJvYcCU0jUfqJA53rDGU+MULKYhZsNpAn11lhDTpBcY2wS5EpSjWKZlEYX9Wbf4tmsPpU+vZ/s0qswgJ8r5B8UUhGlT4DTw= X-Gm-Message-State: AOJu0YwsPwxlkFm4DS7VqOhFtg5itDFpLoCxYGy0xWMAdoWPOZhEFBtC 8739+sXe8cMygNSkNXX2T0nANGH0ABp52a0xHW9itAJvlvgevGZMAUktzeS2Hg6JLmxwi9TM1pI 4aCDjvoav60vHhLqGwYZyTsjMD3g= X-Google-Smtp-Source: AGHT+IHmvWK7mM9OMuV2oPFHDefXOfcfb7bhsM78G0eZItcfICf/zTcQHLgd7ZA4aMSK8YFfP4KkoDtw+3mjDAWuAww= X-Received: by 2002:ac5:c956:0:b0:4bd:54d0:e6df with SMTP id s22-20020ac5c956000000b004bd54d0e6dfmr1117988vkm.1.1712798855741; Wed, 10 Apr 2024 18:27:35 -0700 (PDT) MIME-Version: 1.0 References: <20240409082631.187483-2-21cnbao@gmail.com> <20240410233759.274907-1-sj@kernel.org> In-Reply-To: <20240410233759.274907-1-sj@kernel.org> From: Barry Song <21cnbao@gmail.com> Date: Thu, 11 Apr 2024 13:27:24 +1200 Message-ID: Subject: Re: [PATCH v2 1/5] mm: swap: introduce swap_free_nr() for batched swap_free() To: SeongJae Park Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A5532A000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pfao45so4w8nbyfcoxxge7mup5e59d5z X-HE-Tag: 1712798856-372026 X-HE-Meta: U2FsdGVkX18giml0GyqOStR7PWqx3Umm6WdqPosQQxy8hJdSug8hiM7fbs1W8JydI259xWJZRLo1r/3LvgHxIiUtdxryH88OuvAngMflFp+/SNOJYUFNIzILuUrfZCLHym9IT66oQaSKHnZRdA71sQGSmuQ+j6Np93Ywj009H9cQea1Z5D/FVTTvOwVjdaEx2CqAdvoQWbYrHUMrPmpNVYEPLx4FbLE6a9ybrLMHmBrvDhplSXapiVAV3ieu7EGMjvRf2TEDbvfApwFOfTVq3gGjrlnSwG84mfPyPBpbItgmISXOwvmNIKEH8R6WbubAXw0kIte4StwxOHDJtwIGuQAW0h3XEL33kviMu7Y9Y7Ez/Y1sPDYO6/GoKr0eCcgAubf953esQnEhxuskg3gxakJeeFUGkSdDB51XGfOAOECKNqGQyXEDsKdaegCBeROrFbTLKmhvYVedt0Mpo8d3PrsI7NCXkfKwAzgeL5M7yG1RDbVFGBsqtlJSecSIyqont7qsG2RpMLs3glY3s2d3mXwhrHNdAX7sK0xvGtjTb688Y0ZYWPV/oQMta+F6mjaxG+myx1MPHs3pPvnAvD4FaOQyZEDh4ZOr6Uavs2I7OE1pVZAOX4JQLEAGUcrrVGGqrmOWYjESbQ+5oxjm5b+Zir9m+lan4/3mHTXhj75YWyg2BWBwbFMl1CRT0JPJ1Zy5nPmiYvE5etbKN1XS7he7cNN3n0evO30sZ2aVOF14Y0KQwho85UACG3fjOTePzJmWUlQEqeeQ4/9KuNlQV4p3DQfDmrRcaC7/oSnhvC1mri8CsyJ/qiJJes/8ZXaUiVoRtC47cWS0bOiQ8FwckJtsCtLF3a0iwhtBhvwVRjRU74mHWUMiD1kiVyo33EA9yG6RRgxB3WITpRGTvf8eutRJYw5jP/XbbGHTyfpsRf5pq7uMxyzo9lEZnDY0FIQW6kuILXYIWnQHOrADtvOQV3S Y1qcj+OI bqSwH1MGtYtBySEUJ9mg8/lsOiDISjJlTJw4w0bnJh75VwShDvTMsL2H2LqP9uw0pfLj/hndvWlUEMF32M1mzXAc1JIUizsQUgdX4RS4P+kR5GismflVclAOa4bxqX8yPfXf81MO6saJ+P+LdwHzqxTucTVVJmA/1TZAqbYaafUunGxIWnEGaPXeGYMKV+BZq2xObzoFHcpQQwn+ZYYYgRyc4R01maPObx3KymJw5Anp/ryZwmGuyz20OfHMJxuu3ink4y72/Z0qkIFx3Gwh7LEUCER1kCVwwVnfWYebP/IiyjGKJFwfu1DJ1aYPIQpA2a+IhPy8xKEpeCPvIuhhIlcIpVRpxSjh6KFPGZyVO7cSek5KBc+qjFpPFdWKuJ0Z+a5W1AYTiBJFxuqUlGy/5zbJ469vyYDwLFfXNVZCfWmaBEa7NSyzm+5kLq8bXAasm+W0Ws8RyaGcQWp1sn5Qxsuw6GSGV45GxT/u4Ck7N2i90sOCsdxuzFuOrvnrnFQkYJ07ktNapuzH1HnNZxE1nsX51uywfELIwLt1M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 11:38=E2=80=AFAM SeongJae Park wrot= e: > > Hi Barry, > > On Tue, 9 Apr 2024 20:26:27 +1200 Barry Song <21cnbao@gmail.com> wrote: > > > From: Chuanhua Han > > > > While swapping in a large folio, we need to free swaps related to the w= hole > > folio. To avoid frequently acquiring and releasing swap locks, it is be= tter > > to introduce an API for batched free. > > > > Signed-off-by: Chuanhua Han > > Co-developed-by: Barry Song > > Signed-off-by: Barry Song > > --- > > include/linux/swap.h | 5 +++++ > > mm/swapfile.c | 51 ++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 56 insertions(+) > > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index 11c53692f65f..b7a107e983b8 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > [...] > > +void swap_free_nr(swp_entry_t entry, int nr_pages) > > +{ > > +} > > I found the latest mm-unstable fails build when CONFIG_SWAP is not set wi= th > errors including below, and 'git bisect' points this patch. > > do_mounts.c:(.text+0x6): multiple definition of `swap_free_nr'; init/= main.o:main.c:(.text+0x9c): first defined here > > I think this should be defined as 'static inline'? I confirmed adding th= e two > keywords as below fixes the build failure. definitely yes. It's highly likely that it was an oversight. we definitely meant static inline for !CONFIG_SWAP. Thanks! will fix it in v3. > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 4bf5090de0fd..5fd60d733ba8 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -562,7 +562,7 @@ static inline void swap_free(swp_entry_t swp) > { > } > > -void swap_free_nr(swp_entry_t entry, int nr_pages) > +static inline void swap_free_nr(swp_entry_t entry, int nr_pages) > { > } > > > Thanks, > SJ > Thanks Barry