From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507A5CD11C2 for ; Thu, 11 Apr 2024 01:24:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C28436B00A1; Wed, 10 Apr 2024 21:24:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD7D96B00A3; Wed, 10 Apr 2024 21:24:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC6B66B00A4; Wed, 10 Apr 2024 21:24:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8FCAF6B00A1 for ; Wed, 10 Apr 2024 21:24:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F29F4A0F34 for ; Thu, 11 Apr 2024 01:24:39 +0000 (UTC) X-FDA: 81995506278.08.1A1A628 Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) by imf30.hostedemail.com (Postfix) with ESMTP id 4CB9E8000A for ; Thu, 11 Apr 2024 01:24:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ESpKo5w8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.169 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712798678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1yKWZpJ699ybogaYOH0MhsiOSasgbjtim+qJVmbIjKA=; b=09ZSmFMlV0i3jjddyp/eWffxI5grQBiAvRKbuwkUHWGRxnMNNRUZF9h1yPIsilGuiWGW6k nSMU4Mj5hbMT8t3Fp5Q0Qfq4QO54+/59TXIiG9B+yxMbX7/YKxJsmUrYdUHdGu2gvJ6qM6 qchQdNbT8kZC+VNj4o+1OO+OUGJm0gY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ESpKo5w8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.169 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712798678; a=rsa-sha256; cv=none; b=rFV8NrIKZcKZ0YmP0rl1OTVfyVylj2jUvMlhYAda16lfChCBQEp2vHRtrfuvvatXJHwFxS o5kgKZQQoL+SRsO8LvQXiOxZo069mONViZI5/h9pvV1sqP1JjMBf7wYRZ6Hfuzu9PgKi8n A/cvJ7wFs4wkVa308TWpIWOlss1r58Y= Received: by mail-vk1-f169.google.com with SMTP id 71dfb90a1353d-4daa1be011dso2218197e0c.0 for ; Wed, 10 Apr 2024 18:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712798677; x=1713403477; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1yKWZpJ699ybogaYOH0MhsiOSasgbjtim+qJVmbIjKA=; b=ESpKo5w8eYKUVY6oLc4THmekQpPAByB0crq71mAYLyzm0xj8yDDUa83suuvzLE/txi hydkOa2OoIKOOTBjcIJJs9hzzLtJReuYGdOkKem4zQkCCiEAPIe1i2hD7EKxyMbXCe/m H/v/TOol5c0vQVJ8HBxWHD7euN2Yw+9TsHs/7J4vgJGziqusPaGBEisvdItccTMCcfhF 04SNXisKb/gLYYwRh+kowSCqbxIzRlPXAMxL21i2urkPnZ9gsXUrCc892iKC70eBHOa/ MAQrCOg9kzwChBmaQewq4lwllNhe3DVo5ZuYYVPRzHbJ04qQBIvmX4JMmmBOum8xtNFx CNTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712798677; x=1713403477; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1yKWZpJ699ybogaYOH0MhsiOSasgbjtim+qJVmbIjKA=; b=Jk0y5cnZkRBgKdc2brddEh/+4oFz3BJQjWUWxfP3pt4NY16x9s1kGfbmlp8Eq9zhVk nvJyNV2kqJ0K3N9I6P7lNMEBHuSoTURD8o1wRKEIa4yiYTeJEf/Ndu+lJ4iDS5yV0Jqw rxrMqWOJdd0oh9JXk/gQ3gHxMcJVSDkBEYuQBqzbKjLN0A89G/0gdQuhFCTfHvs8m+EP 9MO9HtTHljGYZYQe7jXIYvbwu0vThogx/nbHBX36hdjoDGpDy6+kgzv53le4KD3CEJ5v CpRHXlISC5GOZ0VQmh2S3/Fl8gh6s7PSulEBMvhjdPjZjynXvWPq8a1J6ksC5c8oo6zq mYsA== X-Forwarded-Encrypted: i=1; AJvYcCUeUwheCqdHh3OTW403eKJG+JWNeWI/AuluJG0YOuLQ7JRJj+5zxtVvlUSzMxgVreMFURy1AZCDC7Mg+kpFWhonV8I= X-Gm-Message-State: AOJu0YxFXAVL8BikCa/WIf9SyUuihMq9BZhKCsWp51R1jT/iHeGB4ASf BsKE5KplydNhGXyt+cvepnYbXgS3TsS6jvrEJfUgEC8VGKLc/0PNI3Xhrrpqh11o+sTcFwxwBTC 5iH/9BDd1jKOjvT/jWDxmAOeRfIU= X-Google-Smtp-Source: AGHT+IEqDE92kK5vjMNlj7NgFV0G2NKCUkrB4T8FG1hzniRORGjFfj/aBLbGkdiB8MnpgH/ICqdHIwpc91C4/u+9RXU= X-Received: by 2002:a05:6122:91a:b0:4d3:31fc:4839 with SMTP id j26-20020a056122091a00b004d331fc4839mr4409139vka.2.1712798677359; Wed, 10 Apr 2024 18:24:37 -0700 (PDT) MIME-Version: 1.0 References: <20240327214816.31191-1-21cnbao@gmail.com> <20240327214816.31191-3-21cnbao@gmail.com> <20240411004057.GA8743@google.com> In-Reply-To: <20240411004057.GA8743@google.com> From: Barry Song <21cnbao@gmail.com> Date: Thu, 11 Apr 2024 13:24:26 +1200 Message-ID: Subject: Re: [PATCH RFC 2/2] zram: support compression at the granularity of multi-pages To: Sergey Senozhatsky Cc: akpm@linux-foundation.org, minchan@kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, linux-mm@kvack.org, terrelln@fb.com, chrisl@kernel.org, david@redhat.com, kasong@tencent.com, yuzhao@google.com, yosryahmed@google.com, nphamcs@gmail.com, willy@infradead.org, hannes@cmpxchg.org, ying.huang@intel.com, surenb@google.com, wajdi.k.feghali@intel.com, kanchana.p.sridhar@intel.com, corbet@lwn.net, zhouchengming@bytedance.com, Tangquan Zheng , Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4CB9E8000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: g861za8muefi3ziy3fqsu7owmhejwteu X-HE-Tag: 1712798678-766579 X-HE-Meta: U2FsdGVkX18W0mLnqgKk287NmjGRceoTe7d/D29ZsnEZ/lL0vPjGSTuIUqwPh4A4MgsXqRNNhqDwwhwYpJ9ys+DC28owiAW5y8TZ2UV9UQEB8fruujuQ/g6yXTTDvP2v1xty1MaiEKnBNqb6j7y7elMHMTuytjRV4hf/l2gYd+r1o/kY/nJjL1wjmAzhZ9uNsrAlSj6RT2wsYS9lB+D3ihkuesSzfNZhcNsbsS1vxvB09Grx4wzTswtAjBO5DK7VVTH8WRI9VE78L/TH9DZCKqi6RWyVEoYhecxkn6ZEHifeP9NXnfT187BrMINQRRWW5gNNxHUuLEwnYVJPyXE5OY/GtX2YlK/ICyu1Puh7B6ztNt8FopAvz4LiLJ1hRY8h8TERrFwgKjpAcr+vEdyrn0SukjWOEQTEKy5Ufp1Uv29wCJ0YJ6ENsBN+KurbRTDl2UdbEhyw2/qb/JrHglpMx+S8UPc5cyHKZYgmtDq0OWePOwEWGsSpaM0hAfwN1tPmdq3H4Tirg5+ZdNo81qclFvciCtbEVVnNrOvUp7XBSU+LGD11Hg3JXuWaY5IC5vQJu/4MRDRy1gJ3wUHybafEfNrScsKrjbgZ/8bdh2sVNL0g0ZZPTLqLI3mjI7xppfSeFvpzn+VWDgEZssgbu25biZc5Y3Fx2JdnTqVxRA69FAD4cCbiyDOannOHEHTGxP41akWJw23i0rxbWrCtvGY51LEj+WNZwpqSFK1oTRiF0U1ZOonE/Oiqzi0RoQVnIULb8qzsPDkLQXFYVvYUvC9J7BCIMX9pMMXW2E3tiznfWgK8CdqI6Q64DQj1Biutm3diBGra85CSQTmajuRO4X0ex7J7I0fpWPXe+qTRVsP71Dp6KlcDO4AkjVxfBLagmfpWE1iNYeeHEeAnsTmAWZGBtywp11yCNZ6eORt2cywqcZnydygDm09QVc610Aj43EuhMA0PYfGOlx2r6f7a6gV knD/MEgW egckFVwyC9UHVxNHjtY39+R2imrwC+HUzoS+s0keOHx7XNsQ1a4UTeRoixCASx6TiS5XjuNyczgoeVq/y4qXXEYRxRj6IP6ENle3W3i+MP/Qu1F6Mr+TgbNGuH7SIgvvbFoP7sOh+UVf6ycPHs7K07OnW2MVKEmP+xuUUPVCpaSXn/0+ZRefU7wd1agrGy1ebA+ElpWQ9OvJU2idKVwmR/MWXuF+cGC4BWsvGlC5y9Zwtuxl8WWkl795G1cMl+v6/dzHKkwbLGPZMiGrN5Vmg0I7O7lIFXCto1VgE97TFqs1SmZnoM5PVGzU+Ewx3iG5rRZc95jIX31RaOoPhKQFkp69CC3rBXgQnB0enZ/8PbmyBzxvZGLVVAYECgeliki2BLwiumDUa4BU9ZW4bDeHdFS1a9XpENApUVQsC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000062, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 12:41=E2=80=AFPM Sergey Senozhatsky wrote: > > On (24/03/28 10:48), Barry Song wrote: > [..] > > diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_dr= v.h > > index 37bf29f34d26..8481271b3ceb 100644 > > --- a/drivers/block/zram/zram_drv.h > > +++ b/drivers/block/zram/zram_drv.h > > @@ -38,7 +38,14 @@ > > * > > * We use BUILD_BUG_ON() to make sure that zram pageflags don't overfl= ow. > > */ > > + > > +#ifdef CONFIG_ZRAM_MULTI_PAGES > > +#define ZRAM_FLAG_SHIFT (CONT_PTE_SHIFT + 1) > > So this is ARM-only? No, it seems that this aspect was overlooked during the patch cleanup proce= ss. Currently, our reliance is solely on !HIGHMEM for the safe utilization of k= map for multi-pages. will fix it in v2. Thanks Barry