From: Barry Song <21cnbao@gmail.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: akpm@linux-foundation.org, minchan@kernel.org,
linux-block@vger.kernel.org, axboe@kernel.dk,
linux-mm@kvack.org, terrelln@fb.com, chrisl@kernel.org,
david@redhat.com, kasong@tencent.com, yuzhao@google.com,
yosryahmed@google.com, nphamcs@gmail.com, willy@infradead.org,
hannes@cmpxchg.org, ying.huang@intel.com, surenb@google.com,
wajdi.k.feghali@intel.com, kanchana.p.sridhar@intel.com,
corbet@lwn.net, zhouchengming@bytedance.com,
Tangquan Zheng <zhengtangquan@oppo.com>,
Barry Song <v-songbaohua@oppo.com>
Subject: Re: [PATCH RFC 2/2] zram: support compression at the granularity of multi-pages
Date: Thu, 11 Apr 2024 13:24:26 +1200 [thread overview]
Message-ID: <CAGsJ_4xrqkoPHNwdS5TqhHNNod+tc=s6VdWBhCGp7DVQB5Yb1Q@mail.gmail.com> (raw)
In-Reply-To: <20240411004057.GA8743@google.com>
On Thu, Apr 11, 2024 at 12:41 PM Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> On (24/03/28 10:48), Barry Song wrote:
> [..]
> > diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> > index 37bf29f34d26..8481271b3ceb 100644
> > --- a/drivers/block/zram/zram_drv.h
> > +++ b/drivers/block/zram/zram_drv.h
> > @@ -38,7 +38,14 @@
> > *
> > * We use BUILD_BUG_ON() to make sure that zram pageflags don't overflow.
> > */
> > +
> > +#ifdef CONFIG_ZRAM_MULTI_PAGES
> > +#define ZRAM_FLAG_SHIFT (CONT_PTE_SHIFT + 1)
>
> So this is ARM-only?
No, it seems that this aspect was overlooked during the patch cleanup process.
Currently, our reliance is solely on !HIGHMEM for the safe utilization of kmap
for multi-pages.
will fix it in v2.
Thanks
Barry
next prev parent reply other threads:[~2024-04-11 1:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 21:48 [PATCH RFC 0/2] mTHP-friendly compression in zsmalloc and zram based on multi-pages Barry Song
2024-03-27 21:48 ` [PATCH RFC 1/2] mm: zsmalloc: support objects compressed based on multiple pages Barry Song
2024-10-21 23:26 ` Barry Song
2024-03-27 21:48 ` [PATCH RFC 2/2] zram: support compression at the granularity of multi-pages Barry Song
2024-04-11 0:40 ` Sergey Senozhatsky
2024-04-11 1:24 ` Barry Song [this message]
2024-04-11 1:42 ` Sergey Senozhatsky
2024-04-11 2:03 ` Barry Song
2024-04-11 4:14 ` Sergey Senozhatsky
2024-04-11 7:49 ` Barry Song
2024-04-19 3:41 ` Sergey Senozhatsky
2024-10-21 23:28 ` Barry Song
2024-11-06 16:23 ` Usama Arif
2024-11-07 10:25 ` Barry Song
2024-11-07 10:31 ` Barry Song
2024-11-07 11:49 ` Usama Arif
2024-11-07 20:53 ` Barry Song
2024-03-27 22:01 ` [PATCH RFC 0/2] mTHP-friendly compression in zsmalloc and zram based on multi-pages Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGsJ_4xrqkoPHNwdS5TqhHNNod+tc=s6VdWBhCGp7DVQB5Yb1Q@mail.gmail.com' \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=chrisl@kernel.org \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kanchana.p.sridhar@intel.com \
--cc=kasong@tencent.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=surenb@google.com \
--cc=terrelln@fb.com \
--cc=v-songbaohua@oppo.com \
--cc=wajdi.k.feghali@intel.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
--cc=zhengtangquan@oppo.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox