From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54DA6D59F78 for ; Wed, 6 Nov 2024 21:01:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D3296B0083; Wed, 6 Nov 2024 16:01:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 883286B00A3; Wed, 6 Nov 2024 16:01:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FD2B6B00A4; Wed, 6 Nov 2024 16:01:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 512B16B00A3 for ; Wed, 6 Nov 2024 16:01:02 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F08D840DFC for ; Wed, 6 Nov 2024 21:01:01 +0000 (UTC) X-FDA: 82756888368.19.4EFF258 Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) by imf09.hostedemail.com (Postfix) with ESMTP id BA76114001F for ; Wed, 6 Nov 2024 21:00:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=M7AtrSBu; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730926674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rP4uisdfc1zjfK+2lZpIDlK/Mivf6HgrmxOj3vGs25s=; b=G/J5CTklXqyNIrwBqH4kvw4esa8waqC0JF69AFB+7zdTbrnBhKwvICplfdlWo04+mB0uDX G1zIZ/jcJifZsry0dDVX52sejqGgtTAa7QqV6P5/XJoofdm8ephzhkJQaruJBUhu0iXBF9 qy8xFG+P0aPZm1itKxQn7XT6tWTZWOA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=M7AtrSBu; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730926674; a=rsa-sha256; cv=none; b=Duf8hjCcPC4OuiNvt4TegebZeH6E5N454CO0sKUW9tmb4VbVvFjgmhhMi2DYB/aO2k5l8C 8vndOQ8Iklm9dnQKV9xcr1Ot0otVLKwe8gTFRM+N1vedoPAjIClMEZOEDSBMHPcI/TxQA1 27rOoN592nW4cncmnJ8+zEJf9sigolE= Received: by mail-vk1-f182.google.com with SMTP id 71dfb90a1353d-512259c860eso81400e0c.2 for ; Wed, 06 Nov 2024 13:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730926859; x=1731531659; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rP4uisdfc1zjfK+2lZpIDlK/Mivf6HgrmxOj3vGs25s=; b=M7AtrSBuAp4BNVNUTmHAqGiY9Q2QS47U46okUg2k0itUTgXqQ+lPRWVQ7hPJubJy/I m+NuSVk8h+69L7lLK+41XgGx3pzGkXjvv2xMH/gGCoEEvyWOtit/6Xv3Uq/V+3329kC5 LI0x+8LQGbXFCpgt12Wn4kRvZ4eWvbhaXQ9c1P4aFiIka32YAdvM9dRvJHJ1kwzN/XVb AGeFSWv0JwAHiTOoDkYLBfh/GmPlXl60HZLjB7oVnerC3MI5Lnr20zwCszmi9XfojUD4 stW4Z2eIdgDU3NwLk9aI8CuENcsiMuHzyzyBIj7MB3BIu73++PVOSgU48E12IHmdag08 hWJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730926859; x=1731531659; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rP4uisdfc1zjfK+2lZpIDlK/Mivf6HgrmxOj3vGs25s=; b=Di8mmbHlJprQYatTzixBecFZMWJqewo9CoIk9roNXjsUcOvbeh6CyVbeCEN8XMrva2 wWkMa1UIj5v3mTMy7v78rqMCLApfq3cfrFtxtMlfq89v4AzOp0yd7/mvIemHzEMFX/mC pEGYYwM4Dosyip44Syh1NooDmGfV5TprRBmfgbM46EaWEhuXdD7gyHAR/tSqQM46Ecjb rL+G6xZoabKh7N27nmYKDVPNiXFmM5goFWufvVujjz1Q4JSObqw+Av1rVb7iA9gWlPSd MNT3MabsD/2SHZt3CJuJWlJGmQvILxVW+6g+mKnc8AFvIGHKZry41arnLfMswAig92ZU HVmg== X-Forwarded-Encrypted: i=1; AJvYcCXWLcMd7iDephWZIF+5kdk3sshTO0SkN/QgrEadNGqnhCMjrZ7lJiE/LCtVcH7hy3WRMfR0XLZMKw==@kvack.org X-Gm-Message-State: AOJu0YwYQeRBhw7WuFQq5pXRWpRib3eq3IT4cxet3k5dROfxm52TABet bvvgl4hmEjlOpz5eWAwVOeF3JIiLAeU3qjWiJ9JaqxqHS+wXgqrGBgXztqmmGKZg2aXqnX+DtPL dfyHTYBd81t4CRuzL/3egRqczkeA= X-Google-Smtp-Source: AGHT+IGdSZPexxSpaevgOqWWazi2SAZKv+vK7A6R+O4NfsGyaoOevXiBmae2SCYBTtGbOuPFfR/UNfr3X778bBg/Qvc= X-Received: by 2002:a05:6102:2908:b0:498:d12b:4774 with SMTP id ada2fe7eead31-4a9542a6661mr24402690137.7.1730926858332; Wed, 06 Nov 2024 13:00:58 -0800 (PST) MIME-Version: 1.0 References: <20241105211934.5083-1-21cnbao@gmail.com> <20241106150631.GA1172372@cmpxchg.org> <20241106124225.632b42c3680cae0b940d2871@linux-foundation.org> In-Reply-To: <20241106124225.632b42c3680cae0b940d2871@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Thu, 7 Nov 2024 10:00:47 +1300 Message-ID: Subject: Re: [PATCH v3] mm: count zeromap read and set for swapout and swapin To: Andrew Morton Cc: Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Nhat Pham , Usama Arif , Chengming Zhou , Yosry Ahmed , Hailong Liu , David Hildenbrand , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BA76114001F X-Stat-Signature: taif33sxrdssmsj3omb6zubu9x7mshcn X-Rspam-User: X-HE-Tag: 1730926835-127214 X-HE-Meta: U2FsdGVkX19Vh+7Fp+LZggtj34e05AXI77oB3ByPvhONsEl5h4KxKd/81HlTEiA41e8RJufGAlveEdvEH2Zl+GzqFvi1VcXBdcMr/BHFiULOvZr0nK8ufKVWhjaNTNh+QbLzLKMaYpCWJTJ3RsnonwcSvUvBKMvoSs0oVa0x6eBneQshPLhRsYr9b0J4t4JMUGziAT2BoewJyRHoNDaChHOfVwNmGPPxBssXH7UjQrrjJJ7ZfAvQ7N20C0ZmdJRQiKdvBCZ3S+/pzK1Nl1r8PpCQq1mgQvzDIijMsCtBbibD+XjQh0NNQRfklKVdUavupDSReTFQ7kdEX77cwzXsnp4w22HKjHZC3okVUVN8P/XP9fXKlpVm4BjQFZHhvJ9xK9EitB8ZKlZnnRjxrgojiYeqfOf15zZuVT1Etz0xgVCvVR6usEJuyGF5jy1vVBG4v6ZuyroAuVuQ8g+dm+hqtxiEAYFrwepEaw1JDJTvmwWoi3tpTYJCmTQt/Lo509Fy6RW18FSnJEmIcbyazgdmO81ipdoXw/SOlEAE+ugI/S5WN3KWV8/IZkzlxRpKtZyOTeReiiXYD7pm532fxwudgb7LsOBx+Es6kQi0MU5vRXHw+PK5P61tcXKQUsT6W7NrQM+B9u93WuQ4PuELiqIVkGK6ry8is6IUMfrpgxER4/1QsEdhH7R1QUpNp3+dAvCrV8wr5WMjSO2LJzRJbBMzZOunicc2ABKGpeFq74L6aJICSxTBEtN5NVsTC1XOwH9c4j4H19gdeYlR35otXOF8woWEM24eyHlOBegJ/keZraeS5iGFGhOB6+Xiw1SreUNh6lv3fUtbYuWjER4ZghAaq6dZ2mVuJvi7yuvJpMb5HNGiVkO3oPd9HbkwEnA5clhBmGf8WhQKJS7qbRGJ1g6U+spJs6AJRrVbsHw3SqOcAwpY8omHOTxJVETV+qh1SKtusPo0mtVDgHIc1w4fOPx PPszAbAN t3TbOu6/15+WZRYj34VJ00b9XnhUE6N7BKF2xKCqPE41fki88yhEIiXb3kqrqesbuYJZ8PyZ3H8OWzhHv51FLJMC2q+2go5EKOLr0PTvtEIn3rnadbcDMJYHaEdEJjTR66rqdFcylnMlOe96zxgR/v3afQm/wj7kGH3CVTMxH6sCPP15uIZn2TSuSFul3sc5nJsAb7NJDER+f64+G/rns5yQpdjl0BHIeVZAqZZPrATIw4Vl5mrYEe8PjHldPc7V/n/llZa7gsi2COaZxogvENcXPhcdrnWkcRfCyeeHEKucbz/A2idU3WFetITIjzjbo+MAYfj+lCezWIwuR972q9XQn2L+2o9/4sU8DfUxjR5LAydYCOexgcW5RXVI5Y6sIQaxWTfLRnHDh0EAYfOg6B80UITvsPKK5J3vBwaqe9+dLrLs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 7, 2024 at 9:42=E2=80=AFAM Andrew Morton wrote: > > On Thu, 7 Nov 2024 09:01:14 +1300 Barry Song <21cnbao@gmail.com> wrote: > > > Oops, it seems that it depends on Kanchana's 'mm: change count_objcg_ev= ent() to > > count_objcg_events() for batch event updates,' which also isn't present= in 6.12. > > > > Otherwise, it won't build, as reported here: > > https://lore.kernel.org/linux-mm/CAGsJ_4whD31+Lk0m2uq-o=3DygvkRsw1uXcPe= qxBONV-RUXkeEzg@mail.gmail.com/ > > argh. > Apologies for the inconvenience. > > Hi Andrew, > > What=E2=80=99s the best approach here? Should we include Kanchana's pat= ch that extends > > the nr argument for count_objcg_events() in 6.12-rc as well? > > Let's do the right thing here. I'll drop this patch from mm-hotfixes. > Please send a v4 against Linus mainline fairly soon then I'll redo > Kanchana's series around that. Alright. The question is whether we should integrate Kanchana's 'mm: change count_objcg_event() to count_objcg_events() for batch event updates' into 'mm: count zeromap read and set for swapout and swapin,' or keep it as a separate patch as patch 1/2? I guess integration would be better, as hotfixes may not be ideal for a pat= ch series? Thanks Barry