From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA59C48BC4 for ; Sat, 17 Feb 2024 10:19:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D44238D0001; Sat, 17 Feb 2024 05:19:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF62D6B0092; Sat, 17 Feb 2024 05:19:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBBC68D0001; Sat, 17 Feb 2024 05:19:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A831A6B008C for ; Sat, 17 Feb 2024 05:19:16 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 227351201C2 for ; Sat, 17 Feb 2024 10:19:16 +0000 (UTC) X-FDA: 81800898312.20.67217BD Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by imf17.hostedemail.com (Postfix) with ESMTP id 8526B40011 for ; Sat, 17 Feb 2024 10:19:14 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hBe3EYWT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708165154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uClJ3fAlScaq3NqQwR+2Ic2/qYD/92ld+NgmLu3RlS8=; b=QYn7sY+MnRD8mxTleXHv8ikBxWa/VFXKkGSMMfk5VLcJMyyQnwyDTjnet7wV9t0VuceG0R 741itNDup4l2H6xL54I+yJa4ef1GbXjRbbj1WSH9FO4Pusddfc283OSAwtDpYwALuEFDzh fVgNAhpwQaODtjHl42++EY01IXFEI/U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hBe3EYWT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708165154; a=rsa-sha256; cv=none; b=hOvkyEMytxhJ7bFFWv5kj+DZ90vV01ywwZEqYnISIpsdT58enuOW0gA3c45+s5eCgcDWAM gCNyPdaW7hUFGZ0sp/LxK7bbiipjkt6nmXw2BcAYVx2zUbxy0peWVNUn4qWxWWDdhkIGTi TaGZj940wdYZAc9/YURmIBVUwIAPvV0= Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-7d698a8d93cso1752785241.3 for ; Sat, 17 Feb 2024 02:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708165153; x=1708769953; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uClJ3fAlScaq3NqQwR+2Ic2/qYD/92ld+NgmLu3RlS8=; b=hBe3EYWTFNtiqUyEGtjKLXld9AjdKwe+S2v854CM5MpkyesMYLE3tfGRI6oWInxb3G zIV7+xrhu2HvMT+WNvsT2EboVY32yW7spFLHQSDCSYqtsMZtIyxxapgRv3+1s7AnMNac gJR4GflCEe+JbTaZD3iLMl7eCQUnQ473jSva8pJT8Hpl+TwFwNQwYiWDbTPz0l03Zba1 DJOn8YwndAXgfRjJPiMogMhKxFlu8EqJKOQ3tsgPppoPnDBFH+md5y2rGLaFhuVDwle4 i3fiWf7/2eRBk/dT4dlcqFwNziQa7QUXeXS+/LLm7BGKcXJ9niQU+3Pevw12j8Ize2R3 4nSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708165153; x=1708769953; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uClJ3fAlScaq3NqQwR+2Ic2/qYD/92ld+NgmLu3RlS8=; b=RLTS6WiLay2zH0zfa/ATfgDKSQrN8HrHyLZFmaNM8w9hbDLGtv2hkzPg6NemC7tP/6 sB1nj9V3DRDOx9dyIs8Ji9XOeX7mx3H55TmK7hTfPiTxykA5t3vJBqphzEZ0HPPiURxk C7/FnkhJT6tIROHLn+qx8ZTMJa4PAZlyEIgdB7Tow8mT+OHhPoRjQkKwpsPxVUdOiJVw PvaMvfcCC/RsfQFTOhI7mYiXhDnGs87t4KiU4SUtVsUUYsOdt9bRweAiqVn7AqvDtSN8 QIIj+p6remsp6wjruC44iGzKDWY6dYonBcC6ZNKRoHRWLBYdOtkpW2FQRwwdptXKv7GI J8+g== X-Forwarded-Encrypted: i=1; AJvYcCWivKgLrPP1uDUhtd2lXBjXNjsmo9vjCdiPvs/ivhX3GYX2jqFPhLsxYFeCpJ/yGH3COPvglRBgJE0O3NswScNB2bc= X-Gm-Message-State: AOJu0YzQ69u4BjF6rReo/3G1DHUoV6ueSF6U/Ak0YubmNwp0CBfF6Mi6 CC8pGLQzfqPt/zJ35wocKihowkWQqKtoJuJ8IL/L8KOQ0Oe1txylWuU8snNMPUmXayydP5+FcBE HOLL14aCgRbcijdgyHZl2gO+1J5Y= X-Google-Smtp-Source: AGHT+IGLXWxnqiQBes97u+3wAzXqStcg0VIXKROlbLqfeL9vuKpwnhs7OrRiTrQQsn+n0pVtkM2GUR4tZoATGUhs308= X-Received: by 2002:a05:6102:2385:b0:470:4514:506b with SMTP id v5-20020a056102238500b004704514506bmr284887vsr.3.1708165153533; Sat, 17 Feb 2024 02:19:13 -0800 (PST) MIME-Version: 1.0 References: <20240217053642.79558-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Sat, 17 Feb 2024 18:19:00 +0800 Message-ID: Subject: Re: [PATCH v2] mm: zswap: increase reject_compress_poor but not reject_compress_fail if compression returns ENOSPC To: Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, nphamcs@gmail.com, zhouchengming@bytedance.com, senozhatsky@chromium.org, linux-kernel@vger.kernel.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8526B40011 X-Stat-Signature: iq11okf8crppcejnibpzz4jwnqz9u5m8 X-HE-Tag: 1708165154-685343 X-HE-Meta: U2FsdGVkX1+zEOKXU12eooiDDziMYOwVDFwDkVZBWngkafGTUe9K9+9cDP4k00tUStJyrynPQ1erUSNNRWgZyst62kvuLMCBnLkWfNd4dNjdbTUv2b3sDKRSwNzgeulv0k5uzYTIM89ROuBzxwRNPQz0lfSoOD2vBKrjVisWHIglYZcho1ClsX14MiMaiDyAYp4Tw1AqqQlP6EWQyLrCHG2VcDoAn9cy5Fj+vbTFSmbNn5tOdcAy+k4+cMm1UmlmV9vqFV+U8tRfb4kNi5SSFwzbbmml6+4ZEwQmdHQ0lln0CjDviiFLekMjz/IxfphilLxj2Raic+Bpby8GPzcbwfr7d/rMXt1eDE6Pg2LCB31y/2E18i34hEU7oPMwezKmeCq45DpA6ZUBmeEKSucnChAahGruNHixjQFZl9LX26vEI/wYHUbCUjdDeXc8N8BaDva7Ey1WNq9sImHB6X9KUm5S4vetxmA6Ew5ny8c2pzkPu3wKDptJxJ2E5aWoKgTqDGwF5zGRuuTV1shcd++U1Bk5cJc9fS5v0KKuiiNkj8wAlVrZMuX7B1Jm/tJXu/FtZRC783x47EjMRJw4Ck7GSB1bByY9tJCVb5TL5LiYrHwwPEaqvE86QJf4C48T5FPQ/ZiUh1S/iCNRzFPeXn/r3/3MmwhwXVIjOv7L9xohvEPTYqCJHlGffKPGNpdpw4TOc2a+IZXXRcawqxyUETpMWkOLkUZQfJbOSjL/iZzUer11uzSyI1EE9WmER/jbwKDTCIsapnbPUoE9PpuCHYJgfkI7VVXvvPmOQOcwf5dM73M2LylHhjT8cHavijdSQvw4noCbrVuqzuusMN+Gig5i5aXCzMfx6d2nuzDl2e6FFcNAYIGVRNoULeDGCqBVXXs5HIwe1G9VoGJrevsCVv1UaHZRMiOHIpv8c+o6bxM72O7fNirav2586fNVwIgg3b4ZVR/lb8crYJHxfYjL5KK K0rtU1aI OdOtBmLrE47V1oklhZi8EFSa0AtS/5gFB2Pj/yo5MM5LnmrmlOBrypAsLd8737LVjPbxeY3rItMt8F0E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 17, 2024 at 4:57=E2=80=AFPM Yosry Ahmed = wrote: > > On Sat, Feb 17, 2024 at 06:36:42PM +1300, Barry Song wrote: > > From: Barry Song > > > > We used to rely on the returned -ENOSPC of zpool_malloc() to increase > > reject_compress_poor. But the code wouldn't get to there after commit > > 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") as the > > new code will goto out immediately after the special compression case > > happens. So there might be no longer a chance to execute zpool_malloc > > now. We are incorrectly increasing zswap_reject_compress_fail instead. > > Thus, we need to fix the counters handling right after compressions > > return ENOSPC. This patch also centralizes the counters handling for > > all of compress_poor, compress_fail and alloc_fail. > > > > Fixes: 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") > > Cc: Chengming Zhou > > Cc: Nhat Pham > > Cc: Sergey Senozhatsky > > Signed-off-by: Barry Song > > --- > > -v2: > > * correct the fixes target according to Yosry, Chengming, Nhat's > > comments; > > * centralize the counters handling according to Yosry's comment > > Yet Yosry is not CC'd :P terribly sorry. I thought you were in my git send-email list ... but you were not... > > The patch LGTM, but it won't apply on top of mm-unstable given the > amount of zswap refactoring there. I would rebase on top of mm-unstable > if I were you (and if you did, add mm-unstable in the subject prefix). This patch has a "fixes" tag, so I assume it should be also in 6.8? > > Acked-by: Yosry Ahmed thanks! > > Thanks!