From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A457EC83F1A for ; Sun, 20 Jul 2025 23:59:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 235256B0092; Sun, 20 Jul 2025 19:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E52D6B0095; Sun, 20 Jul 2025 19:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AD196B0098; Sun, 20 Jul 2025 19:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E9F1A6B0095 for ; Sun, 20 Jul 2025 19:59:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 700E81A029C for ; Sun, 20 Jul 2025 23:59:54 +0000 (UTC) X-FDA: 83686313508.07.053BCD2 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf24.hostedemail.com (Postfix) with ESMTP id 8B8F4180006 for ; Sun, 20 Jul 2025 23:59:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=T4tgnZ+O; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753055992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rMDu15B94CMFfjtDZHBtBYYs1+zD5YCySOnFKbF30Fk=; b=NGLIg/s+nogBsxHiE0Dw8ZE109DOMQ8cQA655o4+haJ6si+w520FJsinDCG7dz51eoWG/Q A1qE/Q7PYTcY/pAQ9WoS+ioE6P7jDtEq8qhJRyb/p0rgS9kIBrEOKB/c5qDhBwqrj3l7+8 xA+6o1K2pMZx6qjDXWmNb6BnwcYdxz0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=T4tgnZ+O; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753055992; a=rsa-sha256; cv=none; b=D51OrHueQUlqP+PJbFKKU1+rn3sbzd4Gx7++4/cF/54f+Rc1EgKbk7yZZE4jZ2IUZ5AZxA ho00DVMoLJ1YH+OHgvxeVAajKV6+DKEHLXTK3VzPKWs/qln9Q8wuHwqTc+CyjtK29GQ4xN jwxRL4op2RqsW5jo+SrR/Wk31KEDMuw= Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-87f161d449dso5513584241.3 for ; Sun, 20 Jul 2025 16:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753055991; x=1753660791; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rMDu15B94CMFfjtDZHBtBYYs1+zD5YCySOnFKbF30Fk=; b=T4tgnZ+OFtt4aikxzUJCLWHBVip3oUutw4vyWm2jhLR3ObmAS8srPD2A1Je6WPpIlU C9dK/AMkeTothIs78STzDAZd3jEHcxVFzStFNWkgc6e5YOD48l/36llzU5tsh5/OuZj4 VvCEQvSHhHsS2ZrFI9ZbuOQjyOPYyM2EDmG87uqI/7/ZgybLxKBgqza2xAQt+TElDoVg gfEemsNgiWYtYRm3SsRtnaidArm0CZzZIhcwOT24lzoZzWP9tJIvZ/YynrnZEpAMlWUL sc3JMXb2KmBDiXJx89wqX725yO8wPdQ8MQ0ChJZqTLmBd8OVi5vRbxRHywmXh2lAAhzn 0Fqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753055991; x=1753660791; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rMDu15B94CMFfjtDZHBtBYYs1+zD5YCySOnFKbF30Fk=; b=fEcYWW07EJUwcKZBM0zRxoBHhQ0VBSzwVQ5d37g4rPYWccIJOVuzN0/eYADPI1DhPH /dLWU1rFex9et3/KPv9KTIicGFt2vWUJiumaMSKxOVAKCh1OWv7wZSougo7INWjJMx4E 4GEgwe+O0pwsYC5NdRqI5Hv4V9cDnxtr9M0Lb5HPYiaouPUTvCMq01O8o4XJpNDHm3U8 eeE5I66xWy3cbO7kl9Syn30ShHgQ4KtYDpAct0KcMIUYuNeb9l3ywKf+zGAXhjVaz8HE wZd5wFMvF8Y6TxIruOly2efBf/+wdrIsmPqwHrTJSQyHEqY/bswR1g2NXlFZ1lgYgX0+ wsKg== X-Forwarded-Encrypted: i=1; AJvYcCXBxc7QJdB/26ZguIEGyjuGAJ5LOkaOE/LE5cKPAxXPAvOv7OJRI2jOMhxjyuBeXeXq1n4f5KUYTw==@kvack.org X-Gm-Message-State: AOJu0YztPHfEKmer5pR77rklPeZgilP/F03hIl5TKyW1/nMwVUND/s5r gZVwRWlKEjHsiz2QV9j7eKGgl04NEzakQ4gu6hSAKF7jD/mxIcdXzyi4UZq1k2x0GXgjek39qMu pBmv5gBsDqwqmqhPRYLhQgYCGZWi+miI= X-Gm-Gg: ASbGnct4a4Tpc3AQ+agnRQ1W8eAcT83WrNQmjgzXoTtdhJImRO621zvWUI01MmS0A3A Pg9fm0iqzuJj7oU09Ic3Rm5lrOpj3ZjbUfhQvrL8xpYg5NMRCIThhHp4lpBEefim03gWDmvck1j XrN1obxgig90MF30U6AlJUmDqnnom0izaK8jCUJrUBq91/ieBuY7iC47bhivoL2O3x2+ixxe6b+ 6e10VY= X-Google-Smtp-Source: AGHT+IG7L0m6HoBIB4Bw4NGY3fjZtWacuz0hzTbVUc6/5aUuTbOVmBAoM4nq8umtZuw19e9HBRzvUyaNBDZrSXYi79s= X-Received: by 2002:a05:6102:5490:b0:4e9:b66d:3c11 with SMTP id ada2fe7eead31-4f95f41a4bemr9512749137.19.1753055991556; Sun, 20 Jul 2025 16:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20250718090244.21092-1-dev.jain@arm.com> <20250718090244.21092-4-dev.jain@arm.com> In-Reply-To: <20250718090244.21092-4-dev.jain@arm.com> From: Barry Song <21cnbao@gmail.com> Date: Mon, 21 Jul 2025 07:59:39 +0800 X-Gm-Features: Ac12FXyjRyO4euuMXuvHEdYT2dtlu9tE6s7OP6fEeHvddqbhgMqFlrnYNQfVQPE Message-ID: Subject: Re: [PATCH v5 3/7] mm: Add batched versions of ptep_modify_prot_start/commit To: Dev Jain Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 8B8F4180006 X-Rspamd-Server: rspam06 X-Stat-Signature: mjbjmisxg3usm6tetgkpjnejqyczboxm X-HE-Tag: 1753055992-354353 X-HE-Meta: U2FsdGVkX1/DG1EQGPl/uzmDH7w4KAAkaP/FcUjGJ43+itytyxHW0Jlb22F9gyIXRMcKBex/qoQVZCMx0bPaPfzm+U7//kj4po9CKqdSS1L9mOOK3Y6bDR/UVtocdF9wRHT2F8eq6HRhvvL4pH/iXG/5f25fYWO+OsLOoi2GAanGooRCRpob9p7TM15lMtWBhwlMohXpJSi1y4VLzAwT+nIHp6+z8aQxVY8zR88fZbX+n0E7qfKdqaw6vk5h6kZRXyGFcmsJpNkSeoS9VAJmchPQGNM8OFkfKadQ0tKpTu6AmQ6sxOrPEkFsD2jCXenkxc+8K9tufxi1dWDksZ08KhI+Ugh/7AbfPm4/ayw6P2m+1dHJkC0wRmOVYgI+hfjIHMU5epgrV/yX7OKA6i9/vOx7aKdV0XhOEx3ZixseVjcGMGJNuGWif3gkMSpdtkw6STwJGtaOtiJrcoqFooRMBgxhtnBcAWf6lnZABHuzVFy7m/AVJCItSKpYxSCw/jtiqiGBR+1Dmlq8s2y14+l8ro2VMKbog/Yd1GO7r2mdWACX8Dg2maXSm3VSkOBFGmS3P8TkxXk8uuzPc40RrBT2a7FoXbq7bC/G9gVmJc7KexJyHQAk8zRFyrqNnPZ+4qk62bMbwxw7N5FGDTUeV+wIDuLL1wTOxqAd75nb7wYRU2QS/gxMcb2FdFTvZRrM9uukIMpfHL/zn+zShlYscTK14V1zDCaqKYZV5OwPmOU1mG4DXfDOfCmc/txdOc2k+3Ee0ALNBxbzHzfunQhfKWPa4xIUYyZOWSnudRim7vDcE53bT1Dm6gqXOgpQS/eJawzGihSMkMwLyVVBQqWTflJ7j5Ufl0b8+kzoG0u+2SXselnYawVIB3Mjf4izM4LGQJOpvSCoYgi9JcKrDzi3A0A2ORJZMlbp/emuO5ualzJlsOCXj1heek83Z7JDpVyJ2yA6uZUruiOdP34D4rqVq/u OIDq80JW U2WWSXQtEJq7Mvf4fao7uYX81B4y43TWS5W4ldWps+kAS1Jj/YZP5ePwFiz8x5vmxNBWaNRTSEjNDRH3qTzBLdnGSTz7MRJhdFQJ0MNACSeX8u2f/YHsfnZ/HRalikDdreO7b6/cQ+SLsb3oZmFIeUHffVrJjBfv1Khqwrp52bKvK5p3c5KhwkbXyeByIPL3Epc586ztlrchHYQ84Sga6SCs1p6PQrTScjsDPPNoNPYcxPUGPLZvl2KRyh3igo/0rQ1I6If+h5a6XaIquV1wa7/B/0WgmAn7sEGYHTUPdeScdfiRwWJ6rImZaFxnH5AeP+pnMailcj+CJs/jB77laOij/rsKFbd26+P7mo0As1W/PkCTWCDzrDR2+n9GBXwsmZ86IHApoZ9pSUgUYRcglP5CT2KCgmRPas6Wuwv9DFDR2QG6X9Ee+bHk3DgavxC8L3f/ZdRqCfQCxrun8ckU/bsVL2c1AGyVOphO8gGnBT/KYTIPgzwAIYxiMxRvg0z25P3oh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 5:03=E2=80=AFPM Dev Jain wrote: > > Batch ptep_modify_prot_start/commit in preparation for optimizing mprotec= t, > implementing them as a simple loop over the corresponding single pte > helpers. Architecture may override these helpers. > > Signed-off-by: Dev Jain Reviewed-by: Barry Song > --- > include/linux/pgtable.h | 84 ++++++++++++++++++++++++++++++++++++++++- > mm/mprotect.c | 4 +- > 2 files changed, 85 insertions(+), 3 deletions(-) > [...] > +#ifndef modify_prot_start_ptes > +static inline pte_t modify_prot_start_ptes(struct vm_area_struct *vma, > + unsigned long addr, pte_t *ptep, unsigned int nr) > +{ > + pte_t pte, tmp_pte; > + > + pte =3D ptep_modify_prot_start(vma, addr, ptep); > + while (--nr) { > + ptep++; > + addr +=3D PAGE_SIZE; > + tmp_pte =3D ptep_modify_prot_start(vma, addr, ptep); > + if (pte_dirty(tmp_pte)) > + pte =3D pte_mkdirty(pte); > + if (pte_young(tmp_pte)) > + pte =3D pte_mkyoung(pte); It might be interesting to explore whether a similar optimization could apply here as well: https://lore.kernel.org/linux-mm/20250624152549.2647828-1-xavier.qyxia@gmai= l.com/ I suspect it would, but it's probably not worth including in this patch. > + } > + return pte; > +} > +#endif > + Thanks Barry