From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E4E5C433F5 for ; Thu, 26 May 2022 09:19:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 410AB8D0003; Thu, 26 May 2022 05:19:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C3C58D0002; Thu, 26 May 2022 05:19:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 285E08D0003; Thu, 26 May 2022 05:19:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 169348D0002 for ; Thu, 26 May 2022 05:19:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DE4AF20427 for ; Thu, 26 May 2022 09:19:57 +0000 (UTC) X-FDA: 79507347234.23.8B0E29C Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf22.hostedemail.com (Postfix) with ESMTP id 98294C0025 for ; Thu, 26 May 2022 09:19:54 +0000 (UTC) Received: by mail-ed1-f49.google.com with SMTP id d22so1080937edj.4 for ; Thu, 26 May 2022 02:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PWxU+JtsJL2fNFelQAP93zLeqGyHIZxzH+VL5XQ3RL4=; b=d7vzQFAjoABslZO6OqfWVN6u5AxG15gybO0PirDW2OqMQGCPPgmQh7jvtW8k0q0F8m D6WmGWA7yu7KhX6lhkFX9HxsHIL7Cll3oRAjD1rgNVFhfidA6sDtqFr/prJnYsDQUskz 9Vq66bIYVwKEPU+vfcHzUKekB2F+sAvykw37Nsda44XCFL05NsfhkLw7aOhl3E5xYkt4 4a+kkwbUJ+gvzo7361gOwgtNUqP6icE8htST05hnRh4r62GMO2l95Wcl0BXqZ0HxZ1gK cC0Lj4r31nyk8I0SNfW3tQv9RcqAAmNbFMXgytdGLdkAsvVAqGvoWgD+7dX1ZAPzAtBY 16dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PWxU+JtsJL2fNFelQAP93zLeqGyHIZxzH+VL5XQ3RL4=; b=uOecUQ+msqpIXXax3sWM0tNposPtgc8BMDIDpuLxq7wSo+hbHO573wci/Y013vxvkv gLbMmBnh3yZMqev7MARCVFL22Vcn7/3FxR23PjiRfWmawZpN0x9X8NFWjraJcbpKnn/V V1IFZjbwMbY/VYxT2uVuxsfrNu/kSY4gAyn2KsrgEogkyGdA9MnT5ro2R2eP2qFlV9Ul c20ZagP5EOSiAoiLC6M6pLKbZ1Jx6CSd5MJQ+O6LJHpQbTfjDlnrMNxHtoHD2yjVTF6E VkMt8k/Ng0TvoLi1R3vvKmLVdyLemXkQwcBOv+nV0r7p441dyHLhY+i/IM/m1vbwHoj5 q1ug== X-Gm-Message-State: AOAM533Mka2UHiic52bZk02ghSPASblVb+o7cvl5kL/DISeRFhfqbCjt eJ9YaOfJR3b6tuzVHc++qJPwM6SQ9aOEarLQGi8= X-Google-Smtp-Source: ABdhPJxOEsVtbdINpopRrUKC9mXOVx6hrzWmDtoIRbZCxGsIP6w4zIbQM+2GirpE8IgGTtVG2l4Ltf0ZTku6JjN+xy8= X-Received: by 2002:a50:ea8b:0:b0:428:7d05:eb7e with SMTP id d11-20020a50ea8b000000b004287d05eb7emr37754359edo.185.1653556796017; Thu, 26 May 2022 02:19:56 -0700 (PDT) MIME-Version: 1.0 References: <20220524071403.128644-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Thu, 26 May 2022 21:19:44 +1200 Message-ID: Subject: Re: [PATCH] arm64: enable THP_SWAP for arm64 To: Yang Shi Cc: Catalin Marinas , Andrew Morton , Will Deacon , Linux-MM , LAK , LKML , hanchuanhua , =?UTF-8?B?5byg6K+X5piOKFNpbW9uIFpoYW5nKQ==?= , =?UTF-8?B?6YOt5YGl?= , Barry Song , "Huang, Ying" , Minchan Kim , Johannes Weiner , Hugh Dickins , Shaohua Li , Rik van Riel , Andrea Arcangeli , Steven Price Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 98294C0025 X-Stat-Signature: uwnkckxmj6sey8z3w8z1hj8rnfhcr69f Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=d7vzQFAj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=21cnbao@gmail.com X-Rspamd-Server: rspam04 X-HE-Tag: 1653556794-383467 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 26, 2022 at 5:49 AM Yang Shi wrote: > > On Wed, May 25, 2022 at 4:10 AM Barry Song <21cnbao@gmail.com> wrote: > > > > On Wed, May 25, 2022 at 7:14 AM Catalin Marinas wrote: > > > > > > On Tue, May 24, 2022 at 10:05:35PM +1200, Barry Song wrote: > > > > On Tue, May 24, 2022 at 8:12 PM Catalin Marinas wrote: > > > > > On Tue, May 24, 2022 at 07:14:03PM +1200, Barry Song wrote: > > > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > > > > > index d550f5acfaf3..8e3771c56fbf 100644 > > > > > > --- a/arch/arm64/Kconfig > > > > > > +++ b/arch/arm64/Kconfig > > > > > > @@ -98,6 +98,7 @@ config ARM64 > > > > > > select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > > > > > > select ARCH_WANT_LD_ORPHAN_WARN > > > > > > select ARCH_WANTS_NO_INSTR > > > > > > + select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES > > > > > > > > > > I'm not opposed to this but I think it would break pages mapped with > > > > > PROT_MTE. We have an assumption in mte_sync_tags() that compound pages > > > > > are not swapped out (or in). With MTE, we store the tags in a slab > > > > > > > > I assume you mean mte_sync_tags() require that THP is not swapped as a whole, > > > > as without THP_SWP, THP is still swapping after being splitted. MTE doesn't stop > > > > THP from swapping through a couple of splitted pages, does it? > > > > > > That's correct, split THP page are swapped out/in just fine. > > > > > > > > object (128-bytes per swapped page) and restore them when pages are > > > > > swapped in. At some point we may teach the core swap code about such > > > > > metadata but in the meantime that was the easiest way. > > > > > > > > If my previous assumption is true, the easiest way to enable THP_SWP > > > > for this moment might be always letting mm fallback to the splitting > > > > way for MTE hardware. For this moment, I care about THP_SWP more as > > > > none of my hardware has MTE. > > > > > > > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > > > > index 45c358538f13..d55a2a3e41a9 100644 > > > > --- a/arch/arm64/include/asm/pgtable.h > > > > +++ b/arch/arm64/include/asm/pgtable.h > > > > @@ -44,6 +44,8 @@ > > > > __flush_tlb_range(vma, addr, end, PUD_SIZE, false, 1) > > > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > > > > > > > +#define arch_thp_swp_supported !system_supports_mte > > > > + > > > > /* > > > > * Outside of a few very special situations (e.g. hibernation), we always > > > > * use broadcast TLB invalidation instructions, therefore a spurious page > > > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > > > index 2999190adc22..064b6b03df9e 100644 > > > > --- a/include/linux/huge_mm.h > > > > +++ b/include/linux/huge_mm.h > > > > @@ -447,4 +447,16 @@ static inline int split_folio_to_list(struct folio *folio, > > > > return split_huge_page_to_list(&folio->page, list); > > > > } > > > > > > > > +/* > > > > + * archs that select ARCH_WANTS_THP_SWAP but don't support THP_SWP due to > > > > + * limitations in the implementation like arm64 MTE can override this to > > > > + * false > > > > + */ > > > > +#ifndef arch_thp_swp_supported > > > > +static inline bool arch_thp_swp_supported(void) > > > > +{ > > > > + return true; > > > > +} > > > > +#endif > > > > + > > > > #endif /* _LINUX_HUGE_MM_H */ > > > > diff --git a/mm/swap_slots.c b/mm/swap_slots.c > > > > index 2b5531840583..dde685836328 100644 > > > > --- a/mm/swap_slots.c > > > > +++ b/mm/swap_slots.c > > > > @@ -309,7 +309,7 @@ swp_entry_t get_swap_page(struct page *page) > > > > entry.val = 0; > > > > > > > > if (PageTransHuge(page)) { > > > > - if (IS_ENABLED(CONFIG_THP_SWAP)) > > > > + if (IS_ENABLED(CONFIG_THP_SWAP) && arch_thp_swp_supported()) > > > > get_swap_pages(1, &entry, HPAGE_PMD_NR); > > > > goto out; > > > > > > I think this should work and with your other proposal it would be > > > limited to MTE pages: > > > > > > #define arch_thp_swp_supported(page) (!test_bit(PG_mte_tagged, &page->flags)) > > > > > > Are THP pages loaded from swap as a whole or are they split? IIRC the > > > > i can confirm thp is written as a whole through: > > [ 90.622863] __swap_writepage+0xe8/0x580 > > [ 90.622881] swap_writepage+0x44/0xf8 > > [ 90.622891] pageout+0xe0/0x2a8 > > [ 90.622906] shrink_page_list+0x9dc/0xde0 > > [ 90.622917] shrink_inactive_list+0x1ec/0x3c8 > > [ 90.622928] shrink_lruvec+0x3dc/0x628 > > [ 90.622939] shrink_node+0x37c/0x6a0 > > [ 90.622950] balance_pgdat+0x354/0x668 > > [ 90.622961] kswapd+0x1e0/0x3c0 > > [ 90.622972] kthread+0x110/0x120 > > > > but i have never got a backtrace in which thp is loaded as a whole though it > > seems the code has this path: > > THP could be swapped out in a whole, but never swapped in as THP. Just > the single base page (4K on x86) is swapped in. yep. it seems swapin_readahead() is never reading a THP or even splitted pages for this 2MB THP. the number of pages to be read-ahead is determined either by /proc/sys/vm/page-cluster if /sys/kernel/mm/swap/vma_ra_enabled is fase or by vma read-ahead algorithm if /sys//kernel/mm/swap/vma_ra_enabled is true And the number is usually quite small. Am I missing any case in which 2MB can be swapped in as whole either by splitted pages or a THP? Thanks Barry