From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07712C4345F for ; Sat, 4 May 2024 04:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 611C36B007B; Sat, 4 May 2024 00:27:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C1C46B0082; Sat, 4 May 2024 00:27:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4898F6B0085; Sat, 4 May 2024 00:27:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2AB0C6B007B for ; Sat, 4 May 2024 00:27:27 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A46F4A202C for ; Sat, 4 May 2024 04:27:26 +0000 (UTC) X-FDA: 82079429292.20.D498AB4 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf17.hostedemail.com (Postfix) with ESMTP id E75FC40004 for ; Sat, 4 May 2024 04:27:24 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kg7W5XeS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714796844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XDD/yCGw7jn5yR/Hffav3ixMpXa6OVJh41weDeDyIKY=; b=Xrdsngs1bjiWlHkDRBLkJFqhs77bMO+s+MfjA6sJ/PytYrYQj47vMpUc1gtDNT3hp1fpxz kXObJ993nFXvAUmrniBSeB2LtY2vjGxYoY6OYOfo7kN9yk/Rf5Je5yCQwMl/14SyL0khfm k8du/jwjBPPzdCnOPRgQeMc4pD3fzxI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714796844; a=rsa-sha256; cv=none; b=shBjK5tcx7SMlZVRuTFKaIvbYLG7MR7B3RVD19Uh1y5dMZZFSyi26z/0SOkkirWBIkeFSG EU6a4qEMXv+jniGjYkbfXt7Hines+A6vIS4y+QdHj5Lre5d0svl0VO7yC9JD69OUxFBJpH SpWmzHrKa8Mz91w6Wxfiv+XQYzXc8U4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kg7W5XeS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-de477949644so330139276.1 for ; Fri, 03 May 2024 21:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714796844; x=1715401644; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XDD/yCGw7jn5yR/Hffav3ixMpXa6OVJh41weDeDyIKY=; b=kg7W5XeSjIPvmIXPI5qituIXX0UehHgo4RT8c4J6wZsw7Rj9H/GwSNt+Y7hG0JDLpg WUnp3LNNJp4SHsfuUWKd+14uzSWKiME8a9zja5q2BROEF8bB4lzAZu5PDPY8p6z390LI GVXjLyFPV5c6N7bCI7MTMib1UqEL7t3jQVhrb/7fNcKuxnptTJddS6fRocNkgsL3rLNY jB6jkXOJkz6BOgHubwvkcu0UPlM+fZ1U/Ht1V0q0HFh8VfsxC1mcbkbbsZJhzjqfBk2S lehkdsgHTXTwIxE1qZC5w3bF2OGVz633Ygbzfy4Cnf8TuFOP1PSd5pYJt2TQ7289qe9b 2d2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714796844; x=1715401644; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XDD/yCGw7jn5yR/Hffav3ixMpXa6OVJh41weDeDyIKY=; b=i/F6XTajArSeDKgmpZBzu0dCT6wblEdrPHFRVifR0BUYG6CFBhBdN6cpKoUH4TQ2jW yJ/jAkBbRbZUiHbY47UOlOjfSDi44pt9KCalygkHFLUraFnkxdCXgAM3Y3ZP+Qbiquq3 5Y6shU6Gwqd9uwJdnTyAxpTPnb/xwwRWWSB75UMiwlPr+E6S2A8YraQ3aDkbcWK2HVM3 sKhcmHa6HQh7jjSuf+Uu6BN17YBKo5mlzdDewzRPDJgSKxEeaz5qW3b7shz4XN0u/+go fLvUMxM8c5w0IPPtlV29XMhVNzLRrWCPS9RM7Nn3vB/gzCFIgxlxEhmJ0IlSArbFP7fH U3yw== X-Forwarded-Encrypted: i=1; AJvYcCUkgGAjcRcuSze7w+WH7LBliNcH+GB8mu70Y9uCeJtPlE4vMa6X7hMtwFOefjV6uK8Q51NMODBGvQBcU7LNLeu5cqk= X-Gm-Message-State: AOJu0YwdEAO1Q7rJ84vmpKTmTJZeZe0zjtA3r388ctkKdRv2zL6pEoN0 rdGhbfjm6OyO1ufmFWht9KtGrwNyzxraV7XzzFWfQ/5CcoTgsRaSs9CBagb+9H1fGC7KgdLeSjY ftYz+150mMXxnEXNbOuKP1mFgBwA= X-Google-Smtp-Source: AGHT+IG61Q1cd6ycuy3/N+FKbe3xiOJoP8sklaJY/Unop+PZLPH07XSMkYLc13/d909KkYHzQiNtwH8d/qnR4KPlCc4= X-Received: by 2002:a25:2009:0:b0:de5:c1a4:560c with SMTP id g9-20020a252009000000b00de5c1a4560cmr4983744ybg.56.1714796843850; Fri, 03 May 2024 21:27:23 -0700 (PDT) MIME-Version: 1.0 References: <20240503005023.174597-1-21cnbao@gmail.com> <20240503005023.174597-3-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Sat, 4 May 2024 12:27:11 +0800 Message-ID: Subject: Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr() To: Christoph Hellwig Cc: Chris Li , Ryan Roberts , akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, "Rafael J. Wysocki" , Pavel Machek , Len Brown Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E75FC40004 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: kau4sbumxxnb9ry6iz7dbnx8h1ka4qby X-HE-Tag: 1714796844-432939 X-HE-Meta: U2FsdGVkX1+NUEri81BxhHLsjWGIcQldEFjG55b5UyKWTVgpGqtxJY6cy8eBKVsl0fJNWE1eDwsGjUen2R+9Fk6OiNcOWSSZUhUciDL+gbJPRZ2Adpx1vGowLwoEEjWZlMdeW4SGRhdhR9iZxvb+rba0slL+8nVnICE7gmBf57KvyNb6lCOXIz6fyb+EVhlWyr6Ys3HpSzA/L2ywpuP8DWtPtT9jGFuzgvCJVhlUq9SNzMQbFZFHoS0HJuCp9KJz3pDWwy+3/lrjvCSwLZOKAG+7CU6zdOakCCQwzFS35Up6QhkEO8nAG8Y1S8/XqauDtzBIUEDbJiwiRPGnbxDoDI8CERsWCjIxCJx16YcsS3IuUomfX/EuJRBx37zcj9y/V0bA05COKd4RSu4unws1pmduetbLcAFzCCledjf93i26ReNRL21FSPbOX+R56FMN01zuWK46Ipq8+aqWOyaQp+hIHVzQxk5kw1bQLe24DFpzwQK5O5o9hjKBIA31tKhDnw9goZZGTiYBlGi29A/VdU6L65tNaosJ0qGcrd2fI94wY9KpC3NQlXVulNn7IF1+BCXy20LJL//C8tCCE8uFGBJcRjlLYNDJTB/k70EtnBzYiF7TEIwP5b6irp0LAsBbcnBJKoUaRek3tYPdTUumbP55JQUG/QGKRtFAtN+9mxivrA3y37QuMUHCC8e0QhXzy/TJPFznkV52R5T6fchDjQz0DQ/DiYOPjK8gHduI9EA1pCAsM0Gkwg4aZrOjpgqwRlmg7iz9lQvDDf0VPnv/kG64bIYc/OBu40g4z5/COMuiNSX5H2xHn+yTqumN1+Y2HzcjmjUrRnMV8a0YRsTbbZ+LwSrqOT9xmT/3W5ckFMgTMyNaJTHgzjoiCkGSjEIZ72hlOrwCjmQAqD/9GTiyF4aY6lfPuhWhZnjkEw+8iwct+PYKC9mW3mbXUDdLsM1M49bQnpiE4h1tkHkRQiN CUs8KEZG Bn8OvGe/4HFBxpxNpeXLqymdwT8PqxOmhP61IagypH4zQMntPNCiE+zDJnIqf0gCnF6cHDcXKTpiGqz4mfocrAepERhMlaQ70ABPkrVR1qfx4FRBf1VgBI7ft8iVOPnd+mF2gni1TX5VVN1y2cUjd/girTNFhku4eJwnugUXBzFAoo4kfdK2sIZVEemECD3P1/1OglbS8awec8a0BK2iI7RlrS3hxrv5RqQnhfN0snghyAjl/lOlwmsMs2Z64Q3vcKzclT9aLGPTo45EHiZpGAn76lBGxh+PmYi/vQ2sCfUhMRvXq0NHpPHso0vVIZA/nAS1OE3sTHu7ZU/ZV7tzobMzKpSktzziJSsvH6P9pgMDnaGPHlVJrKy0nM26W0SET9HK4ty0eO0/KZteAyUrY4/MGNAm8N5hHzM1GX+sTtWG/VMAaPonAaezd1Sn61EPo1RAT2hc4NUXPhlJLqMTWkQrRew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000331, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 4, 2024 at 12:03=E2=80=AFPM Christoph Hellwig wrote: > > On Fri, May 03, 2024 at 01:37:06PM -0700, Chris Li wrote: > > Either way works. It will produce the same machine code. I have a > > slight inclination to just drop swap_free(entry) API so that it > > discourages the caller to do a for loop over swap_free(). > > Then just ad the number of entries parameter to swap_free and do away > with the separate swap_free_nr. swap_free_nr() isn't separate, after this patch, it is the only one left. there won't be swap_free() any more. it seems you want to directly "rename" it to swap_free()?