From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E83C04FFE for ; Thu, 9 May 2024 00:46:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 699CD6B0085; Wed, 8 May 2024 20:46:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 670036B0089; Wed, 8 May 2024 20:46:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 537716B008A; Wed, 8 May 2024 20:46:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 343DA6B0085 for ; Wed, 8 May 2024 20:46:51 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A786E8149A for ; Thu, 9 May 2024 00:46:50 +0000 (UTC) X-FDA: 82097017380.22.1227973 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by imf12.hostedemail.com (Postfix) with ESMTP id 8553840005 for ; Thu, 9 May 2024 00:46:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pv14ukzg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715215608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1HutaMr4YNAQdV0piVG8U9fxjw32ZuJHu11VAl/8knE=; b=ko2Y40MHGhtUozCHLZoWacKbdNeRnVBvlDLBQW6A+TWh/h9LPt8hU/zHnpJhizO155f/mQ vBuMG2LN62HaP4D7ua19ixkc5ePeq2RfQ2fc6vA8OotZXN4b9smgYXprRmN+BsCFylE2OR SXSJzN4jqsjD2vIXKys9tZ5o4nCHmZE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pv14ukzg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715215608; a=rsa-sha256; cv=none; b=tsoBLXHnj0XynsDmUQD0fW1v2ztT33UIz+lm1dHjUOMBKdgrMsZquYCQmfYcieMzzCD1jO cPSpLiVUTeFVvDVe09NaEEQY4pRnQK/32DwojMLs42FiK5ROr8/GmkwmEqMIjL+3GzZ+nB IOvcvNt6dw3Lbkcq3QjRbKNoY1g/Y+I= Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-4df1e45461fso148122e0c.0 for ; Wed, 08 May 2024 17:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715215607; x=1715820407; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1HutaMr4YNAQdV0piVG8U9fxjw32ZuJHu11VAl/8knE=; b=Pv14ukzgAZmluyNOndHXc1fq3ad+5XA1BLKeTfNeKuPXgyQuJc5eHYES9KYMgEE8cC lXucvGr++f6W6b2x476pld5G0VCii20Dsq6nvPrTD2SEy+6GAhgK04hB2y8TV+STzn7y Zl61XNq5byUYmTCNP/XNTOlJ9MwjSicsFMrLKbVNf2KPwrQ4CCqcUrAt1A/OMbBVq5gC mQheyRgGtihuRVW8NRQdyXtZc0hOEB5JSrk62ID4QVt1rTNqJfC10mIuHMjK1XMEe4Nc kTN/DQChr3guOQvvhtg60RgCzWo/6ORWs6IKPzCf+SJdLH8rF+u/pH317A/OUEm/XftE 4fLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715215607; x=1715820407; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1HutaMr4YNAQdV0piVG8U9fxjw32ZuJHu11VAl/8knE=; b=MkSUn3z+mSTmvnDvMQYRUFMYbCAdlidInU2BqHlqWhINwuEomUxte370//PNKUymsH jeM+IU493K0HGsY5JTLnVHQ0zYlP9xegYSUonHBeD+fwMH65F4+bzhgMpyw7hiaI9PZx uwaf2gIbcwuIb0XdI9WrAihQSkMLLNFR2JKs3GB+diyATVCzdbJ5n0RVmdBbyctzstrg ZuPw9nQE+gN7n/jgeUAFQ4oFnIF0mdE3tawWIdFfGR8PsA2WG8drU9OiMdEC1uKeCJbP M8T0Hhk5G9/ljYLpCXWdPXapcvl7Xyp1uyzWzYASvyqN9k6X6KhwxN4/D6patXe19TWZ EfJQ== X-Forwarded-Encrypted: i=1; AJvYcCUfe3lRfXjOr/c6quO1WXy8xgPU5tqnYFiO48jpy6PkMjx+rCUuZJtKWQS6uzOBBN92uLgTGCo7ovxkHG306t/1slc= X-Gm-Message-State: AOJu0Ywi1aJ541pu/fwJ8ACxeFoTcqJn1FMxCMiI5qYsfjbQp7lZmtXS dMCob83djKMW73zAEwu1UA9fQfCl+EWpRzMeTNZpeWrSNLAZjrdXR7xbFNaqzdbetrHn9wP/AOG tTPOzAhjJZuzMjkn/ypovtEdMDYrz4g== X-Google-Smtp-Source: AGHT+IF79LXSq4NewTC5DFVGeNH4TGRK7B023rxeM+UTTC9bpQ7D2OYFXWiN0Dal3DjFVZkbQyCweJ7ZkvtSI8S33PY= X-Received: by 2002:a05:6122:7cb:b0:4d8:797b:94df with SMTP id 71dfb90a1353d-4df6929c091mr4383063e0c.2.1715215607538; Wed, 08 May 2024 17:46:47 -0700 (PDT) MIME-Version: 1.0 References: <20240508191931.46060-1-alexghiti@rivosinc.com> <20240508191931.46060-2-alexghiti@rivosinc.com> In-Reply-To: <20240508191931.46060-2-alexghiti@rivosinc.com> From: Barry Song <21cnbao@gmail.com> Date: Thu, 9 May 2024 12:46:35 +1200 Message-ID: Subject: Re: [PATCH 01/12] mm, arm64: Rename ARM64_CONTPTE to THP_CONTPTE To: Alexandre Ghiti Cc: Ryan Roberts , Catalin Marinas , Will Deacon , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Ard Biesheuvel , Anup Patel , Atish Patra , Andrey Ryabinin , Andrey Konovalov , Vincenzo Frascino , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Stat-Signature: baomdwcyjwxm7zhwhu8kd8z5564jkjfm X-Rspam-User: X-Rspamd-Queue-Id: 8553840005 X-HE-Tag: 1715215608-882902 X-HE-Meta: U2FsdGVkX1/DrsjKUNQ6iVTaxST1NlA4ruiMMLoerBIsebBg2C/zwogqudULTiPNjNLhuy5I0z3vY0r8dp3QRDDK3+aXFJIRQ/YDMW4xU8nX7hvOG38GV9QjyK4jCGAra14D4Hdob4oDnkoMlXjILBAAbYvDiHk+PI8pro+lAsSUUGzBI2bQioM0XR+nGm59BFFWHq+K+Q0P5Qh+yjNgrptd59vdsBh959FwSpWGEq1aYRlp6EfUZVq1Qwi8+SJuDSZJDyH6LZL4DDwZPocMf4FeBdy0fr+L0k/bnWtbYzt0jpLEhbtFgvuMWgNi5lA22WbCq9mznh/uqDeEmmIOuh97xlqK40b20STjcbEpLFN6ctI6BcQ9bp/V8mwj2kpIeR99Qk6kMljXAB5nDKpaYOvP8X9a5xvIW2eV+O4sz36lGkXtVcTq3ywzU651IB9z4IUzD0Pi5ixvVxS/n3FjWlZdGLppVftJy6bq3aIAsQn3u8mYRonpR7z/DdhyIHsFCyHOdEuyWgzL5ZJrdduX6rmm753rVzYeK5VQg0Lsw+MQGdECHqjKcweRMSMylz+wKb7/lnGkH5f0K/6Bmr0jwDpFdDrgp0Nhyh01SEOq/uMpYyl9keRtAOlCfz5Zr7qZan3rW2jeWKTrFD5iB2hvEm3NZ5MfTTkckEO2NVsMiL79MB0RxrmOJy2Jd7F7s0ERA7Yl7pZxGxGfzknt6XaR40xw3UX2WBj+K+iqKSMkAxhVZZxKJR5efBsj/HWb9/MuWHWtYrtuW7FeTB/VFyFknjzP1rKSV8cQ0M/18Mta+8UmSSs+SZs9zLT90Fp6u+yef5OGUofuG2RQ0Sn2UwjuSjGQzfviKdBACMwKFW0ZFdv5hpUVlHFWgx8GsMkG1Mu/bzap9yEfU+wOwiStSxAOa5Qv+BAUQ41e1idCIymEdcgy7bcq2bl8WMWU8/5eS+SMFGUcNrZ1MWkVm8/Q+U7 mgRTswhG dhqkVMZbPKMk1cUH+4fWh9i6uNInslIpXRo7bZNiwShC33u1Uf01qKI8bb73fyHnTb015YJdPMpVXsfSjHQxedfwiuScm5Iwbzbw8+6DMaP4gZBaTyBxoOtydwAR/TNgKxHPz6iR8IR+eKTFB7Y+gZfBHJ+0BLVQWjGGlVNNIO40reyAfdN0PRlQk3tx6Vb3sMCH/312UmX+AJYhUkna32byVWxAj3pf2DdIf7r8qnfOLlwaerdYBXt0+yWpjjxXsveRYEKsbJ34TCx/UDW2nbvvdwRhFAzDnVgAFzs3uWBxG5Ci7PFolBv/Hh65juXy93ldUh+H/5cN/4Qm8ph+/mRcoQvJiYCtgmz2Ea11JlzoFEwE3jeHtEB+IclrwW6RoKI/gPqEV7pXyRqD9XqCiSNVLjcGcqNPaAYhaililX/LKfzYfJe2yltrnv3CGgw+4ldU58CcDalemHGGXCiTEKsfURlIYkYPH8vPuqpcZqqeJO5F+GdVX0IpivRGepiMeyE6TJ3GN9FOPBrlI3FhRqQtTyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 9, 2024 at 7:20=E2=80=AFAM Alexandre Ghiti wrote: > > The ARM64_CONTPTE config represents the capability to transparently use > contpte mappings for THP userspace mappings, which will be implemented > in the next commits for riscv, so make this config more generic and move > it to mm. > > Signed-off-by: Alexandre Ghiti > --- > arch/arm64/Kconfig | 9 --------- > arch/arm64/include/asm/pgtable.h | 6 +++--- > arch/arm64/mm/Makefile | 2 +- > mm/Kconfig | 9 +++++++++ > 4 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index ac2f6d906cc3..9d823015b4e5 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -2227,15 +2227,6 @@ config UNWIND_PATCH_PAC_INTO_SCS > select UNWIND_TABLES > select DYNAMIC_SCS > > -config ARM64_CONTPTE > - bool "Contiguous PTE mappings for user memory" if EXPERT > - depends on TRANSPARENT_HUGEPAGE > - default y > - help > - When enabled, user mappings are configured using the PTE contig= uous > - bit, for any mappings that meet the size and alignment requirem= ents. > - This reduces TLB pressure and improves performance. > - > endmenu # "Kernel Features" > > menu "Boot options" > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pg= table.h > index 7c2938cb70b9..1758ce71fae9 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -1369,7 +1369,7 @@ extern void ptep_modify_prot_commit(struct vm_area_= struct *vma, > unsigned long addr, pte_t *ptep, > pte_t old_pte, pte_t new_pte); > > -#ifdef CONFIG_ARM64_CONTPTE > +#ifdef CONFIG_THP_CONTPTE Is it necessarily THP? can't be hugetlb or others? I feel THP_CONTPTE isn't a good name. > > /* > * The contpte APIs are used to transparently manage the contiguous bit = in ptes > @@ -1622,7 +1622,7 @@ static inline int ptep_set_access_flags(struct vm_a= rea_struct *vma, > return contpte_ptep_set_access_flags(vma, addr, ptep, entry, dirt= y); > } > > -#else /* CONFIG_ARM64_CONTPTE */ > +#else /* CONFIG_THP_CONTPTE */ > > #define ptep_get __ptep_get > #define set_pte __set_pte > @@ -1642,7 +1642,7 @@ static inline int ptep_set_access_flags(struct vm_a= rea_struct *vma, > #define __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS > #define ptep_set_access_flags __ptep_set_access_flags > > -#endif /* CONFIG_ARM64_CONTPTE */ > +#endif /* CONFIG_THP_CONTPTE */ > > int find_num_contig(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, size_t *pgsize); > diff --git a/arch/arm64/mm/Makefile b/arch/arm64/mm/Makefile > index 60454256945b..52a1b2082627 100644 > --- a/arch/arm64/mm/Makefile > +++ b/arch/arm64/mm/Makefile > @@ -3,7 +3,7 @@ obj-y :=3D dma-mapping.o extabl= e.o fault.o init.o \ > cache.o copypage.o flush.o \ > ioremap.o mmap.o pgd.o mmu.o \ > context.o proc.o pageattr.o fixmap.o > -obj-$(CONFIG_ARM64_CONTPTE) +=3D contpte.o > +obj-$(CONFIG_THP_CONTPTE) +=3D contpte.o > obj-$(CONFIG_HUGETLB_PAGE) +=3D hugetlbpage.o > obj-$(CONFIG_PTDUMP_CORE) +=3D ptdump.o > obj-$(CONFIG_PTDUMP_DEBUGFS) +=3D ptdump_debugfs.o > diff --git a/mm/Kconfig b/mm/Kconfig > index c325003d6552..fd4de221a1c6 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -984,6 +984,15 @@ config ARCH_HAS_CACHE_LINE_SIZE > config ARCH_HAS_CONTPTE > bool > > +config THP_CONTPTE > + bool "Contiguous PTE mappings for user memory" if EXPERT > + depends on ARCH_HAS_CONTPTE && TRANSPARENT_HUGEPAGE > + default y > + help > + When enabled, user mappings are configured using the PTE contig= uous > + bit, for any mappings that meet the size and alignment requirem= ents. > + This reduces TLB pressure and improves performance. > + > config ARCH_HAS_CURRENT_STACK_POINTER > bool > help > -- > 2.39.2 Thanks Barry