From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CEEE7716C for ; Thu, 5 Dec 2024 06:33:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A19A6B007B; Thu, 5 Dec 2024 01:33:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 352406B0082; Thu, 5 Dec 2024 01:33:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21A2A6B0083; Thu, 5 Dec 2024 01:33:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 06B056B007B for ; Thu, 5 Dec 2024 01:33:41 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C09361213E1 for ; Thu, 5 Dec 2024 06:33:40 +0000 (UTC) X-FDA: 82859938728.03.3BD5488 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 7D218C000C for ; Thu, 5 Dec 2024 06:33:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Kqtkup+K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733380412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bY+b0xTb8ZmdemLjxSlbAotpStBS9jhlVR+fF3spJyw=; b=TjNLZQl4o0MtZDTLB/N2uhweZTIW6TNWRMo+xOdF8EK1kKjqydnKT80A/U6hNCtFRE+VfW wNvTZ8KLvBJxiCHCCz02TgOkeABZganM5LnZUKtgfF92Z9IC/DQ6l8MTekpenba8XfFx2B i9dg06+tAGsXXOxzbwbKCe3obY+pcnE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733380412; a=rsa-sha256; cv=none; b=xxdiNBhfFtOLcgKaIrQDd750AXL6aTA79f3pv31rnhJrp61Bos1qM9JQPEu/tL8EctVREK R2mCRVMXhgfW3mCLLFnR7hnGuDAZ5qghrnAxMusrJFCP4avCt9xmqWA0wylkBwUxt5qGYG mutugEbYJaz17rL3GU+ASMCF5bRpB9E= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Kqtkup+K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-4afb8c1691dso144888137.0 for ; Wed, 04 Dec 2024 22:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733380418; x=1733985218; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bY+b0xTb8ZmdemLjxSlbAotpStBS9jhlVR+fF3spJyw=; b=Kqtkup+KP98PKj1igIqLgCC+wkZL4jCvY4CxcY3EHLFbSPrK2mGXcmeCUWFtoazgz7 VhFqxBzXeRMJwvoI+Sd2LJrR+OhSKMLX8nNKlbS42eq3D/jep76FywhGIb6g9VA0ef6+ zc2IYTNoqZS0F73YerZ+4xbTMmIrouUWakGKXARmxHnpHGBzsDT/YdQFXnBvm5AnF2tS Ljb25wRtTOiymZ4jwRoERwrNl4z/xvQ7xAKOWwvvc9JD0B30QvDfpY4hIstN0y3ZdsQj 9DAmeKdbITfOYpLbO5JAXw665OHxe4GGMjsRKSQhVuYRxFa/6IQhTNKoT2iUjN/9sMbb 0Yzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733380418; x=1733985218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bY+b0xTb8ZmdemLjxSlbAotpStBS9jhlVR+fF3spJyw=; b=BwTIwpj2G8KctboF1Wv3kuNUyPjrepueb/5l8+a99YwQs2vQe/+HY9WT47fS9RJbT9 QbrLU6AzZXeOb5Nj4WFd63REhHogdjBLaR7hNQkGpocyZFFN6kUDstdHCTykloJoctug 1b8MVNTTp/QBbO1kJks8gd6mKk6EM6cXj5pr1QFjbZr3KwehKVJxK+Na8cBQ5kR/pllE kWBP5uuQSDwWZTMyvlqJDhhOUEjcqwZCYD5Jy5ziaZ+wnGGYuuFOVLnjjEAqUdPKYTci Z7I+9PFMxFdqPiuCt4bE8TQRgmCoSfuQtg/9kgDJO3/JTmfGiSGXhQu0Myk00ReHaVDM 3iAw== X-Forwarded-Encrypted: i=1; AJvYcCVzPay711g5Yb3NK7bCden3vLzAyJjCNUt81/BYCGcvWpozbi6oxnUM4nN8MRrSm8Vo4ufKoMWGng==@kvack.org X-Gm-Message-State: AOJu0YwluKM01e+1BGZnhnWEUU8CG4F9Ij5fp762OjZ0BK9J2RXuT245 1+RRiIN9f56THGkFCBLWYtevGh8bJDb2gubhYwKkoLHl/XG9OMiUOpouxjCVY7SP6VzveTJm5cr HlqsFE7wPQ941A0yAjuHa86iRQBU= X-Gm-Gg: ASbGncvxQYjfX9lSVopWyGYqCeWcBV2MF/ih/93fYaSFVcrRBonQVaJ/Xrpz80A9CVD My8G4s2Md81UVeuknnMBsmS2HLm3HT6mmp9lL5adc9koSr5lbILC+NUd7MR/Fdkw10Q== X-Google-Smtp-Source: AGHT+IERqDzM5gmDIo/KivV3jGkklwe/H6ZETWS9YZLPfHPITYcompqQJJ5/bdWwEa45Q6bWjoEXurvkVvab1g9jrhg= X-Received: by 2002:a05:6102:3668:b0:4af:a576:30b6 with SMTP id ada2fe7eead31-4afa5765438mr7735662137.20.1733380417968; Wed, 04 Dec 2024 22:33:37 -0800 (PST) MIME-Version: 1.0 References: <48fe508d-ecb9-4607-aab6-cc18b4bc78e9@linux.alibaba.com> In-Reply-To: <48fe508d-ecb9-4607-aab6-cc18b4bc78e9@linux.alibaba.com> From: Barry Song <21cnbao@gmail.com> Date: Thu, 5 Dec 2024 19:33:27 +1300 Message-ID: Subject: Re: [PATCH] mm: migrate: drop redundant anonymous statistics for file folios migration To: Baolin Wang Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: kf6cjrip31x164aeqhc3n8h4ogakzdf5 X-Rspamd-Queue-Id: 7D218C000C X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733380400-510546 X-HE-Meta: U2FsdGVkX1+EeL1nPyOF0YNCNDrYfNq3Tdik52Hq7SFk8lA6Gr1SLULCW8rbNFZEP6foRPh12fSEzsGY/Ri2x7d8MB9pwn+Ph7MFpLgGTdXIcvU27zZethyVksj3GURxwzB2B9nfIZ9N2CdvwtzV7Qw8ucYDB+GFmcbYJfrY6hHf7/ms6XT6pFBpOAP7UV4biZK+deCZrMueslz2MzPacvC7NrUTW1BQD6UslPU+z8q5GTRc0ZC/Jy26CBycFcYw0N83iwbGZlain5W6eNyZJmMtXf91UWj740RBl77n11gJSfL8Ur6uVq+uD0QaNJ3IfmYaDdPt0IrIAPgtOm8xa7fseJz4scN+5Hxw35A98fnoIEh9SEkHDDVIGxMn7/QoW1xA/0ljp+2R1kejvHhVJKxs8VEANWcLC/HKndS8ykQ03kVhBZrOdPDuJVC65K91YR8HFlcSWRG11JNdvFui1rlGOe40e+8csUlknpG2ONqkRhPbTlnx9n38Upwc9BRsswWDsouZXJGBX1msX2PtGTFAiWWrtkWk+XIMsUXhPZtNYAUqVR3PCsKJAW/CAq9kx3bzSvLqZKowsV2AWvvDvZOyS2nvhzt6ZBRnLdTSI5rUA/d7nHHjq6ELwRDpDQ5ZFOlnuCTh/4JUq9SbuTDQk44GAgHH9a+immZ9SfXEWSbKlhc4dN/z8EYxST8aTpifL0kVymK7dduZg+p1Go3ZuOxhvsZQWB5iveVZqKzoCg4XZjcP1Ss0rx/eRSh2eFZTReyTamaIKupCyZ7lPq22JMyNa5Mvo9slIjME8gDfPsy/TM3w7MHO8sRXJu45RWQHJN/lzqv09gR5aalNuMRVFTQTb73uNwRzMECb0RZf4io2Oj3nJGOUGTEY6FynpuvrhR+tPNo3CgfKq9WeK3EsO79uDtjkdJdHQQsaBAbn/3I+oFxUfvRtapJsxkWqrcEr2SaPWPNjvLPOoE5t7xj SxZ2zU01 uhpmgev1QFNtdDROPIelTJgTTLX5FpbfOI2WiPDSPCQJDBFymC9z/w/3oJF8jpLsYFcg1548+sAW4X7fUnrDWRh4VJiQarTg2mTR0PyHoqG/k+VBIGuu8ecq0QHOIsqA9/s4EE1i0+5tarL2jM7SWblsWaq4tP+lXBztdR46Zu3UZa685fj/81vieZo1L8ZmTseuNTMMkIZ+GAXMUp/sJ4Dk2BFY2gaqTPF3Xdp4KXSRsh1PrYrY1DRGqVQ6Ygua2TCw/ZX/b3y5CT/8SN8o1x1CyGUu3HufgTbuBijtTVSdik9NPMXlFWYhWrj2jOm4TBDlZe7VnI+ROTZ5YYZeZ2jStOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 5, 2024 at 7:06=E2=80=AFPM Baolin Wang wrote: > > > > On 2024/12/5 13:00, Barry Song wrote: > > On Thu, Dec 5, 2024 at 4:54=E2=80=AFPM Baolin Wang > > wrote: > >> > >> Commit 5d65c8d758f2 ("mm: count the number of anonymous THPs per size"= ) adds > >> a new anonymous counter per THP size, however, when folio_mapping() is= not NULL > >> during folio migration, it means this is not an anonymous folio, so re= move the > >> redundant anonymous statistics in this case. > > > > why? Are you sure anon folios won't call __folio_migrate_mapping()? > > folio->mapping is PAGE_MAPPING_ANON for anon folios. > > > > static __always_inline bool folio_test_anon(const struct folio *folio) > > { > > return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != =3D 0; > > } > > Ah, sorry for noise. This just caught my eyes when reading the code, and > I did not think about it deeply before sending a quick patch. Thanks to > Barry and Ying for the reminder. No worries. I recall encountering a negative count during the development o= f the original patch and eventually realizing it was due to forgetting to increment the migrated anon folios. Your patch seems to reintroduce the bug I encount= ered back then :-) > > Andrew, please drop this quick patch. Sorry for the trouble. > Thanks Barry