From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B3FC54798 for ; Sat, 9 Mar 2024 04:57:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 625496B007D; Fri, 8 Mar 2024 23:57:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AD2C6B007E; Fri, 8 Mar 2024 23:57:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 427AA6B0080; Fri, 8 Mar 2024 23:57:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2DB5F6B007D for ; Fri, 8 Mar 2024 23:57:02 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 874441C1960 for ; Sat, 9 Mar 2024 04:57:01 +0000 (UTC) X-FDA: 81876291042.30.2704D14 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf27.hostedemail.com (Postfix) with ESMTP id C1F5C40005 for ; Sat, 9 Mar 2024 04:56:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ga3DJ35B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709960219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=osWZlmBqOmSJdGGGdtztOJyldzmIVm2zqkCVbfLVzA4=; b=e06JswnnCs3RmFIptWEsvjnbKeAZhNGQKez9QrVNBrjyFWTWUdXB8E/lBuz4sYhsTGRYH9 JMVDDK+aCqq3WPC1TMsBsN6ZCClaRl0EO/XRBF51B+2FFPluvQovEME+ZHrk/7CamRGXh1 4QOv7iQG8YkEs7NMTcDqqOm4jZ8HxMo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ga3DJ35B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709960219; a=rsa-sha256; cv=none; b=sWST6xRvkXsmDpCzSgf6sVpbqjLqOLlLMjnnW6WJej7xI4s2JIDKYg6EXIqfcxTpcUyOQv KpEAHbkOvWZs2I+pAmgB4HfxF5BsgacnoMJsMKm5pRnJGc1yNlVm2Qip//NGOLFasWOU/m CecTcosWKaM2gANcoi6bPSPX72xjlAY= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-7da728b0597so1246330241.1 for ; Fri, 08 Mar 2024 20:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709960219; x=1710565019; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=osWZlmBqOmSJdGGGdtztOJyldzmIVm2zqkCVbfLVzA4=; b=Ga3DJ35BjmpPI8X7Inx3P3rwTJkKrWGr5tUcGtY2HccAwzI/deO7NG4Pm7XJ+64UIT oeqVAvvZpZKh/Lk1Y6xI8HM31wL5GV8ENIRohTPpTLItSjbww78qk8iDrwh6H+Q4KwTs po/xERmTTARXtxHq3mJt9vCjcYPXqjFoJBaKVqcED57hNMlkM2jEME5FRGM8YgZc4PFb i+bGmVceC+9ZCQ1BA61w/QBithUBqjm9XQWsriBMQmy2+li7EDHR1c46TeTXfM8lsqxM XFpbTrP+xHCNSfGoyYfK/aoAMre3WLHEMSBeWItOxMrH9735OScbmOQtuTzhnDCtjqS0 EQQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709960219; x=1710565019; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=osWZlmBqOmSJdGGGdtztOJyldzmIVm2zqkCVbfLVzA4=; b=iXcdzYSlm6RhD3yd9YXbUAJWbw62Hx+hXqt0CUfofba47exTUwH58r647mkyardQBj 6+iteBM6heZEeRjmjQ24IvV41K2vCa5nDo4BbSrKzFRbgFdHbddD/VmiFulJvxGjEDFX k3Bz/z8RF4BJVm6RyEF0Pr6srC/S2qxMKf/9Qj76/a/a3QNMBKq2WQd9xwWE2QD2MjxS K/uGxs6Sb0GG0UL4oELVdSNmCebP3cvCrYYTfVkjMoYv8rANUNYwqpff7oZkvAHEjBxm uJuCVBLkvCPiajJyWkpRSfh5xoj1+iYU32BNXJ64jLVBwzflRz86VbpC6Yp/mw8s1A3d Sy1Q== X-Forwarded-Encrypted: i=1; AJvYcCUEqHDc70JoJ9a/eZWmHhKzuMOxncq94RscCvsLivRsoTMqVOIz3459KGEkZDci4e5hgbLgL4BvUflu8RErn7///10= X-Gm-Message-State: AOJu0Yxb03PeptuoKfzTWlpdWlZCeFg1eLfTzOI83Kxaa+bRzZYZJr3+ Cx8IN+/EydlQgl1OIP0jkNNM+ckrMZJqMf1gsePX7psTE+LhNj4Yw7i2Es2O2sjN5/fA3duarA4 dxKBR1TKUHFSv0J0xEBO46zeac1s= X-Google-Smtp-Source: AGHT+IEfPvgGnvOmPfBz0ryFMzUkH06078cz1HC6iNd3lI3FsufJVZobQkeMZtVIXfrhk9y3sc87ratO3Pr925fF/94= X-Received: by 2002:a05:6102:9a1:b0:472:eeb3:5c34 with SMTP id f1-20020a05610209a100b00472eeb35c34mr849041vsb.9.1709960218874; Fri, 08 Mar 2024 20:56:58 -0800 (PST) MIME-Version: 1.0 References: <20240222081135.173040-1-21cnbao@gmail.com> <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org> <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org> <20240308204251.43d7e518ba95fb4ce22f8d4d@linux-foundation.org> In-Reply-To: <20240308204251.43d7e518ba95fb4ce22f8d4d@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Sat, 9 Mar 2024 12:56:47 +0800 Message-ID: Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable To: Andrew Morton Cc: herbert@gondor.apana.org.au, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song , davem@davemloft.net, hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, zhouchengming@bytedance.com, nphamcs@gmail.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C1F5C40005 X-Stat-Signature: xkjufajcdrfhdaxp8p9nkjtcbfwrgrqd X-Rspam-User: X-HE-Tag: 1709960219-730879 X-HE-Meta: U2FsdGVkX19NZw+Oqu2Zd5Tlr3kAdcalEm6a9p/HLzzPxFThDRQZawmgZbISjvp9Jks1MxmSJkEorh0QJXuJ8ps3qbuGsQsLJCVVmNH769DgtCB8yc/XM7HMk2fcuhNCVGMqnUdqxq95rXDmrO9ZYy8UERTrPyjrS+X1LnYKTeKnpqCo3vdDhHPQs0cAy1L4m1ihsJ+DEcJ/inunUnVKAJIMleMMGzFqRJ3zbqd/Ue6Es6nDLaZzsY9OVEKVSYJKR5h0Tk4A26D6ve8MEpo735fVng7+w+qe9Qyko0+l7OJv95v/0Jm4SFGKurs4l1/JlM9W4wjQwp/o9A5+b3uUIIAh6QYF3N/miT8gLD5KU6cIAX+tIfevvKdOGU9+1TSm6x0SMSPyB71chAxdjR8aCLaDH1F67akxLpIP9p3xY1xXIcjpqprWQp/l0j3KAlyr9Tq2Vp7hF92jhSRHftiQbEEkuwkj6KTC0lGucAriaOLhH7NiAV4BoxfgyrU0TwCltlDdXR994E2fwunto1cAS3to5wlViZqNdtPidZZ7wTaUmHKucJYx7ZEUkcxIuE30nju+kGYNRueJuphuSPsYJeKkhAbygi1Y4chivduMG+kNv3WfIvXQxRjpotO4ERtgJmbI69PDGjT3ZB2/VIYqAyHrNOZDvNKO541RDFAB56/4CbZVRP91KY58bL+qYHZrNAcdtizxFFA3y04vRSsfnYP/1jA3UAh4PgU0oXo8Yeaal69d58zsDpevEqpYp78RHsTE13HhPzWOk/+oiAcw1uxl3C9ITZl5I96YBf5wCGtoSf1rs3JqsreViHZP+HDAjMlBF/UbIvoWphr9Z/6gC5twFb3tBxGqRgNEzlICl76p9kdV5lsZUaoGcYgBln/Zor4bQx5BozEBlGClHT/go8RxnpbWitPLBKW6XCUOQmXSfPG0qyko4T70XFkW8XHrgUcDy9lJOiALdrOfY/e IvEBivbj rQNiCA/S47U9OyVfpagMO9eTxL0PuDXK8NrzHcqV/aSDwm+Xi3l8xlFoeVtLQeuSm42n6d3skAkE3drgoOnlCjzHt7cXC6JQ0iMNbf8Fsy/Zp7Tntnep5l+eSPsDf4ucnrfMOfnJXxAKostjXZQjzrqZmAO5/lRsMh4lswgF4LasRok0RLXWzjYZH72b0rZg8j+R8JaX3vcsmQs6aHptLmhWTrfIUm7D/bvce4Rc/yOozHSeTWhvqKxeiy8LwbIn449KK3manwbZygwutqfrEde0MMFPAaDd2tyzSegbvGHamDlNO+AwNSwEkcUwJtJLriAPQqT6XZ3jFE/CryfsEQYy2TJBwxBBxwdItMJDLtuRFpX31Z1cWDh8cq+H4/M970nzbSYKqSj2O3hSEy0P/mv+Q1BjhMXSlxdlK+AFiJXcQqttbps6qsopJBRCiiCD10RZfR3o+29eYknZmMDXsQIdvSVuRJXStSJv54xkU7R4ml+P5C7JTH0q2Xuj9HnAclmqPnIZAnENJWC7Z65M3rpJMkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 9, 2024 at 12:42=E2=80=AFPM Andrew Morton wrote: > > On Fri, 8 Mar 2024 20:36:41 -0800 Andrew Morton wrote: > > > > Okay, I understand. Since this patch improves zswap's performance, I = wanted > > > it to be integrated sooner to contribute. However, I'm perfectly will= ing to > > > respect your concerns and adhere to the community's best practices. > > > > > > > OK. I very much doubt if anyone is running those drivers on mm.git, so > > adding it now isn't likely to hurt. > > > > So I'll merge it now and shall aim to get it upstream very late in the > > next merge window. > > Nope. mm.git won't build without acomp_is_async(). > > We can merge the zswap patch via the crypto tree. Acked-by: me. Herbert Acked the acomp_is_async() patch in v5 instead of picking it up into crypto: https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/ > > Or please just resend the zswap change after 6.9-rc1 is released. > Thanks Barry Thanks Barry