From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1ECC3DA61 for ; Mon, 29 Jul 2024 04:52:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3434F6B0098; Mon, 29 Jul 2024 00:52:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 319E96B00A6; Mon, 29 Jul 2024 00:52:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E2016B00A7; Mon, 29 Jul 2024 00:52:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F3EB86B0098 for ; Mon, 29 Jul 2024 00:52:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A39C7140219 for ; Mon, 29 Jul 2024 04:52:34 +0000 (UTC) X-FDA: 82391569428.26.C339F48 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf09.hostedemail.com (Postfix) with ESMTP id E0D91140008 for ; Mon, 29 Jul 2024 04:52:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GLsLSghY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722228713; a=rsa-sha256; cv=none; b=xs6twPy0pDQ1o/Ru1lkFCh9poV0JYhkJFgBO3y04KKVyEpJ+522lKS5CkKC5lVZpqJEW1t vlQT76HYqHetiRfivQoDS9fBxJSJ2UDZUKjc/WcrQ2BFfQ/VXOsIllK9wZPQiYiqd5oxVj DYy9/vxPqk5DXAbQoklfNop8b1FZiqQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GLsLSghY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722228713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ofiyx5F0hQVYQXdxJr8h0U/CqHEl0NlaMiB507KxBTo=; b=mAradytwm9xyqdNbqtjVB4qUzEb6ic+TtpIuShXeKwhKA4ZH4vctuKa2GTJUjUb/mlP2ws tBryPkCwOc+xr+LH7FIPF9/Z5YZiT5qARf5nQ/L99A8vax9kv8Vl5ac8QF/YyvlYKgx7Xd asdsZO1zQPZxqec0eNCjhOJOa19S3R4= Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-49297ff2594so476379137.1 for ; Sun, 28 Jul 2024 21:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722228752; x=1722833552; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ofiyx5F0hQVYQXdxJr8h0U/CqHEl0NlaMiB507KxBTo=; b=GLsLSghYXmy057xRdUCEe/VX0HW3/ziWKFRRYOHIsDOYXYFgNkeGryUO32E5W8wGxZ bi3YotEl+4tywRs4LEOpod1AgTDs6biQEMLw7RUsKPOAMip9TF/w5weqMAglIpB1xtJg k1AUOOIwQiX8dCmVKwgwVGvNrHK69VreK+aALsOWRM8BZKtLGnue/gy/fLCzEVPWtOMR S/snHwm/UjqeyRh8oNC8P7U8lUefdx1hS5ce9zfOJIajEUjBl6DkEDfgZE7D8mHtsxYN ZhZiAHj+0Fkezo6cYvMsE7HYOcmk22Gm3R9leTVs54eUdcNcxXUZmsjvJjELEjCKxdsW 8Rtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722228752; x=1722833552; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ofiyx5F0hQVYQXdxJr8h0U/CqHEl0NlaMiB507KxBTo=; b=cuqd9Yiqz03LjlmzTc9bLT8N+UC9GWGkcRratoJdZF5ypf00rN9ch/F8FkReTk50iU 8bt1hUfCpvix811zpct480ki8IZh8yAvi2KeqRWv1EWFrfqGsEOiVLI71gyD6B6iIGSo 77wZ5U6JeIhTqQZC+H8SJ9oQLb7NobLHpl1UVJEyhLpxMrxOCYGHuyjPi/i2OlYHAaIQ cZJyHcwC6vkIMAay1lRFvVUeTgd1eFPgchHWwxeOrvH124HsLw111q6WSywZwD6Anwpt O2BvuEFT0BapOb3ZdJt2vcINitp/aRK7fz3rCwf7EOmg0ArKD8R4hEo8NOuDRUzjGL1d lTMA== X-Forwarded-Encrypted: i=1; AJvYcCWqaSo9zlt5R2jYWYErVFRlOU/v+dCC1mS+8Nm/YN8m90awNm0TdHUvbw3XWReFDMprnHInpAlFVpoPF09Wze43psE= X-Gm-Message-State: AOJu0YzAAP7lueMt6m1BZtPEHNVIyZhj36RThXFwxGzwRFsZ434+7g1H 4jfs0bGcrQubo9p1kemmwjIExB29CILmY7qukI96s78pNvIA7RFYf659ExQiBysoKau4bvJlLsS BKFANI1IoJc5hvy08t4jGenajzus= X-Google-Smtp-Source: AGHT+IHQsxFo1QG7juCbJBdv3znU8kGo5WoeRRqZ+fNAtYje2XFef5zWQusAXpIMuMtzU3QjpRQJvth37+2A76m5caQ= X-Received: by 2002:a05:6102:32c5:b0:493:bf46:7f00 with SMTP id ada2fe7eead31-493fa61bdf0mr6994008137.5.1722228751920; Sun, 28 Jul 2024 21:52:31 -0700 (PDT) MIME-Version: 1.0 References: <20240729020222.36389-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Mon, 29 Jul 2024 16:52:21 +1200 Message-ID: Subject: Re: [PATCH v5 2/4] mm: Introduce mem_cgroup_swapin_uncharge_swap_nr() helper for large folios swap-in To: Matthew Wilcox Cc: yosryahmed@google.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, ying.huang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E0D91140008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: f8xfrizm8ng9sp19qnayoosnbc87bhu1 X-HE-Tag: 1722228752-636463 X-HE-Meta: U2FsdGVkX19RZRlNbFdrKVvoeOXPtOcT5IAkXhPyWH8uLlp8ugU1HkSWT/Uzfvzm24SiglHhxLoleNNfGYcj9GEYUEe+9KCFuh+qtcuC83jhIHMtfXaXI8sAckqBbSSmoZC5RnY/3x1wEI/3xKK4huzFTKaF2l70EJUmzW6UYV23Gf/9qd++pArZhMStVWS9jKtN6ipyH869VZMWnOqlzOhppMomWMFdbj5K9pL7+VmlCLucw5QAKXdMS0YpFlDT9r4n06Pz39t2RImx+mjlTbXQbhORwyq8LL25fWNRthw5FyYkKCjp6JYvj7wh6cU+bQwY+/ExoiKyzVEA7xab81ALjzrKJps/RZYbyI4C4O2+MMvip+/QdG2oXNxfIiob5YzKaZP/lJolMEC4JNCVKhl/ua9k4U6k2a78xR93ruOqDLCH3Ld2kwNnyQn64hdemtrmrk/nWqGCrN3hluVVWPyg84EMGNhha4Oco13Uaip/PjBqAwjo4vLySrfVGiy7lkDGCMmV0tdPymz6FuOOKYiBES9bFIGkkhTK/epmsbB05J995+tHp/mTZzyYSeRuLIwyrAzLbML3DqTUBbf2OZgZQAlkAdmk1c7kUpgFpldzFJ/Fkw8I1aYF1o/ORhOiMTHN/3lz2YdJ1X3dW/VnqDz7xBV/jQCXIk6JkKs0yXH0n7M35GLvC5it909t/NHK7bZkdJP89l+Qs/feAAhFlUN6bIbeOoYBi92rK4sF8Tssb7TBUMNOpTva1JL65T5gqdbY2K3aq8mDXSu6rv0Ec4wBvBFbB5PMvO40eV5EncGkOQnJd4xHYQREe5LgkDMIbyuzEQ2uhCWBAZ5WEVcUITXKiyAxDoam8QmwJZfVgvRpgT7va3mbW7TSzsqWl45Xnq9hpLAqXQ5HkBBXhuiAX3rLrT39Fj7wcND67mM34CxKj8AKaTWz7vmmazhGEhTAU4n+GlNn06w7A7zxHJc Lb4WYtoX hnz4K4FNfLtttx6t67uP30V9X7T/JKtn1VOiOXJnipb6PVObANVZFP/xuBEMVExMb79pRVDQ9n7hEVG/oNw0SAHnZl2HiHgJCfaeMQam5JQvWgFRbk2WlRnYEK4lCIbpiLkevbC32SgCxVYvnpfXbzEUtMoFgm7nBFHAFlvajm3rO55LdO4E8Mqv35zf1YSISc9Ycq6W/FfX5e21Jj9h09V7A6oJFfX+r34/4lMJeW7ed8KtMvi+E2a04qi6T3Gei9Uqo0NCJEeq2bXXYG264YLXv4P+GTJOs/MHQVk4yPtNCFZX4OVcemfJ32/Mplak35auXkDPloV9gvWh6qTXVq4xR6FYz+Cepf5n8a5zoQYPqAWgs0/HPAoi9eiaX/5wa5UqdP8/wzIwD4TKhFkYX0cwlYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002863, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 3:43=E2=80=AFPM Matthew Wilcox wrote: > > On Mon, Jul 29, 2024 at 02:02:22PM +1200, Barry Song wrote: > > -void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry); > > + > > +void mem_cgroup_swapin_uncharge_swap_nr(swp_entry_t entry, unsigned in= t nr_pages); > [...] > > +static inline void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry) > > +{ > > + mem_cgroup_swapin_uncharge_swap_nr(entry, 1); > > +} > > There are only two callers of mem_cgroup_swapin_uncharge_swap! Just > add an argument to mem_cgroup_swapin_uncharge_swap() and change the two > callers. It would be _less_ code than this extra wrapper, and certainly > less confusing. sounds good to me. I can totally drop this wrapper - mem_cgroup_swapin_uncharge_swap() in v6. Thanks Barry