From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749D6C30658 for ; Fri, 5 Jul 2024 10:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF8556B0099; Fri, 5 Jul 2024 06:13:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA6566B009B; Fri, 5 Jul 2024 06:13:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B94D86B009C; Fri, 5 Jul 2024 06:13:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9754B6B0099 for ; Fri, 5 Jul 2024 06:13:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 46121A41B0 for ; Fri, 5 Jul 2024 10:13:02 +0000 (UTC) X-FDA: 82305285804.23.4BFDCFC Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 80291C000C for ; Fri, 5 Jul 2024 10:13:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IwjrSgdn; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720174355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ffIBOnbAtE0Ds0Y0ZfHWukYmzyfflqKoxCL+XXIWOw=; b=00L4j3vJDYNeAMS9jRWSc3n/XvIUf7G055wJwYYm4BYaf18oDx08AU1FUi+qkTUf2sBQkI tRMEWRIs3XRi6WZ8aP8UaudTLSCV4Zh8xMBqf2qQBYG0eV6B6mUw94HFvzfOHv9fhSvWHz O+46VclfeDb8upsJmNEcusi0LRPnC7g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720174355; a=rsa-sha256; cv=none; b=kJbBIeYhDeKX5YiSir6QT/czKiD+M8wwsJNcfO65hOsoYAC9klKP0OX00aMcGdKklPXwqE 9/VLKiXZiAxhWJ/9qWKOJr9K5HDXHAmfmQf7hSBo0cbBOlNJdIZbmXe9t9Q3opbZ2Wbd6x +eWDot3Pz9dmr0q01lstRTLz92UCaCM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IwjrSgdn; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-4f2e147ee98so506424e0c.0 for ; Fri, 05 Jul 2024 03:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720174379; x=1720779179; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1ffIBOnbAtE0Ds0Y0ZfHWukYmzyfflqKoxCL+XXIWOw=; b=IwjrSgdnnRMnfGNgmFtixdk7tex0Xylmu0GPUF0tDFUPO2VwVTKxl2HzZXgeYWV8xN /WxpnMSu5v3wIBqwt5Ll3kPxPEY26TkrJCuyHGEzO2+Ok2SFjKu/SyuTRY29UhsUc4ul +qFaGNrnZ8b3cngExeT10S1mP+3Xwt0sDpPrnYhy0auBeMA+J2BClMTIWj6j/jQtzAiW V5r/AqnKLfGeYh6Cw0kUe5D9CI2pDNMINXG4ebb2L8p88fsAZpK7p5Tn7O3fVnbpLBMj CKAj8AWToF9VjMmLcGK6VidCfk9Y5bDpCH2gf4ICD4dkLSSKNxR8thKl4FADEPfLXN4K 5mug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720174379; x=1720779179; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ffIBOnbAtE0Ds0Y0ZfHWukYmzyfflqKoxCL+XXIWOw=; b=kQpZBnXX9terNj0ZTR+6IW0PcccgsuK6GalljLeD0YYqn1d/2VClJn5+499sues08k XYJGNxmbaC1pJT/ppo+NQ5P3idceRTZsESoz/uYE5Yj4dK/07Y/QzG4b3XklMqip0mDN jlIa91TfCvj2h/KmUeqtltYNnAIzlqQGPlXnbKjpD96c5K75NrGqtwYjWs+dXulYuUXF lftR+9fThGcimYDBBvahEO04Pf2opc5iaOUzfhY52NsH6SvBr5uLyiHmuRJp+vs6iQxM Tkg268pvY26fj3M4uEpWVMKqPhfs2nXoj1wEUs7XkyqjoaA6FjtKLCNIsbL73XifXVir hg0A== X-Forwarded-Encrypted: i=1; AJvYcCVW/kX2qFJ54iC7P9oS05iBla7l5ehRMW06JruIRkTOTZ/HDaqsRZNSYuzDBLYyZLpDNJja0GNJhx78g6tjQkSorWw= X-Gm-Message-State: AOJu0YzzFNanX5O7UTIsRTHCtMqmrB5rzVBYtDJVGSh7z5rb4l4EeKOF 6OKV6P5J3Gy9G0VYbFMpQitlSZ5dr9V8dAHep1ZPrxjDvYfhYZozx95QkByfmMMlicGpcSSBNjk k10oWi04uX9hAtR3XXYft0G+mSqo= X-Google-Smtp-Source: AGHT+IF0QIqCtQqTz52Y1BoLh1Nja6AliTHdHDR9hySC0rEEiDpsO+4lWZqTpEpJHgf9lSAUAvjgQfO1I8OQz8b0Bks= X-Received: by 2002:a05:6122:2885:b0:4ef:65fe:7ee3 with SMTP id 71dfb90a1353d-4f2f3e5f688mr4962547e0c.5.1720174379458; Fri, 05 Jul 2024 03:12:59 -0700 (PDT) MIME-Version: 1.0 References: <20240704012905.42971-1-ioworker0@gmail.com> <20240704012905.42971-2-ioworker0@gmail.com> <677fc803-0bb9-48dc-a1ff-3ca1fb0dea15@redhat.com> In-Reply-To: <677fc803-0bb9-48dc-a1ff-3ca1fb0dea15@redhat.com> From: Barry Song <21cnbao@gmail.com> Date: Fri, 5 Jul 2024 22:12:48 +1200 Message-ID: Subject: Re: [PATCH v3 1/2] mm: add per-order mTHP split counters To: David Hildenbrand Cc: Lance Yang , akpm@linux-foundation.org, dj456119@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mingzhe Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 80291C000C X-Stat-Signature: sst5k6ch1by1incnxkpdqrihd6tqrhh1 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720174380-159144 X-HE-Meta: U2FsdGVkX19ycx6bShOt7aanGUYKPrOO4mODgeenTq9RUzbhuHWJ7ImGEmlXsZBougd5Id8TERsWeRm+RAsrUvhkujGsDrFdqMjsdFlGrJG4iqsAv9td6jOYt9U2Tph5sk8hFXjFusoe3Ppg7gTD3olfEf5qQv2+JU7wX/Wt64jqT1oBH2UdxgiQKI3H010Hu0gOxUh6o5c9KDCJdvDm0NuZAxY8BWdD/rUTdk29t/Wf5PhfquSV1EGoc1BgNugnfI37jgj6Ca1W2vvikNC2JtjZv7iq9t1kiAYMKl8tjfQPmCmVrwh2Jo3cedyIE1KZxTeyvl3ArZnAzdf9aj7fWYtGDOszO2DD9roETVw10fLxyOM6ozW/4U8xSCWCo3mDHOtugCtWGZNDJdm1pUDxHHscFJcZJ631KclZAMRMQU/Uu5HoRYXP2DPERBmHXb8Pm/0Juiko4RoScKe7Z38/dOmJBx/amcqeL7pdzpKsg/1hLshVxMfTn95gmatLXo2pS4q1LjSmSp3OT+phqKnennG4oPA8Y+GL3Y0kZf1A6zG6U1FW2LFUAzxA3wJ1xwicUdezfdQWlDprZVfWfQoiZX7SpKIbymAODCuDHPsPN7XlUxFbtx69kY2MgVgEVSBg48sRQrwrEQ/E33FcNnpjq499iwYsplSGy1+NH9W0daH171H1TdcPT8fxIFKRsyjnzIMnMKV197qMLAHm53OtNVXGJr6VVsAAV0mzmsvdO/KSBJa+c+lKHJO9nxLkhXwG1hWhCB2+phcgxW2RuwyJNmSVG9kGQZ1W1+EoU9etu+EF/fObbHM5n06MyF/tMranARGm6BmfRwFuvNOZ1uERBKfnYcUG89JxxbZJw/LzMDccoicdq6Wa9J+7Pq6smh0gcDP/OI5w/T2Wro/NnOkkUuTJh8M+Qf8LRasYajEWacg/41R197R1vei+x3fZsk6Bhkc7DMD8GXWE82oeYK5 CQVRiQUn DOdaGNc23OqxoT1ihBhEsLh871sdU36DBctMRO6gnRySFVlFCS1hi91r5uHNh18QJSM03OPMcF8j7Inm5ml7cuc4K60jzAOnk8Cgp/s3g6V8WBFNwCDICy+nSBRNe+PVaNthISXQJ6syVU8BgSe+9lYXTVnUSoDUidasMzKTpisXlRJdux+6JOwh7zyNsbv/IYYdjB93ZDRqshEnAPfMUBuRPcDPfxCgHQ/3bXFULug8uSXvdXHSXOTQHbdEUHfrv+/Z7TFyDPWY8NX97L/6A0Gs1PxpaQK0EsBbXaut9DnSivLz5Dhg9FjOjp8nxfrNG+r9b X-Bogosity: Ham, tests=bogofilter, spamicity=0.071520, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 5, 2024 at 9:08=E2=80=AFPM David Hildenbrand = wrote: > > > @@ -3253,8 +3259,9 @@ int split_huge_page_to_list_to_order(struct page = *page, struct list_head *list, > > i_mmap_unlock_read(mapping); > > out: > > xas_destroy(&xas); > > - if (is_thp) > > + if (order >=3D HPAGE_PMD_ORDER) > > We likely should be using "=3D=3D HPAGE_PMD_ORDER" here, to be safe for t= he > future. I feel this might need to be separate since all other places are using folio_test_pmd_mappable() ? > > Acked-by: David Hildenbrand > > -- > Cheers, > > David / dhildenb >