From: Barry Song <baohua@kernel.org>
To: Jianyue Wu <wujianyue000@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, akpm@linux-foundation.org, david@kernel.org,
mhocko@suse.com, zhengqi.arch@bytedance.com,
shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com,
chrisl@kernel.org, kasong@tencent.com,
shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: move folio LRU helpers out of swap
Date: Wed, 8 Apr 2026 10:27:30 +0800 [thread overview]
Message-ID: <CAGsJ_4xV+=esx4+LDV6tBtyoWaTaJjC3iv0UsEnVD-m_tCN9Tw@mail.gmail.com> (raw)
In-Reply-To: <CAJxJ_jjJtpJJrSA39E1La7qcBE1QMx_Eb1FNwEgy7u0=M6X0-w@mail.gmail.com>
On Wed, Apr 8, 2026 at 8:41 AM Jianyue Wu <wujianyue000@gmail.com> wrote:
>
> On 4/7/2026 10:22 PM, Johannes Weiner wrote:
> > Ironically, the only thing that doesn't fit in this file is the swap
> > stuff. The page_cluster & sysctl should be static in swap_state.c.
> >
> > The rest seems thematically relatively clean - infrastructure for
> > managing folio lifetime. swap.c is not the best name for it, but short
> > of finding a very clear improvement I'd just leave it alone.
>
> Thanks everyone for the reviews and the clear feedback.
>
> I’m withdrawing this patch. I understand the concerns about the
> relative include path, the limited benefit versus churn/conflicts.
> I learned a lot from the discussion, many details in mm parts.
Please don’t abandon this direction — it just needs a better
approach. While this patch isn’t perfect, cleaning up
include/linux/swap.h and mm/swap.c seems like a worthwhile
path. include/linux/swap.h is basically a tangled mess.
Thanks
Barry
next prev parent reply other threads:[~2026-04-08 2:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 11:00 Jianyue Wu
2026-04-07 11:20 ` Michal Hocko
2026-04-07 12:31 ` Jianyue Wu
2026-04-07 12:46 ` Michal Hocko
2026-04-07 11:42 ` David Hildenbrand (Arm)
2026-04-07 12:33 ` Jianyue Wu
2026-04-07 13:40 ` Matthew Wilcox
2026-04-08 1:09 ` Barry Song
2026-04-07 14:22 ` Johannes Weiner
2026-04-08 0:41 ` Jianyue Wu
2026-04-08 2:27 ` Barry Song [this message]
2026-04-08 1:38 ` Baoquan He
2026-04-08 2:20 ` Barry Song
2026-04-08 2:49 ` Baoquan He
2026-04-08 14:50 ` Jianyue Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGsJ_4xV+=esx4+LDV6tBtyoWaTaJjC3iv0UsEnVD-m_tCN9Tw@mail.gmail.com' \
--to=baohua@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=wujianyue000@gmail.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox