From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00988C5478C for ; Tue, 27 Feb 2024 19:01:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 747C080014; Tue, 27 Feb 2024 14:01:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7A394000A; Tue, 27 Feb 2024 14:01:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C05980014; Tue, 27 Feb 2024 14:01:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4C3A494000A for ; Tue, 27 Feb 2024 14:01:55 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 172721A0D86 for ; Tue, 27 Feb 2024 19:01:55 +0000 (UTC) X-FDA: 81838503390.17.6537FB2 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by imf03.hostedemail.com (Postfix) with ESMTP id AB66620019 for ; Tue, 27 Feb 2024 19:01:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IvoCeftg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709060512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WfFFXzSpX0Mc4KzxGc+Bs2TXLtROHHndagwLfCtpLgk=; b=I7Gl0Zvh7TU/r9LSRDjRFVO53048rdE6EWgF50wimF6wOKs7GnFUKUNNvwqCUTBuUKC/on deL2OT/ZvLruP6Q5UZ0qzmiUREfAriPwVqCrB0Ggt60h7M1fhydD1bEOfdBvlvSH8sqZL2 EMW//uvqqKjihcUeEaUKozuaxm8tj6E= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IvoCeftg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709060512; a=rsa-sha256; cv=none; b=OzvkdrSrMVYZoqZUufIoT4TSIbIblyjEjsY5dKfUcbIyOzdJHYNKWxWlytliFJzgIKHtDU 7PBsG/HRMBlI/YeWXtqbp6kHD3whSU62v6odFuEoMbT8aZEB0XZlp/hhrIn4uRFrw45jdn s0BGXh35+RTVkrP5mDlSv5NkSInrs7s= Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-7cedcea89a0so2937772241.1 for ; Tue, 27 Feb 2024 11:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709060511; x=1709665311; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WfFFXzSpX0Mc4KzxGc+Bs2TXLtROHHndagwLfCtpLgk=; b=IvoCeftge7hBkBWOcBwh4BrDlqKV7hIC85swX2IddIntnzO2k1ywD0OfdwAW2RTjBa rfWF9b85N5IC92O9Thk8XQ7ZHvam2sPkUPwtsJ2gaTDGST5JFq34s5I7l73hAlBo/24e qpL+4e/Vmncm0sfVAoEv/q1iwUEyhO6YXdBj0BFSCEhP8sutki87BFNwtZ/i+lMY7mZo afVFIXpFFomjNS0ZIY1N/penBLWkcsGS4Qyn756JUvqq5HdCnV5lIFEgLkWQ5V0UJcJB kahOcuee26Y1TCXnY0BC2TtFOvt6auVNwcPqC7HZfkR7Qdky1gjjN6iKPUvw6J8Yy3ZZ lE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709060511; x=1709665311; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WfFFXzSpX0Mc4KzxGc+Bs2TXLtROHHndagwLfCtpLgk=; b=t1rqArSxc/JAyOGEtP3GC+xkyTemA0beLSeSYklAg22EiQpJ7Jb0pcjp5kSpPZ20iU D6+7+p+JF83LEFTlWHtbzod6/AVD6iC+3JxTRzJFC4UGse4jLmq73k1Z4p5sN3GTeCI5 plznN+m219hVFgWoLK96yxPYWiDU9SElH6I3FIswtnHFCMlgZFr2yEpvmRoZvFia8ilC EgvqEAVohGhuAjj8xQCelct3JuZfZBFpI6kXY4b8de/8sBAQd9kNgY1v6MNaESnKMLi7 ST58rkQ7Uff7qNosKB7lHYutJFYFCOzwdoweOhHLoErwaW0pcC6xWz4Y3+S8jH339SXP grqA== X-Forwarded-Encrypted: i=1; AJvYcCWpsFMgHS22J3xyGX54XzhH1YgGp7JSo0yy4VuiGTMRWCCuMMnfi5ICFQmONxZfwDeIFwea2yDScm96Wn7WLv4SFyo= X-Gm-Message-State: AOJu0YxuLyVkdHgrFF1qRPh6BjmP5u20RPFsDoWrm+QvJNScfvX70IyL 594Efj6IC3rpxda5GHxNnDK/50i6SzTW+AcQ3mSK+MmPENl3TQXZvugOHsHMcUsDTPGpwQNJ5IK xFmTHPsBjoZNV5mW7GsYyXHN17lk= X-Google-Smtp-Source: AGHT+IEeakGXngQCMim18TnOJiecyRkKHreCK/SntmFGZkjnj7s5owwh/pYnzNyyAQ8cB8qjcq7plWYQixSZBYqlppY= X-Received: by 2002:a1f:6681:0:b0:4d3:384e:937c with SMTP id a123-20020a1f6681000000b004d3384e937cmr610147vkc.8.1709060511570; Tue, 27 Feb 2024 11:01:51 -0800 (PST) MIME-Version: 1.0 References: <20240227024050.244567-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Wed, 28 Feb 2024 08:01:40 +1300 Message-ID: Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Lance Yang , Ryan Roberts , David Hildenbrand , Yin Fengwei Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AB66620019 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8do6sy4gkwnxbmdodput55nb1y6ishhf X-HE-Tag: 1709060512-461767 X-HE-Meta: U2FsdGVkX1+d5uAdk15Easn+sSwlbqMe1A47ifYpwD+3AeGeQrqC9sn69XNMbD0iwvnP5HXt/hKkt+vpvvW4YE8azR6fJs0e0RNsCEq/CoRsy0O9+ZbGMQq7vqiSMsbB+rVXAPAvwyfUfFDZdjKo2ePXFHHboFQYKPV5oTyxk6se+1nnlPue4jozmfmQlrztPZYdxTq9lvwmGWtDgM6x6SCcRwRBiaIaAWuAQFE7xMX54g+7kNW0l64E8e0rARReR+Flb6DgZYgPs/3oy3Y0GrYIS9qwrEoDrrC6VkPSc/GjrnyvSUIisRhUq7pQJ5xTiRHzYYvUbw1WtYp+T5h4yLKe+u3rmpjVnu4IThyVtKuAgvD1Y0Ftix9XAYmJz0a3pVEzffZKfAkEWdhhrmp3HKm+zL1MitkPRkPhdScM9pbKLUVXUTKQMfuZKdr7XDOCE5PkjH4NDKhfOj4+O8plTxz9CoOqd66IN8OblukZHVYzRfAqt/wRj6ihZqYTZ7/u1xyQa0KSyn7+bzWkwFccQQm3bQLLjObbxQK5fXxzxPEzKnjtlLzU2BPlbLmE/qioOiBPp6HTB1jX9CQfc6oDhWMx06uhCIL29AjrTeAWRvtL52w40jjhfmDEREH00Y76R8ACTXmftH9a5djtmERxskUYE9wIG/BQ1xJojmKHQTKTaCelA/0IXSd+3pko5lE8QbOaBMPI8MOvBSXF3quhcXpKlhowb8ynDg0KLXZMDA/OWtEoBWWybxvUzeBfBSXJ/MWoIHPY3fPm0Yp991WjVQ2JvdmdL80T+moUT9LBtfcHp27PS2A78p0DxHGYcqc7rEQJ1br5PF3EvqsqEAlu9QSATH0wa9AAxPp+YSMatsMXiUD5i2s181U5VDW13z0AS2XFDMTt+kA3f8nVFhsG3WZBKCbgbqpEMocN9WQ1s4RtRFPZmsoG9DujgvMQlVg9GD5IHweQ10wI1MoQOQ8 xQyIFbix vdG2ziAvf2ND6b+7NamZfnfMW6WimTQRt6CZfSnZEcKGTAtQv4izM5Im6roNS97uiohvumiIKEe/7XVI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 28, 2024 at 5:00=E2=80=AFAM Christoph Hellwig wrote: > > On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote: > > From: Barry Song > > > > madvise and some others might need folio_pte_batch to check if a range > > of PTEs are completely mapped to a large folio with contiguous physcial > > addresses. Let's export it for others to use. > > It doesn't look exported to me in the patch (and that's a good thing!). > > But even for making it non-static you probably want to include that in > the series actually making use of it. at least two parallel jobs[1][2] (maybe more ) need it right now. Getting this one pulled in early will help build a common base for them and avoid duplicates&conflicts in th= em. [1] https://lore.kernel.org/linux-mm/20240118111036.72641-7-21cnbao@gmail.c= om/ [2] https://lore.kernel.org/linux-mm/20240225123215.86503-1-ioworker0@gmail= .com/ > > > +extern int folio_pte_batch(struct folio *folio, unsigned long addr, > > + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > > + bool *any_writable); > > no need for the extern here. Yes. this has been moved to internal.h as "static inline" in v2: https://lore.kernel.org/linux-mm/20240227104201.337988-1-21cnbao@gmail.com/ Thanks Barry