From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3571C531DF for ; Tue, 20 Aug 2024 10:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BBB26B0083; Tue, 20 Aug 2024 06:11:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5478B6B0085; Tue, 20 Aug 2024 06:11:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BE7E6B0088; Tue, 20 Aug 2024 06:11:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1989B6B0083 for ; Tue, 20 Aug 2024 06:11:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C1B9B818F0 for ; Tue, 20 Aug 2024 10:11:37 +0000 (UTC) X-FDA: 82472207034.08.3AF4621 Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by imf12.hostedemail.com (Postfix) with ESMTP id D63654000A for ; Tue, 20 Aug 2024 10:11:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UOg8mwiO; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.51 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724148680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nF9S5axPX+d6KdUCX914qYZ7PwT7JT7vV7x4YJM1rI4=; b=z8UvgY+v0peIzL7BVcf/oSpx1NoS9hSbiQjBe8zwqAyPxQPnkucd7UhFTeTwYQM6jEdjBD 53+25SIIwLuxvHv/s82ePDkBViBF+rSa51qnf3X/gJb5EdywQG10iBoAMCBQxsIzHSSA4V iQvEl2hIOgv6alNA4nEzgy1jvu+/HKg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UOg8mwiO; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.51 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724148680; a=rsa-sha256; cv=none; b=jINXzoQwHZyXHeCGNCZDi/52Jjr2/FMAmGs/2TEQKHdiytvRhyxf0qF8AVNIh3cqVac9AD Cs6xh1/Xu8Jezso7AVzMhxrBr5yYei7yMxpSjQGO4tRqq8VJ8mEGaWcZXmyPE4QfydVrnB 9LPECs6PlpflhZffhLHoAEmYVBQPQD0= Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-4929f9a28c7so1808503137.1 for ; Tue, 20 Aug 2024 03:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724148695; x=1724753495; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nF9S5axPX+d6KdUCX914qYZ7PwT7JT7vV7x4YJM1rI4=; b=UOg8mwiOtkSo8ds0CC1FLhNgVCUBm3ulitTtdiBDoPIb75v3Sw+6GTJc43uYfO2swi FHIl8fntbncG2+xeIHLXJtTvl6bjWv5mkq6zvk5EP9bPsBTY+fB3PMOjI0o8Sxo7awNB YR73nLTv+uDqOdtBTduFosRAbWw8wcPtbNfQLwqUhAWk8Z/BL0oHnJAEwUcCa+z9e1VP Adir756cgly+V0x7gquqJ6uIkFYFjmq/Kvg2fMhX8XtC8MPUxZ3NHzLHqAgLh8PkeO97 +ltrsNo8bW1R8JTaffdTyXcMgRJoxF7LCQxmLnYdXR1irTH9Nt+KguiHeL3WVUkvYo5y fvVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724148695; x=1724753495; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nF9S5axPX+d6KdUCX914qYZ7PwT7JT7vV7x4YJM1rI4=; b=emMNCYrev8e9j4Ca5oPKa8vaeML5KrBteWir6de2ewNNJ/yfpdWzuDd0XKdbfJqIx+ wLVFWyOOro+09nka5b2fvSCtapSJVIKo2eY3T1q1q55Cl9HuwGgIsJInMxwOLgz87a/Y Mnby/T9iEYCt7+4HcOQMHpUL/oVcJLx3cVveNt8EiAFGM6j+UbE4a5Qnc2RqkX8qEj03 ppM+E9YlVn291F91rld+QIObaRc/dqPSl9bfKPXWXUA15nSITbWjX7q7QW2qino25QHB YgtcRUHVbp23BWWnnBPQA6/48ScRxC4w0af945vA92bnOyA6q7iIVx/f9UumdBKuzM+C DHnA== X-Forwarded-Encrypted: i=1; AJvYcCXCo8dmaGNE7cL5dO65uRwscaoWSTAExXgm899DT59nLSejA5AuzZwc37ypYxPbfVlfCRQbD++05mupof1gXxX8iX4= X-Gm-Message-State: AOJu0YwOYVyHAUN/UC/0YDVcbhHtd+A8Ty7+eDL2EVNTXhMBZ2I8PEhZ UKvCBqSYHZwExsVFvIoQtTMztonLXmE7e61vlo3d3sJA5PNFtB+JzcWbSK5oP71tZ+eSDsLs3Yg rCSS3W3Y+qm9LC/V80vXdDUkp+5QiQPK3 X-Google-Smtp-Source: AGHT+IHY2GJH4azXVKTaIBxjD7Gk06+2FNujSUPDMZwMWR/OS9MVKJ3Uwim/wDGOBGMuopIK1ZK+17m7iyb3suxHgQ8= X-Received: by 2002:a05:6102:6cd:b0:497:6a77:8097 with SMTP id ada2fe7eead31-497799848e8mr17854017137.23.1724148694706; Tue, 20 Aug 2024 03:11:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 20 Aug 2024 22:11:23 +1200 Message-ID: Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail To: gaoxu Cc: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Suren Baghdasaryan , Shaohua Li , yipengxiang , fengbaopeng , Kalesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: jii8t1gdd4skybjpghi8snnpxprgwb6y X-Rspamd-Queue-Id: D63654000A X-Rspamd-Server: rspam11 X-HE-Tag: 1724148695-887128 X-HE-Meta: U2FsdGVkX1/1nkihBCJSDlnPtBiHmzgVx90fpKNqhWZzdENqq2oIw5E2koKN5jdpE6Sv9bbIzLEwuKcH/JTnA954DRIgibA8RRAujJTkdj/0PYes9D9nVZ+7FmAzJ2KsMRrP9qBp1gOEsdMsJcn7U31Mik+pphnKroQa3zUazOaM1AtX2gNjuQjJCUEhR5Vp2h2xBuDRZ5OLdVSWxLG4k7qXfoycF1e+iaErT0OZmHYtHDJaonrWnW6GjDFVtgbrxDBULUwHcfZOQx+nJS6P1HucQ7TLMoKyuo8oQ5mPnI2JC5X5ajlwsEAg11bsnL+wvl2fUzHoZCdZzPkhjZqEuwZB6imfje9yDs3kJe6Ht3cvTC/zkoVVOsU6324dUa3hpFxDssVmkJGAOQHamO2VsvgoBwQybDWDDQL7WXT9nEoxx3EtDCByXSE4Hlh6dEczqXHt0v6ToAqoPf25HkWuHkhWf8n48x4gz0au+mJ7gTFJe6vUl94cDEbu9YPzkd/H/wVaz0wzPEMvpBVv35AxrcemtLQH1OYiCoAMA5Cxse0isWGj8PAnt03ZYhsd5eBlybHcd4ot1vrlpt9UHGaGJXJlkSl17JKOmh3I9hojk6VZ1Emv02g5Em4cKEYvFoZmFMaWTJTYlAmAmomCHIbTwBjMDmAxSUx2avYXDTIjx1/8otICwNLkvuTeNBECenm8SZhTyK2LL5kPpcbnX37WkZKz26dd3JVzppafTzTRmKsN1Lm7DC7gMmi/utX7REKVsSs0nFSFqTXNO/8EC6P0Xj3TOOKqwSTuYtGAZ/Y2jsJjlx/r+YgBrgxwfXOXQarG2o1BX7TacZ9p4SRAy13FnX7plkRDQsEN4xA1Gs9fpFnxqhM31nuj1wtyvE9cnBhnggW9rrcoGy/9UizN2Pe6EwNagK4zQA3KwHR+5ryFaeudjNvZbPEVIWpSujXJ8SUA6x31uC8G65X9qsa32vt ZH0hWHB+ qGMDB6AGj/JDxZ8xPszJl4gj+yrwyE2cvO27Bfrwcq6wGbnSU6U4jq3Tf1XMv5jh2TqDUYckR0Fjd7U4uU0m2XQd7rBoRx9x+mpdKvXh8I7Ks2dGU2QlUMV9My8i+WXXiCSPnSUe99J4qNIzN5IEVJLVhV7tTqxr5/hadOWmmc+Yt2VKi3E25xzlO4VTluV3unTQEeqySJFKgVUoV+x0u5d/URAhuxCAErar+/6T+CqrC4HPOjFOG9qsI4s6Kapx9ik50Kza2gEbfrJAj9SDahHk6wmdnMRvYcw7HgZBsXzCU6WmqoUO+5gOO+KE71jGwJL8Eus9XqrAP2uq455GAgMCfUfkvBkD3iBIZ6bOOZ7cam6wHz544NaOpoV+MDnAdWomsfppHVqGdbuZI+x++vkmWjinqIKWGtz+kcH+rJ9anVKIzxxF0DzxBDTaL+pp8iv4JBRZIRvgpcPQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003838, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 7:48=E2=80=AFPM gaoxu wrote: > > Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfree_f= n: > 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it's > moved to the LRU tail, it allows for faster release lazy-free folio an= d > reduces the impact on file refault. > 2. When mglru is enabled, the lazy-free folio is reclaimabled and should = be > added using lru_gen_add_folio(lruvec, folio, true) instead of > lru_gen_add_folio(lruvec, folio, false) for adding to gen. > > With the change in place, workingset_refault_file is reduced by 33% in th= e > continuous startup testing of the applications in the Android system. > Hi Gao, Just curious, in which scenario are we frequently calling MADV_FREE but not MADV_DONTNEED? > Signed-off-by: gao xu > --- > V1 -> V2: Based on the latest mm-unstable, recreate the patch. > > mm/swap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 6b838986d..e0dbfc983 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -641,7 +641,7 @@ static void lru_lazyfree(struct lruvec *lruvec, struc= t folio *folio) > * anonymous folios > */ > folio_clear_swapbacked(folio); > - lruvec_add_folio(lruvec, folio); > + lruvec_add_folio_tail(lruvec, folio); > > __count_vm_events(PGLAZYFREE, nr_pages); > __count_memcg_events(lruvec_memcg(lruvec), PGLAZYFREE, nr_pages); > -- > 2.17.1