From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F69C54798 for ; Sat, 9 Mar 2024 03:58:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33B7D6B0071; Fri, 8 Mar 2024 22:58:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EAA86B0072; Fri, 8 Mar 2024 22:58:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B2666B0075; Fri, 8 Mar 2024 22:58:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0AF2B6B0071 for ; Fri, 8 Mar 2024 22:58:55 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7EA301614FE for ; Sat, 9 Mar 2024 03:58:54 +0000 (UTC) X-FDA: 81876144588.25.EA41C3F Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by imf16.hostedemail.com (Postfix) with ESMTP id DA6B7180007 for ; Sat, 9 Mar 2024 03:58:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=X6lEU0Yh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709956732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B7n9LEXpLClFkriaPc7m9Dsp028MApBRBmYp4M2ZTTo=; b=z5//7mKYG5dwshuKa4WhVuTkIv1YrcTIRrSEOA8xnGYV8wa3jryhP1E+MCm+dp8AJjxuKF trXQ4AmJS38Hk+Su3vEtrPzQm/8sc+GzADZBsjFgXxlR5cJklGLqCJgmqQ4Ig9lYL0+xaz gofnCWsYEQhahp54Ag1S0R0odL9aV2A= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=X6lEU0Yh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709956732; a=rsa-sha256; cv=none; b=R2Uvl6+FlzX1SAvE+gsmMHjcZxtnrl0OswZmeqysRIcBP+/Y4nALL1iEmGk4uD7T0yy8bG OWNsreKnQudUc33HunUK9D6tmC8NOO3yyCB0z4/CDLOrBbmrEaxUqyklkne6+1S7/5BDz3 VGmSmgUWik3fDv8nh74Apy57I2uoCCo= Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-7dbc08c62deso308517241.3 for ; Fri, 08 Mar 2024 19:58:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709956732; x=1710561532; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B7n9LEXpLClFkriaPc7m9Dsp028MApBRBmYp4M2ZTTo=; b=X6lEU0YhHV7VMCmTaHUcxNbB8QcEQjooEf4oQHL+MVsva3xXcZ4nsPNE8XKhG4TOeo vQEXALBIABMNfNeU4mZt+WbFW8yT9v3qsdJrye/YLG1jloWre947KXJVHFO38MpB/POp OSCZb/XdJmj5qaz3uLYTjtm7wxoXuC2bsZz/vbEqsFpLpFOrZKIDk7mykkSVctDqFZ+z FXJO/jpIdkX8QNe3fV+3+xhpJtHlBW7InPUyXbwPKxgk0hgcWaQHD2ZICrZwhnQ7RYRu d4U3y7W8lojnCzuLNDQ2w56TDR4w0gNbOzjxfKjwIpAxlN6qCVd9nnk1FnnsD4/XaRfd G5LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709956732; x=1710561532; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B7n9LEXpLClFkriaPc7m9Dsp028MApBRBmYp4M2ZTTo=; b=UB7bBfL/y9gCxCRaFhGMV8CUjvgujuGL3HXtXiK+V14NvzbVVvHDC1ZCoQHrvVeflS 9c/qTw16IZA2EaGiurGb7jImYdK7GJgjokC4o/D0G/hDNF72x9DDDUwGcy//1S8QMZPZ mWfU2LDv4Iy4UNVilixRkJ7jmbnsvybvNTlGeyvNZd/X9uFh+PuZAdrsxlpipqcHGVaj wx6KSEY/eCJXi5brc9aq9/8U/y70Pl6lOh95YIzMgdqeQPJ0oMgWYqOOk/4UkszkQOKo GCNsBThF4WTiMHDcPux2GvmmPzyRap5cuo4WlfBky8ZjXkMoUyuxDUJqRf2Bud746MLw y8dw== X-Forwarded-Encrypted: i=1; AJvYcCVnGGdSlNKUVeVSfS239jtVZoOoiRxy3ktjkSp+C7yA4QDBT+fOpEH5Ix6dOgrjJ8JcwF9vrXJMb0OlX97qGyDAerM= X-Gm-Message-State: AOJu0YxCjipk29/I8h/AnBORkWuR0dWQmrbFdIHh8XWIdbYCpY2P/TOc 3ZWLeVLxcEiqIKggscMZK9rufJsJ0PmsZ3FySorjRL5Iu2IuHtmUc6Zl5Qkh53hUF/oBJx18jCk pUEEU8ksDl39Mlfrv54KvFzBuw9k= X-Google-Smtp-Source: AGHT+IFb7GMtTiKxWFYZHNVCtOCEKDF3SdV9CJvzSD4QbYGTRENQ1u704E8MXErV/KDPVJ6RLIpg9g8X3puZGDq+nFE= X-Received: by 2002:a67:f4d3:0:b0:471:f1a2:13c8 with SMTP id s19-20020a67f4d3000000b00471f1a213c8mr627866vsn.11.1709956731762; Fri, 08 Mar 2024 19:58:51 -0800 (PST) MIME-Version: 1.0 References: <20240222081135.173040-1-21cnbao@gmail.com> <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org> In-Reply-To: <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Sat, 9 Mar 2024 11:58:39 +0800 Message-ID: Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable To: Andrew Morton Cc: herbert@gondor.apana.org.au, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song , davem@davemloft.net, hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, zhouchengming@bytedance.com, nphamcs@gmail.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DA6B7180007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: rxdns1y7qgh8xw48prdu3z7hi4wdcej5 X-HE-Tag: 1709956732-106697 X-HE-Meta: U2FsdGVkX1/E1GpuNstQeMk/74GRwB0WwO+crvOn5vuxNrMtix2Ha9sGpAj+oQQv3F55/+iXEXCXJ7ItyfCRszcT8LkdZl4X6ne5/a6xdgs+1+PzyQ+AgZ5xCx14qzQirQena5WfgHt2c6Zy5OO1C/GEovWPVcMjeMrXOliXoVTjmbB4t0Cnp2xbd9cwaTluNKqMvoEIE6xT3iHNGne4ye+gg0zzt/A9V6yOCRJJqp6VHlXIqc+jAhQz7c3A7bmw9C92Edz+f34FEWsD9s633Eni8bR1gOkDH6wQVaDPWPILSDIegqmEIOqgJFcOIJDwCo9SSx+XtfbSr7MxyYUGoSMDMA4uN6UHAxbUdVy/zjbXJ9bFUSv3WHxyfLft87wjy105ng3vNZkCMwjzATvYaLkhmhqPOKUvsxbOuuKvpSquyqJvM/4rGwmehHjLfqWMcVNfXOLkH99K29yvk2Sgm094D7EDIbuS6qPCEn1/vFzxmNw4xD/xXZqTySST/lUaSdsdWSo9xb8bAYOju9rx+9Q9FDfvCbdcADu12q0r1fglZ8oK3dTJYLzj6B80SJN8AInT0c89s5NEbNRBc6XpBMq78GpixWsOCYyhEsJeeXL426AK7GUfSCq1+ieEZ4wJlZUEbrgdrMq4uBuLbm4kY0EZbNTfkDrikQvk7ZgGkHg5w57ZT7yal5hkufvsKFT+4aFm8A9JBCn2xIFu6QPqXBNW4sx3+97IKdVmXnpzd80CUrg2XoX5DZ2VcgqAa2E827kW1j7Dm4EJSVJ53M0ef+xegPdwVFkFv/kj8eRhgE4W10n0xQ8RDuvFz6mM6/DBzdvPthuPVPTiL7rVA4vtjYyvYfpnBs+HI4I3ppbivqRC9EBg3HZbWTe2FRRHSZ3Fn1Q+mN72CBhLVRzNax8KDOskywpVDVdeSNkbjN1p7snmM2u+Sc6nfpm10pxhRfYUfA3jier49nM+2RezvoL CaBLL9aZ iHR6krvrnVfHS221TdZ2yjTogR3iGdUH9vPLO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 9, 2024 at 11:23=E2=80=AFAM Andrew Morton wrote: > > On Fri, 8 Mar 2024 19:57:38 +0800 Barry Song <21cnbao@gmail.com> wrote: > > > Hi Andrew, > > > > On Thu, Feb 22, 2024 at 4:11=E2=80=AFPM Barry Song <21cnbao@gmail.com> = wrote: > > > > > > From: Barry Song > > > > > > In zswap, if we use zsmalloc, we cannot sleep while we map the > > > compressed memory, so we copy it to a temporary buffer. By > > > knowing the alg won't sleep can help zswap to avoid the > > > memcpy. > > > Thus we introduce an API in crypto to expose if acomp is async, > > > and zswap can use it to decide if it can remove copying to the > > > tmp buffer. > > > > > > -v6: > > > * add acked-by of Herbert, Thanks! > > > * remove patch 3/3 from the series, as that one will go > > > through crypto > > > > Can you please pull this into mm-tree? This used to have 3 patches. > > > > 3/3 was separated according to Herbert's requirements and has > > been in a crypto tree. > > crypto: scomp - remove memcpy if sg_nents is 1 and pages are lowmem > > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.g= it/commit/?id=3D77292bb8ca > > > > Two drivers fixes(patch 1 needs) have also been in crypto tree: > > crypto: hisilicon/zip - fix the missing CRYPTO_ALG_ASYNC in cra_flags > > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.g= it/commit/?id=3Ddb8ac88385 > > > > crypto: iaa - fix the missing CRYPTO_ALG_ASYNC in cra_flags > > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.g= it/commit/?id=3D30dd94dba35 > > > > So it should be quite safe to pull this series into mm-tree now. > > But this zswap chage requires the presence of the other patches, yes? As far as I understand, we rely on two driver fixes because those drivers d= idn't set the correct cra_flags needed by our patch1. Without those fixes impleme= nted, two platforms might encounter issues: Intel with IAA (Intel Analytics Accelerator) and Hisilicon with ZIP. Other platforms should be unaffected. The two driver fixes have been merged into the crypto tree. > > So the mm.git tree alone will be buggy? And if mm.git merges ahead of > the other trees, there will be a window where mainline will be buggy? Before 6.9-rc1, there might be issues if mm enters Linus' tree before Herbe= rt's crypto tree. However, by 6.9-rc1, everything should be fine. > > If so, I think it wuold be better to merge the zswap patch in the next > merge window. > Okay, I understand. Since this patch improves zswap's performance, I wanted it to be integrated sooner to contribute. However, I'm perfectly willing to respect your concerns and adhere to the community's best practices. So please handle it in the best way you think :-) Thanks Barry