From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE87C3ABB2 for ; Mon, 16 Sep 2024 06:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4BD36B008A; Mon, 16 Sep 2024 02:16:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFC5D6B008C; Mon, 16 Sep 2024 02:16:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9C486B0092; Mon, 16 Sep 2024 02:16:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8A8C86B008A for ; Mon, 16 Sep 2024 02:16:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 093D61C0CCE for ; Mon, 16 Sep 2024 06:16:35 +0000 (UTC) X-FDA: 82569592350.06.8C51CA1 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf23.hostedemail.com (Postfix) with ESMTP id 4A0F8140017 for ; Mon, 16 Sep 2024 06:16:33 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="NCFea/pe"; spf=pass (imf23.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726467283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X/pWnXCVlNoJ6VkECBnDb2dCNBxxBagSxuCXe+0vj/U=; b=SvOjJz5vMCIaQfX8mhmzG0qoGrEnV2vhRzUFcjdjM1Tcexrlc9l4rGFyXcLzgVrqTGjKoB DzTrtDCks7Qs7kuGPnTQ3es98fho1gPE5XXoyRAtc820XfHW406GilVSAfEqEeESCTm+Ir THw9WBB1+5w6EgiDFi2r7ySHnq3Wi4k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726467283; a=rsa-sha256; cv=none; b=Wkbzqm6VwP3+ax/noHyNfLIZonsmOPggJjK3ThoHFMrfMMNFYp8dx8wb4v/oLRczzuk1Tv nFYW1AY3GzuEq/B5YfTQvesMhePP9mPYo3+/Gc5EPHk0Yf7YjOWzPhK5wiRDDyn/G6j4fl rq2kohk+qJ9MhByQNeaSW2Vkl6jxTQo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="NCFea/pe"; spf=pass (imf23.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-49bd76fa981so1514312137.3 for ; Sun, 15 Sep 2024 23:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726467392; x=1727072192; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X/pWnXCVlNoJ6VkECBnDb2dCNBxxBagSxuCXe+0vj/U=; b=NCFea/peBnUpZ9nHyvtFziRVb5SIG1gGtkkSnrKBsGBVbqeMywTxyvf4ncGtgyyjrI CfcDSakGhKV+HiSWMmc8cj5xdEAHJ9RV9coezmtsKjzZkShgL4Rm53qfoxfjn/F7uVA1 /iFYa9QSX/l0lV3YJcvmw9tSBgEHV0+xH1zkz7P983INYR9vCd0HVoCHCQADBAIslw3c ox54URu/I7B0XN3PnjqYtCjUNsJRrIkJCtgGdEvz90AjRpY4tShhU2hYqOOJs81PhIb1 +XakaK5Tbpx1ggULUJtyD9u7ZZRDuBcJJJ4Q5G7V4HZh16MEXjBUUnNuID1zb5ZCN7tS +zXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726467392; x=1727072192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X/pWnXCVlNoJ6VkECBnDb2dCNBxxBagSxuCXe+0vj/U=; b=fLMdn3qnnAjlAZcXONUGAA8XxSuedaUyn+vwJWpQPiWW0irzS0s3t09wp9YVkS5p1B 1vUqYC4JwlQ7/BK0EZO9mApJ9infa8FuMJY0cjP9NYpHT38k1Hzp8pGU6iluASeBCQu5 wLZ0J9JpDyL2c6Q50z6YrRRp/PfYNBc1GFUWanrbAm8CSoL/A6AUK2rQTcC4Nxsb+hZ1 3af0pOmlyu2JNuRKhH+OyU+YpFwvuCwZ51LMGC6sxyv8z8cHak6nHk9xMA8KzkRFrWG5 IbE9F5+uhv6uCXjRolkgKQbcIOYwVzfgcou5E62MnQ7M1w7XOhOCapWdEpZYbKF+MOWZ OeJw== X-Forwarded-Encrypted: i=1; AJvYcCX68I7Zc2odAdmtWWNX48jl99okVIUkohav3WUCmgZgAmX1hAlmGuhF/99sDVpjj7AENN7R4I2kgw==@kvack.org X-Gm-Message-State: AOJu0YyB7xj3Xn1tPUdwqWvyFLlCSdQiBG1JkLFDdjvzpF2Zc2NGEE1E GUs/+C+p6xtYGPXfeQT2pAkvyGNVkj4SddLNoiPXWK/cLKT/vypWcAy5SzmaIqPJW6P50Plx2AC 6Q7njOzqTjxXDbujLmf8HGwelDh3b6J/NYzA= X-Google-Smtp-Source: AGHT+IHuDb4AshHoNGEtNLYb9Aqw/hI5Qvqs88n6Gf2duV4ShPpQUJ+XqeS6TANXDbbWCyu71nmrOqVR6aM2RpwtFvg= X-Received: by 2002:a05:6102:ccf:b0:48f:db3d:593e with SMTP id ada2fe7eead31-49d41513e1fmr10472930137.14.1726467392099; Sun, 15 Sep 2024 23:16:32 -0700 (PDT) MIME-Version: 1.0 References: <8fe04e86f0907588d210885ac91965960f97f450.1714581792.git.andre.glover@linux.intel.com> In-Reply-To: <8fe04e86f0907588d210885ac91965960f97f450.1714581792.git.andre.glover@linux.intel.com> From: Barry Song <21cnbao@gmail.com> Date: Mon, 16 Sep 2024 14:16:20 +0800 Message-ID: Subject: Re: [RFC PATCH 2/3] crypto: add by_n attribute to acomp_req To: Andre Glover Cc: tom.zanussi@linux.intel.com, minchan@kernel.org, senozhatsky@chromium.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, herbert@gondor.apana.org.au, davem@davemloft.net, fenghua.yu@intel.com, dave.jiang@intel.com, wajdi.k.feghali@intel.com, james.guilford@intel.com, vinodh.gopal@intel.com, bala.seshasayee@intel.com, heath.caldwell@intel.com, kanchana.p.sridhar@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4A0F8140017 X-Stat-Signature: 7pozn7hr67xhe76mfi5b6kw8wgkmsddt X-HE-Tag: 1726467393-710348 X-HE-Meta: U2FsdGVkX1/zn+eMpIrF+1FypviSPX3gR0LDanJpwsZsnzQ2FZHQkpOJAztQCpiKhV+ZdZ1zqme2uvQMeHgfJHEp6sCcT6b76aNIE+sZiyL72MzoiMEyungE4yChu4Q//7mhOiBq0ZcDCi2hyyeFysVvUemej6ML2/EPab8KRmgsbyxi+KKN7X4Tt9YckWRGUP7k4uj/eydBrq9N9dK0J4Kui8h2N72YdhHcFiN2z6Pie5sQDBPDfHHI+4+ZMio+THceUOw044zc1p2e7DX9P+Za19lqPo8toM2+MgRAd0dXy0NMU1Flk04LqbtbwckzqufNXYBXkpWs2w8MWJhlmp51aLzBTGB3sD+2mKmdEbcN/v0ri4W664vsFUIzXsMvI31CqbhkggO8xSRCqitxBRwXbeeU0p2vY06WKx5c3a7Drs0E6adHizykmSmHOvbnSRHQZR46rKh/l+HIfsGBu9gJrSb5LG0v8r8bRf8tMjdtFP5ms1Qapy5UAZlKKPrE53xAe8m6CGX4jUrXzbQwKZxQZhaCxGlcQdswIIxrPEMw8RAJlhpVWbSk5Qzy37nYg1+aRte+o9Kb4SjiWyokRosxuuiiRPRgsm5KrOXMV5kvY1l9xOwKtmrEJHDgXnP2XOfDZcf7rmKMuCufMu6TIO1iehvdF1SCQzDAlkxAcnA7wRTwR8s+6gGLGNOl3JEbSitr9GdLdh+SBDhZvH0WpslcYEA+Whdy2dD3WVV+i+gjUjZxbnBv/cXmHRr5ua0qXjq5KZwCsis5Uklc2O9rVkeSDTcjkia9tqOL1rwtb8pQn6Es71kE5FWNDWV7pfNaju1zagKweRb7RrFEAsxhB85tM+7qfZzhVPnyCLOkdtxEUiBFzfl6JhmOmBuAK5JkYZ1O18UBiSnBvZnl6+ghExff6fM+DJosDqYIxR6dyXXSRyKNt6bhOgGegbF5ZS2p7hoHKocv1iY9KBO0JLO 7k8xEBHx X+R/e/W5mYvwbMqEmy2IBtBHHv2Dni8/iZmUtZDSi7D8c7ksYF/HP2rrAC4YHufJsSKr4n/27FfQ8ywsEuf+X1o5cm3QR3gWfSZUaIMrsSpCqW1B0yS/x5MbCxy5ZSu+lf+B9bv5AuBKVVjRZ3OWheA+nCdHSPEnNmQfsEGiRF5HT16zWcXimK6RC3912A5oV47re4uvocIL96F7I/+G3aNOeoizZyBr1gizfH9AfuVB7MS8h0fuakPT1B4NIUIQcnn0SkmLUNg2w4ZJs0M3RnAQEv9kKRzgsbx5Wsg1zm8kxVAwO6btG6ro93bSTHCSyvd9xnVOfCyxtVJ8iJAk3TxrAYNj0V9XmW7tRbqaGGUw0l5yT+tzYcc38UyILKh/IdOuTLdC3YdmVLnE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 2, 2024 at 5:46=E2=80=AFAM Andre Glover wrote: > > Add the 'by_n' attribute to the acomp_req. The 'by_n' attribute can be > used a directive by acomp crypto algorithms for splitting compress and > decompress operations into "n" separate jobs. Hi Andre, I am definitely in favor of the patchset idea. However, I'm not convinced t= hat a separate by_n API is necessary. Couldn=E2=80=99t this functionality be hand= led automatically within your driver? For instance, if a large folio is detecte= d, could it automatically apply the by_n concept? Am I overlooking something that makes exposing the API necessary in this case? > > Signed-off-by: Andre Glover > --- > include/crypto/acompress.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h > index 2b73cef2f430..c687729e1966 100644 > --- a/include/crypto/acompress.h > +++ b/include/crypto/acompress.h > @@ -25,6 +25,7 @@ > * @slen: Size of the input buffer > * @dlen: Size of the output buffer and number of bytes produced > * @flags: Internal flags > + * @by_n: by_n setting used by acomp alg > * @__ctx: Start of private context data > */ > struct acomp_req { > @@ -34,6 +35,7 @@ struct acomp_req { > unsigned int slen; > unsigned int dlen; > u32 flags; > + u32 by_n; > void *__ctx[] CRYPTO_MINALIGN_ATTR; > }; > > -- > 2.27.0 > Thanks Barry