From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14308C3DA61 for ; Mon, 29 Jul 2024 04:41:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A6E6B0096; Mon, 29 Jul 2024 00:41:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C9526B0098; Mon, 29 Jul 2024 00:41:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7E36B009A; Mon, 29 Jul 2024 00:41:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7322A6B0096 for ; Mon, 29 Jul 2024 00:41:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CCD581A033C for ; Mon, 29 Jul 2024 04:41:29 +0000 (UTC) X-FDA: 82391541498.20.71702A7 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 14CE12000D for ; Mon, 29 Jul 2024 04:41:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nnFcv494; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722228028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RvMehHFovVJWeBpH4SDKvqU5fsitO2FHmL29ZzK4oEA=; b=Q20nLoOx1g/lI8T6g/AtYM0q23zbycYFP+FhI59o5cSuFO9daYbRQ37vmev9evbpCCArgT BYN0IacZu/DalOBR04QnXrM7gq8d7PWdqDhrcClWyAp/GUbwunTcIQ43aHhCOcsrRS1+eG 8B2bHSPuN20hz2ySpsnU64oW6In6TAA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722228028; a=rsa-sha256; cv=none; b=yW1wuvCA/5FtMfdF+6zOGnRNBEH95Jvdln9WXd8BD377njwA+Hgc2mjj2XkNPXiRF8GU6N b+sBSdAud77zn84lhSfpk/zJTXhrKN28afVDdPQbXb4Jcwx3Q/n8MKdL3rlFsKE+Pc4iSP tUJtSi+bXOeZPkrC4j3+l2lRFAu/3uM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nnFcv494; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-492a01bce97so464308137.2 for ; Sun, 28 Jul 2024 21:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722228087; x=1722832887; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RvMehHFovVJWeBpH4SDKvqU5fsitO2FHmL29ZzK4oEA=; b=nnFcv494VhI9pSL2HMl6JDbHC8z2ClTTNvNQ/Er4vY5lNkmOOLqDAwVjUtycpFt3no dPgduxCUvgFozguW5P5Xvw/jsDYWEsYazqT4D2Get4CZHvjEpjGyfITK0hCDfY2p0oY5 u1E5w8jXWFkDFW50iXNnd6A5dGgNNA6WQu4Oh42e7uV5t/F7ycm4OB/iUxa0XzguT3Hv vmlTyvAvkkwHE7uMMlyBiSwov0imoo2FXkXavplNSXGxSXYNmvZXYjdRnWq+VpSBXdzN Q+7+o5qNEnTf+r1YU3FjSFO+IVgnOIzstdAV2DBRR6ELiwq1aRSw67Vb7g0LTKwI9tTE kqWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722228087; x=1722832887; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RvMehHFovVJWeBpH4SDKvqU5fsitO2FHmL29ZzK4oEA=; b=CV2iNbVamM18gG/pWQzfWhkk5b0Fl3anNbGGfNknkHs0jixaxOFKr84rIYUh1yjSNg 9J8+JSmovYZi2lciwJ7+hpV2MqADpi4XtcsEthcFgUmh+kASz3Gfe4MVfF34CLNBTsky hrOUqjYTy9CiSHVsLOuESvOU1kLN0it67arpOJ+fp0xw9zBTwKcbbrIS4kz7reQoHoBT tMQvwFgK1FguquIon0qmrWJrTpXpBc4ZYHzCrAcAuwBgtU1kK17QsS9DfFGGED24lTdR JIyUxRRGIU9D9I5aKLiAIqNzj5LD/9sWoev7tHHO++DEP/pkOSM/UbKD/encBxRngjeT bpJg== X-Forwarded-Encrypted: i=1; AJvYcCXLkB0nSJKd8gIM0RZ8pbfGGRI7gvn8tR5uG/j0qQalWjb0wUOUJHEkbIafBR7wzXPpjesTgRNFxZ+CWGja8NlnIp4= X-Gm-Message-State: AOJu0Ywbkh/2pvnNwUIbfi5U2z8yJ53cFHVX1T2g/L9I6YdArvi+UmV1 V+SBNuBkaxFruGFkgjggeT4rVoC8sAOt6P3FrZZxlYqhF9YdhovJ3dyFLFPsivWGSll32lN+Nau SSqgJ2QzFapRdIMAJjC+J9n5+3c0= X-Google-Smtp-Source: AGHT+IEGUlbD6eLPUKNik9e3P1JeR0U0VL6y3soem8DsRydlwQrTBk+IkxA8QN5IelQ2sITl6PKNPtCOSCRgj+MVrEc= X-Received: by 2002:a05:6102:3f0e:b0:493:e585:6ce3 with SMTP id ada2fe7eead31-493fadd965emr7177806137.31.1722228087038; Sun, 28 Jul 2024 21:41:27 -0700 (PDT) MIME-Version: 1.0 References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-4-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Mon, 29 Jul 2024 16:41:16 +1200 Message-ID: Subject: Re: [PATCH v5 3/4] mm: support large folios swapin as a whole for zRAM-like swapfile To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, ying.huang@intel.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, yosryahmed@google.com, Chuanhua Han Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 14CE12000D X-Stat-Signature: ckhe3sd3irekqu7s34yguqz6uiy1ajoa X-Rspam-User: X-HE-Tag: 1722228087-840069 X-HE-Meta: U2FsdGVkX1+QgxtKyYvHVh4Je8tPgSVXTjyYVMT3Ro+LAl0a9eNRZ09FVAqqr1KRP6sEJAZnTV7UNK2bWBjuswFujJZWVQCQQ5AyGVCJeDmWKrC1pjrB2hJnSKHs2SkI2dJ5YU+I9DhoRrXixAgqv8NSpvId+CmJ7s4fxmhxtK7Wl5PBAFiNUIY4vCweGQnUPTNQDHZIzPe8+cSdTxufIQDkVUCXBVqDzL9pgURhDXt4r5XJGC5yMY3pdgkW3N6D+0eOhO7Qc6PGPms5NA7/tTIyxCglD9cHG71PLpJyos49qiflbRSdrqzPzennN297IuPLJkqGXDf2Nj/yfhyJ9xGBI9hYDXhNQNiAaH04EFaov5opnMMaw8O8ehYzKoiiuxYDrJBYxR54REZpw9Du+4RkRoAKDmXJfo53VemKIWnzlHyoatTSu0urKH9xj0bLZy0tjh4+YhH0Y38ybM8Fh7qI3peiDyVPW5O2mTJajs7Nc2gqWdq62K7C9LgSTfpGBCtMXL+K8rQw2dnDC4wiMFBGmvbSJj/9+8/2VGOP0v3BtnpAhRzpThsjlApHuTLmomEWYxctxjZtuAWGhxzt3SWIarqoRREBgy3rIAiD5FuIusuaCDn15yaYD261xN2Pnsn01S1B+dvXOa88s3VC7FobQleuPvdGkX9Gg2DGVy2k0cmbAiaWAGzO85cGFwRa2JT2IDQWqTSKfWOcD39Uy4lIm/27pts3Q/IW67VtOpctbPStQIPQM32/ARi4cbsaIOgspebWk9ualKtAo5fOz8dMS2CVOHVE9VPY65zM8Jcmg8BN2XUvS0W8GVQf75kBfb0/Hw6csu3wfQZk4VXua+SlogifYrycxi+0T5Dyr/GbtnKAvhnMd/Bz+5DwszXCIipJIDD9LfXZHdSEsaUgv3bgrcOPgUvnscfF8Tw/8ekS/QJJ24rYuQiyem91HKYgH7nEbRBCkzwvIj4oTGc NE/be2wX nu9zrHi5D8KjOIW6LrW8fo0IKMSgXZ9KAC/yu17tNnadGWxNl78YtAwjkFjjJVuzuYJuvFqZIJIP47eEWDhcme/Gcam+6l+5UdhU9Tld4ejluEdJHZO2b9K7gsgAxr9g4sWHr8rf2T1/cWmBc4vc2wTJ8uObig95/Gry3AQII9aWyXcQWCO1EvpnbQ6z+MwGoXh3rFoAW1LvYmXzV/AYf67FF1VXUfom+g3mwWjrS/r6B+iiqxNPjQX9xezkyHZ85A6d+VsgQTtOLpshX8/C5PPRTk8IxTYbRGC0hRgIXfccp3QSTJIAYlQ2ctv+sJBLERc/7CPNEEqzFzaNcYxtcGQytV4twIn5nrbpz X-Bogosity: Ham, tests=bogofilter, spamicity=0.018122, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 3:51=E2=80=AFPM Matthew Wilcox wrote: > > On Fri, Jul 26, 2024 at 09:46:17PM +1200, Barry Song wrote: > > - folio =3D vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0= , > > - vma, vmf->address, false)= ; > > + folio =3D alloc_swap_folio(vmf); > > page =3D &folio->page; > > This is no longer correct. You need to set 'page' to the precise page > that is being faulted rather than the first page of the folio. It was > fine before because it always allocated a single-page folio, but now it > must use folio_page() or folio_file_page() (whichever has the correct > semantics for you). > > Also you need to fix your test suite to notice this bug. I suggest > doing that first so that you know whether you've got the calculation > correct. I don't understand why the code is designed in the way the page is the first page of this folio. Otherwise, we need lots of changes later while mapping the folio in ptes and rmap. > Thanks Barry