From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9153E7716D for ; Thu, 5 Dec 2024 15:24:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F9746B00D9; Thu, 5 Dec 2024 10:19:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A64D76B0131; Thu, 5 Dec 2024 10:19:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D89F6B00BC; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 657A76B009E for ; Sun, 27 Oct 2024 15:52:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 776561603E9 for ; Sun, 27 Oct 2024 19:52:05 +0000 (UTC) X-FDA: 82720428168.03.A237F9A Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by imf26.hostedemail.com (Postfix) with ESMTP id D269E140002 for ; Sun, 27 Oct 2024 19:52:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=quarantine); spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730058593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LeNyK1dS8fdGfFYCHz8SEYzY/h/VTeC8f7pSxMKfbEE=; b=1imfd3fVxXhIqPSFf+QhFm48UFCtKJPky2PYSQFJbiQ9oVZIt6tJBl3zR4sYDuzRT1OcKt lpLuxXxhdy++GQ0mxGSz5TktLhrezJ7rai0hD1f8i8st5QYBbJ3xr4kUT+UMttA93aeQhk Ydg1FVjM25hpgWVutIGOXBbvrk2W4Gc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730058593; a=rsa-sha256; cv=none; b=sclW60ULpFtWDhonRE6N0V1fi2pY+di/LvkrDRrVegnJjMuSoxFKNGToBZVORe06lTqujq okxRFDrNrPQ/TUSuJe4iDQ1datfks+IZKkuCidjA1KJvYUzaeOdfKquvw1FbmXw6PCnBem q449Jn3SuiCKN3i23u5xVifJAzTdo4o= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=quarantine); spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-5101c527611so303897e0c.3 for ; Sun, 27 Oct 2024 12:52:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730058748; x=1730663548; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LeNyK1dS8fdGfFYCHz8SEYzY/h/VTeC8f7pSxMKfbEE=; b=E8qyP3yJNGdJxN1mUVVfFw9PYxDChx0/M77ypMHlaygtpFWerBDqGqRtUdIz9juyDG oS5Yx6mhRnyaZHpA/pYivTA8BsuWV/L3B+VlnvS+frLa0NiJK31CtTQUjmRljFeu/uIN aFFNvLlS0uH7ln4c/HB7qssbK7qHtWHkF4lnTVx0wSnXiwDpfs4/pGdE6QBXlkjHFnjP eDCw9keeKmX0zN5/PyZCWIaZEGfzruqyHygnRb5b4SRqun9eFnN6pR0WrzoImKR1HtNe U6upGrhXza5nJVHnJHMNdDNObVIj6d/WP1jhHSVOg1avJfZ3DglsnZFJ/6FdzMXjt/Wq gWKg== X-Forwarded-Encrypted: i=1; AJvYcCXZsOc7IB8DJPrGZAOGKmqx7ifY4VWamHh//OAJTwKkjxxvGxF+RxjUcv6cCTG7vKixDCHvQMqtVw==@kvack.org X-Gm-Message-State: AOJu0YxxjufTxgzOq5gLFBXbylXeaKTl2/hHFwS+AnTET+A1Uy5A7Xbh QR2eVuoQsC31aEzAc01wpXfZTisW/YoKCb1XR1k2qv/HohgAs6Vgl5KxTI2Fn3hg0/bMnj68iLT 1JVjc++TcI8Ymo0rVGMGf8xTcGNg= X-Google-Smtp-Source: AGHT+IGZIhcR1qbYPRbikr3C426yAUQjADRfHf67ahq+w0TwSO4haB8Ydbmr5zPqqCM+K04KlxvHmSH5NQbFcMW8G3A= X-Received: by 2002:a05:6122:1ad5:b0:50a:36ab:c788 with SMTP id 71dfb90a1353d-51014ff5f55mr3170942e0c.3.1730058747749; Sun, 27 Oct 2024 12:52:27 -0700 (PDT) MIME-Version: 1.0 References: <20241027175743.1056710-1-mcanal@igalia.com> <20241027175743.1056710-2-mcanal@igalia.com> In-Reply-To: <20241027175743.1056710-2-mcanal@igalia.com> From: Barry Song Date: Mon, 28 Oct 2024 03:52:16 +0800 Message-ID: Subject: Re: [PATCH 1/3] mm: fix the format of the kernel parameter ``thp_anon=`` To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: Jonathan Corbet , Andrew Morton , Hugh Dickins , David Hildenbrand , Ryan Roberts , Baolin Wang , Lance Yang , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: wdi54ccatrx16rd18e66dn7upes9jmej X-Rspamd-Queue-Id: D269E140002 X-Rspamd-Server: rspam09 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1730058731-360499 X-HE-Meta: U2FsdGVkX1+VOzohDe6nm1t2GwPDe1qDKGq4ee3KbVTfp0jhzsOl9opSR+IxeGoT7GnYjROseqinp/PM8+XnNit7a3lFUkGC/6WK/SkL8SdTJphHTIJ8boXYmdR/d51TTXQxYd0ywovSTsNl4ss9s8391ePsZILo3YRWVJStwVbGQL3BDzz5LKNL+y0xj52Spggt2uW6XAiGmT9flX7Gk9KfwJrhFQ1W8zMnQefXDty+89ctTCiMR/neFfSLjNdUp8eSOUZyyg9A8e0o8j2mmxBcGel6/rPfrUq0blIEGHq83+I2/kqWSyZD5b6ZOaeqUx45gH65U40uPyCLhYXriJi3emwGuMRoNeIqMgSfL4l6Zes6kcSGATNb4gV1HIt0adHuSRuEkZ4Ll7WJRy+UQGfwX2a678lCfAFmmqxlnajnE2Y/6mNPKr2A37cBeudf9sOlIXrF+Jd4Ju3APm++6t4EwTguPVOWU/U4Z+W6Xq1SX7oCdipA1E4eEJLUtvG6/Qw8ppkBKa2DAnkeh8HL1PNB4uhMugoblawnKlRXSwlTfoyYtoKqoUEyqG8yOD9TpHnN32po7eVLlewhOrco6/50InSQmetche2dqzVBOohu6mZIGWKczwB2Yq9KEoESp/v8mcACv++OIZ8scniobb4GTCFih2jDaqDRrWfJ7irstz4CucRLO5uXTMeOhRPxQSyyq1Ywc0xBRJnXWxoQ8d+haYM0klwZah3RK2DPldLR7aWi+cjvw+ICf54z+/1KsDbcNp2J2kJIAjMfyszrfnMqyjYXKiwY+xVUC0fZKXhMLeYW2mnHYbUocnje7xG85tb27UuoSzKV2wAQdxiQ3bGnDHIYOtFvPpcInYZFSL6an136ZGrFYyzgRPDzySxiVac003NEPiBMBp2B1hkTeuduYv5No8QGoWjXXxSnniXsVmx2jVkcNdUifmzqlkKUKshhKkZ/IqmzTwxmHjG Qxs70mM2 6xv3rZI+pnrSfk/Zv87KqW8Fjr0Qh4pHtKp4p8V9R3tM9JkEKp68LoinzgX9A1Rgqfd6pAUr9pUlZbBX2UlfwmpsD5xEdJYUPWusm7fhAfzBXwWOdDMyn5AGtb6Z7HLV7b45ZS1pP4fUHBzTIg4V2LySIHi3criGqV6o06i7WzvhYcyXcdwMKjUrQ5b7pCs0gLVWR6Y4bc9LYabAXlWbBiYGLTrhJflJ6HQUdrzwSvAKVCt1vnvDmqS+oWHzpWAY36x0I8G+3tWY/5zog13rH9Gk7b+7NzPBhJi+2cxM7Tg1W9SOE+LHjvjlGv/uGmNFwWdpmBGr1s6JT+r+PnKnD6RJ9zcAtWrxtlCaqa4nuz4S6v7oTEgGs9R71HagubnUeIM7uVo6QfkM9yjI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 1:58=E2=80=AFAM Ma=C3=ADra Canal wrote: > > If we add ``thp_anon=3D32,64KB:always`` to the kernel command line, we > will see the following error: > > [ 0.000000] huge_memory: thp_anon=3D32,64K:always: error parsing strin= g, ignoring setting > > This happens because the correct format isn't ``thp_anon=3D,[= KMG]:```, > as [KMG] must follow each number to especify its unit. So, the correct > format is ``thp_anon=3D[KMG],[KMG]:```. what if 32768,64K: always? > > Therefore, adjust the documentation to reflect the correct format of the > parameter ``thp_anon=3D``. > > Fixes: dd4d30d1cdbe ("mm: override mTHP "enabled" defaults at kernel cmdl= ine") > Signed-off-by: Ma=C3=ADra Canal > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > Documentation/admin-guide/mm/transhuge.rst | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat= ion/admin-guide/kernel-parameters.txt > index 1518343bbe22..1666576acc0e 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -6688,7 +6688,7 @@ > 0: no polling (default) > > thp_anon=3D [KNL] > - Format: ,[KMG]:;-[= KMG]: > + Format: [KMG],[KMG]:;[KM= G]-[KMG]: > state is one of "always", "madvise", "never" or "= inherit". > Control the default behavior of the system with r= espect > to anonymous transparent hugepages. > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/a= dmin-guide/mm/transhuge.rst > index 203ba7aaf5fc..745055c3dc09 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -303,7 +303,7 @@ control by passing the parameter ``transparent_hugepa= ge=3Dalways`` or > kernel command line. > > Alternatively, each supported anonymous THP size can be controlled by > -passing ``thp_anon=3D,[KMG]:;-[KMG]:``, > +passing ``thp_anon=3D[KMG],[KMG]:;[KMG]-[= KMG]:``, > where ```` is the THP size (must be a power of 2 of PAGE_SIZE and > supported anonymous THP) and ```` is one of ``always``, ``madvis= e``, > ``never`` or ``inherit``. > -- > 2.46.2 >