From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C330BC27C4F for ; Tue, 18 Jun 2024 06:05:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FCFC6B02E7; Tue, 18 Jun 2024 02:05:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AA716B02E8; Tue, 18 Jun 2024 02:05:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FD9D6B02E9; Tue, 18 Jun 2024 02:05:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0E6876B02E7 for ; Tue, 18 Jun 2024 02:05:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C0B040497 for ; Tue, 18 Jun 2024 06:05:47 +0000 (UTC) X-FDA: 82242973134.06.64FCD25 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by imf26.hostedemail.com (Postfix) with ESMTP id B8DCD140010 for ; Tue, 18 Jun 2024 06:05:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HsldPI8i; spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718690742; a=rsa-sha256; cv=none; b=dSilOaWWCyuccMpyBl2h92Cxio3xmCxjLQg+zRc1SmA3+dlt4dV3X6DehNPYhRRci0u6lp WzNnNtkNxItqqQnCiwvxyC399L0glIgBk+Xr/mc2OCb7MCfcDc1qShnlUArn+zmlgzmSlg c/1Yym1qTdfcWGsB56tE1h4nfdqeu0E= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HsldPI8i; spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718690742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X3Q8ObGzij+dSG86Z8PK2tJ3mq5QnKxsXUU6s1/w4HI=; b=hMmQzaTJLh8y326ViN5kc8LVEmU1IJRhc2C149HMEAb4LyltVAVsgNZmW1FCSKLOM3XZEZ s5hHfSo8PcRj8SFSwb0JNgmEGUZSGAufWaQ9pzCJYYu4PTBsSgzGL7EbGg76oXYhnEzFyQ 0gxQynKnt3ZJ9yEQHWJlPosk7Yic6+0= Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-48c3957a7c5so1982856137.0 for ; Mon, 17 Jun 2024 23:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718690745; x=1719295545; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X3Q8ObGzij+dSG86Z8PK2tJ3mq5QnKxsXUU6s1/w4HI=; b=HsldPI8iMxuW0P9JNexl2IYTCm5DgHUhYlJLxJd2arTmXGM6p5TYYrqiq74ogRTWj1 fu9NNOs9Xfhe5RCb17jLV0EwYhY/bg29mdIRoRxQc3vEn8Qd9KSo5XvT5Zy/uZuflmZC qUDJ3H8pFFJ3Ba1GVu7kRCBv54gOvMWw8l/AxlQl5p41O1a5bgCPGv8cXpmCTjXTWRLk 58MJqTccTFqwzokUtMcowCNyXGo+83AyW87SjQMKZQA/BT27GOUvzdqu3kVCj/MvfrD2 KbE3q2FYfj+FUUZdBgQ/sFoaj70/Xk4ZdjOrxe7HOgElktr9LOtnVOOqlRJUSl/kMZmZ nyMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718690745; x=1719295545; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X3Q8ObGzij+dSG86Z8PK2tJ3mq5QnKxsXUU6s1/w4HI=; b=UQ5iGOazAFsgTy0+F7YosKPrg/OSKF8rRDuN+ksGIvFI620QioD44dIfKFrGXxgSlf UkshXE5Y2hCq9+l2NAfxGea5nQbzWw3GyiP5pBf/1KbC8Pf4kCME0YWCb++a5mBYn8Ux Cls00uvzcGGhOwvFX08RXuYWS34dJppFSKmFJZ8xOWeWFwgEpkYY0aTEBE/hwppNhT8s lJexJ5XaVjkBVJ6+rksrVjwhhdA0Cr9wb2fBHWjoL67k5bGjeN40ghS9NfR4dHFM9WcU YXcpFRQO6kMFvqLnRCudaLcAUYN0BlCJMPHUIcZFSOZqnnAqtCgRDpJzQJjXScdhzFph P3GQ== X-Forwarded-Encrypted: i=1; AJvYcCWQTLOiH1C5K35prEJjG/4sL/zQ6S8XlczQOHz1MRt8JTGPaP+780ZIRd2ZO5s6FOH9AuxLqJ6QzH3JI9qGWKM8Nyk= X-Gm-Message-State: AOJu0YyomDLDVFnLsSVIwbnK9+08bdoBmrVONl5EjCqrvdK0QhQ2+wpp nI+oRbIYxMzttYW6wZdShNHsOOVLK4tprILazfG+bwcDHCsCre2QlUa66415dgRy5G37nWU8+gx Alg8rGeJN+Y1G9ip9SKu2vAhehPE= X-Google-Smtp-Source: AGHT+IHBlKj1p/6YAG4PEUMl2WFpNXmPgZkujfmPlp3m5fILb2qTogaanfMgBh8OxzmUUNvjWkx03BYKP6OXP/RZMdY= X-Received: by 2002:a67:e3c3:0:b0:48c:47c3:7857 with SMTP id ada2fe7eead31-48dae3e67c2mr11674131137.29.1718690744439; Mon, 17 Jun 2024 23:05:44 -0700 (PDT) MIME-Version: 1.0 References: <20240614100329.1203579-1-hch@lst.de> <20240614100329.1203579-2-hch@lst.de> <20240614112148.cd1961e84b736060c54bdf26@linux-foundation.org> <20240616085436.GA28058@lst.de> <20240617053201.GA16852@lst.de> <20240618055253.GA27945@lst.de> In-Reply-To: <20240618055253.GA27945@lst.de> From: Barry Song <21cnbao@gmail.com> Date: Tue, 18 Jun 2024 18:05:33 +1200 Message-ID: Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap To: Christoph Hellwig Cc: Andrew Morton , Trond Myklebust , Anna Schumaker , Steve French , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, Barry Song , Ryan Roberts Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: xzhns1sperftzko4dct3irim4c76arrb X-Rspamd-Queue-Id: B8DCD140010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718690745-699913 X-HE-Meta: U2FsdGVkX1/seBqsefzkFeG63i8Qkxs0Rd2h3F3kXpRb0wXyoZaIOgM/9bRQIAuo4UfBz+SjOl8h85i5yzfS29mHE02Ax8GmfwGl2kOrmLTfKvZU/8PRR1tc7XCJsl+/M46Y4rcTseN4Z0K1+e07vauL5glIHmXi1qGP40qM8SrkR65auzbOb9RVQrSDp32QsyxdpDrHgO5SkkPAHCDdfrmAQ9WJ8hJnfuIMb2/HiY2+ONIoJAjI1LDlzVT4C4HI8e8XpGAikd7S5tn6NF6yyj2t22RdH8vMVdo7ji9GOp1NUfDtmE0fhOvrA9Kut3aHWhA1VQogNtTb9NYBThOJapXjzlTXz4faEcHJank5GztOqd9VGbsfSy6+nT9Rvmklc+4aHnYPddG93zf80rq21ySwNsdaqw8WrhDswJ8SqevE51uOv/8pyiW+0viArKeAG4Pt2JRqxYwpMSmv8/ofPxwiBQ9Woz2MgaKDwSbvES6M+/BwC5M/zHrucxVkuZ2BFOlIV93hOK66EMBTzYPqo1JEnF8pCKPhfOaZnWhNjvdpLyRi/+ICvrOicTB/H4aOaKTp6HrXnSySvWsNCGen8JqThOtjLTq7IR8yZx1FUxTy0ggDts/5gu5c+FJ0fQe1kH9cAC4y4CRusZe6sGxjiCNTQHJ1qz07oHi2ENXnPL5+rXLvtbI/amGAiV62ltbB/7DrNeNDuBFGMWmJM5WDkTAcJmdebYHH3WVk5XwMYtJ0BZir0ygTHVp467wybSu0XoVP7jJMdcEJ+tyuNz/DElmLMb9tHZ2jB5+pHeGEowmd2mh+w0tmPU74Xo7pTTpONGoX7EuG8Np+VCXrCaJR+kgc5may8YYMYNKZdcwOMO2lndpz3z51AQPL5bRC+WkTaL+snL7tKf1WAkTKXqtVkZPnG3kkfE/nbWQN4LRduOmVmaRmntXfxPgj0oW/nOER0TfXhi/dLC3ElVhO9Y1 gNrWwKD2 l2fTfDXjw83MLvWMxHUrx/mOElhWqK7HtBXpNAKOtqpQne20Y+Wbq+Px0JSE6SXXDcIdFJ+Pfqnc0sK57Q4cEK8DasnB2qRWbGfMqQx//lc1/jRCOcZUse2WBuaVE+zR1FWEjbRHOsDhC0HzbHKM1lKgJpCkmWAihGy/Ul/RIJLur1ndfp5+p0jezUQ78GyzblT5gPBMUDsnaXoKWKcVzSLTbsLViiXy92VM+dYg/cDL4TjPJ5WEAr+BdWc7b3Yq688/7yhGtvLyIZBTQfVINP/JznMyFzpIJSSc3EICh4x3UkE6toQ0BKb+2zELO8deuMKFIbqH4KseppdTwCGFdc4i+SR1hxoDLECrFDrSNOrzBVqJQDFhbBSITY+Qxbd6/JWDdZbd0u/8H6bMJ0lYBpWjoBUbmFi4p0OfhwNCXqEfobIo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 5:52=E2=80=AFPM Christoph Hellwig wrot= e: > > On Mon, Jun 17, 2024 at 08:02:47PM +1200, Barry Song wrote: > > I did everything the same as above, > > but always got failure at the last step to swapon: > > /mnt/test # swapon swapfile > > swapon: /mnt/test/swapfile: swapon failed: Invalid argument > > You are probably missing > > CONFIG_NFS_SWAP=3Dy > > in your .config. Yes, that was exactly what I missed. I then figured it out, reproduced the issue, and discovered that the root cause was unrelated to large folios. It was actually due to a batched bio plugging optimization from 2022. You can find the new = patch here: https://lore.kernel.org/linux-mm/20240617220135.43563-1-21cnbao@gmail.com/ >