From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E78C3DA61 for ; Tue, 30 Jul 2024 03:15:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACD506B0085; Mon, 29 Jul 2024 23:15:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A56B86B0088; Mon, 29 Jul 2024 23:15:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91E026B0089; Mon, 29 Jul 2024 23:15:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 73BA66B0085 for ; Mon, 29 Jul 2024 23:15:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DB6E0C021D for ; Tue, 30 Jul 2024 03:15:35 +0000 (UTC) X-FDA: 82394953830.25.917863C Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf01.hostedemail.com (Postfix) with ESMTP id 206464000F for ; Tue, 30 Jul 2024 03:15:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="f/tu5vmr"; spf=pass (imf01.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722309279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nto1jrvILAsl/5NefBeJdv0jQDCPstv39lORcSktRro=; b=PBIHU3hc6MKn4dL1RqjfA3AvlNstHh2+Tr3eVZkjHAeuwMpoDg+lihRlsyzI5X1Ul60Lwj HLgKd2Vi6saVAjrN2R18ce72u7+PQos56vxZRCNhSyHHiuNjXbAd4V8BFyehhutd+nsTvu QFM/fuPsI1qE+E/K9HmpD+FTknZf+k0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722309279; a=rsa-sha256; cv=none; b=Ro31GumWDBvaqgbYc13zpicdrwLaP5BBuW6fOp29GdLYWMgrCj+tLmeIa9WKZwilqzW+LW TKlwyslyOAPJplxVwej9cEeSyk58AeMr4MxXLGty4bK6m2eg/6+paW3NoFdkiwOSXyhI4z tPxR2VIOn1UumYAmRtXHj6hBZUkp/oI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="f/tu5vmr"; spf=pass (imf01.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6bb687c3cceso9002576d6.0 for ; Mon, 29 Jul 2024 20:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722309333; x=1722914133; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Nto1jrvILAsl/5NefBeJdv0jQDCPstv39lORcSktRro=; b=f/tu5vmrDpXcFmoKkdktizLGl4VHJBtU/FTttqFoVoL+mMndcZk5g6ZSswl1IodFM0 Sfa6BuFM4OPPgMDzCXrSoeo7Y/ckKzJWjxpR6uaSTWkHh4cwerCFm8s1UnQo0z/aiErp kS9ytKILyMMViWBGVhVDyrBJ76ZoDISr3cvH9WKMKOpinzTGRQ3dCjY0rGtd5sLNcwZq l5JRjKruo7PYHYtl9cGrGK/YTArbfz6s1wBYuyGvsxIBoy0OY50eRDxKANXSnCy9VFkG jHmyAIxZwM+DlmNpJGzffQVJu1zX+jkRmzQ46GMnRc5b3ulQagyBcQhNhn1sFvxVBqvU KGGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722309333; x=1722914133; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nto1jrvILAsl/5NefBeJdv0jQDCPstv39lORcSktRro=; b=cDE4Fj0k6yldHn38UThJwKgnka1dGa/CWwyne67UcqY/GD6hbvIPeYegt9LgNxhkPv F4uyzBm0cGiha+2OygpTwHVDhmSLWvniK1nGm6nPmbm3EQyMYJ2I0nd2a3wZeaoyenFs 4eSwpqdnzPuyN/WrGtre/LewtfSLWffJtAj6yCGrTG7Nad3W88HSFz54mFidXei2D+ti tgY4ibfpP0DAelYME0DxD4Ep9lgYfNQXJjTP/C0Gnw9dvm6bOthFhEDfFrtHJgLNzAL8 SXRH0WEbfI1xZFF8DdpaJ+hosKyYF8nV3YlgmrmIt/oMfScYEuNK12mQmPWz/fQNDQ8v y18A== X-Forwarded-Encrypted: i=1; AJvYcCVpnduHkYtAKZPDQi2LVDv5zY1KkeZnqUHAH+UHgzI3qwXlGbJYY9A4N1hHxaqhcx4x2E63JNQei8Z8bYm00LMQwcY= X-Gm-Message-State: AOJu0YzC0pYl2LCXuy/JqiimD1goxugAAyFCnoXKGQT7g+yCx8UhlKB9 PLCXsV1rz4JHvfnsdDWaACl9W7bAsGga2+VcvryOl/Uqdv+djem2kyIDwdPaRsjkqWFSmPLvFSo Nk4cBHUDB8i8WJGazpLH54QFKGDY= X-Google-Smtp-Source: AGHT+IGJLl+etrv2QedB/ZTbVHfGz4EgTrx1v64zlfElJwuxkhWZ2VVNbHeEaLNR4QUlqczzPW/niHtUEf5CYsIyEIc= X-Received: by 2002:a05:6214:27ed:b0:6b9:9192:7948 with SMTP id 6a1803df08f44-6bb557b5215mr114472856d6.0.1722309333076; Mon, 29 Jul 2024 20:15:33 -0700 (PDT) MIME-Version: 1.0 References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-2-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 30 Jul 2024 11:15:21 +0800 Message-ID: Subject: Re: [PATCH v5 1/4] mm: swap: introduce swapcache_prepare_nr and swapcache_clear_nr for large folios swap-in To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, ying.huang@intel.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: uzza8wjoo5oahn5nskzek19aft9zubyc X-Rspamd-Queue-Id: 206464000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722309333-830714 X-HE-Meta: U2FsdGVkX193Gs0XIrqLGLvsdGKxtotInD/1z0/Bdehfsl4TDFUb/nc+1hVkpQSISAp3luhughVi0CIUjtge9QQUCEz3+GmAuC4geEvPffTg4PcdWbeLOPSYdcJIT6tribtH5Kuu6CL+PQxgZW/rREJCloF5L7CbXSCVg2CRqJOZRsD6lKzxh5PjKYYCvWUaZUef/9wOrk/M+Q4BX86fPv9zogFjGPi+8qIJvmA6YSvzLh0dx1Lm4e4VEfNx/rJXOPKusSm7KyxfkYh+3u7wQT0TlId2nukywEzCabEpRKwqEBcSSSxfPWcWf+nmzw69KwB5g4q1ZVWamceCl6TtAZJ0YZXuo+vshZv1bLCFYnBsx49tjscU1RZQvablH4Je+Sx19yjnSo7PTheon/m2zXuITHoqqIyPThxUXp1fP84DU5vZye5ogey8LpEqdgfM8LFYMNvlFzHRZ1xETH7edCc5KqqSR50Y9GgONnlacta7ZCO7N7Kw9TRMH7vOHSVC7Iag4rea+xvjCInagYlecg212tANw/DcUioj4iZuenXy6CD6PSyfnZwkh9UJ3voIjQyegMTtXt3Sw8UEFUzEjjRgvn0xde3m8+8M7/A6r0m0uQaiGK3mMgVmFwj/uEfUywKyRjG3LWNr35x4l4o2v2bhSaBnUDz7bHR2iJKJSLsBiPXy48LkgdTJJpIcjiGvrMA+iQ1FuPNuoXhOydY5oEWtp9ebzhcXkICF0kXg5SKUJGX61qdO79KiPk93MW8uXifYLU0hnvd70oyGZVerZcSgEbANStM07qfpkfV5+MNEFbIf8rawA5GNzlgu6TXiGKpRfKwRedvHSlaRVU4jGdV1SfD05v+Pd7is6gIi21Xo51b1xfi5L7SOg54dXIwnaYsrIGDo14mSgU0uK6w4yQphPDIViJ5W4x51gBxRI/USqDWwzq25HEZkSuC+QNe/rNemMFqcOFPMDik7c2Z IzL7LlCQ 3hOgfpUgYJxYccaG6LcYmHk8cVvJGIYuJUzWyhy+7a3Fxfpu05Yj8Z6XbTf6oEpDhRsZtLudiCeeNiTVb9q5GQMN05rB5He12zdpUFY+P7h7Z8jlfS2o91TvXuW3DYjwoluQwhB4VzmHcrPXzFOM9iGjAi6CrM99ZFqd4l/5+YQd2CxgXD5Vt3CTIvcLgU/kJ2+3ViufqRJ6zkP4WZGBeCHCr77CxKYVx5v25YNFzBuxArLZfI67Z1dODi/BKnFCFsVHQPFxcqRX/q1iujLn/XvfQlz7c0aUwYHPWu6fs2Jrn/7sjg8Q8pRnhfUOf2kJIhAiyo1iaNLwq/+BMOzcNjOd324zukEgtzKshRx2lesL1eSrs7DfQtT0a/zyiqV9O2K1x81GSFngeNSw5Jwjq4Qy5CQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000499, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 30, 2024 at 11:11=E2=80=AFAM Matthew Wilcox wrote: > > On Fri, Jul 26, 2024 at 09:46:15PM +1200, Barry Song wrote: > > +static inline int swapcache_prepare(swp_entry_t entry) > > +{ > > + return swapcache_prepare_nr(entry, 1); > > +} > > Same comment as 2/4 -- there are only two callers of swapcache_prepre(). > Just make that take the 'nr' argument and change both callers to pass 1. make sense to me. As Baolin also needs this patch for shmem, I'm going to separate this one from this series and send a new version with the suggested change so that Andrew can pull it earlier. Thanks Barry