From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA215E7716C for ; Thu, 5 Dec 2024 15:22:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAFF76B00D6; Thu, 5 Dec 2024 10:19:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 755326B00F4; Thu, 5 Dec 2024 10:19:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B17B6B00E3; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9ED318D0003 for ; Mon, 28 Oct 2024 21:03:40 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E1441C620C for ; Tue, 29 Oct 2024 01:03:40 +0000 (UTC) X-FDA: 82724841696.18.587D0B0 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by imf01.hostedemail.com (Postfix) with ESMTP id 93D1440007 for ; Tue, 29 Oct 2024 01:03:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730163607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4bhcbV3qJpMoe7dq0DyYnJZ1QcBEHyF7RQEz/W7RTy8=; b=fAn+6pZrn/gfOlQi0lRiqGQxrVpAKxWvbd4JY2DY86KaaBYfqmyBm6+yYHFpvorKGDAx0w NgrU3uZmCabe0Y+2qQU2E+2jtFtf/+QqJN0YD0QPTZImqH9pB4qLFQ0K+OvQK8W9dVaTLG 9v2lyl/a3biwt+FcWb/TrRvFsGhg/+w= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=quarantine) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730163607; a=rsa-sha256; cv=none; b=NdFPpImRi7acI78GXjH0XONrUle5KJ03unkZH6CPOiuz7x2a3+ZB9t0reFORmFURI77Lbd lB1N+nSeyIHF4zsxV4BBiwWHD+jtRKof6A2FDg4Y3982CS881kl3IuKIQQ3SU6Ktb6xAf+ /i82qsTBh4bqoHgp7q58vpVqgqWZnMo= Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-84fed1ff217so2896049241.1 for ; Mon, 28 Oct 2024 18:03:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730163817; x=1730768617; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4bhcbV3qJpMoe7dq0DyYnJZ1QcBEHyF7RQEz/W7RTy8=; b=HRbOJa5e2bVuIdmXBL3+K7GId+G3IXs3Sq3UPEM+NQ27oaWiZFkY+932L7We7sm39z sFgwfWpLpxByYRLDSm429gCSAV/si0j0XHvYJ0X++KTr0kKOK453n4EZ6FpAfXRP7XvS 5L71UJ1dW/ghrVOwOsWu7fxWZTrjX5RqbwQhXdfErHlcczdlPEwkEo5qerclfR0BP9yF 6XieJsV0cVwOSZ8fo+e8No5LZT7hpDUI7rDvDAg9sJbUkbawebmz1Kr43Rr0P2WIhkRW 0fDJLcOSgkj/qmZSBFuD8zB+SNT/os311xMLPzhczBZrVMqIfgt8aJ68+WzB3wYUTfB5 TTAQ== X-Forwarded-Encrypted: i=1; AJvYcCVrmbjtJNqOjxKUywuVW4ZPmVDQUWCWo917dYNapYfD1/5YlxcN/ChY5jA454JUaroF/xGTAaMKSg==@kvack.org X-Gm-Message-State: AOJu0YzChTi/3kStY1MYvk8mEJ1LUIWEvNXf1GNt6R5PUG4Lx+xhKVZl sJNstf9/0sARL/PAD3dZha2G+wzUMouFCRHyP+qKSvpq3eEHewtdi30PNIytr7OkzEl0L15rE83 8XleO5u88wD4CkKqejSYpYeCSwHc= X-Google-Smtp-Source: AGHT+IEKvEDLN/HP590zYcpR2/L3gFcXo+/EAU1H261w8qZA/nyr6ixLCyNEuCarN3qJVgtVuB25ovSFTcw7aXLA04U= X-Received: by 2002:ac5:c748:0:b0:50d:5754:c903 with SMTP id 71dfb90a1353d-51050600e32mr255939e0c.4.1730163817549; Mon, 28 Oct 2024 18:03:37 -0700 (PDT) MIME-Version: 1.0 References: <20241029002324.1062723-1-mcanal@igalia.com> <20241029002324.1062723-2-mcanal@igalia.com> In-Reply-To: <20241029002324.1062723-2-mcanal@igalia.com> From: Barry Song Date: Tue, 29 Oct 2024 09:03:25 +0800 Message-ID: Subject: Re: [PATCH v2 1/4] mm: fix docs for the kernel parameter ``thp_anon=`` To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: Jonathan Corbet , Andrew Morton , Hugh Dickins , David Hildenbrand , Ryan Roberts , Baolin Wang , Lance Yang , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: o5ky4t77koosm3819rfcwmybm5qhgfrr X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspamd-Queue-Id: 93D1440007 X-Rspam: Yes X-HE-Tag: 1730163799-415753 X-HE-Meta: U2FsdGVkX19rITnkAK1YQZD3/2Qs5RSJuNryW1k49i/djgddwPAPAk41n5s5AZaSBd+fJ4SzRgPr9PxKggFKzIXKshgMimueolmdgBuNMP6wfpDVSYaIJQUN2EzxlXnkhYXidslYRKd+S+Qj/LwcpHxP6I+j5U1DEACqEt14uM5YKHQeTGENcI3pxplFdMPVnmD5yZh0CfH1KmAOin9raQJq4TKL5Lwe2HSOvHImhZ07tpmC9QLvAiYB1vFSAppPSI/atGXJ/dtzvNrhjOc7UDhlRmdJYdTxKWebsei2VzsEHQ7lemPbNzuOq6tDbzUDlwEybkglmhNRwEiR2eF7pOQg1CfqZ8E1Xk5pEpUqHYo0SOyeE8cY7xugJYyxw5VgoaaLM2AQs8Af+LybEI86OkyKCXC5gNtqnLed3W5J1MYCFc07A5b4xTU8GknRXbZGFaPyWlBziD3yk1VfRN6s78UXCEsMvfkNBDVh4fKNSB1JdGo2BaWd/pTbSZ0T1iXUj82atJRF2Ez47etSCXdui0TAa4JDfDfomKAFwD/eOELoiiC/Rk3rhwi4mpZzxzqyrLPoeVpTiHlWQU5yAocQ8e7YOd54E09k81J7KAuvynX9CsGhULuOX9WKMD19I15h74O/66x9XLk+UTBtj76PT5pCeYBgoNuYhNpCu5RTgRDtQzddHOkgZx1TrkLwD4BrwjqCIehky98AMSGdleF10PCZaRfYjpVCLpvwnaoRC0ZL4iCAyVZs/RkabNWX5cvUdmHwt4WtuHqtFnLBMx9D3cSSP+Jx8XKbZgU+lGwLbBpZU4VWrH5LJum7yX6A+bA3ngn691D+TU2cERlwbI3JzxmjyeLJbFOGYeAfVXxrPr8hKOfG/P9b62jpkHEudTA8Kh4xpeDDpvimgzQLoRaciSMrp9i536a5klrKRh7XxWmHs1yTFHFi4laWLleG+4QQvnlEcPnKkLKoXWsQM3/ zaWgTjlm IHQKy//Tv2RIN6MY84JhP4axVcC9+68+0LNk7xA+mO02uKBnBtsMC/Hpt20wdkxIHFciX/AbvMIFerAaQQTlzMQBEsGxeg4uau4hXeSsRvSYSlB8zYBL3dqFpLojuY42x5CdPPzYiz2LtwdrXlcK9A1+kMElW/ZtmagJK7GP3Wrn/gCn8CDdvO6HPzwZgUM+dFotbFI1qq06q7TXh/0yS28ICxtNBB4PZpuavtviQGnsNX5QP5lFcgJvgeN0Rr8jjy0XMuZOV3yDxcG079N6GgT6fgqOnbYs6zqeptK3QduoC2DU5sukjlhWpBTNMkmZBOMatozW1qEKCvlv942WoQpYPPrIOKpnbx5OyMJeLmzpS9MTBXv8q72ckEeJy1LVaLHJ1mNRUfiX4pVK/YIavCZtKWXZbqPS+db99UFiUz7pDYB/4DnYfa7iD1zx0oxZELfBw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 29, 2024 at 8:24=E2=80=AFAM Ma=C3=ADra Canal wrote: > > If we add ``thp_anon=3D32,64K:always`` to the kernel command line, we > will see the following error: > > [ 0.000000] huge_memory: thp_anon=3D32,64K:always: error parsing strin= g, ignoring setting > > This happens because the correct format isn't ``thp_anon=3D,[= KMG]:```, > as [KMG] must follow each number to especify its unit. So, the correct > format is ``thp_anon=3D[KMG],[KMG]:```. > > Therefore, adjust the documentation to reflect the correct format of the > parameter ``thp_anon=3D``. > > Fixes: dd4d30d1cdbe ("mm: override mTHP "enabled" defaults at kernel cmdl= ine") > Signed-off-by: Ma=C3=ADra Canal > Acked-by: Barry Song > Acked-by: David Hildenbrand Can we separate this and apply it to v6.12-rc? If Andrew doesn't require a = new version for the separation, can we extract it from this series and apply it to mm? > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > Documentation/admin-guide/mm/transhuge.rst | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat= ion/admin-guide/kernel-parameters.txt > index 1518343bbe22..1666576acc0e 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -6688,7 +6688,7 @@ > 0: no polling (default) > > thp_anon=3D [KNL] > - Format: ,[KMG]:;-[= KMG]: > + Format: [KMG],[KMG]:;[KM= G]-[KMG]: > state is one of "always", "madvise", "never" or "= inherit". > Control the default behavior of the system with r= espect > to anonymous transparent hugepages. > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/a= dmin-guide/mm/transhuge.rst > index 203ba7aaf5fc..745055c3dc09 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -303,7 +303,7 @@ control by passing the parameter ``transparent_hugepa= ge=3Dalways`` or > kernel command line. > > Alternatively, each supported anonymous THP size can be controlled by > -passing ``thp_anon=3D,[KMG]:;-[KMG]:``, > +passing ``thp_anon=3D[KMG],[KMG]:;[KMG]-[= KMG]:``, > where ```` is the THP size (must be a power of 2 of PAGE_SIZE and > supported anonymous THP) and ```` is one of ``always``, ``madvis= e``, > ``never`` or ``inherit``. > -- > 2.46.2 > Thanks Barry